• Joined on 2021-03-29
ychenfo commented on pull request M-Labs/nac3#140 2022-01-10 16:01:56 +08:00
List Slice Support (#72)

They're just more typing for the developer. The toolchain doesn't have issues with long symbols, by C++ name mangler standards those aren't even barely long symbols.

Ok I see, so should I just…

ychenfo commented on pull request M-Labs/nac3#140 2022-01-10 15:56:56 +08:00
List Slice Support (#72)

Just wondering: Do we really need thhe IRRT prefix? The symbol names are super long and I think __nac3 prefix is enough?

They might be enough indeed. After all I think the purpose of the…

ychenfo commented on pull request M-Labs/nac3#140 2022-01-10 15:50:27 +08:00
List Slice Support (#72)

Ok I see, I will delete this struct and just use their names directly.

ychenfo commented on pull request M-Labs/nac3#140 2022-01-09 22:28:17 +08:00
List Slice Support (#72)

Oh here as the names are getting more, I just thought that since there are still some places in the following code that these names repeatedly appear (especially when adding inline attributes, and in…

ychenfo commented on pull request M-Labs/nac3#140 2022-01-09 20:03:12 +08:00
List Slice Support (#72)

rebased on the current master branch

ychenfo pushed to list_slice at M-Labs/nac3 2022-01-09 19:59:31 +08:00
96a2881a08 nac3core: list slice support
44f4c4f028 nac3core: build script use Path::join
8ef9e74aaf move rustfmt.toml upper
9c20e84c84 flake: fix/cleanup
b88f17ed42 switch to clang-unwrapped, build IRRT with wasm32
Compare 10 commits »
ychenfo pushed to master at M-Labs/nac3 2022-01-09 12:07:41 +08:00
44f4c4f028 nac3core: build script use Path::join
ychenfo pushed to fix_nix_irrt at M-Labs/nac3 2022-01-09 11:18:28 +08:00
fc83b52fd9 add clang to nativeBuildInputs, fix compile error
4760851638 nac3standalone: link modules and load irrt like in nac3artiq
Compare 2 commits »
ychenfo created pull request M-Labs/nac3#162 2022-01-09 04:43:47 +08:00
Fix compile error for loading IRRT
ychenfo pushed to fix_nix_irrt at M-Labs/nac3 2022-01-09 04:40:07 +08:00
d23cbfd2ca add clang to nativeBuildInputs, fix compile error
ychenfo created branch fix_nix_irrt in M-Labs/nac3 2022-01-09 04:40:07 +08:00
ychenfo created pull request M-Labs/nac3#161 2022-01-09 03:02:00 +08:00
nac3standalone: link modules and load irrt like in nac3artiq
ychenfo pushed to load_irrt_standalone at M-Labs/nac3 2022-01-09 02:19:04 +08:00
4760851638 nac3standalone: link modules and load irrt like in nac3artiq
ychenfo created branch load_irrt_standalone in M-Labs/nac3 2022-01-09 02:19:03 +08:00
ychenfo pushed to master at M-Labs/nac3 2022-01-09 01:12:33 +08:00
1ee857de6a nac3core: format, fix clippy warning
ychenfo pushed to master at M-Labs/nac3 2022-01-09 01:05:52 +08:00
170e3c208f nac3core: format, fix clippy warning
ychenfo pushed to master at M-Labs/nac3 2022-01-09 00:59:04 +08:00
4a65d82db5 introduce IRRT, implement power
ychenfo closed pull request M-Labs/nac3#160 2022-01-09 00:52:37 +08:00
Introduce IRRT and implement power operator (#50)
ychenfo commented on pull request M-Labs/nac3#160 2022-01-09 00:50:15 +08:00
Introduce IRRT and implement power operator (#50)

I've reimplemented it based on your code. Can we delete the power_operator branch?

Thanks! Sure, let me delete power_operator branch and open up a new branch to handle the irrt linking…

ychenfo commented on issue M-Labs/nac3#50 2022-01-09 00:44:18 +08:00
implement the power operator

Done in nac3artiq. @ychenfo can I leave it to you to send another PR that implements the same linking system from nac3artiq in nac3standalone (output a single .o via link_module in LLVM) and the…