• Joined on 2021-03-29
ychenfo pushed to host_var_err_msg at M-Labs/nac3 2022-03-02 21:49:53 +08:00
a8c52c4a94 nac3artiq: remove cached pyid_to_type if error
ychenfo created branch host_var_err_msg in M-Labs/nac3 2022-03-02 21:49:53 +08:00
ychenfo commented on pull request M-Labs/nac3#174 2022-02-07 02:20:04 +08:00
Tuple by value (#172)

Please change this to a match with 3 clauses.

rebased as the latest master branch and fix the style problem.

ychenfo pushed to tuple_by_value at M-Labs/nac3 2022-02-07 02:19:22 +08:00
d6ab73afb0 nac3core: style
6f9f455152 nac3core: list slice irrt use one function to handle var size
e50f1017fa nac3core: irrt list of tuple use struct value representation
77608346b1 nac3core: handle tuple by value
f5ce7376e3 flake: fix Windows build
Compare 5 commits »
ychenfo commented on pull request M-Labs/nac3#174 2022-02-07 02:08:05 +08:00
Tuple by value (#172)

I see, thanks!

ychenfo commented on pull request M-Labs/nac3#174 2022-02-07 02:07:47 +08:00
Tuple by value (#172)

I mean this irrt function then is supposed to be only run with valid input parameters, for checks on things like src_len > dest_len and throwing exceptions about them, we already have TODO

ychenfo commented on pull request M-Labs/nac3#174 2022-02-02 03:36:47 +08:00
Tuple by value (#172)

rebased on the latest master branch, and use one list slice assignment function to handle various sizes of list element.

ychenfo pushed to tuple_by_value at M-Labs/nac3 2022-02-02 03:32:52 +08:00
ef4598ba99 nac3core: list slice irrt use one function to handle var size
e9df7a4ca3 nac3core: irrt list of tuple use struct value representation
23cefaf4b6 nac3core: handle tuple by value
1288624218 lock insta version (#179)
0124bcd26c update dependencies (missing part of previous commit)
Compare 8 commits »
ychenfo commented on pull request M-Labs/nac3#174 2022-02-02 02:54:36 +08:00
Tuple by value (#172)

I think then it would be extending the list, and we would later add the check to throw an exception prior to entering this function?

ychenfo commented on pull request M-Labs/nac3#174 2022-02-02 02:53:26 +08:00
Tuple by value (#172)

Thanks for the suggestions! Yes I was just a bit worried about constant optimization of the call to __builtin_memcpy intrinsic as previously I just call it with the size argument always being a…

ychenfo commented on pull request M-Labs/nac3#174 2022-01-27 12:32:04 +08:00
Tuple by value (#172)

ah what about this? might still be a bit less efficient because of the condition but would be more compact.

diff --git a/nac3core/src/codegen/irrt/irrt.c…
ychenfo commented on pull request M-Labs/nac3#174 2022-01-27 11:57:40 +08:00
Tuple by value (#172)

Yes indeed there's a lot of code duplication now.. functionality wise all the other ones can be replaced by this, but this one will be a bit slower when step is not 1, since the original assignment…

ychenfo commented on pull request M-Labs/nac3#174 2022-01-26 04:16:15 +08:00
Tuple by value (#172)

rebased to include tests and latest commits in master branch.

ychenfo pushed to tuple_by_value at M-Labs/nac3 2022-01-26 04:14:38 +08:00
e042db0734 nac3core: irrt list of tuple use struct value representation
e90fe1b61f nac3core: handle tuple by value
43048eb8d8 nac3standalone: add tests for list slice and len
ace0e2a2c6 nac3core: fix use of size_t in list comprehension, cleanup
e891683f2e flake: hack-link libstdc++ statically on Windows. Closes #175
Compare 14 commits »
ychenfo created pull request M-Labs/nac3#178 2022-01-26 04:05:46 +08:00
nac3standalone: add tests for list slice and len
ychenfo created branch add_list_len_test in M-Labs/nac3 2022-01-26 04:00:27 +08:00
ychenfo pushed to add_list_len_test at M-Labs/nac3 2022-01-26 04:00:27 +08:00
43048eb8d8 nac3standalone: add tests for list slice and len
ychenfo pushed to list_comp_size_t_fix at M-Labs/nac3 2022-01-25 03:36:33 +08:00
ace0e2a2c6 nac3core: fix use of size_t in list comprehension, cleanup
ychenfo commented on pull request M-Labs/nac3#177 2022-01-25 02:52:22 +08:00
fix use of size_t in list comprehension

Renamed to zero_64 and zero_32

ychenfo pushed to list_comp_size_t_fix at M-Labs/nac3 2022-01-25 02:50:32 +08:00
1b220c156f nac3core: fix use of size_t in list comprehension, cleanup