srenblad/nalgebra
1
0
Fork 0
forked from M-Labs/nalgebra
Code Pull Requests Activity

clippy: fix len_zero warnings

Browse Source
This commit is contained in:
Philippe Renon 2020-11-16 12:11:24 +01:00
parent d577a18a45
commit de4a067d27
4 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/base/construction.rs
View File

@ -195,7 +195,7 @@ where
where
SB: Storage<N, U1, C>,
{
assert!(rows.len() > 0, "At least one row must be given.");
assert!(!rows.is_empty(), "At least one row must be given.");
let nrows = R::try_to_usize().unwrap_or_else(|| rows.len());
let ncols = rows[0].len();
assert!(
@ -237,7 +237,7 @@ where
where
SB: Storage<N, R>,
{
assert!(columns.len() > 0, "At least one column must be given.");
assert!(!columns.is_empty(), "At least one column must be given.");
let ncols = C::try_to_usize().unwrap_or(columns.len());
let nrows = columns[0].len();
assert!(

6
src/base/norm.rs
View File

@ -524,12 +524,12 @@ where
match D::dim() {
1 => {
if vs.len() == 0 {
if vs.is_empty() {
let _ = f(&Self::canonical_basis_element(0));
}
}
2 => {
if vs.len() == 0 {
if vs.is_empty() {
let _ = f(&Self::canonical_basis_element(0))
&& f(&Self::canonical_basis_element(1));
} else if vs.len() == 1 {
@ -542,7 +542,7 @@ where
// Otherwise, nothing.
}
3 => {
if vs.len() == 0 {
if vs.is_empty() {
let _ = f(&Self::canonical_basis_element(0))
&& f(&Self::canonical_basis_element(1))
&& f(&Self::canonical_basis_element(2));

4
src/base/statistics.rs
View File

@ -199,7 +199,7 @@ impl<N: Scalar, R: Dim, C: Dim, S: Storage<N, R, C>> Matrix<N, R, C, S> {
where
N: Field + SupersetOf<f64>,
{
if self.len() == 0 {
if self.is_empty() {
N::zero()
} else {
let val = self.iter().cloned().fold((N::zero(), N::zero()), |a, b| {
@ -308,7 +308,7 @@ impl<N: Scalar, R: Dim, C: Dim, S: Storage<N, R, C>> Matrix<N, R, C, S> {
where
N: Field + SupersetOf<f64>,
{
if self.len() == 0 {
if self.is_empty() {
N::zero()
} else {
self.sum() / crate::convert(self.len() as f64)

2
src/linalg/svd.rs
View File

@ -108,7 +108,7 @@ where
max_niter: usize,
) -> Option<Self> {
assert!(
matrix.len() != 0,
!matrix.is_empty(),
"Cannot compute the SVD of an empty matrix."
);
let (nrows, ncols) = matrix.data.shape();