From 9f8cfa207af0b71d141d2eba3f9ce7ecb719d8e3 Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Mon, 2 May 2022 21:55:51 +0200
Subject: [PATCH 01/91] enabled complex eigenvalues for lapack

---
 nalgebra-lapack/src/eigen.rs | 157 ++++++++++++++++++++++++++++-------
 1 file changed, 129 insertions(+), 28 deletions(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index 8eab62d8..594cb080 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -69,8 +69,8 @@ where
             "Unable to compute the eigenvalue decomposition of a non-square matrix."
         );
 
-        let ljob = if left_eigenvectors { b'V' } else { b'T' };
-        let rjob = if eigenvectors { b'V' } else { b'T' };
+        let ljob = if left_eigenvectors { b'V' } else { b'N' };
+        let rjob = if eigenvectors { b'V' } else { b'N' };
 
         let (nrows, ncols) = m.shape_generic();
         let n = nrows.value();
@@ -232,22 +232,27 @@ where
     /// The complex eigenvalues of the given matrix.
     ///
     /// Panics if the eigenvalue computation does not converge.
-    pub fn complex_eigenvalues(mut m: OMatrix<T, D, D>) -> OVector<Complex<T>, D>
+    pub fn complex_eigenvalues(mut m: OMatrix<T, D, D>, left_eigenvectors: bool, eigenvectors: bool) 
+        -> (OVector<Complex<T>, D>,  Option<OMatrix<T, D, D>>,  Option<OMatrix<T, D, D>>)
     where
-        DefaultAllocator: Allocator<Complex<T>, D>,
+        DefaultAllocator: Allocator<Complex<T>, D> + Allocator<Complex<T>, D, D>,
     {
         assert!(
             m.is_square(),
             "Unable to compute the eigenvalue decomposition of a non-square matrix."
         );
 
-        let nrows = m.shape_generic().0;
+        let ljob = if left_eigenvectors { b'V' } else { b'N' };
+        let rjob = if eigenvectors { b'V' } else { b'N' };
+
+        let (nrows, ncols) = m.shape_generic();
         let n = nrows.value();
 
         let lda = n as i32;
 
         // TODO: avoid the initialization?
         let mut wr = Matrix::zeros_generic(nrows, Const::<1>);
+        // TODO: Tap into the workspace.
         let mut wi = Matrix::zeros_generic(nrows, Const::<1>);
 
         let mut info = 0;
@@ -255,8 +260,8 @@ where
         let mut placeholder2 = [T::zero()];
 
         let lwork = T::xgeev_work_size(
-            b'T',
-            b'T',
+            ljob,
+            rjob,
             n as i32,
             m.as_mut_slice(),
             lda,
@@ -273,31 +278,127 @@ where
 
         let mut work = vec![T::zero(); lwork as usize];
 
-        T::xgeev(
-            b'T',
-            b'T',
-            n as i32,
-            m.as_mut_slice(),
-            lda,
-            wr.as_mut_slice(),
-            wi.as_mut_slice(),
-            &mut placeholder1,
-            1 as i32,
-            &mut placeholder2,
-            1 as i32,
-            &mut work,
-            lwork,
-            &mut info,
-        );
-        lapack_panic!(info);
+        match (left_eigenvectors, eigenvectors) {
+            (true, true) => {
+                // TODO: avoid the initializations?
+                let mut vl = Matrix::zeros_generic(nrows, ncols);
+                let mut vr = Matrix::zeros_generic(nrows, ncols);
 
-        let mut res = Matrix::zeros_generic(nrows, Const::<1>);
+                T::xgeev(
+                    ljob,
+                    rjob,
+                    n as i32,
+                    m.as_mut_slice(),
+                    lda,
+                    wr.as_mut_slice(),
+                    wi.as_mut_slice(),
+                    &mut vl.as_mut_slice(),
+                    n as i32,
+                    &mut vr.as_mut_slice(),
+                    n as i32,
+                    &mut work,
+                    lwork,
+                    &mut info,
+                );
+                lapack_panic!(info);
 
-        for i in 0..res.len() {
-            res[i] = Complex::new(wr[i].clone(), wi[i].clone());
+                let mut res = Matrix::zeros_generic(nrows, Const::<1>);
+
+                for i in 0..res.len() {
+                    res[i] = Complex::new(wr[i].clone(), wi[i].clone());
+                }
+        
+                return (res, Some(vl), Some(vr))
+            }
+            (true, false) => {
+                // TODO: avoid the initialization?
+                let mut vl = Matrix::zeros_generic(nrows, ncols);
+
+                T::xgeev(
+                    ljob,
+                    rjob,
+                    n as i32,
+                    m.as_mut_slice(),
+                    lda,
+                    wr.as_mut_slice(),
+                    wi.as_mut_slice(),
+                    &mut vl.as_mut_slice(),
+                    n as i32,
+                    &mut placeholder2,
+                    1 as i32,
+                    &mut work,
+                    lwork,
+                    &mut info,
+                );
+                lapack_panic!(info);
+
+                let mut res = Matrix::zeros_generic(nrows, Const::<1>);
+
+                for i in 0..res.len() {
+                    res[i] = Complex::new(wr[i].clone(), wi[i].clone());
+                }
+        
+                return (res, Some(vl), None)
+            }
+            (false, true) => {
+                // TODO: avoid the initialization?
+                let mut vr = Matrix::zeros_generic(nrows, ncols);
+
+                T::xgeev(
+                    ljob,
+                    rjob,
+                    n as i32,
+                    m.as_mut_slice(),
+                    lda,
+                    wr.as_mut_slice(),
+                    wi.as_mut_slice(),
+                    &mut placeholder1,
+                    1 as i32,
+                    &mut vr.as_mut_slice(),
+                    n as i32,
+                    &mut work,
+                    lwork,
+                    &mut info,
+                );
+                lapack_panic!(info);
+
+                let mut res = Matrix::zeros_generic(nrows, Const::<1>);
+
+                for i in 0..res.len() {
+                    res[i] = Complex::new(wr[i].clone(), wi[i].clone());
+                }
+        
+                return (res, None, Some(vr))
+            }
+            (false, false) => {
+                T::xgeev(
+                    ljob,
+                    rjob,
+                    n as i32,
+                    m.as_mut_slice(),
+                    lda,
+                    wr.as_mut_slice(),
+                    wi.as_mut_slice(),
+                    &mut placeholder1,
+                    1 as i32,
+                    &mut placeholder2,
+                    1 as i32,
+                    &mut work,
+                    lwork,
+                    &mut info,
+                );
+                lapack_panic!(info);
+
+                let mut res = Matrix::zeros_generic(nrows, Const::<1>);
+
+                for i in 0..res.len() {
+                    res[i] = Complex::new(wr[i].clone(), wi[i].clone());
+                }
+        
+                return (res, None, None)
+            }
         }
 
-        res
     }
 
     /// The determinant of the decomposed matrix.

From 71ef287fead3449a9914020b016b0207dc68d039 Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Mon, 2 May 2022 22:49:07 +0200
Subject: [PATCH 02/91] removed return statements

---
 nalgebra-lapack/src/eigen.rs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index 594cb080..6c63ee33 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -308,7 +308,7 @@ where
                     res[i] = Complex::new(wr[i].clone(), wi[i].clone());
                 }
         
-                return (res, Some(vl), Some(vr))
+                (res, Some(vl), Some(vr))
             }
             (true, false) => {
                 // TODO: avoid the initialization?
@@ -338,7 +338,7 @@ where
                     res[i] = Complex::new(wr[i].clone(), wi[i].clone());
                 }
         
-                return (res, Some(vl), None)
+                (res, Some(vl), None)
             }
             (false, true) => {
                 // TODO: avoid the initialization?
@@ -368,7 +368,7 @@ where
                     res[i] = Complex::new(wr[i].clone(), wi[i].clone());
                 }
         
-                return (res, None, Some(vr))
+                (res, None, Some(vr))
             }
             (false, false) => {
                 T::xgeev(
@@ -395,7 +395,7 @@ where
                     res[i] = Complex::new(wr[i].clone(), wi[i].clone());
                 }
         
-                return (res, None, None)
+                (res, None, None)
             }
         }
 

From aafb7138489e9cb48072e9d7ecc0f52365f908fa Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Tue, 3 May 2022 19:11:56 +0200
Subject: [PATCH 03/91] removed whitespace

---
 nalgebra-lapack/src/eigen.rs | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index 6c63ee33..0c2106ad 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -307,7 +307,6 @@ where
                 for i in 0..res.len() {
                     res[i] = Complex::new(wr[i].clone(), wi[i].clone());
                 }
-        
                 (res, Some(vl), Some(vr))
             }
             (true, false) => {
@@ -337,7 +336,6 @@ where
                 for i in 0..res.len() {
                     res[i] = Complex::new(wr[i].clone(), wi[i].clone());
                 }
-        
                 (res, Some(vl), None)
             }
             (false, true) => {
@@ -367,7 +365,6 @@ where
                 for i in 0..res.len() {
                     res[i] = Complex::new(wr[i].clone(), wi[i].clone());
                 }
-        
                 (res, None, Some(vr))
             }
             (false, false) => {
@@ -394,7 +391,6 @@ where
                 for i in 0..res.len() {
                     res[i] = Complex::new(wr[i].clone(), wi[i].clone());
                 }
-        
                 (res, None, None)
             }
         }

From 4d968da1adc960e4ac51d0f3c39ea0d9ef77e1c1 Mon Sep 17 00:00:00 2001
From: Solra Bizna <solra@bizna.name>
Date: Wed, 25 May 2022 16:42:18 -0600
Subject: [PATCH 04/91] Make "Point::new" a const fn

---
 src/geometry/point_construction.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/geometry/point_construction.rs b/src/geometry/point_construction.rs
index 2136080a..ac54b349 100644
--- a/src/geometry/point_construction.rs
+++ b/src/geometry/point_construction.rs
@@ -202,7 +202,7 @@ impl<T: Scalar> Point1<T> {
     /// assert_eq!(p.x, 1.0);
     /// ```
     #[inline]
-    pub fn new(x: T) -> Self {
+    pub const fn new(x: T) -> Self {
         Point {
             coords: Vector1::new(x),
         }
@@ -216,7 +216,7 @@ macro_rules! componentwise_constructors_impl(
             #[doc = $doc]
             #[doc = "```"]
             #[inline]
-            pub fn new($($args: T),*) -> Self {
+            pub const fn new($($args: T),*) -> Self {
                 Point { coords: $Vector::new($($args),*) }
             }
         }

From 0cdf3ce4524231c0b9cb66c4ae08512e7af9d2a8 Mon Sep 17 00:00:00 2001
From: Jacob Trueb <jtrueb@northwestern.edu>
Date: Wed, 25 May 2022 17:51:19 -0500
Subject: [PATCH 05/91] Fix UnitComplex cast doctest failure on macOS

---
 src/geometry/unit_complex_construction.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/geometry/unit_complex_construction.rs b/src/geometry/unit_complex_construction.rs
index ebf4e81d..9536e87f 100644
--- a/src/geometry/unit_complex_construction.rs
+++ b/src/geometry/unit_complex_construction.rs
@@ -131,10 +131,11 @@ where
     ///
     /// # Example
     /// ```
+    /// #[macro_use] extern crate approx;
     /// # use nalgebra::UnitComplex;
     /// let c = UnitComplex::new(1.0f64);
     /// let c2 = c.cast::<f32>();
-    /// assert_eq!(c2, UnitComplex::new(1.0f32));
+    /// assert_relative_eq!(c2, UnitComplex::new(1.0f32));
     /// ```
     pub fn cast<To: Scalar>(self) -> UnitComplex<To>
     where

From 8aa10b819c465eb17b3fd4558512469cfab6cd98 Mon Sep 17 00:00:00 2001
From: Benjamin Saunders <ben.e.saunders@gmail.com>
Date: Sat, 11 Jun 2022 11:07:24 -0700
Subject: [PATCH 06/91] Implement `cast` for `Unit<Vector<T, D, S>>`

Currently, `cast` is resolved via `Unit`'s `Deref` impl, which leads
to it confusingly stripping the `Unit` from `UnitVector`s. Add an
inherent impl which takes precedence, similar to the existing
specialization for `UnitQuaternion`.
---
 src/base/matrix.rs | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/src/base/matrix.rs b/src/base/matrix.rs
index 8f8786c1..d9294c9e 100644
--- a/src/base/matrix.rs
+++ b/src/base/matrix.rs
@@ -2186,3 +2186,28 @@ where
         }
     }
 }
+
+impl<T, D, S> Unit<Vector<T, D, S>>
+where
+    T: Scalar,
+    D: Dim,
+    S: RawStorage<T, D, U1>,
+{
+    /// Cast the components of `self` to another type.
+    ///
+    /// # Example
+    /// ```
+    /// # use nalgebra::Vector3;
+    /// let v = Vector3::<f64>::y_axis();
+    /// let v2 = v.cast::<f32>();
+    /// assert_eq!(v2, Vector3::<f32>::y_axis());
+    /// ```
+    pub fn cast<T2: Scalar>(self) -> Unit<OVector<T2, D>>
+    where
+        T: Scalar,
+        OVector<T2, D>: SupersetOf<Vector<T, D, S>>,
+        DefaultAllocator: Allocator<T2, D, U1>,
+    {
+        Unit::new_unchecked(crate::convert_ref(self.as_ref()))
+    }
+}

From 1e31e6ba69625cbb5ed9eae14f990953b7290e3e Mon Sep 17 00:00:00 2001
From: devil-ira <justthecooldude@gmail.com>
Date: Sat, 23 Jul 2022 17:39:59 +0200
Subject: [PATCH 07/91] Add feature `convert-glam021`.

---
 Cargo.toml                       |  2 ++
 src/third_party/glam/mod.rs      |  2 ++
 src/third_party/glam/v021/mod.rs | 18 ++++++++++++++++++
 3 files changed, 22 insertions(+)
 create mode 100644 src/third_party/glam/v021/mod.rs

diff --git a/Cargo.toml b/Cargo.toml
index 732676ec..faee3029 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -44,6 +44,7 @@ convert-glam017 = [ "glam017" ]
 convert-glam018 = [ "glam018" ]
 convert-glam019 = [ "glam019" ]
 convert-glam020 = [ "glam020" ]
+convert-glam021 = [ "glam021" ]
 
 # Serialization
 ## To use serde in a #[no-std] environment, enable the
@@ -95,6 +96,7 @@ glam017        = { package = "glam", version = "0.17", optional = true }
 glam018        = { package = "glam", version = "0.18", optional = true }
 glam019        = { package = "glam", version = "0.19", optional = true }
 glam020        = { package = "glam", version = "0.20", optional = true }
+glam021        = { package = "glam", version = "0.21", optional = true }
 cust_core      = { version = "0.1", optional = true }
 
 
diff --git a/src/third_party/glam/mod.rs b/src/third_party/glam/mod.rs
index ae2c4514..06bdcfb7 100644
--- a/src/third_party/glam/mod.rs
+++ b/src/third_party/glam/mod.rs
@@ -12,3 +12,5 @@ mod v018;
 mod v019;
 #[cfg(feature = "glam020")]
 mod v020;
+#[cfg(feature = "glam021")]
+mod v021;
diff --git a/src/third_party/glam/v021/mod.rs b/src/third_party/glam/v021/mod.rs
new file mode 100644
index 00000000..d0168923
--- /dev/null
+++ b/src/third_party/glam/v021/mod.rs
@@ -0,0 +1,18 @@
+#[path = "../common/glam_isometry.rs"]
+mod glam_isometry;
+#[path = "../common/glam_matrix.rs"]
+mod glam_matrix;
+#[path = "../common/glam_point.rs"]
+mod glam_point;
+#[path = "../common/glam_quaternion.rs"]
+mod glam_quaternion;
+#[path = "../common/glam_rotation.rs"]
+mod glam_rotation;
+#[path = "../common/glam_similarity.rs"]
+mod glam_similarity;
+#[path = "../common/glam_translation.rs"]
+mod glam_translation;
+#[path = "../common/glam_unit_complex.rs"]
+mod glam_unit_complex;
+
+pub(self) use glam021 as glam;

From 238750fb30a5f3785e37fbf4a4ebc5af48e55dd3 Mon Sep 17 00:00:00 2001
From: devil-ira <justthecooldude@gmail.com>
Date: Sat, 23 Jul 2022 23:55:40 +0200
Subject: [PATCH 08/91] Use `From` trait to convert glam types to arrays.

---
 src/third_party/glam/common/glam_matrix.rs | 6 +++---
 src/third_party/glam/common/glam_point.rs  | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/third_party/glam/common/glam_matrix.rs b/src/third_party/glam/common/glam_matrix.rs
index fa9f713f..26f58803 100644
--- a/src/third_party/glam/common/glam_matrix.rs
+++ b/src/third_party/glam/common/glam_matrix.rs
@@ -14,7 +14,7 @@ macro_rules! impl_vec_conversion(
         impl From<$Vec2> for Vector2<$N> {
             #[inline]
             fn from(e: $Vec2) -> Vector2<$N> {
-                (*e.as_ref()).into()
+                <[$N;2]>::from(e).into()
             }
         }
 
@@ -31,7 +31,7 @@ macro_rules! impl_vec_conversion(
         impl From<$Vec3> for Vector3<$N> {
             #[inline]
             fn from(e: $Vec3) -> Vector3<$N> {
-                (*e.as_ref()).into()
+                <[$N;3]>::from(e).into()
             }
         }
 
@@ -48,7 +48,7 @@ macro_rules! impl_vec_conversion(
         impl From<$Vec4> for Vector4<$N> {
             #[inline]
             fn from(e: $Vec4) -> Vector4<$N> {
-                (*e.as_ref()).into()
+                <[$N;4]>::from(e).into()
             }
         }
 
diff --git a/src/third_party/glam/common/glam_point.rs b/src/third_party/glam/common/glam_point.rs
index b15a6c6d..205986b8 100644
--- a/src/third_party/glam/common/glam_point.rs
+++ b/src/third_party/glam/common/glam_point.rs
@@ -9,7 +9,7 @@ macro_rules! impl_point_conversion(
         impl From<$Vec2> for Point2<$N> {
             #[inline]
             fn from(e: $Vec2) -> Point2<$N> {
-                (*e.as_ref()).into()
+                <[$N;2]>::from(e).into()
             }
         }
 
@@ -23,7 +23,7 @@ macro_rules! impl_point_conversion(
         impl From<$Vec3> for Point3<$N> {
             #[inline]
             fn from(e: $Vec3) -> Point3<$N> {
-                (*e.as_ref()).into()
+                <[$N;3]>::from(e).into()
             }
         }
 
@@ -37,7 +37,7 @@ macro_rules! impl_point_conversion(
         impl From<$Vec4> for Point4<$N> {
             #[inline]
             fn from(e: $Vec4) -> Point4<$N> {
-                (*e.as_ref()).into()
+                <[$N;4]>::from(e).into()
             }
         }
 

From f9aa2d76aab6ed1dc2c31f485f20d6557cc86233 Mon Sep 17 00:00:00 2001
From: Tim Taubner <tt@daedalean.ai>
Date: Thu, 31 Mar 2022 17:28:31 +0200
Subject: [PATCH 09/91] Start from random rotation in from_matrix to prevent
 issues when calling from_matrix on rotation matrices

---
 src/geometry/quaternion_construction.rs |  4 +++-
 src/geometry/rotation_specialization.rs | 10 +++++++---
 tests/geometry/rotation.rs              | 16 +++++++++++++++-
 3 files changed, 25 insertions(+), 5 deletions(-)

diff --git a/src/geometry/quaternion_construction.rs b/src/geometry/quaternion_construction.rs
index 6de21bd5..dbd1edbc 100644
--- a/src/geometry/quaternion_construction.rs
+++ b/src/geometry/quaternion_construction.rs
@@ -410,9 +410,11 @@ where
     /// This is an iterative method. See `.from_matrix_eps` to provide mover
     /// convergence parameters and starting solution.
     /// This implements "A Robust Method to Extract the Rotational Part of Deformations" by Müller et al.
+    #[cfg(feature = "rand-no-std")]
     pub fn from_matrix(m: &Matrix3<T>) -> Self
     where
-        T: RealField,
+        T: RealField + Scalar,
+        Standard: Distribution<Rotation3<T>>,
     {
         Rotation3::from_matrix(m).into()
     }
diff --git a/src/geometry/rotation_specialization.rs b/src/geometry/rotation_specialization.rs
index 41405c87..b57eeb53 100644
--- a/src/geometry/rotation_specialization.rs
+++ b/src/geometry/rotation_specialization.rs
@@ -706,11 +706,15 @@ where
     /// This is an iterative method. See `.from_matrix_eps` to provide mover
     /// convergence parameters and starting solution.
     /// This implements "A Robust Method to Extract the Rotational Part of Deformations" by Müller et al.
+    #[cfg(feature = "rand-no-std")]
     pub fn from_matrix(m: &Matrix3<T>) -> Self
     where
-        T: RealField,
+        T: RealField + crate::Scalar,
+        Standard: Distribution<Rotation3<T>>,
     {
-        Self::from_matrix_eps(m, T::default_epsilon(), 0, Self::identity())
+        // Starting from a random rotation has almost zero likelihood to end up in a maximum if `m` is already a rotation matrix
+        let random_rotation: Rotation3<T> = rand::thread_rng().gen();
+        Self::from_matrix_eps(m, T::default_epsilon(), 0, random_rotation)
     }
 
     /// Builds a rotation matrix by extracting the rotation part of the given transformation `m`.
@@ -730,7 +734,7 @@ where
         T: RealField,
     {
         if max_iter == 0 {
-            max_iter = usize::max_value();
+            max_iter = usize::MAX;
         }
 
         let mut rot = guess.into_inner();
diff --git a/tests/geometry/rotation.rs b/tests/geometry/rotation.rs
index 84bba676..61af83d9 100644
--- a/tests/geometry/rotation.rs
+++ b/tests/geometry/rotation.rs
@@ -1,4 +1,5 @@
-use na::{Quaternion, RealField, UnitQuaternion, Vector2, Vector3};
+use std::f64::consts::PI;
+use na::{Matrix3, Quaternion, RealField, Rotation3, UnitQuaternion, UnitVector3, Vector2, Vector3};
 
 #[test]
 fn angle_2() {
@@ -16,6 +17,19 @@ fn angle_3() {
     assert_eq!(a.angle(&b), 0.0);
 }
 
+#[test]
+fn from_rotation_matrix() {
+    // Test degenerate case when from_matrix_eps gets stuck in maximum
+    let identity = Rotation3::from_matrix(&Matrix3::new(
+        1.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 1.0,
+    ));
+    assert_relative_eq!(identity, &Rotation3::identity(), epsilon = 0.001);
+    let rotated_z = Rotation3::from_matrix(&Matrix3::new(
+        1.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, -1.0,
+    ));
+    assert_relative_eq!(rotated_z, &Rotation3::from_axis_angle(&UnitVector3::new_unchecked(Vector3::new(1.0, 0.0, 0.0)), PI), epsilon = 0.001);
+}
+
 #[test]
 fn quaternion_euler_angles_issue_494() {
     let quat = UnitQuaternion::from_quaternion(Quaternion::new(

From 257d95b3d34b07a1f322076e4e2ff8298679bc92 Mon Sep 17 00:00:00 2001
From: Tim Taubner <tt@daedalean.ai>
Date: Thu, 31 Mar 2022 18:03:59 +0200
Subject: [PATCH 10/91] Add test case for issue 1078

---
 tests/geometry/rotation.rs | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/geometry/rotation.rs b/tests/geometry/rotation.rs
index 61af83d9..369b5454 100644
--- a/tests/geometry/rotation.rs
+++ b/tests/geometry/rotation.rs
@@ -28,6 +28,10 @@ fn from_rotation_matrix() {
         1.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, -1.0,
     ));
     assert_relative_eq!(rotated_z, &Rotation3::from_axis_angle(&UnitVector3::new_unchecked(Vector3::new(1.0, 0.0, 0.0)), PI), epsilon = 0.001);
+    // Test that issue 1078 is fixed
+    let m = nalgebra::Matrix3::<f64>::new(0.0, 0.0, 1.0, 0.0, -1.0, 0.0, 1.0, 0.0, 0.0);
+    assert_relative_ne!(identity, nalgebra::Rotation3::from_matrix(&m));
+    assert_relative_eq!(nalgebra::Rotation3::from_matrix_unchecked(m.clone()), nalgebra::Rotation3::from_matrix(&m));
 }
 
 #[test]

From ac203fe4fd101e3ae0e0a542f175fcb23f7dabbe Mon Sep 17 00:00:00 2001
From: Tim Taubner <tt@daedalean.ai>
Date: Thu, 31 Mar 2022 18:07:04 +0200
Subject: [PATCH 11/91] Add test case for issue 628

---
 tests/geometry/rotation.rs | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/tests/geometry/rotation.rs b/tests/geometry/rotation.rs
index 369b5454..661430a0 100644
--- a/tests/geometry/rotation.rs
+++ b/tests/geometry/rotation.rs
@@ -19,7 +19,7 @@ fn angle_3() {
 
 #[test]
 fn from_rotation_matrix() {
-    // Test degenerate case when from_matrix_eps gets stuck in maximum
+    // Test degenerate case when from_matrix gets stuck in Identity rotation
     let identity = Rotation3::from_matrix(&Matrix3::new(
         1.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 1.0,
     ));
@@ -28,10 +28,15 @@ fn from_rotation_matrix() {
         1.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, -1.0,
     ));
     assert_relative_eq!(rotated_z, &Rotation3::from_axis_angle(&UnitVector3::new_unchecked(Vector3::new(1.0, 0.0, 0.0)), PI), epsilon = 0.001);
+    // Test that issue 628 is fixed
+    let m_628 = nalgebra::Matrix3::<f64>::new(-1.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, 1.0);
+    assert_relative_ne!(identity, nalgebra::Rotation3::from_matrix(&m_628), epsilon = 0.01);
+    assert_relative_eq!(nalgebra::Rotation3::from_matrix_unchecked(m_628.clone()), nalgebra::Rotation3::from_matrix(&m_628), epsilon = 0.001);
+
     // Test that issue 1078 is fixed
-    let m = nalgebra::Matrix3::<f64>::new(0.0, 0.0, 1.0, 0.0, -1.0, 0.0, 1.0, 0.0, 0.0);
-    assert_relative_ne!(identity, nalgebra::Rotation3::from_matrix(&m));
-    assert_relative_eq!(nalgebra::Rotation3::from_matrix_unchecked(m.clone()), nalgebra::Rotation3::from_matrix(&m));
+    let m_1078 = nalgebra::Matrix3::<f64>::new(0.0, 0.0, 1.0, 0.0, -1.0, 0.0, 1.0, 0.0, 0.0);
+    assert_relative_ne!(identity, nalgebra::Rotation3::from_matrix(&m_1078), epsilon = 0.01);
+    assert_relative_eq!(nalgebra::Rotation3::from_matrix_unchecked(m_1078.clone()), nalgebra::Rotation3::from_matrix(&m_1078), epsilon = 0.001);
 }
 
 #[test]

From d515e4f1be71acc31eadb5f26133102e840403fe Mon Sep 17 00:00:00 2001
From: Tim Taubner <tt@daedalean.ai>
Date: Fri, 1 Apr 2022 14:30:20 +0200
Subject: [PATCH 12/91] Perturbations to check for convergence into maximum.

---
 src/geometry/rotation_specialization.rs | 30 +++++++++++++++++++------
 1 file changed, 23 insertions(+), 7 deletions(-)

diff --git a/src/geometry/rotation_specialization.rs b/src/geometry/rotation_specialization.rs
index b57eeb53..304f5ee5 100644
--- a/src/geometry/rotation_specialization.rs
+++ b/src/geometry/rotation_specialization.rs
@@ -17,7 +17,7 @@ use std::ops::Neg;
 
 use crate::base::dimension::{U1, U2, U3};
 use crate::base::storage::Storage;
-use crate::base::{Matrix2, Matrix3, SMatrix, SVector, Unit, Vector, Vector1, Vector2, Vector3};
+use crate::base::{Matrix2, Matrix3, SMatrix, SVector, Unit, Vector, Vector1, Vector2, Vector3, UnitVector3};
 
 use crate::geometry::{Rotation2, Rotation3, UnitComplex, UnitQuaternion};
 
@@ -706,15 +706,12 @@ where
     /// This is an iterative method. See `.from_matrix_eps` to provide mover
     /// convergence parameters and starting solution.
     /// This implements "A Robust Method to Extract the Rotational Part of Deformations" by Müller et al.
-    #[cfg(feature = "rand-no-std")]
     pub fn from_matrix(m: &Matrix3<T>) -> Self
     where
-        T: RealField + crate::Scalar,
-        Standard: Distribution<Rotation3<T>>,
+        T: RealField,
     {
         // Starting from a random rotation has almost zero likelihood to end up in a maximum if `m` is already a rotation matrix
-        let random_rotation: Rotation3<T> = rand::thread_rng().gen();
-        Self::from_matrix_eps(m, T::default_epsilon(), 0, random_rotation)
+        Self::from_matrix_eps(m, T::default_epsilon(), 0, Rotation3::identity())
     }
 
     /// Builds a rotation matrix by extracting the rotation part of the given transformation `m`.
@@ -737,6 +734,7 @@ where
             max_iter = usize::MAX;
         }
 
+        let mut perturbation_axes = UnitVector3::new_unchecked(Vector3::new(T::one(), T::zero(), T::zero()));
         let mut rot = guess.into_inner();
 
         for _ in 0..max_iter {
@@ -752,7 +750,25 @@ where
             if let Some((axis, angle)) = Unit::try_new_and_get(axisangle, eps.clone()) {
                 rot = Rotation3::from_axis_angle(&axis, angle) * rot;
             } else {
-                break;
+                // Check if stuck in a maximum w.r.t. the norm (m - rot).norm()
+                let mut perturbed = rot.clone();
+                let norm_squared = (m - &rot).norm_squared();
+                let mut new_norm_squared: T;
+                // Perturb until the new norm is significantly different
+                loop {
+                    perturbed *= Rotation3::from_axis_angle(&perturbation_axes, T::frac_pi_8());
+                    new_norm_squared = (m - &perturbed).norm_squared();
+                    if relative_ne!(norm_squared, new_norm_squared) {
+                        break;
+                    }
+                }
+                // If new norm is larger, it's a minimum
+                if norm_squared < new_norm_squared {
+                    break;
+                }
+                // If not, continue from perturbed rotation, but use a different axes for the next perturbation
+                perturbation_axes = UnitVector3::new_unchecked(Vector3::new(perturbation_axes.y.clone(), perturbation_axes.z.clone(), perturbation_axes.x.clone()));
+                rot = perturbed;
             }
         }
 

From 26e69863e1bbe6ccc4866dc34f944b49c03603ac Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Wed, 27 Jul 2022 09:45:54 +0200
Subject: [PATCH 13/91] Rotation from matrix: small code cleanups

---
 src/geometry/quaternion_construction.rs |  3 +--
 src/geometry/rotation_specialization.rs | 15 ++++++++++-----
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/src/geometry/quaternion_construction.rs b/src/geometry/quaternion_construction.rs
index dbd1edbc..18f7a65c 100644
--- a/src/geometry/quaternion_construction.rs
+++ b/src/geometry/quaternion_construction.rs
@@ -413,8 +413,7 @@ where
     #[cfg(feature = "rand-no-std")]
     pub fn from_matrix(m: &Matrix3<T>) -> Self
     where
-        T: RealField + Scalar,
-        Standard: Distribution<Rotation3<T>>,
+        T: RealField,
     {
         Rotation3::from_matrix(m).into()
     }
diff --git a/src/geometry/rotation_specialization.rs b/src/geometry/rotation_specialization.rs
index 304f5ee5..f00d8cd7 100644
--- a/src/geometry/rotation_specialization.rs
+++ b/src/geometry/rotation_specialization.rs
@@ -17,7 +17,9 @@ use std::ops::Neg;
 
 use crate::base::dimension::{U1, U2, U3};
 use crate::base::storage::Storage;
-use crate::base::{Matrix2, Matrix3, SMatrix, SVector, Unit, Vector, Vector1, Vector2, Vector3, UnitVector3};
+use crate::base::{
+    Matrix2, Matrix3, SMatrix, SVector, Unit, UnitVector3, Vector, Vector1, Vector2, Vector3,
+};
 
 use crate::geometry::{Rotation2, Rotation3, UnitComplex, UnitQuaternion};
 
@@ -710,8 +712,7 @@ where
     where
         T: RealField,
     {
-        // Starting from a random rotation has almost zero likelihood to end up in a maximum if `m` is already a rotation matrix
-        Self::from_matrix_eps(m, T::default_epsilon(), 0, Rotation3::identity())
+        Self::from_matrix_eps(m, T::default_epsilon(), 0, Self::identity())
     }
 
     /// Builds a rotation matrix by extracting the rotation part of the given transformation `m`.
@@ -734,7 +735,7 @@ where
             max_iter = usize::MAX;
         }
 
-        let mut perturbation_axes = UnitVector3::new_unchecked(Vector3::new(T::one(), T::zero(), T::zero()));
+        let mut perturbation_axes = Vector3::x_axis();
         let mut rot = guess.into_inner();
 
         for _ in 0..max_iter {
@@ -754,20 +755,24 @@ where
                 let mut perturbed = rot.clone();
                 let norm_squared = (m - &rot).norm_squared();
                 let mut new_norm_squared: T;
+
                 // Perturb until the new norm is significantly different
                 loop {
                     perturbed *= Rotation3::from_axis_angle(&perturbation_axes, T::frac_pi_8());
                     new_norm_squared = (m - &perturbed).norm_squared();
+
                     if relative_ne!(norm_squared, new_norm_squared) {
                         break;
                     }
                 }
+
                 // If new norm is larger, it's a minimum
                 if norm_squared < new_norm_squared {
                     break;
                 }
+
                 // If not, continue from perturbed rotation, but use a different axes for the next perturbation
-                perturbation_axes = UnitVector3::new_unchecked(Vector3::new(perturbation_axes.y.clone(), perturbation_axes.z.clone(), perturbation_axes.x.clone()));
+                perturbation_axes = UnitVector3::new_unchecked(perturbation_axes.yzx());
                 rot = perturbed;
             }
         }

From 18a8a3067101d294b82c95b65a34db5367ee36ae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Wed, 27 Jul 2022 09:46:02 +0200
Subject: [PATCH 14/91] cargo fmt

---
 tests/geometry/rotation.rs | 44 +++++++++++++++++++++++++++-----------
 1 file changed, 32 insertions(+), 12 deletions(-)

diff --git a/tests/geometry/rotation.rs b/tests/geometry/rotation.rs
index 661430a0..883d4c0b 100644
--- a/tests/geometry/rotation.rs
+++ b/tests/geometry/rotation.rs
@@ -1,5 +1,7 @@
+use na::{
+    Matrix3, Quaternion, RealField, Rotation3, UnitQuaternion, UnitVector3, Vector2, Vector3,
+};
 use std::f64::consts::PI;
-use na::{Matrix3, Quaternion, RealField, Rotation3, UnitQuaternion, UnitVector3, Vector2, Vector3};
 
 #[test]
 fn angle_2() {
@@ -20,23 +22,41 @@ fn angle_3() {
 #[test]
 fn from_rotation_matrix() {
     // Test degenerate case when from_matrix gets stuck in Identity rotation
-    let identity = Rotation3::from_matrix(&Matrix3::new(
-        1.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 1.0,
-    ));
+    let identity =
+        Rotation3::from_matrix(&Matrix3::new(1.0, 0.0, 0.0, 0.0, 1.0, 0.0, 0.0, 0.0, 1.0));
     assert_relative_eq!(identity, &Rotation3::identity(), epsilon = 0.001);
-    let rotated_z = Rotation3::from_matrix(&Matrix3::new(
-        1.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, -1.0,
-    ));
-    assert_relative_eq!(rotated_z, &Rotation3::from_axis_angle(&UnitVector3::new_unchecked(Vector3::new(1.0, 0.0, 0.0)), PI), epsilon = 0.001);
+    let rotated_z =
+        Rotation3::from_matrix(&Matrix3::new(1.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, -1.0));
+    assert_relative_eq!(
+        rotated_z,
+        &Rotation3::from_axis_angle(&UnitVector3::new_unchecked(Vector3::new(1.0, 0.0, 0.0)), PI),
+        epsilon = 0.001
+    );
     // Test that issue 628 is fixed
     let m_628 = nalgebra::Matrix3::<f64>::new(-1.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, 1.0);
-    assert_relative_ne!(identity, nalgebra::Rotation3::from_matrix(&m_628), epsilon = 0.01);
-    assert_relative_eq!(nalgebra::Rotation3::from_matrix_unchecked(m_628.clone()), nalgebra::Rotation3::from_matrix(&m_628), epsilon = 0.001);
+    assert_relative_ne!(
+        identity,
+        nalgebra::Rotation3::from_matrix(&m_628),
+        epsilon = 0.01
+    );
+    assert_relative_eq!(
+        nalgebra::Rotation3::from_matrix_unchecked(m_628.clone()),
+        nalgebra::Rotation3::from_matrix(&m_628),
+        epsilon = 0.001
+    );
 
     // Test that issue 1078 is fixed
     let m_1078 = nalgebra::Matrix3::<f64>::new(0.0, 0.0, 1.0, 0.0, -1.0, 0.0, 1.0, 0.0, 0.0);
-    assert_relative_ne!(identity, nalgebra::Rotation3::from_matrix(&m_1078), epsilon = 0.01);
-    assert_relative_eq!(nalgebra::Rotation3::from_matrix_unchecked(m_1078.clone()), nalgebra::Rotation3::from_matrix(&m_1078), epsilon = 0.001);
+    assert_relative_ne!(
+        identity,
+        nalgebra::Rotation3::from_matrix(&m_1078),
+        epsilon = 0.01
+    );
+    assert_relative_eq!(
+        nalgebra::Rotation3::from_matrix_unchecked(m_1078.clone()),
+        nalgebra::Rotation3::from_matrix(&m_1078),
+        epsilon = 0.001
+    );
 }
 
 #[test]

From 7aadbcf21d2feafbe282fcdcc6b6469bf60dc859 Mon Sep 17 00:00:00 2001
From: Tim Taubner <tt@daedalean.ai>
Date: Wed, 27 Jul 2022 11:31:34 +0200
Subject: [PATCH 15/91] From_rotation_matrix: Use the larger of eps.sqrt() or
 eps*eps as disturbance. Add tests for eps > 1.0

---
 src/geometry/quaternion_construction.rs |  1 -
 src/geometry/rotation_specialization.rs |  7 +++--
 tests/geometry/rotation.rs              | 40 ++++++++++++++++++-------
 3 files changed, 34 insertions(+), 14 deletions(-)

diff --git a/src/geometry/quaternion_construction.rs b/src/geometry/quaternion_construction.rs
index 18f7a65c..6de21bd5 100644
--- a/src/geometry/quaternion_construction.rs
+++ b/src/geometry/quaternion_construction.rs
@@ -410,7 +410,6 @@ where
     /// This is an iterative method. See `.from_matrix_eps` to provide mover
     /// convergence parameters and starting solution.
     /// This implements "A Robust Method to Extract the Rotational Part of Deformations" by Müller et al.
-    #[cfg(feature = "rand-no-std")]
     pub fn from_matrix(m: &Matrix3<T>) -> Self
     where
         T: RealField,
diff --git a/src/geometry/rotation_specialization.rs b/src/geometry/rotation_specialization.rs
index f00d8cd7..fc2c9b93 100644
--- a/src/geometry/rotation_specialization.rs
+++ b/src/geometry/rotation_specialization.rs
@@ -735,6 +735,8 @@ where
             max_iter = usize::MAX;
         }
 
+        // Using sqrt(eps) ensures we perturb with something larger than eps; clamp to eps to handle the case of eps > 1.0
+        let eps_disturbance = eps.clone().sqrt().max(eps.clone() * eps.clone());
         let mut perturbation_axes = Vector3::x_axis();
         let mut rot = guess.into_inner();
 
@@ -758,10 +760,9 @@ where
 
                 // Perturb until the new norm is significantly different
                 loop {
-                    perturbed *= Rotation3::from_axis_angle(&perturbation_axes, T::frac_pi_8());
+                    perturbed *= Rotation3::from_axis_angle(&perturbation_axes, eps_disturbance.clone());
                     new_norm_squared = (m - &perturbed).norm_squared();
-
-                    if relative_ne!(norm_squared, new_norm_squared) {
+                    if abs_diff_ne!(norm_squared, new_norm_squared, epsilon = T::default_epsilon()) {
                         break;
                     }
                 }
diff --git a/tests/geometry/rotation.rs b/tests/geometry/rotation.rs
index 883d4c0b..f5a77b54 100644
--- a/tests/geometry/rotation.rs
+++ b/tests/geometry/rotation.rs
@@ -32,31 +32,51 @@ fn from_rotation_matrix() {
         &Rotation3::from_axis_angle(&UnitVector3::new_unchecked(Vector3::new(1.0, 0.0, 0.0)), PI),
         epsilon = 0.001
     );
-    // Test that issue 628 is fixed
-    let m_628 = nalgebra::Matrix3::<f64>::new(-1.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, 1.0);
+    // Test that issue 627 is fixed
+    let m_627 = Matrix3::<f64>::new(-1.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, 1.0);
     assert_relative_ne!(
         identity,
-        nalgebra::Rotation3::from_matrix(&m_628),
+        Rotation3::from_matrix(&m_627),
         epsilon = 0.01
     );
     assert_relative_eq!(
-        nalgebra::Rotation3::from_matrix_unchecked(m_628.clone()),
-        nalgebra::Rotation3::from_matrix(&m_628),
+        Rotation3::from_matrix_unchecked(m_627.clone()),
+        Rotation3::from_matrix(&m_627),
         epsilon = 0.001
     );
-
     // Test that issue 1078 is fixed
-    let m_1078 = nalgebra::Matrix3::<f64>::new(0.0, 0.0, 1.0, 0.0, -1.0, 0.0, 1.0, 0.0, 0.0);
+    let m_1078 = Matrix3::<f64>::new(0.0, 0.0, 1.0, 0.0, -1.0, 0.0, 1.0, 0.0, 0.0);
     assert_relative_ne!(
         identity,
-        nalgebra::Rotation3::from_matrix(&m_1078),
+        Rotation3::from_matrix(&m_1078),
         epsilon = 0.01
     );
     assert_relative_eq!(
-        nalgebra::Rotation3::from_matrix_unchecked(m_1078.clone()),
-        nalgebra::Rotation3::from_matrix(&m_1078),
+        Rotation3::from_matrix_unchecked(m_1078.clone()),
+        Rotation3::from_matrix(&m_1078),
         epsilon = 0.001
     );
+    // Additional test cases for eps >= 1.0
+    assert_relative_ne!(
+        identity,
+        Rotation3::from_matrix_eps(&m_627, 1.2, 0, Rotation3::identity()),
+        epsilon = 0.6
+    );
+    assert_relative_eq!(
+        Rotation3::from_matrix_unchecked(m_627.clone()),
+        Rotation3::from_matrix_eps(&m_627, 1.2, 0, Rotation3::identity()),
+        epsilon = 0.6
+    );
+    assert_relative_ne!(
+        identity,
+        Rotation3::from_matrix_eps(&m_1078, 1.0, 0, Rotation3::identity()),
+        epsilon = 0.1
+    );
+    assert_relative_eq!(
+        Rotation3::from_matrix_unchecked(m_1078.clone()),
+        Rotation3::from_matrix_eps(&m_1078, 1.0, 0, Rotation3::identity()),
+        epsilon = 0.1
+    );
 }
 
 #[test]

From 0c2d9deac7da51c91cd5d2b8e08bcf05350cece0 Mon Sep 17 00:00:00 2001
From: Tim Taubner <tt@daedalean.ai>
Date: Wed, 27 Jul 2022 11:44:42 +0200
Subject: [PATCH 16/91] cargo fmt

---
 src/geometry/rotation_specialization.rs |  9 +++++++--
 tests/geometry/rotation.rs              | 12 ++----------
 2 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/src/geometry/rotation_specialization.rs b/src/geometry/rotation_specialization.rs
index fc2c9b93..c9197fd6 100644
--- a/src/geometry/rotation_specialization.rs
+++ b/src/geometry/rotation_specialization.rs
@@ -760,9 +760,14 @@ where
 
                 // Perturb until the new norm is significantly different
                 loop {
-                    perturbed *= Rotation3::from_axis_angle(&perturbation_axes, eps_disturbance.clone());
+                    perturbed *=
+                        Rotation3::from_axis_angle(&perturbation_axes, eps_disturbance.clone());
                     new_norm_squared = (m - &perturbed).norm_squared();
-                    if abs_diff_ne!(norm_squared, new_norm_squared, epsilon = T::default_epsilon()) {
+                    if abs_diff_ne!(
+                        norm_squared,
+                        new_norm_squared,
+                        epsilon = T::default_epsilon()
+                    ) {
                         break;
                     }
                 }
diff --git a/tests/geometry/rotation.rs b/tests/geometry/rotation.rs
index f5a77b54..2e8d2482 100644
--- a/tests/geometry/rotation.rs
+++ b/tests/geometry/rotation.rs
@@ -34,11 +34,7 @@ fn from_rotation_matrix() {
     );
     // Test that issue 627 is fixed
     let m_627 = Matrix3::<f64>::new(-1.0, 0.0, 0.0, 0.0, -1.0, 0.0, 0.0, 0.0, 1.0);
-    assert_relative_ne!(
-        identity,
-        Rotation3::from_matrix(&m_627),
-        epsilon = 0.01
-    );
+    assert_relative_ne!(identity, Rotation3::from_matrix(&m_627), epsilon = 0.01);
     assert_relative_eq!(
         Rotation3::from_matrix_unchecked(m_627.clone()),
         Rotation3::from_matrix(&m_627),
@@ -46,11 +42,7 @@ fn from_rotation_matrix() {
     );
     // Test that issue 1078 is fixed
     let m_1078 = Matrix3::<f64>::new(0.0, 0.0, 1.0, 0.0, -1.0, 0.0, 1.0, 0.0, 0.0);
-    assert_relative_ne!(
-        identity,
-        Rotation3::from_matrix(&m_1078),
-        epsilon = 0.01
-    );
+    assert_relative_ne!(identity, Rotation3::from_matrix(&m_1078), epsilon = 0.01);
     assert_relative_eq!(
         Rotation3::from_matrix_unchecked(m_1078.clone()),
         Rotation3::from_matrix(&m_1078),

From 008511d96eed1adfdb1b3cacda5ff8cf76a4d075 Mon Sep 17 00:00:00 2001
From: Chammika Mannakkara <chammika.mannakkara@become.co.jp>
Date: Tue, 4 May 2021 22:23:49 +0900
Subject: [PATCH 17/91] from_row_iterator added

---
 src/base/allocator.rs         |  7 +++
 src/base/construction.rs      | 41 +++++++++++++++++
 src/base/default_allocator.rs | 86 +++++++++++++++++++++++++++++++++++
 3 files changed, 134 insertions(+)

diff --git a/src/base/allocator.rs b/src/base/allocator.rs
index 29286420..ccbcca37 100644
--- a/src/base/allocator.rs
+++ b/src/base/allocator.rs
@@ -41,6 +41,13 @@ pub trait Allocator<T, R: Dim, C: Dim = U1>: Any + Sized {
         ncols: C,
         iter: I,
     ) -> Self::Buffer;
+
+    /// Allocates a buffer initialized with the content of the given row-major order iterator.
+    fn allocate_from_row_iterator<I: IntoIterator<Item = T>>(
+        nrows: R,
+        ncols: C,
+        iter: I,
+    ) -> Self::Buffer;
 }
 
 /// A matrix reallocator. Changes the size of the memory buffer that initially contains (`RFrom` ×
diff --git a/src/base/construction.rs b/src/base/construction.rs
index fe4e4b08..009d8c76 100644
--- a/src/base/construction.rs
+++ b/src/base/construction.rs
@@ -86,6 +86,17 @@ where
         Self::from_data(DefaultAllocator::allocate_from_iterator(nrows, ncols, iter))
     }
 
+    /// Creates a matrix with all its elements filled by an row-major order iterator.
+    #[inline]
+    pub fn from_row_iterator_generic<I>(nrows: R, ncols: C, iter: I) -> Self
+    where
+        I: IntoIterator<Item = T>,
+    {
+        Self::from_data(DefaultAllocator::allocate_from_row_iterator(
+            nrows, ncols, iter,
+        ))
+    }
+
     /// Creates a matrix with its elements filled with the components provided by a slice in
     /// row-major order.
     ///
@@ -479,6 +490,36 @@ macro_rules! impl_constructors(
             Self::from_iterator_generic($($gargs, )* iter)
         }
 
+        /// Creates a matrix or vector with all its elements filled by a row-major iterator.
+        ///
+        /// The output matrix is filled row-by-row.
+        ///
+        /// ## Example
+        /// ```
+        /// # use nalgebra::{Matrix2x3, Vector3, DVector, DMatrix};
+        /// # use std::iter;
+        ///
+        /// let v = Vector3::from_row_iterator((0..3).into_iter());
+        /// // The additional argument represents the vector dimension.
+        /// let dv = DVector::from_row_iterator(3, (0..3).into_iter());
+        /// let m = Matrix2x3::from_row_iterator((0..6).into_iter());
+        /// // The two additional arguments represent the matrix dimensions.
+        /// let dm = DMatrix::from_row_iterator(2, 3, (0..6).into_iter());
+        ///
+        /// // For Vectors from_row_iterator is identical to from_iterator
+        /// assert!(v.x == 0 && v.y == 1 && v.z == 2);
+        /// assert!(dv[0] == 0 && dv[1] == 1 && dv[2] == 2);
+        /// assert!(m.m11 == 0 && m.m12 == 1 && m.m13 == 2 &&
+        ///         m.m21 == 3 && m.m22 == 4 && m.m23 == 5);
+        /// assert!(dm[(0, 0)] == 0 && dm[(0, 1)] == 1 && dm[(0, 2)] == 2 &&
+        ///         dm[(1, 0)] == 3 && dm[(1, 1)] == 4 && dm[(1, 2)] == 5);
+        /// ```
+        #[inline]
+        pub fn from_row_iterator<I>($($args: usize,)* iter: I) -> Self
+            where I: IntoIterator<Item = T> {
+            Self::from_row_iterator_generic($($gargs, )* iter)
+        }
+
         /// Creates a matrix or vector filled with the results of a function applied to each of its
         /// component coordinates.
         ///
diff --git a/src/base/default_allocator.rs b/src/base/default_allocator.rs
index 09197bbd..e055604c 100644
--- a/src/base/default_allocator.rs
+++ b/src/base/default_allocator.rs
@@ -80,6 +80,40 @@ impl<T: Scalar, const R: usize, const C: usize> Allocator<T, Const<R>, Const<C>>
         //         yielded enough elements to initialize our matrix.
         unsafe { <Self as Allocator<T, Const<R>, Const<C>>>::assume_init(res) }
     }
+
+    #[inline]
+    fn allocate_from_row_iterator<I: IntoIterator<Item = T>>(
+        nrows: Const<R>,
+        ncols: Const<C>,
+        iter: I,
+    ) -> Self::Buffer {
+        #[cfg(feature = "no_unsound_assume_init")]
+        let mut res: Self::Buffer = unimplemented!();
+        #[cfg(not(feature = "no_unsound_assume_init"))]
+        let mut res = unsafe { Self::allocate_uninitialized(nrows, ncols).assume_init() };
+        let mut count = 0;
+        let res_ptr = res.as_mut_slice();
+
+        for (i, e) in iter
+            .into_iter()
+            .take(ncols.value() * nrows.value())
+            .enumerate()
+        {
+            unsafe {
+                *res_ptr
+                    .get_unchecked_mut((i % ncols.value()) * nrows.value() + i / ncols.value()) = e;
+            }
+            // res_ptr[(i % ncols.value()) * nrows.value() + i / ncols.value()] = e;
+            count += 1;
+        }
+
+        assert!(
+            count == nrows.value() * ncols.value(),
+            "Matrix init. from row iterator: iterator not long enough."
+        );
+
+        res
+    }
 }
 
 // Dynamic - Static
@@ -128,6 +162,32 @@ impl<T: Scalar, C: Dim> Allocator<T, Dynamic, C> for DefaultAllocator {
 
         VecStorage::new(nrows, ncols, res)
     }
+
+    #[inline]
+    fn allocate_from_row_iterator<I: IntoIterator<Item = T>>(
+        nrows: Dynamic,
+        ncols: C,
+        iter: I,
+    ) -> Self::Buffer {
+        let it = iter.into_iter().take(nrows.value() * ncols.value());
+        let mut res: Vec<T> = Vec::with_capacity(nrows.value() * ncols.value());
+        let res_ptr = res.as_mut_ptr();
+        let mut count = 0;
+
+        unsafe {
+            for (i, e) in it.enumerate() {
+                *res_ptr.add((i % ncols.value()) * nrows.value() + i / ncols.value()) = e;
+                count += 1;
+            }
+            res.set_len(nrows.value() * ncols.value());
+        }
+        assert!(
+            count == nrows.value() * ncols.value(),
+            "Matrix init. from row iterator: iterator not long enough."
+        );
+
+        VecStorage::new(nrows, ncols, res)
+    }
 }
 
 // Static - Dynamic
@@ -176,6 +236,32 @@ impl<T: Scalar, R: DimName> Allocator<T, R, Dynamic> for DefaultAllocator {
 
         VecStorage::new(nrows, ncols, res)
     }
+
+    #[inline]
+    fn allocate_from_row_iterator<I: IntoIterator<Item = T>>(
+        nrows: R,
+        ncols: Dynamic,
+        iter: I,
+    ) -> Self::Buffer {
+        let it = iter.into_iter().take(nrows.value() * ncols.value());
+        let mut res: Vec<T> = Vec::with_capacity(nrows.value() * ncols.value());
+        let res_ptr = res.as_mut_ptr();
+        let mut count = 0;
+
+        unsafe {
+            for (i, e) in it.enumerate() {
+                *res_ptr.add((i % ncols.value()) * nrows.value() + i / ncols.value()) = e;
+                count += 1;
+            }
+            res.set_len(nrows.value() * ncols.value());
+        }
+        assert!(
+            count == nrows.value() * ncols.value(),
+            "Matrix init. from row iterator: iterator not long enough."
+        );
+
+        VecStorage::new(nrows, ncols, res)
+    }
 }
 
 /*

From 8588ef8fb20f6e3fb0f3dbbf99f32e850638a451 Mon Sep 17 00:00:00 2001
From: Gianluca Oldani <gianluca.oldani@unibg.it>
Date: Wed, 2 Mar 2022 00:52:01 +0100
Subject: [PATCH 18/91] Sound implementation for from_row_iterator

---
 src/base/default_allocator.rs | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/base/default_allocator.rs b/src/base/default_allocator.rs
index e055604c..b048ba24 100644
--- a/src/base/default_allocator.rs
+++ b/src/base/default_allocator.rs
@@ -87,10 +87,7 @@ impl<T: Scalar, const R: usize, const C: usize> Allocator<T, Const<R>, Const<C>>
         ncols: Const<C>,
         iter: I,
     ) -> Self::Buffer {
-        #[cfg(feature = "no_unsound_assume_init")]
-        let mut res: Self::Buffer = unimplemented!();
-        #[cfg(not(feature = "no_unsound_assume_init"))]
-        let mut res = unsafe { Self::allocate_uninitialized(nrows, ncols).assume_init() };
+        let mut res = Self::allocate_uninit(nrows, ncols);
         let mut count = 0;
         let res_ptr = res.as_mut_slice();
 
@@ -101,7 +98,7 @@ impl<T: Scalar, const R: usize, const C: usize> Allocator<T, Const<R>, Const<C>>
         {
             unsafe {
                 *res_ptr
-                    .get_unchecked_mut((i % ncols.value()) * nrows.value() + i / ncols.value()) = e;
+                    .get_unchecked_mut((i % ncols.value()) * nrows.value() + i / ncols.value()) = MaybeUninit::new(e);
             }
             // res_ptr[(i % ncols.value()) * nrows.value() + i / ncols.value()] = e;
             count += 1;
@@ -112,7 +109,7 @@ impl<T: Scalar, const R: usize, const C: usize> Allocator<T, Const<R>, Const<C>>
             "Matrix init. from row iterator: iterator not long enough."
         );
 
-        res
+        unsafe { <Self as Allocator<T, Const<R>, Const<C>>>::assume_init(res) }
     }
 }
 
@@ -250,7 +247,7 @@ impl<T: Scalar, R: DimName> Allocator<T, R, Dynamic> for DefaultAllocator {
 
         unsafe {
             for (i, e) in it.enumerate() {
-                *res_ptr.add((i % ncols.value()) * nrows.value() + i / ncols.value()) = e;
+                *res_ptr.add((i % ncols.value()) * nrows.value() + i / ncols.value()) = MaybeUninit::new(e).assume_init();
                 count += 1;
             }
             res.set_len(nrows.value() * ncols.value());

From 59b01e955f2d6901eba972c58c2ffcb4c9b5781d Mon Sep 17 00:00:00 2001
From: Gianluca Oldani <gianluca.oldani@unibg.it>
Date: Thu, 3 Mar 2022 13:33:04 +0100
Subject: [PATCH 19/91] Fixed formatting

---
 src/base/default_allocator.rs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/base/default_allocator.rs b/src/base/default_allocator.rs
index b048ba24..d9bc2c6b 100644
--- a/src/base/default_allocator.rs
+++ b/src/base/default_allocator.rs
@@ -98,7 +98,8 @@ impl<T: Scalar, const R: usize, const C: usize> Allocator<T, Const<R>, Const<C>>
         {
             unsafe {
                 *res_ptr
-                    .get_unchecked_mut((i % ncols.value()) * nrows.value() + i / ncols.value()) = MaybeUninit::new(e);
+                    .get_unchecked_mut((i % ncols.value()) * nrows.value() + i / ncols.value()) =
+                    MaybeUninit::new(e);
             }
             // res_ptr[(i % ncols.value()) * nrows.value() + i / ncols.value()] = e;
             count += 1;
@@ -247,7 +248,8 @@ impl<T: Scalar, R: DimName> Allocator<T, R, Dynamic> for DefaultAllocator {
 
         unsafe {
             for (i, e) in it.enumerate() {
-                *res_ptr.add((i % ncols.value()) * nrows.value() + i / ncols.value()) = MaybeUninit::new(e).assume_init();
+                *res_ptr.add((i % ncols.value()) * nrows.value() + i / ncols.value()) =
+                    MaybeUninit::new(e).assume_init();
                 count += 1;
             }
             res.set_len(nrows.value() * ncols.value());

From 89767ee9f33106f874127fd2ee018dc259ad070b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sat, 30 Jul 2022 18:06:47 +0200
Subject: [PATCH 20/91] Reduce code duplication for allocating a storage from a
 raw iterator.

---
 src/base/allocator.rs         | 30 ++++++++++++-
 src/base/default_allocator.rs | 85 -----------------------------------
 2 files changed, 29 insertions(+), 86 deletions(-)

diff --git a/src/base/allocator.rs b/src/base/allocator.rs
index ccbcca37..bb227d3b 100644
--- a/src/base/allocator.rs
+++ b/src/base/allocator.rs
@@ -42,12 +42,40 @@ pub trait Allocator<T, R: Dim, C: Dim = U1>: Any + Sized {
         iter: I,
     ) -> Self::Buffer;
 
+    #[inline]
     /// Allocates a buffer initialized with the content of the given row-major order iterator.
     fn allocate_from_row_iterator<I: IntoIterator<Item = T>>(
         nrows: R,
         ncols: C,
         iter: I,
-    ) -> Self::Buffer;
+    ) -> Self::Buffer {
+        let mut res = Self::allocate_uninit(nrows, ncols);
+        let mut count = 0;
+
+        unsafe {
+            // OK because the allocated buffer is guaranteed to be contiguous.
+            let res_ptr = res.as_mut_slice_unchecked();
+
+            for (k, e) in iter
+                .into_iter()
+                .take(ncols.value() * nrows.value())
+                .enumerate()
+            {
+                let i = k / ncols.value();
+                let j = k % ncols.value();
+                // result[(i, j)] = e;
+                *res_ptr.get_unchecked_mut(i + j * nrows.value()) = MaybeUninit::new(e);
+                count += 1;
+            }
+
+            assert!(
+                count == nrows.value() * ncols.value(),
+                "Matrix init. from row iterator: iterator not long enough."
+            );
+
+            <Self as Allocator<T, R, C>>::assume_init(res)
+        }
+    }
 }
 
 /// A matrix reallocator. Changes the size of the memory buffer that initially contains (`RFrom` ×
diff --git a/src/base/default_allocator.rs b/src/base/default_allocator.rs
index d9bc2c6b..09197bbd 100644
--- a/src/base/default_allocator.rs
+++ b/src/base/default_allocator.rs
@@ -80,38 +80,6 @@ impl<T: Scalar, const R: usize, const C: usize> Allocator<T, Const<R>, Const<C>>
         //         yielded enough elements to initialize our matrix.
         unsafe { <Self as Allocator<T, Const<R>, Const<C>>>::assume_init(res) }
     }
-
-    #[inline]
-    fn allocate_from_row_iterator<I: IntoIterator<Item = T>>(
-        nrows: Const<R>,
-        ncols: Const<C>,
-        iter: I,
-    ) -> Self::Buffer {
-        let mut res = Self::allocate_uninit(nrows, ncols);
-        let mut count = 0;
-        let res_ptr = res.as_mut_slice();
-
-        for (i, e) in iter
-            .into_iter()
-            .take(ncols.value() * nrows.value())
-            .enumerate()
-        {
-            unsafe {
-                *res_ptr
-                    .get_unchecked_mut((i % ncols.value()) * nrows.value() + i / ncols.value()) =
-                    MaybeUninit::new(e);
-            }
-            // res_ptr[(i % ncols.value()) * nrows.value() + i / ncols.value()] = e;
-            count += 1;
-        }
-
-        assert!(
-            count == nrows.value() * ncols.value(),
-            "Matrix init. from row iterator: iterator not long enough."
-        );
-
-        unsafe { <Self as Allocator<T, Const<R>, Const<C>>>::assume_init(res) }
-    }
 }
 
 // Dynamic - Static
@@ -160,32 +128,6 @@ impl<T: Scalar, C: Dim> Allocator<T, Dynamic, C> for DefaultAllocator {
 
         VecStorage::new(nrows, ncols, res)
     }
-
-    #[inline]
-    fn allocate_from_row_iterator<I: IntoIterator<Item = T>>(
-        nrows: Dynamic,
-        ncols: C,
-        iter: I,
-    ) -> Self::Buffer {
-        let it = iter.into_iter().take(nrows.value() * ncols.value());
-        let mut res: Vec<T> = Vec::with_capacity(nrows.value() * ncols.value());
-        let res_ptr = res.as_mut_ptr();
-        let mut count = 0;
-
-        unsafe {
-            for (i, e) in it.enumerate() {
-                *res_ptr.add((i % ncols.value()) * nrows.value() + i / ncols.value()) = e;
-                count += 1;
-            }
-            res.set_len(nrows.value() * ncols.value());
-        }
-        assert!(
-            count == nrows.value() * ncols.value(),
-            "Matrix init. from row iterator: iterator not long enough."
-        );
-
-        VecStorage::new(nrows, ncols, res)
-    }
 }
 
 // Static - Dynamic
@@ -234,33 +176,6 @@ impl<T: Scalar, R: DimName> Allocator<T, R, Dynamic> for DefaultAllocator {
 
         VecStorage::new(nrows, ncols, res)
     }
-
-    #[inline]
-    fn allocate_from_row_iterator<I: IntoIterator<Item = T>>(
-        nrows: R,
-        ncols: Dynamic,
-        iter: I,
-    ) -> Self::Buffer {
-        let it = iter.into_iter().take(nrows.value() * ncols.value());
-        let mut res: Vec<T> = Vec::with_capacity(nrows.value() * ncols.value());
-        let res_ptr = res.as_mut_ptr();
-        let mut count = 0;
-
-        unsafe {
-            for (i, e) in it.enumerate() {
-                *res_ptr.add((i % ncols.value()) * nrows.value() + i / ncols.value()) =
-                    MaybeUninit::new(e).assume_init();
-                count += 1;
-            }
-            res.set_len(nrows.value() * ncols.value());
-        }
-        assert!(
-            count == nrows.value() * ncols.value(),
-            "Matrix init. from row iterator: iterator not long enough."
-        );
-
-        VecStorage::new(nrows, ncols, res)
-    }
 }
 
 /*

From d5284a2a86ac05d40720d14ecf71896abdcb7241 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sat, 30 Jul 2022 18:16:18 +0200
Subject: [PATCH 21/91] Remove unused extern crate.

---
 src/lib.rs | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/lib.rs b/src/lib.rs
index 1ee1a3ba..8da86531 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -109,8 +109,6 @@ extern crate alloc;
 #[cfg(not(feature = "std"))]
 extern crate core as std;
 
-#[cfg(feature = "io")]
-extern crate pest;
 #[macro_use]
 #[cfg(feature = "io")]
 extern crate pest_derive;

From 54ab62d9715831384a4ea618f1cf641bd8f4c6fe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sat, 30 Jul 2022 18:19:17 +0200
Subject: [PATCH 22/91] Remove another unused extern crate.

---
 nalgebra-sparse/src/lib.rs | 2 --
 1 file changed, 2 deletions(-)

diff --git a/nalgebra-sparse/src/lib.rs b/nalgebra-sparse/src/lib.rs
index 8567261a..c62677c3 100644
--- a/nalgebra-sparse/src/lib.rs
+++ b/nalgebra-sparse/src/lib.rs
@@ -143,8 +143,6 @@
 )]
 
 pub extern crate nalgebra as na;
-#[cfg(feature = "io")]
-extern crate pest;
 #[macro_use]
 #[cfg(feature = "io")]
 extern crate pest_derive;

From 11ff2ed69b42ba4b77482dca4ebde7513290429b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sun, 31 Jul 2022 09:42:02 +0200
Subject: [PATCH 23/91] Release v0.31.1

---
 CHANGELOG.md               | 15 +++++++++++++++
 Cargo.toml                 |  6 +++---
 nalgebra-sparse/Cargo.toml |  2 +-
 3 files changed, 19 insertions(+), 4 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c00c01fc..2950a1df 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,21 @@ documented here.
 
 This project adheres to [Semantic Versioning](https://semver.org/).
 
+## [0.31.1] (31 July 2022)
+
+### Modified
+- Improve performances of multiplication of two sparse matrices.
+
+### Added
+- Add `Matrix::from_row_iterator` to build a matrix from an iterator yielding components in row-major order.
+- Add support for conversion from/to types of `glam` 0.21.
+- `nalgebra-sparse`: add support for the matrix-market export of sparse matrices.
+- `nalgebra-lapack`: add a `GE` for solving the generalized eigenvalues problem.
+
+### Fixed
+- Fix `Rotation3::from_matrix` and `UnitQuaternion::from_matrix` when the input matrix is already a valid
+  rotation matrix.
+
 ## [0.31.0] (30 Apr. 2022)
 
 ### Breaking changes
diff --git a/Cargo.toml b/Cargo.toml
index faee3029..5b9940df 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name    = "nalgebra"
-version = "0.31.0"
+version = "0.31.1"
 authors = [ "Sébastien Crozet <developer@crozet.re>" ]
 
 description = "General-purpose linear algebra library with transformations and statically-sized or dynamically-sized matrices."
@@ -132,6 +132,6 @@ required-features = ["rand"]
 lto = true
 
 [package.metadata.docs.rs]
-# Enable certain features when building docs for docs.rs
-features = [ "proptest-support", "compare", "macros", "rand" ]
+# Enable all the features when building the docs on docs.rs
+all-features = true
 
diff --git a/nalgebra-sparse/Cargo.toml b/nalgebra-sparse/Cargo.toml
index 390f594e..b9c343e4 100644
--- a/nalgebra-sparse/Cargo.toml
+++ b/nalgebra-sparse/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "nalgebra-sparse"
-version = "0.7.0"
+version = "0.7.1"
 authors = [ "Andreas Longva", "Sébastien Crozet <developer@crozet.re>" ]
 edition = "2018"
 description = "Sparse matrix computation based on nalgebra."

From d3b7acce4d97823d37b7d652293765dcc6e1562f Mon Sep 17 00:00:00 2001
From: Ritoban Roy-Chowdhury <ritobanrc@gmail.com>
Date: Mon, 8 Aug 2022 17:48:10 -0700
Subject: [PATCH 24/91] update DefaultAllocator docs to say ArrayStorage
 instead of GenericArray

---
 src/base/default_allocator.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/base/default_allocator.rs b/src/base/default_allocator.rs
index 09197bbd..6aaadfc7 100644
--- a/src/base/default_allocator.rs
+++ b/src/base/default_allocator.rs
@@ -26,7 +26,7 @@ use std::mem::{ManuallyDrop, MaybeUninit};
  * Allocator.
  *
  */
-/// An allocator based on `GenericArray` and `VecStorage` for statically-sized and dynamically-sized
+/// An allocator based on [`ArrayStorage`] and [`VecStorage`] for statically-sized and dynamically-sized
 /// matrices respectively.
 #[derive(Copy, Clone, Debug)]
 pub struct DefaultAllocator;

From 84c44984b1fd8975bdd195e3b5c9077c4c9c5e55 Mon Sep 17 00:00:00 2001
From: Patrick Owen <patowen95@gmail.com>
Date: Fri, 12 Aug 2022 01:33:11 -0400
Subject: [PATCH 25/91] Use #[inline] to improve opt-level 1 performance

---
 src/base/dimension.rs | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/base/dimension.rs b/src/base/dimension.rs
index 4be97586..b1b700d7 100644
--- a/src/base/dimension.rs
+++ b/src/base/dimension.rs
@@ -252,14 +252,17 @@ pub trait ToTypenum {
 }
 
 unsafe impl<const T: usize> Dim for Const<T> {
+    #[inline]
     fn try_to_usize() -> Option<usize> {
         Some(T)
     }
 
+    #[inline]
     fn value(&self) -> usize {
         T
     }
 
+    #[inline]
     fn from_usize(dim: usize) -> Self {
         assert_eq!(dim, T);
         Self

From b90dc7c042e9278786ba54c5b0fc8d85db8412d7 Mon Sep 17 00:00:00 2001
From: lukas <lukashermann28@gmail.com>
Date: Mon, 15 Aug 2022 19:14:38 -0700
Subject: [PATCH 26/91] Add `clear_triplet()`

---
 nalgebra-sparse/src/coo.rs              | 20 +++++++++++++++++
 nalgebra-sparse/tests/unit_tests/coo.rs | 29 +++++++++++++++++++++++++
 2 files changed, 49 insertions(+)

diff --git a/nalgebra-sparse/src/coo.rs b/nalgebra-sparse/src/coo.rs
index 2b302e37..e047745a 100644
--- a/nalgebra-sparse/src/coo.rs
+++ b/nalgebra-sparse/src/coo.rs
@@ -211,6 +211,26 @@ impl<T> CooMatrix<T> {
         self.values.push(v);
     }
 
+    /// Remove a single triplet from the matrix.
+    ///
+    /// This removes the value `v` from the `i`th row and `j`th column in the matrix.
+    pub fn clear_triplet(&mut self, i: usize, j: usize, v: T) -> Option<(usize, usize, T)>
+    where
+        T: PartialEq,
+    {
+        let triple_idx = self
+            .triplet_iter()
+            .position(|triplet| triplet == (i, j, &v));
+        if let Some(triple_idx) = triple_idx {
+            self.row_indices.remove(triple_idx);
+            self.col_indices.remove(triple_idx);
+            let retv = self.values.remove(triple_idx);
+            Some((i, j, retv))
+        } else {
+            None
+        }
+    }
+
     /// The number of rows in the matrix.
     #[inline]
     #[must_use]
diff --git a/nalgebra-sparse/tests/unit_tests/coo.rs b/nalgebra-sparse/tests/unit_tests/coo.rs
index c70c5f97..6ec88fb1 100644
--- a/nalgebra-sparse/tests/unit_tests/coo.rs
+++ b/nalgebra-sparse/tests/unit_tests/coo.rs
@@ -226,6 +226,35 @@ fn coo_push_valid_entries() {
     );
 }
 
+#[test]
+fn coo_clear_triplet_valid_entries() {
+    let mut coo = CooMatrix::new(3, 3);
+
+    coo.push(0, 0, 1);
+    coo.push(0, 0, 2);
+    coo.push(2, 2, 3);
+
+    // clear a triplet that is not included
+    let triplet = coo.clear_triplet(0, 0, 0);
+    assert_eq!(triplet, None);
+    assert_eq!(
+        coo.triplet_iter().collect::<Vec<_>>(),
+        vec![(0, 0, &1), (0, 0, &2), (2, 2, &3)]
+    );
+    let triplet = coo.clear_triplet(0, 0, 1);
+    assert_eq!(triplet, Some((0, 0, 1)));
+    assert_eq!(
+        coo.triplet_iter().collect::<Vec<_>>(),
+        vec![(0, 0, &2), (2, 2, &3)]
+    );
+    let triplet = coo.clear_triplet(0, 0, 2);
+    assert_eq!(triplet, Some((0, 0, 2)));
+    assert_eq!(coo.triplet_iter().collect::<Vec<_>>(), vec![(2, 2, &3)]);
+    let triplet = coo.clear_triplet(2, 2, 3);
+    assert_eq!(triplet, Some((2, 2, 3)));
+    assert_eq!(coo.triplet_iter().collect::<Vec<_>>(), vec![]);
+}
+
 #[test]
 fn coo_push_out_of_bounds_entries() {
     {

From bcc5527baac743df259b85c9a61a5793a63ce8fc Mon Sep 17 00:00:00 2001
From: lukas <lukashermann28@gmail.com>
Date: Mon, 15 Aug 2022 19:28:58 -0700
Subject: [PATCH 27/91] Switch return type to just T

---
 nalgebra-sparse/src/coo.rs              | 6 +++---
 nalgebra-sparse/tests/unit_tests/coo.rs | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/nalgebra-sparse/src/coo.rs b/nalgebra-sparse/src/coo.rs
index e047745a..197ef6f4 100644
--- a/nalgebra-sparse/src/coo.rs
+++ b/nalgebra-sparse/src/coo.rs
@@ -214,7 +214,7 @@ impl<T> CooMatrix<T> {
     /// Remove a single triplet from the matrix.
     ///
     /// This removes the value `v` from the `i`th row and `j`th column in the matrix.
-    pub fn clear_triplet(&mut self, i: usize, j: usize, v: T) -> Option<(usize, usize, T)>
+    pub fn clear_triplet(&mut self, i: usize, j: usize, v: T) -> Option<T>
     where
         T: PartialEq,
     {
@@ -224,8 +224,8 @@ impl<T> CooMatrix<T> {
         if let Some(triple_idx) = triple_idx {
             self.row_indices.remove(triple_idx);
             self.col_indices.remove(triple_idx);
-            let retv = self.values.remove(triple_idx);
-            Some((i, j, retv))
+            let removed_value = self.values.remove(triple_idx);
+            Some(removed_value)
         } else {
             None
         }
diff --git a/nalgebra-sparse/tests/unit_tests/coo.rs b/nalgebra-sparse/tests/unit_tests/coo.rs
index 6ec88fb1..4b640596 100644
--- a/nalgebra-sparse/tests/unit_tests/coo.rs
+++ b/nalgebra-sparse/tests/unit_tests/coo.rs
@@ -242,16 +242,16 @@ fn coo_clear_triplet_valid_entries() {
         vec![(0, 0, &1), (0, 0, &2), (2, 2, &3)]
     );
     let triplet = coo.clear_triplet(0, 0, 1);
-    assert_eq!(triplet, Some((0, 0, 1)));
+    assert_eq!(triplet, Some(1));
     assert_eq!(
         coo.triplet_iter().collect::<Vec<_>>(),
         vec![(0, 0, &2), (2, 2, &3)]
     );
     let triplet = coo.clear_triplet(0, 0, 2);
-    assert_eq!(triplet, Some((0, 0, 2)));
+    assert_eq!(triplet, Some(2));
     assert_eq!(coo.triplet_iter().collect::<Vec<_>>(), vec![(2, 2, &3)]);
     let triplet = coo.clear_triplet(2, 2, 3);
-    assert_eq!(triplet, Some((2, 2, 3)));
+    assert_eq!(triplet, Some(3));
     assert_eq!(coo.triplet_iter().collect::<Vec<_>>(), vec![]);
 }
 

From bdfa643e3cc749b44058ab467068e4aa96287513 Mon Sep 17 00:00:00 2001
From: lukas <lukashermann28@gmail.com>
Date: Tue, 16 Aug 2022 00:15:03 -0700
Subject: [PATCH 28/91] clear_triplets

---
 nalgebra-sparse/src/coo.rs              | 20 +++++---------------
 nalgebra-sparse/tests/unit_tests/coo.rs | 20 +++-----------------
 2 files changed, 8 insertions(+), 32 deletions(-)

diff --git a/nalgebra-sparse/src/coo.rs b/nalgebra-sparse/src/coo.rs
index 197ef6f4..9793fa1e 100644
--- a/nalgebra-sparse/src/coo.rs
+++ b/nalgebra-sparse/src/coo.rs
@@ -211,24 +211,14 @@ impl<T> CooMatrix<T> {
         self.values.push(v);
     }
 
-    /// Remove a single triplet from the matrix.
-    ///
-    /// This removes the value `v` from the `i`th row and `j`th column in the matrix.
-    pub fn clear_triplet(&mut self, i: usize, j: usize, v: T) -> Option<T>
+    /// Clear all triplets from the matrix.
+    pub fn clear_triplets(&mut self, i: usize, j: usize, v: T) -> Option<T>
     where
         T: PartialEq,
     {
-        let triple_idx = self
-            .triplet_iter()
-            .position(|triplet| triplet == (i, j, &v));
-        if let Some(triple_idx) = triple_idx {
-            self.row_indices.remove(triple_idx);
-            self.col_indices.remove(triple_idx);
-            let removed_value = self.values.remove(triple_idx);
-            Some(removed_value)
-        } else {
-            None
-        }
+        self.col_indices.clear();
+        self.row_indices.clear();
+        self.values.clear();
     }
 
     /// The number of rows in the matrix.
diff --git a/nalgebra-sparse/tests/unit_tests/coo.rs b/nalgebra-sparse/tests/unit_tests/coo.rs
index 4b640596..b9c22885 100644
--- a/nalgebra-sparse/tests/unit_tests/coo.rs
+++ b/nalgebra-sparse/tests/unit_tests/coo.rs
@@ -227,32 +227,18 @@ fn coo_push_valid_entries() {
 }
 
 #[test]
-fn coo_clear_triplet_valid_entries() {
+fn coo_clear_triplets_valid_entries() {
     let mut coo = CooMatrix::new(3, 3);
 
     coo.push(0, 0, 1);
     coo.push(0, 0, 2);
     coo.push(2, 2, 3);
-
-    // clear a triplet that is not included
-    let triplet = coo.clear_triplet(0, 0, 0);
-    assert_eq!(triplet, None);
     assert_eq!(
         coo.triplet_iter().collect::<Vec<_>>(),
         vec![(0, 0, &1), (0, 0, &2), (2, 2, &3)]
     );
-    let triplet = coo.clear_triplet(0, 0, 1);
-    assert_eq!(triplet, Some(1));
-    assert_eq!(
-        coo.triplet_iter().collect::<Vec<_>>(),
-        vec![(0, 0, &2), (2, 2, &3)]
-    );
-    let triplet = coo.clear_triplet(0, 0, 2);
-    assert_eq!(triplet, Some(2));
-    assert_eq!(coo.triplet_iter().collect::<Vec<_>>(), vec![(2, 2, &3)]);
-    let triplet = coo.clear_triplet(2, 2, 3);
-    assert_eq!(triplet, Some(3));
-    assert_eq!(coo.triplet_iter().collect::<Vec<_>>(), vec![]);
+    coo.clear_triplets();
+    assert_eq(coo.triplet_iter.collect::<Vec<_>>(), vec![]);
 }
 
 #[test]

From 41e1cc0db223bdbd4fc5547212760d68fd262f30 Mon Sep 17 00:00:00 2001
From: lukas <lukashermann28@gmail.com>
Date: Tue, 16 Aug 2022 00:20:13 -0700
Subject: [PATCH 29/91] extend test case

---
 nalgebra-sparse/tests/unit_tests/coo.rs | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/nalgebra-sparse/tests/unit_tests/coo.rs b/nalgebra-sparse/tests/unit_tests/coo.rs
index b9c22885..16ee5647 100644
--- a/nalgebra-sparse/tests/unit_tests/coo.rs
+++ b/nalgebra-sparse/tests/unit_tests/coo.rs
@@ -239,6 +239,14 @@ fn coo_clear_triplets_valid_entries() {
     );
     coo.clear_triplets();
     assert_eq(coo.triplet_iter.collect::<Vec<_>>(), vec![]);
+    // making sure everyhting works after clearing
+    coo.push(0, 0, 1);
+    coo.push(0, 0, 2);
+    coo.push(2, 2, 3);
+    assert_eq!(
+        coo.triplet_iter().collect::<Vec<_>>(),
+        vec![(0, 0, &1), (0, 0, &2), (2, 2, &3)]
+    );
 }
 
 #[test]

From b9483ab545621517974390a7d4ff1d846318683c Mon Sep 17 00:00:00 2001
From: Lukas Hermann <lukashermann28@gmail.com>
Date: Tue, 16 Aug 2022 22:06:43 +0000
Subject: [PATCH 30/91] remove bad return type

---
 nalgebra-sparse/src/coo.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nalgebra-sparse/src/coo.rs b/nalgebra-sparse/src/coo.rs
index 9793fa1e..240e2c57 100644
--- a/nalgebra-sparse/src/coo.rs
+++ b/nalgebra-sparse/src/coo.rs
@@ -212,7 +212,7 @@ impl<T> CooMatrix<T> {
     }
 
     /// Clear all triplets from the matrix.
-    pub fn clear_triplets(&mut self, i: usize, j: usize, v: T) -> Option<T>
+    pub fn clear_triplets(&mut self, i: usize, j: usize, v: T)
     where
         T: PartialEq,
     {

From 0eb1f5c125b65847fea06f5d0f01f030096c3450 Mon Sep 17 00:00:00 2001
From: lukas <lukashermann28@gmail.com>
Date: Tue, 16 Aug 2022 20:10:17 -0700
Subject: [PATCH 31/91] 'fix error's

---
 nalgebra-sparse/src/coo.rs              | 2 +-
 nalgebra-sparse/tests/unit_tests/coo.rs | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/nalgebra-sparse/src/coo.rs b/nalgebra-sparse/src/coo.rs
index 240e2c57..1a1720ed 100644
--- a/nalgebra-sparse/src/coo.rs
+++ b/nalgebra-sparse/src/coo.rs
@@ -212,7 +212,7 @@ impl<T> CooMatrix<T> {
     }
 
     /// Clear all triplets from the matrix.
-    pub fn clear_triplets(&mut self, i: usize, j: usize, v: T)
+    pub fn clear_triplets(&mut self)
     where
         T: PartialEq,
     {
diff --git a/nalgebra-sparse/tests/unit_tests/coo.rs b/nalgebra-sparse/tests/unit_tests/coo.rs
index 16ee5647..d232b041 100644
--- a/nalgebra-sparse/tests/unit_tests/coo.rs
+++ b/nalgebra-sparse/tests/unit_tests/coo.rs
@@ -238,7 +238,7 @@ fn coo_clear_triplets_valid_entries() {
         vec![(0, 0, &1), (0, 0, &2), (2, 2, &3)]
     );
     coo.clear_triplets();
-    assert_eq(coo.triplet_iter.collect::<Vec<_>>(), vec![]);
+    assert_eq!(coo.triplet_iter().collect::<Vec<_>>(), vec![]);
     // making sure everyhting works after clearing
     coo.push(0, 0, 1);
     coo.push(0, 0, 2);

From 498fbf51b13d3af325c2f4c546fa4b394d53818f Mon Sep 17 00:00:00 2001
From: lukas <lukashermann28@gmail.com>
Date: Sat, 20 Aug 2022 00:09:12 -0700
Subject: [PATCH 32/91] remove unnecessary trait bounds

---
 nalgebra-sparse/src/coo.rs | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/nalgebra-sparse/src/coo.rs b/nalgebra-sparse/src/coo.rs
index 1a1720ed..25dc07fb 100644
--- a/nalgebra-sparse/src/coo.rs
+++ b/nalgebra-sparse/src/coo.rs
@@ -212,10 +212,7 @@ impl<T> CooMatrix<T> {
     }
 
     /// Clear all triplets from the matrix.
-    pub fn clear_triplets(&mut self)
-    where
-        T: PartialEq,
-    {
+    pub fn clear_triplets(&mut self) {
         self.col_indices.clear();
         self.row_indices.clear();
         self.values.clear();

From 3aca9af616620aa54f63ae1f5c876ca99c1a2890 Mon Sep 17 00:00:00 2001
From: Patiga <dev@patiga.eu>
Date: Fri, 19 Aug 2022 13:34:21 +0200
Subject: [PATCH 33/91] Link listed types in lib.rs to their docs

Helpful because lib.rs is the 'main page' for docs.rs
This allows for easy/direct access to the mentioned types
Currently you need to look up mentioned types via the search bar
---
 src/lib.rs | 44 +++++++++++++++++++++++++-------------------
 1 file changed, 25 insertions(+), 19 deletions(-)

diff --git a/src/lib.rs b/src/lib.rs
index 8da86531..86a5dc6b 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -46,28 +46,34 @@ fn main() {
 **nalgebra** is meant to be a general-purpose, low-dimensional, linear algebra library, with
 an optimized set of tools for computer graphics and physics. Those features include:
 
-* A single parametrizable type `Matrix` for vectors, (square or rectangular) matrices, and slices
-  with dimensions known either at compile-time (using type-level integers) or at runtime.
+* A single parametrizable type [`Matrix`](Matrix) for vectors, (square or rectangular) matrices, and
+  slices with dimensions known either at compile-time (using type-level integers) or at runtime.
 * Matrices and vectors with compile-time sizes are statically allocated while dynamic ones are
   allocated on the heap.
-* Convenient aliases for low-dimensional matrices and vectors: `Vector1` to `Vector6` and
-  `Matrix1x1` to `Matrix6x6`, including rectangular matrices like `Matrix2x5`.
-* Points sizes known at compile time, and convenience aliases: `Point1` to `Point6`.
-* Translation (seen as a transformation that composes by multiplication): `Translation2`,
-  `Translation3`.
-* Rotation matrices: `Rotation2`, `Rotation3`.
-* Quaternions: `Quaternion`, `UnitQuaternion` (for 3D rotation).
-* Unit complex numbers can be used for 2D rotation: `UnitComplex`.
-* Algebraic entities with a norm equal to one: `Unit<T>`, e.g., `Unit<Vector3<f32>>`.
-* Isometries (translation ⨯ rotation): `Isometry2`, `Isometry3`
-* Similarity transformations (translation ⨯ rotation ⨯ uniform scale): `Similarity2`, `Similarity3`.
-* Affine transformations stored as a homogeneous matrix: `Affine2`, `Affine3`.
-* Projective (i.e. invertible) transformations stored as a homogeneous matrix: `Projective2`,
-  `Projective3`.
+* Convenient aliases for low-dimensional matrices and vectors: [`Vector1`](Vector1) to
+  [`Vector6`](Vector6) and [`Matrix1x1`](Matrix1) to [`Matrix6x6`](Matrix6), including rectangular
+  matrices like [`Matrix2x5`](Matrix2x5).
+* Points sizes known at compile time, and convenience aliases: [`Point1`](Point1) to
+  [`Point6`](Point6).
+* Translation (seen as a transformation that composes by multiplication):
+  [`Translation2`](Translation2), [`Translation3`](Translation3).
+* Rotation matrices: [`Rotation2`](Rotation2), [`Rotation3`](Rotation3).
+* Quaternions: [`Quaternion`](Quaternion), [`UnitQuaternion`](UnitQuaternion) (for 3D rotation).
+* Unit complex numbers can be used for 2D rotation: [`UnitComplex`](UnitComplex).
+* Algebraic entities with a norm equal to one: [`Unit<T>`](Unit), e.g., `Unit<Vector3<f32>>`.
+* Isometries (translation ⨯ rotation): [`Isometry2`](Isometry2), [`Isometry3`](Isometry3)
+* Similarity transformations (translation ⨯ rotation ⨯ uniform scale):
+  [`Similarity2`](Similarity2), [`Similarity3`](Similarity3).
+* Affine transformations stored as a homogeneous matrix:
+  [`Affine2`](Affine2), [`Affine3`](Affine3).
+* Projective (i.e. invertible) transformations stored as a homogeneous matrix:
+  [`Projective2`](Projective2), [`Projective3`](Projective3).
 * General transformations that does not have to be invertible, stored as a homogeneous matrix:
-  `Transform2`, `Transform3`.
-* 3D projections for computer graphics: `Perspective3`, `Orthographic3`.
-* Matrix factorizations: `Cholesky`, `QR`, `LU`, `FullPivLU`, `SVD`, `Schur`, `Hessenberg`, `SymmetricEigen`.
+  [`Transform2`](Transform2), [`Transform3`](Transform3).
+* 3D projections for computer graphics: [`Perspective3`](Perspective3),
+  [`Orthographic3`](Orthographic3).
+* Matrix factorizations: [`Cholesky`](Cholesky), [`QR`](QR), [`LU`](LU), [`FullPivLU`](FullPivLU),
+  [`SVD`](SVD), [`Schur`](Schur), [`Hessenberg`](Hessenberg), [`SymmetricEigen`](SymmetricEigen).
 * Insertion and removal of rows of columns of a matrix.
 */
 

From 743eaa47474b63030a12a5c8cd7aaa7b5d8a890b Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Tue, 13 Sep 2022 19:09:27 +0200
Subject: [PATCH 34/91] renaming method

---
 nalgebra-lapack/src/eigen.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index 0c2106ad..1d78d036 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -229,10 +229,10 @@ where
         None
     }
 
-    /// The complex eigenvalues of the given matrix.
+    /// The complex eigen decomposition of the given matrix.
     ///
     /// Panics if the eigenvalue computation does not converge.
-    pub fn complex_eigenvalues(mut m: OMatrix<T, D, D>, left_eigenvectors: bool, eigenvectors: bool) 
+    pub fn complex_eigen_decomposition(mut m: OMatrix<T, D, D>, left_eigenvectors: bool, eigenvectors: bool) 
         -> (OVector<Complex<T>, D>,  Option<OMatrix<T, D, D>>,  Option<OMatrix<T, D, D>>)
     where
         DefaultAllocator: Allocator<Complex<T>, D> + Allocator<Complex<T>, D, D>,

From c62801114b3c123ead9c9aba48a1905e9ed373d0 Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Wed, 14 Sep 2022 18:15:16 +0200
Subject: [PATCH 35/91] fixed formatting

---
 nalgebra-lapack/src/eigen.rs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index 1d78d036..77c0f873 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -394,7 +394,6 @@ where
                 (res, None, None)
             }
         }
-
     }
 
     /// The determinant of the decomposed matrix.

From a0412c39f260adf146a52c2b44fc7d212f07be1d Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Wed, 14 Sep 2022 19:07:38 +0200
Subject: [PATCH 36/91] formatting

---
 nalgebra-lapack/src/eigen.rs | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index 77c0f873..bab9de83 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -232,8 +232,15 @@ where
     /// The complex eigen decomposition of the given matrix.
     ///
     /// Panics if the eigenvalue computation does not converge.
-    pub fn complex_eigen_decomposition(mut m: OMatrix<T, D, D>, left_eigenvectors: bool, eigenvectors: bool) 
-        -> (OVector<Complex<T>, D>,  Option<OMatrix<T, D, D>>,  Option<OMatrix<T, D, D>>)
+    pub fn complex_eigen_decomposition(
+        mut m: OMatrix<T, D, D>,
+        left_eigenvectors: bool,
+        eigenvectors: bool,
+    ) -> (
+        OVector<Complex<T>, D>,
+        Option<OMatrix<T, D, D>>,
+        Option<OMatrix<T, D, D>>,
+    )
     where
         DefaultAllocator: Allocator<Complex<T>, D> + Allocator<Complex<T>, D, D>,
     {

From 1079f0c1c395f9c1d8f7a66eaff979f64ac4bed3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sat, 24 Sep 2022 09:50:58 +0200
Subject: [PATCH 37/91] Add a non-const version of Point::new when the cuda
 feature is enabled

---
 src/geometry/point_construction.rs | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/src/geometry/point_construction.rs b/src/geometry/point_construction.rs
index ac54b349..c061b872 100644
--- a/src/geometry/point_construction.rs
+++ b/src/geometry/point_construction.rs
@@ -216,9 +216,22 @@ macro_rules! componentwise_constructors_impl(
             #[doc = $doc]
             #[doc = "```"]
             #[inline]
+            #[cfg(not(feature = "cuda"))]
             pub const fn new($($args: T),*) -> Self {
                 Point { coords: $Vector::new($($args),*) }
             }
+
+            // TODO: always let new be const once CUDA updates its supported
+            //       nightly version to something more recent.
+            #[doc = "Initializes this point from its components."]
+            #[doc = "# Example\n```"]
+            #[doc = $doc]
+            #[doc = "```"]
+            #[inline]
+            #[cfg(feature = "cuda")]
+            pub fn new($($args: T),*) -> Self {
+                Point { coords: $Vector::new($($args),*) }
+            }
         }
     )*}
 );

From 1870080f94e0d5b0374e88a565871b55e562619b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sat, 24 Sep 2022 10:13:15 +0200
Subject: [PATCH 38/91] Remove const for Point1::new when targetting cuda

---
 src/geometry/point_construction.rs | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/src/geometry/point_construction.rs b/src/geometry/point_construction.rs
index c061b872..598cf4ed 100644
--- a/src/geometry/point_construction.rs
+++ b/src/geometry/point_construction.rs
@@ -202,11 +202,29 @@ impl<T: Scalar> Point1<T> {
     /// assert_eq!(p.x, 1.0);
     /// ```
     #[inline]
+    #[cfg(not(feature = "cuda"))]
     pub const fn new(x: T) -> Self {
         Point {
             coords: Vector1::new(x),
         }
     }
+
+    /// Initializes this point from its components.
+    ///
+    /// # Example
+    ///
+    /// ```
+    /// # use nalgebra::Point1;
+    /// let p = Point1::new(1.0);
+    /// assert_eq!(p.x, 1.0);
+    /// ```
+    #[inline]
+    #[cfg(feature = "cuda")]
+    pub fn new(x: T) -> Self {
+        Point {
+            coords: Vector1::new(x),
+        }
+    }
 }
 macro_rules! componentwise_constructors_impl(
     ($($doc: expr; $Point: ident, $Vector: ident, $($args: ident:$irow: expr),*);* $(;)*) => {$(

From b37eeee636284c6d54e36a9ac3dea8780bb814a9 Mon Sep 17 00:00:00 2001
From: lukas <lukashermann28@gmail.com>
Date: Fri, 30 Sep 2022 19:49:47 -0700
Subject: [PATCH 39/91] add mutable triplet iter

---
 nalgebra-sparse/src/coo.rs | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/nalgebra-sparse/src/coo.rs b/nalgebra-sparse/src/coo.rs
index 25dc07fb..b71cb0b6 100644
--- a/nalgebra-sparse/src/coo.rs
+++ b/nalgebra-sparse/src/coo.rs
@@ -170,6 +170,16 @@ impl<T> CooMatrix<T> {
             .map(|((i, j), v)| (*i, *j, v))
     }
 
+    /// A mutable iterator over triplets (i, j, v).
+    // TODO: Consider giving the iterator a concrete type instead of impl trait...?
+    pub fn triplet_iter_mut(&mut self) -> impl Iterator<Item = (usize, usize, &mut T)> {
+        self.row_indices
+            .iter()
+            .zip(&self.col_indices)
+            .zip(self.values.iter_mut())
+            .map(|((i, j), v)| (*i, *j, v))
+    }
+
     /// Reserves capacity for COO matrix by at least `additional` elements.
     ///
     /// This increase the capacities of triplet holding arrays by reserving more space to avoid

From 9a38c554af63ac3dc147e6376c670a43afec18f4 Mon Sep 17 00:00:00 2001
From: lukas <lukashermann28@gmail.com>
Date: Sun, 2 Oct 2022 11:57:37 -0700
Subject: [PATCH 40/91] add test case

---
 nalgebra-sparse/tests/unit_tests/coo.rs | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/nalgebra-sparse/tests/unit_tests/coo.rs b/nalgebra-sparse/tests/unit_tests/coo.rs
index d232b041..fae0144a 100644
--- a/nalgebra-sparse/tests/unit_tests/coo.rs
+++ b/nalgebra-sparse/tests/unit_tests/coo.rs
@@ -87,6 +87,26 @@ fn coo_construction_for_valid_data() {
     }
 }
 
+#[test]
+fn coo_triplets_iter_mut() {
+    // Arbitrary matrix, with duplicates
+    let i = vec![0, 1, 0, 0, 0, 0, 2, 1];
+    let j = vec![0, 2, 0, 1, 0, 3, 3, 2];
+    let v = vec![2, 3, 4, 7, 1, 3, 1, 5];
+    let mut coo =
+        CooMatrix::<i32>::try_from_triplets(3, 5, i.clone(), j.clone(), v.clone()).unwrap();
+    coo.triplet_iter_mut().for_each(|(_i, _j, v)| *v = *v * *v);
+
+    let expected_triplets: Vec<_> = i
+        .iter()
+        .zip(&j)
+        .zip(&v)
+        .map(|((i, j), v)| (*i, *j, v * v))
+        .collect();
+    let actual_triplets: Vec<_> = coo.triplet_iter().map(|(i, j, v)| (i, j, *v)).collect();
+    assert_eq!(expected_triplets, actual_triplets)
+}
+
 #[test]
 fn coo_try_from_triplets_reports_out_of_bounds_indices() {
     {

From 3d52327f8298c1769a5b0a2e8e7a340a4d7cd46b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sun, 9 Oct 2022 16:26:26 +0200
Subject: [PATCH 41/91] nalgebra-lapack: merge both Eigen decomposition
 function into a single one.

---
 nalgebra-lapack/src/eigen.rs | 336 +++++------------------------------
 1 file changed, 45 insertions(+), 291 deletions(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index bab9de83..68b34b56 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -13,7 +13,7 @@ use na::{DefaultAllocator, Matrix, OMatrix, OVector, Scalar};
 
 use lapack;
 
-/// Eigendecomposition of a real square matrix with real eigenvalues.
+/// Eigendecomposition of a real square matrix with real or complex eigenvalues.
 #[cfg_attr(feature = "serde-serialize", derive(Serialize, Deserialize))]
 #[cfg_attr(
     feature = "serde-serialize",
@@ -36,8 +36,10 @@ pub struct Eigen<T: Scalar, D: Dim>
 where
     DefaultAllocator: Allocator<T, D> + Allocator<T, D, D>,
 {
-    /// The eigenvalues of the decomposed matrix.
-    pub eigenvalues: OVector<T, D>,
+    /// The real parts of eigenvalues of the decomposed matrix.
+    pub eigenvalues_re: OVector<T, D>,
+    /// The imaginary parts of the eigenvalues of the decomposed matrix.
+    pub eigenvalues_im: OVector<T, D>,
     /// The (right) eigenvectors of the decomposed matrix.
     pub eigenvectors: Option<OMatrix<T, D, D>>,
     /// The left eigenvectors of the decomposed matrix.
@@ -104,169 +106,27 @@ where
         lapack_check!(info);
 
         let mut work = vec![T::zero(); lwork as usize];
+        let mut vl = if left_eigenvectors {
+            Some(Matrix::zeros_generic(nrows, ncols))
+        } else {
+            None
+        };
+        let mut vr = if eigenvectors {
+            Some(Matrix::zeros_generic(nrows, ncols))
+        } else {
+            None
+        };
 
-        match (left_eigenvectors, eigenvectors) {
-            (true, true) => {
-                // TODO: avoid the initializations?
-                let mut vl = Matrix::zeros_generic(nrows, ncols);
-                let mut vr = Matrix::zeros_generic(nrows, ncols);
+        let vl_ref = vl
+            .as_mut()
+            .map(|m| m.as_mut_slice())
+            .unwrap_or(&mut placeholder1);
+        let vr_ref = vr
+            .as_mut()
+            .map(|m| m.as_mut_slice())
+            .unwrap_or(&mut placeholder2);
 
-                T::xgeev(
-                    ljob,
-                    rjob,
-                    n as i32,
-                    m.as_mut_slice(),
-                    lda,
-                    wr.as_mut_slice(),
-                    wi.as_mut_slice(),
-                    &mut vl.as_mut_slice(),
-                    n as i32,
-                    &mut vr.as_mut_slice(),
-                    n as i32,
-                    &mut work,
-                    lwork,
-                    &mut info,
-                );
-                lapack_check!(info);
-
-                if wi.iter().all(|e| e.is_zero()) {
-                    return Some(Self {
-                        eigenvalues: wr,
-                        left_eigenvectors: Some(vl),
-                        eigenvectors: Some(vr),
-                    });
-                }
-            }
-            (true, false) => {
-                // TODO: avoid the initialization?
-                let mut vl = Matrix::zeros_generic(nrows, ncols);
-
-                T::xgeev(
-                    ljob,
-                    rjob,
-                    n as i32,
-                    m.as_mut_slice(),
-                    lda,
-                    wr.as_mut_slice(),
-                    wi.as_mut_slice(),
-                    &mut vl.as_mut_slice(),
-                    n as i32,
-                    &mut placeholder2,
-                    1 as i32,
-                    &mut work,
-                    lwork,
-                    &mut info,
-                );
-                lapack_check!(info);
-
-                if wi.iter().all(|e| e.is_zero()) {
-                    return Some(Self {
-                        eigenvalues: wr,
-                        left_eigenvectors: Some(vl),
-                        eigenvectors: None,
-                    });
-                }
-            }
-            (false, true) => {
-                // TODO: avoid the initialization?
-                let mut vr = Matrix::zeros_generic(nrows, ncols);
-
-                T::xgeev(
-                    ljob,
-                    rjob,
-                    n as i32,
-                    m.as_mut_slice(),
-                    lda,
-                    wr.as_mut_slice(),
-                    wi.as_mut_slice(),
-                    &mut placeholder1,
-                    1 as i32,
-                    &mut vr.as_mut_slice(),
-                    n as i32,
-                    &mut work,
-                    lwork,
-                    &mut info,
-                );
-                lapack_check!(info);
-
-                if wi.iter().all(|e| e.is_zero()) {
-                    return Some(Self {
-                        eigenvalues: wr,
-                        left_eigenvectors: None,
-                        eigenvectors: Some(vr),
-                    });
-                }
-            }
-            (false, false) => {
-                T::xgeev(
-                    ljob,
-                    rjob,
-                    n as i32,
-                    m.as_mut_slice(),
-                    lda,
-                    wr.as_mut_slice(),
-                    wi.as_mut_slice(),
-                    &mut placeholder1,
-                    1 as i32,
-                    &mut placeholder2,
-                    1 as i32,
-                    &mut work,
-                    lwork,
-                    &mut info,
-                );
-                lapack_check!(info);
-
-                if wi.iter().all(|e| e.is_zero()) {
-                    return Some(Self {
-                        eigenvalues: wr,
-                        left_eigenvectors: None,
-                        eigenvectors: None,
-                    });
-                }
-            }
-        }
-
-        None
-    }
-
-    /// The complex eigen decomposition of the given matrix.
-    ///
-    /// Panics if the eigenvalue computation does not converge.
-    pub fn complex_eigen_decomposition(
-        mut m: OMatrix<T, D, D>,
-        left_eigenvectors: bool,
-        eigenvectors: bool,
-    ) -> (
-        OVector<Complex<T>, D>,
-        Option<OMatrix<T, D, D>>,
-        Option<OMatrix<T, D, D>>,
-    )
-    where
-        DefaultAllocator: Allocator<Complex<T>, D> + Allocator<Complex<T>, D, D>,
-    {
-        assert!(
-            m.is_square(),
-            "Unable to compute the eigenvalue decomposition of a non-square matrix."
-        );
-
-        let ljob = if left_eigenvectors { b'V' } else { b'N' };
-        let rjob = if eigenvectors { b'V' } else { b'N' };
-
-        let (nrows, ncols) = m.shape_generic();
-        let n = nrows.value();
-
-        let lda = n as i32;
-
-        // TODO: avoid the initialization?
-        let mut wr = Matrix::zeros_generic(nrows, Const::<1>);
-        // TODO: Tap into the workspace.
-        let mut wi = Matrix::zeros_generic(nrows, Const::<1>);
-
-        let mut info = 0;
-        let mut placeholder1 = [T::zero()];
-        let mut placeholder2 = [T::zero()];
-
-        let lwork = T::xgeev_work_size(
+        T::xgeev(
             ljob,
             rjob,
             n as i32,
@@ -274,142 +134,36 @@ where
             lda,
             wr.as_mut_slice(),
             wi.as_mut_slice(),
-            &mut placeholder1,
-            n as i32,
-            &mut placeholder2,
-            n as i32,
+            vl_ref,
+            if left_eigenvectors { n as i32 } else { 1 },
+            vr_ref,
+            if eigenvectors { n as i32 } else { 1 },
+            &mut work,
+            lwork,
             &mut info,
         );
+        lapack_check!(info);
 
-        lapack_panic!(info);
+        Some(Self {
+            eigenvalues_re: wr,
+            eigenvalues_im: wi,
+            left_eigenvectors: vl,
+            eigenvectors: vr,
+        })
+    }
 
-        let mut work = vec![T::zero(); lwork as usize];
-
-        match (left_eigenvectors, eigenvectors) {
-            (true, true) => {
-                // TODO: avoid the initializations?
-                let mut vl = Matrix::zeros_generic(nrows, ncols);
-                let mut vr = Matrix::zeros_generic(nrows, ncols);
-
-                T::xgeev(
-                    ljob,
-                    rjob,
-                    n as i32,
-                    m.as_mut_slice(),
-                    lda,
-                    wr.as_mut_slice(),
-                    wi.as_mut_slice(),
-                    &mut vl.as_mut_slice(),
-                    n as i32,
-                    &mut vr.as_mut_slice(),
-                    n as i32,
-                    &mut work,
-                    lwork,
-                    &mut info,
-                );
-                lapack_panic!(info);
-
-                let mut res = Matrix::zeros_generic(nrows, Const::<1>);
-
-                for i in 0..res.len() {
-                    res[i] = Complex::new(wr[i].clone(), wi[i].clone());
-                }
-                (res, Some(vl), Some(vr))
-            }
-            (true, false) => {
-                // TODO: avoid the initialization?
-                let mut vl = Matrix::zeros_generic(nrows, ncols);
-
-                T::xgeev(
-                    ljob,
-                    rjob,
-                    n as i32,
-                    m.as_mut_slice(),
-                    lda,
-                    wr.as_mut_slice(),
-                    wi.as_mut_slice(),
-                    &mut vl.as_mut_slice(),
-                    n as i32,
-                    &mut placeholder2,
-                    1 as i32,
-                    &mut work,
-                    lwork,
-                    &mut info,
-                );
-                lapack_panic!(info);
-
-                let mut res = Matrix::zeros_generic(nrows, Const::<1>);
-
-                for i in 0..res.len() {
-                    res[i] = Complex::new(wr[i].clone(), wi[i].clone());
-                }
-                (res, Some(vl), None)
-            }
-            (false, true) => {
-                // TODO: avoid the initialization?
-                let mut vr = Matrix::zeros_generic(nrows, ncols);
-
-                T::xgeev(
-                    ljob,
-                    rjob,
-                    n as i32,
-                    m.as_mut_slice(),
-                    lda,
-                    wr.as_mut_slice(),
-                    wi.as_mut_slice(),
-                    &mut placeholder1,
-                    1 as i32,
-                    &mut vr.as_mut_slice(),
-                    n as i32,
-                    &mut work,
-                    lwork,
-                    &mut info,
-                );
-                lapack_panic!(info);
-
-                let mut res = Matrix::zeros_generic(nrows, Const::<1>);
-
-                for i in 0..res.len() {
-                    res[i] = Complex::new(wr[i].clone(), wi[i].clone());
-                }
-                (res, None, Some(vr))
-            }
-            (false, false) => {
-                T::xgeev(
-                    ljob,
-                    rjob,
-                    n as i32,
-                    m.as_mut_slice(),
-                    lda,
-                    wr.as_mut_slice(),
-                    wi.as_mut_slice(),
-                    &mut placeholder1,
-                    1 as i32,
-                    &mut placeholder2,
-                    1 as i32,
-                    &mut work,
-                    lwork,
-                    &mut info,
-                );
-                lapack_panic!(info);
-
-                let mut res = Matrix::zeros_generic(nrows, Const::<1>);
-
-                for i in 0..res.len() {
-                    res[i] = Complex::new(wr[i].clone(), wi[i].clone());
-                }
-                (res, None, None)
-            }
-        }
+    /// Returns `true` if all the eigenvalues are real.
+    pub fn eigenvalues_are_real(&self) -> bool {
+        self.eigenvalues_im.iter().all(|e| e.is_zero())
     }
 
     /// The determinant of the decomposed matrix.
     #[inline]
     #[must_use]
-    pub fn determinant(&self) -> T {
-        let mut det = T::one();
-        for e in self.eigenvalues.iter() {
-            det *= e.clone();
+    pub fn determinant(&self) -> Complex<T> {
+        let mut det: Complex<T> = na::one();
+        for (re, im) in self.eigenvalues_re.iter().zip(self.eigenvalues_im.iter()) {
+            det *= Complex::new(re.clone(), im.clone());
         }
 
         det

From a752a4bbf5fb55c82d8776fcb9327c9b70da128c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sun, 9 Oct 2022 22:03:03 +0200
Subject: [PATCH 42/91] Release v0.31.2

---
 CHANGELOG.md | 10 ++++++++++
 Cargo.toml   |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 2950a1df..e035e084 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,16 @@ documented here.
 
 This project adheres to [Semantic Versioning](https://semver.org/).
 
+## [0.31.2] (09 Oct. 2022)
+
+### Modified
+- Use `#[inline]` on the `Dim` implementation for `Const` to improve opt-level 1 performance.
+- Make the `Point::new` constructions const-fn.
+
+### Added
+- Add `UnitVector::cast` to change the underlying scalar type.
+
+
 ## [0.31.1] (31 July 2022)
 
 ### Modified
diff --git a/Cargo.toml b/Cargo.toml
index 5b9940df..89de73e5 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name    = "nalgebra"
-version = "0.31.1"
+version = "0.31.2"
 authors = [ "Sébastien Crozet <developer@crozet.re>" ]
 
 description = "General-purpose linear algebra library with transformations and statically-sized or dynamically-sized matrices."

From e227dd693e233cc2819277ffe0f0b252bdb84bf8 Mon Sep 17 00:00:00 2001
From: lukas <lukashermann28@gmail.com>
Date: Mon, 10 Oct 2022 19:05:47 -0700
Subject: [PATCH 43/91] Refactor unit tests

---
 nalgebra-sparse/tests/unit_tests/coo.rs | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/nalgebra-sparse/tests/unit_tests/coo.rs b/nalgebra-sparse/tests/unit_tests/coo.rs
index fae0144a..8e46651f 100644
--- a/nalgebra-sparse/tests/unit_tests/coo.rs
+++ b/nalgebra-sparse/tests/unit_tests/coo.rs
@@ -95,16 +95,30 @@ fn coo_triplets_iter_mut() {
     let v = vec![2, 3, 4, 7, 1, 3, 1, 5];
     let mut coo =
         CooMatrix::<i32>::try_from_triplets(3, 5, i.clone(), j.clone(), v.clone()).unwrap();
-    coo.triplet_iter_mut().for_each(|(_i, _j, v)| *v = *v * *v);
+
+    let actual_triplets: Vec<_> = coo.triplet_iter_mut().map(|(i, j, v)| (i, j, *v)).collect();
 
     let expected_triplets: Vec<_> = i
         .iter()
         .zip(&j)
         .zip(&v)
-        .map(|((i, j), v)| (*i, *j, v * v))
+        .map(|((i, j), v)| (*i, *j, *v))
         .collect();
-    let actual_triplets: Vec<_> = coo.triplet_iter().map(|(i, j, v)| (i, j, *v)).collect();
-    assert_eq!(expected_triplets, actual_triplets)
+    assert_eq!(expected_triplets, actual_triplets);
+
+    for (_i, _j, v) in coo.triplet_iter_mut() {
+        *v += *v;
+    }
+
+    let actual_triplets: Vec<_> = coo.triplet_iter_mut().map(|(i, j, v)| (i, j, *v)).collect();
+    let v = vec![4, 6, 8, 14, 2, 6, 2, 10];
+    let expected_triplets: Vec<_> = i
+        .iter()
+        .zip(&j)
+        .zip(&v)
+        .map(|((i, j), v)| (*i, *j, *v))
+        .collect();
+    assert_eq!(expected_triplets, actual_triplets);
 }
 
 #[test]

From 2cbb27c6f83b36a997b19b3a100d08a7e4fb0d48 Mon Sep 17 00:00:00 2001
From: Peng Guanwen <pg999w@outlook.com>
Date: Thu, 15 Sep 2022 08:40:16 +0000
Subject: [PATCH 44/91] Derive CheckBytes trait on Archive struct

---
 src/base/array_storage.rs       |  5 ++++-
 src/base/dimension.rs           | 10 ++++++++--
 src/base/matrix.rs              |  5 ++++-
 src/base/unit.rs                |  5 ++++-
 src/geometry/dual_quaternion.rs |  5 ++++-
 src/geometry/isometry.rs        |  5 ++++-
 src/geometry/orthographic.rs    |  5 ++++-
 src/geometry/perspective.rs     |  5 ++++-
 src/geometry/point.rs           |  5 ++++-
 src/geometry/quaternion.rs      |  5 ++++-
 src/geometry/rotation.rs        |  5 ++++-
 src/geometry/scale.rs           |  5 ++++-
 src/geometry/similarity.rs      |  5 ++++-
 src/geometry/translation.rs     |  5 ++++-
 14 files changed, 60 insertions(+), 15 deletions(-)

diff --git a/src/base/array_storage.rs b/src/base/array_storage.rs
index 3bc71e1a..d155cba7 100644
--- a/src/base/array_storage.rs
+++ b/src/base/array_storage.rs
@@ -27,11 +27,14 @@ use std::mem;
 /// A array-based statically sized matrix data storage.
 #[repr(transparent)]
 #[derive(Copy, Clone, PartialEq, Eq, Hash)]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 #[cfg_attr(feature = "cuda", derive(cust_core::DeviceCopy))]
 pub struct ArrayStorage<T, const R: usize, const C: usize>(pub [[T; R]; C]);
 
diff --git a/src/base/dimension.rs b/src/base/dimension.rs
index b1b700d7..06697618 100644
--- a/src/base/dimension.rs
+++ b/src/base/dimension.rs
@@ -13,11 +13,14 @@ use serde::{Deserialize, Deserializer, Serialize, Serializer};
 
 /// Dim of dynamically-sized algebraic entities.
 #[derive(Clone, Copy, Eq, PartialEq, Debug)]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 #[cfg_attr(feature = "cuda", derive(cust_core::DeviceCopy))]
 pub struct Dynamic {
     value: usize,
@@ -207,7 +210,10 @@ dim_ops!(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 #[cfg_attr(feature = "cuda", derive(cust_core::DeviceCopy))]
 pub struct Const<const R: usize>;
 
diff --git a/src/base/matrix.rs b/src/base/matrix.rs
index d9294c9e..e9cc5258 100644
--- a/src/base/matrix.rs
+++ b/src/base/matrix.rs
@@ -150,11 +150,14 @@ pub type MatrixCross<T, R1, C1, R2, C2> =
 /// some concrete types for `T` and a compatible data storage type `S`).
 #[repr(C)]
 #[derive(Clone, Copy)]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 #[cfg_attr(feature = "cuda", derive(cust_core::DeviceCopy))]
 pub struct Matrix<T, R, C, S> {
     /// The data storage that contains all the matrix components. Disappointed?
diff --git a/src/base/unit.rs b/src/base/unit.rs
index 6fc00092..1596b71a 100644
--- a/src/base/unit.rs
+++ b/src/base/unit.rs
@@ -21,11 +21,14 @@ use crate::{Dim, Matrix, OMatrix, RealField, Scalar, SimdComplexField, SimdRealF
 /// in their documentation, read their dedicated pages directly.
 #[repr(transparent)]
 #[derive(Clone, Hash, Copy)]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 // #[cfg_attr(feature = "cuda", derive(cust_core::DeviceCopy))]
 pub struct Unit<T> {
     pub(crate) value: T,
diff --git a/src/geometry/dual_quaternion.rs b/src/geometry/dual_quaternion.rs
index 6f1b7053..3b283629 100644
--- a/src/geometry/dual_quaternion.rs
+++ b/src/geometry/dual_quaternion.rs
@@ -40,11 +40,14 @@ use simba::scalar::{ClosedNeg, RealField};
 ///  See <https://github.com/dimforge/nalgebra/issues/487>
 #[repr(C)]
 #[derive(Debug, Copy, Clone)]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 #[cfg_attr(feature = "cuda", derive(cust_core::DeviceCopy))]
 pub struct DualQuaternion<T> {
     /// The real component of the quaternion
diff --git a/src/geometry/isometry.rs b/src/geometry/isometry.rs
index 92169742..d245c99b 100755
--- a/src/geometry/isometry.rs
+++ b/src/geometry/isometry.rs
@@ -70,7 +70,10 @@ use crate::geometry::{AbstractRotation, Point, Translation};
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 pub struct Isometry<T, R, const D: usize> {
     /// The pure rotational part of this isometry.
     pub rotation: R,
diff --git a/src/geometry/orthographic.rs b/src/geometry/orthographic.rs
index 7348f676..ede7f587 100644
--- a/src/geometry/orthographic.rs
+++ b/src/geometry/orthographic.rs
@@ -19,11 +19,14 @@ use crate::geometry::{Point3, Projective3};
 
 /// A 3D orthographic projection stored as a homogeneous 4x4 matrix.
 #[repr(C)]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 #[cfg_attr(feature = "cuda", derive(cust_core::DeviceCopy))]
 #[derive(Copy, Clone)]
 pub struct Orthographic3<T> {
diff --git a/src/geometry/perspective.rs b/src/geometry/perspective.rs
index 351960bb..de29747f 100644
--- a/src/geometry/perspective.rs
+++ b/src/geometry/perspective.rs
@@ -20,11 +20,14 @@ use crate::geometry::{Point3, Projective3};
 
 /// A 3D perspective projection stored as a homogeneous 4x4 matrix.
 #[repr(C)]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 #[cfg_attr(feature = "cuda", derive(cust_core::DeviceCopy))]
 #[derive(Copy, Clone)]
 pub struct Perspective3<T> {
diff --git a/src/geometry/point.rs b/src/geometry/point.rs
index 306c18e5..e9a21439 100644
--- a/src/geometry/point.rs
+++ b/src/geometry/point.rs
@@ -40,7 +40,10 @@ use std::mem::MaybeUninit;
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 pub struct OPoint<T: Scalar, D: DimName>
 where
     DefaultAllocator: Allocator<T, D>,
diff --git a/src/geometry/quaternion.rs b/src/geometry/quaternion.rs
index f38dca6f..53da24e3 100755
--- a/src/geometry/quaternion.rs
+++ b/src/geometry/quaternion.rs
@@ -23,11 +23,14 @@ use crate::geometry::{Point3, Rotation};
 /// that may be used as a rotation.
 #[repr(C)]
 #[derive(Copy, Clone)]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 #[cfg_attr(feature = "cuda", derive(cust_core::DeviceCopy))]
 pub struct Quaternion<T> {
     /// This quaternion as a 4D vector of coordinates in the `[ x, y, z, w ]` storage order.
diff --git a/src/geometry/rotation.rs b/src/geometry/rotation.rs
index 2a8bf427..4a71da0f 100755
--- a/src/geometry/rotation.rs
+++ b/src/geometry/rotation.rs
@@ -49,11 +49,14 @@ use crate::geometry::Point;
 /// * [Conversion to a matrix <span style="float:right;">`matrix`, `to_homogeneous`…</span>](#conversion-to-a-matrix)
 ///
 #[repr(C)]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 #[cfg_attr(feature = "cuda", derive(cust_core::DeviceCopy))]
 #[derive(Copy, Clone)]
 pub struct Rotation<T, const D: usize> {
diff --git a/src/geometry/scale.rs b/src/geometry/scale.rs
index 37da1ef0..e6c46e47 100755
--- a/src/geometry/scale.rs
+++ b/src/geometry/scale.rs
@@ -17,11 +17,14 @@ use crate::geometry::Point;
 
 /// A scale which supports non-uniform scaling.
 #[repr(C)]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 #[cfg_attr(feature = "cuda", derive(cust_core::DeviceCopy))]
 #[derive(Copy, Clone)]
 pub struct Scale<T, const D: usize> {
diff --git a/src/geometry/similarity.rs b/src/geometry/similarity.rs
index 8c38ff1e..a827246e 100755
--- a/src/geometry/similarity.rs
+++ b/src/geometry/similarity.rs
@@ -38,7 +38,10 @@ use crate::geometry::{AbstractRotation, Isometry, Point, Translation};
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 pub struct Similarity<T, R, const D: usize> {
     /// The part of this similarity that does not include the scaling factor.
     pub isometry: Isometry<T, R, D>,
diff --git a/src/geometry/translation.rs b/src/geometry/translation.rs
index bef66f68..7e10ac4c 100755
--- a/src/geometry/translation.rs
+++ b/src/geometry/translation.rs
@@ -17,11 +17,14 @@ use crate::geometry::Point;
 
 /// A translation.
 #[repr(C)]
-#[cfg_attr(feature = "rkyv-serialize", derive(bytecheck::CheckBytes))]
 #[cfg_attr(
     feature = "rkyv-serialize-no-std",
     derive(rkyv::Archive, rkyv::Serialize, rkyv::Deserialize)
 )]
+#[cfg_attr(
+    feature = "rkyv-serialize",
+    archive_attr(derive(bytecheck::CheckBytes))
+)]
 #[cfg_attr(feature = "cuda", derive(cust_core::DeviceCopy))]
 #[derive(Copy, Clone)]
 pub struct Translation<T, const D: usize> {

From bc566d91bf5dd1082eca5cddfa6009dc80b9c41c Mon Sep 17 00:00:00 2001
From: Peng Guanwen <pg999w@outlook.com>
Date: Thu, 15 Sep 2022 09:35:21 +0000
Subject: [PATCH 45/91] Add test for rkyv

---
 .github/workflows/nalgebra-ci-build.yml |  2 +-
 Cargo.toml                              |  1 +
 tests/core/mod.rs                       |  2 ++
 tests/core/rkyv.rs                      | 44 +++++++++++++++++++++++++
 4 files changed, 48 insertions(+), 1 deletion(-)
 create mode 100644 tests/core/rkyv.rs

diff --git a/.github/workflows/nalgebra-ci-build.yml b/.github/workflows/nalgebra-ci-build.yml
index c00b6cbc..d1a6c923 100644
--- a/.github/workflows/nalgebra-ci-build.yml
+++ b/.github/workflows/nalgebra-ci-build.yml
@@ -61,7 +61,7 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - name: test
-        run: cargo test --features arbitrary,rand,serde-serialize,sparse,debug,io,compare,libm,proptest-support,slow-tests;
+        run: cargo test --features arbitrary,rand,serde-serialize,sparse,debug,io,compare,libm,proptest-support,slow-tests,rkyv-safe-deser;
   test-nalgebra-glm:
     runs-on: ubuntu-latest
     steps:
diff --git a/Cargo.toml b/Cargo.toml
index 89de73e5..4bd1e12f 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -66,6 +66,7 @@ rand        = [ "rand-no-std", "rand-package/std", "rand-package/std_rng", "rand
 arbitrary        = [ "quickcheck" ]
 proptest-support = [ "proptest" ]
 slow-tests       = []
+rkyv-safe-deser  = [ "rkyv-serialize", "rkyv/validation" ]
 
 [dependencies]
 nalgebra-macros = { version = "0.1", path = "nalgebra-macros", optional = true }
diff --git a/tests/core/mod.rs b/tests/core/mod.rs
index 5fb8c82b..3c968a5d 100644
--- a/tests/core/mod.rs
+++ b/tests/core/mod.rs
@@ -8,6 +8,8 @@ mod matrix_slice;
 #[cfg(feature = "mint")]
 mod mint;
 mod serde;
+#[cfg(feature = "rkyv-serialize-no-std")]
+mod rkyv;
 
 #[cfg(feature = "compare")]
 mod matrixcompare;
diff --git a/tests/core/rkyv.rs b/tests/core/rkyv.rs
new file mode 100644
index 00000000..b89f5211
--- /dev/null
+++ b/tests/core/rkyv.rs
@@ -0,0 +1,44 @@
+use na::{
+    Isometry3, IsometryMatrix2, IsometryMatrix3, Matrix3x4, Point2, Point3, Quaternion, Rotation2,
+    Rotation3, Similarity3, SimilarityMatrix2, SimilarityMatrix3, Translation2, Translation3,
+};
+use rkyv::ser::{serializers::AllocSerializer, Serializer};
+
+macro_rules! test_rkyv(
+    ($($test: ident, $ty: ident);* $(;)*) => {$(
+        #[test]
+        fn $test() {
+            let v: $ty<f32> = rand::random();
+            // serialize
+            let mut serializer = AllocSerializer::<0>::default();
+            serializer.serialize_value(&v).unwrap();
+            let serialized = serializer.into_serializer().into_inner();
+
+            let deserialized: $ty<f32> = unsafe { rkyv::from_bytes_unchecked(&serialized).unwrap() };
+            assert_eq!(v, deserialized);
+
+            #[cfg(feature = "rkyv-safe-deser")]
+            {
+                let deserialized: $ty<f32> = rkyv::from_bytes(&serialized).unwrap();
+                assert_eq!(v, deserialized);
+            }
+        }
+    )*}
+);
+
+test_rkyv!(
+    rkyv_matrix3x4,          Matrix3x4;
+    rkyv_point3,             Point3;
+    rkyv_translation3,       Translation3;
+    rkyv_rotation3,          Rotation3;
+    rkyv_isometry3,          Isometry3;
+    rkyv_isometry_matrix3,   IsometryMatrix3;
+    rkyv_similarity3,        Similarity3;
+    rkyv_similarity_matrix3, SimilarityMatrix3;
+    rkyv_quaternion,         Quaternion;
+    rkyv_point2,             Point2;
+    rkyv_translation2,       Translation2;
+    rkyv_rotation2,          Rotation2;
+    rkyv_isometry_matrix2,   IsometryMatrix2;
+    rkyv_similarity_matrix2, SimilarityMatrix2;
+);

From f485806782283b9d5568598f7c363a95be64dac7 Mon Sep 17 00:00:00 2001
From: Peng Guanwen <pg999w@outlook.com>
Date: Fri, 16 Sep 2022 08:06:44 +0000
Subject: [PATCH 46/91] rustfmt

---
 tests/core/mod.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/core/mod.rs b/tests/core/mod.rs
index 3c968a5d..acdcd236 100644
--- a/tests/core/mod.rs
+++ b/tests/core/mod.rs
@@ -7,9 +7,9 @@ mod matrix;
 mod matrix_slice;
 #[cfg(feature = "mint")]
 mod mint;
-mod serde;
 #[cfg(feature = "rkyv-serialize-no-std")]
 mod rkyv;
+mod serde;
 
 #[cfg(feature = "compare")]
 mod matrixcompare;

From c596e4985d5b6dee193c0e68a3d60baf6bf71ec5 Mon Sep 17 00:00:00 2001
From: David Stansby <dstansby@gmail.com>
Date: Fri, 14 Oct 2022 13:52:56 +0100
Subject: [PATCH 47/91] Make CSR/CSC matrix examples more self contained

---
 nalgebra-sparse/src/csc.rs | 6 ++++--
 nalgebra-sparse/src/csr.rs | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/nalgebra-sparse/src/csc.rs b/nalgebra-sparse/src/csc.rs
index d926dafb..0cd89f5c 100644
--- a/nalgebra-sparse/src/csc.rs
+++ b/nalgebra-sparse/src/csc.rs
@@ -24,6 +24,7 @@ use std::slice::{Iter, IterMut};
 /// # Usage
 ///
 /// ```
+/// use nalgebra_sparse::coo::CooMatrix;
 /// use nalgebra_sparse::csc::CscMatrix;
 /// use nalgebra::{DMatrix, Matrix3x4};
 /// use matrixcompare::assert_matrix_eq;
@@ -32,8 +33,9 @@ use std::slice::{Iter, IterMut};
 /// // change the sparsity pattern of the matrix after it has been constructed. The easiest
 /// // way to construct a CSC matrix is to first incrementally construct a COO matrix,
 /// // and then convert it to CSC.
-/// # use nalgebra_sparse::coo::CooMatrix;
-/// # let coo = CooMatrix::<f64>::new(3, 3);
+///
+/// let mut coo = CooMatrix::<f64>::new(3, 3);
+/// coo.push(2, 0, 1.0);
 /// let csc = CscMatrix::from(&coo);
 ///
 /// // Alternatively, a CSC matrix can be constructed directly from raw CSC data.
diff --git a/nalgebra-sparse/src/csr.rs b/nalgebra-sparse/src/csr.rs
index 90be35f1..255e8404 100644
--- a/nalgebra-sparse/src/csr.rs
+++ b/nalgebra-sparse/src/csr.rs
@@ -25,6 +25,7 @@ use std::slice::{Iter, IterMut};
 /// # Usage
 ///
 /// ```
+/// use nalgebra_sparse::coo::CooMatrix;
 /// use nalgebra_sparse::csr::CsrMatrix;
 /// use nalgebra::{DMatrix, Matrix3x4};
 /// use matrixcompare::assert_matrix_eq;
@@ -33,8 +34,9 @@ use std::slice::{Iter, IterMut};
 /// // change the sparsity pattern of the matrix after it has been constructed. The easiest
 /// // way to construct a CSR matrix is to first incrementally construct a COO matrix,
 /// // and then convert it to CSR.
-/// # use nalgebra_sparse::coo::CooMatrix;
-/// # let coo = CooMatrix::<f64>::new(3, 3);
+///
+/// let mut coo = CooMatrix::<f64>::new(3, 3);
+/// coo.push(2, 0, 1.0);
 /// let csr = CsrMatrix::from(&coo);
 ///
 /// // Alternatively, a CSR matrix can be constructed directly from raw CSR data.

From d61f9e29ba1e4dd6a70dc26c9606af2f81350db4 Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Sat, 15 Oct 2022 16:49:13 +0200
Subject: [PATCH 48/91] working on issue 1106

---
 nalgebra-lapack/src/eigen.rs | 65 +++++++++++++++++++++++++++++++++---
 1 file changed, 61 insertions(+), 4 deletions(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index 68b34b56..d6dc90d0 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -7,9 +7,8 @@ use num_complex::Complex;
 use simba::scalar::RealField;
 
 use crate::ComplexHelper;
-use na::allocator::Allocator;
-use na::dimension::{Const, Dim};
-use na::{DefaultAllocator, Matrix, OMatrix, OVector, Scalar};
+use na::dimension::{Const, Dim, DimName};
+use na::{DefaultAllocator, Matrix, OMatrix, OVector, Scalar, allocator::Allocator};
 
 use lapack;
 
@@ -148,7 +147,7 @@ where
             eigenvalues_re: wr,
             eigenvalues_im: wi,
             left_eigenvectors: vl,
-            eigenvectors: vr,
+            eigenvectors: vr
         })
     }
 
@@ -168,6 +167,64 @@ where
 
         det
     }
+
+    /// Returns a tuple of vectors. The elements of the tuple are the complex eigenvalues, complex left eigenvectors and complex right eigenvectors respectively. 
+    /// The elements appear as conjugate pairs within each vector, with the positive of the pair always being first.
+    pub fn get_complex_elements(&self) -> (Option<Vec<Complex<T>>>, Option<Vec<OVector<Complex<T>, D>>>, Option<Vec<OVector<Complex<T>, D>>>) where DefaultAllocator: Allocator<Complex<T>, D> {
+        match !self.eigenvalues_are_real() {
+            true => (None, None, None),
+            false => {
+                let number_of_elements = self.eigenvalues_re.nrows();
+                let number_of_complex_entries = self.eigenvalues_im.iter().fold(0, |acc, e| if !e.is_zero() {acc + 1} else {acc});
+                let mut eigenvalues = Vec::<Complex<T>>::with_capacity(2*number_of_complex_entries);
+                let mut eigenvectors = match self.eigenvectors.is_some() {
+                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(2*number_of_complex_entries)),
+                    false => None
+                };
+                let mut left_eigenvectors = match self.left_eigenvectors.is_some() {
+                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(2*number_of_complex_entries)),
+                    false => None
+                };
+
+                let eigenvectors_raw = self.eigenvectors;
+                let left_eigenvectors_raw = self.left_eigenvectors;
+
+                for mut i in 0..number_of_elements {
+                    if self.eigenvalues_im[i] != T::zero() {
+                        //Complex conjugate pairs of eigenvalues appear consecutively with the eigenvalue having the positive imaginary part first.
+                        eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[i].clone(), self.eigenvalues_im[i].clone()));
+                        eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[i].clone(), -self.eigenvalues_im[i].clone()));
+
+                        if eigenvectors.is_some() {
+                            let mut r1_vec = OVector::<Complex<T>, D>::zeros(number_of_elements);
+                            let mut r1_vec_conj = OVector::<Complex<T>, D>::zeros(number_of_elements);
+
+                            for j in 0..number_of_elements {
+                                r1_vec[j] = Complex::<T>::new(self.eigenvectors.unwrap()[(i,j)].clone(),self.eigenvectors.unwrap()[(i,j+1)].clone());
+                                r1_vec_conj[j] = Complex::<T>::new(self.eigenvectors.unwrap()[(i,j)].clone(),-self.eigenvectors.unwrap()[(i,j+1)].clone());
+                            }
+    
+                            eigenvectors.unwrap().push(r1_vec);
+                            eigenvectors.unwrap().push(r1_vec_conj);
+                        }
+
+
+                        if left_eigenvectors.is_some() {
+                            //TODO: Do the same for left
+                        }
+
+
+                        i += 1;
+                    }
+                    
+                }
+                (Some(eigenvalues), left_eigenvectors, eigenvectors)
+            }
+        }
+
+
+    }
+
 }
 
 /*

From b732b75a774b2c51b97b9b0a1df192de8208b809 Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Sat, 15 Oct 2022 19:10:31 +0200
Subject: [PATCH 49/91] added panic so that the code compiles

---
 nalgebra-lapack/src/eigen.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index d6dc90d0..0448679c 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -171,6 +171,7 @@ where
     /// Returns a tuple of vectors. The elements of the tuple are the complex eigenvalues, complex left eigenvectors and complex right eigenvectors respectively. 
     /// The elements appear as conjugate pairs within each vector, with the positive of the pair always being first.
     pub fn get_complex_elements(&self) -> (Option<Vec<Complex<T>>>, Option<Vec<OVector<Complex<T>, D>>>, Option<Vec<OVector<Complex<T>, D>>>) where DefaultAllocator: Allocator<Complex<T>, D> {
+        panic!("TODO");
         match !self.eigenvalues_are_real() {
             true => (None, None, None),
             false => {

From 8ee68afaacfdbe5016727968a1a8e2212e0f4ed6 Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Sat, 15 Oct 2022 19:17:05 +0200
Subject: [PATCH 50/91] commented out so that code compiles

---
 nalgebra-lapack/src/eigen.rs | 80 ++++++++++++++++++------------------
 1 file changed, 40 insertions(+), 40 deletions(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index 0448679c..d81468ef 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -172,56 +172,56 @@ where
     /// The elements appear as conjugate pairs within each vector, with the positive of the pair always being first.
     pub fn get_complex_elements(&self) -> (Option<Vec<Complex<T>>>, Option<Vec<OVector<Complex<T>, D>>>, Option<Vec<OVector<Complex<T>, D>>>) where DefaultAllocator: Allocator<Complex<T>, D> {
         panic!("TODO");
-        match !self.eigenvalues_are_real() {
-            true => (None, None, None),
-            false => {
-                let number_of_elements = self.eigenvalues_re.nrows();
-                let number_of_complex_entries = self.eigenvalues_im.iter().fold(0, |acc, e| if !e.is_zero() {acc + 1} else {acc});
-                let mut eigenvalues = Vec::<Complex<T>>::with_capacity(2*number_of_complex_entries);
-                let mut eigenvectors = match self.eigenvectors.is_some() {
-                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(2*number_of_complex_entries)),
-                    false => None
-                };
-                let mut left_eigenvectors = match self.left_eigenvectors.is_some() {
-                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(2*number_of_complex_entries)),
-                    false => None
-                };
+        // match !self.eigenvalues_are_real() {
+        //     true => (None, None, None),
+        //     false => {
+        //         let number_of_elements = self.eigenvalues_re.nrows();
+        //         let number_of_complex_entries = self.eigenvalues_im.iter().fold(0, |acc, e| if !e.is_zero() {acc + 1} else {acc});
+        //         let mut eigenvalues = Vec::<Complex<T>>::with_capacity(2*number_of_complex_entries);
+        //         let mut eigenvectors = match self.eigenvectors.is_some() {
+        //             true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(2*number_of_complex_entries)),
+        //             false => None
+        //         };
+        //         let mut left_eigenvectors = match self.left_eigenvectors.is_some() {
+        //             true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(2*number_of_complex_entries)),
+        //             false => None
+        //         };
 
-                let eigenvectors_raw = self.eigenvectors;
-                let left_eigenvectors_raw = self.left_eigenvectors;
+        //         let eigenvectors_raw = self.eigenvectors;
+        //         let left_eigenvectors_raw = self.left_eigenvectors;
 
-                for mut i in 0..number_of_elements {
-                    if self.eigenvalues_im[i] != T::zero() {
-                        //Complex conjugate pairs of eigenvalues appear consecutively with the eigenvalue having the positive imaginary part first.
-                        eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[i].clone(), self.eigenvalues_im[i].clone()));
-                        eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[i].clone(), -self.eigenvalues_im[i].clone()));
+        //         for mut i in 0..number_of_elements {
+        //             if self.eigenvalues_im[i] != T::zero() {
+        //                 //Complex conjugate pairs of eigenvalues appear consecutively with the eigenvalue having the positive imaginary part first.
+        //                 eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[i].clone(), self.eigenvalues_im[i].clone()));
+        //                 eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[i].clone(), -self.eigenvalues_im[i].clone()));
 
-                        if eigenvectors.is_some() {
-                            let mut r1_vec = OVector::<Complex<T>, D>::zeros(number_of_elements);
-                            let mut r1_vec_conj = OVector::<Complex<T>, D>::zeros(number_of_elements);
+        //                 if eigenvectors.is_some() {
+        //                     let mut r1_vec = OVector::<Complex<T>, D>::zeros(number_of_elements);
+        //                     let mut r1_vec_conj = OVector::<Complex<T>, D>::zeros(number_of_elements);
 
-                            for j in 0..number_of_elements {
-                                r1_vec[j] = Complex::<T>::new(self.eigenvectors.unwrap()[(i,j)].clone(),self.eigenvectors.unwrap()[(i,j+1)].clone());
-                                r1_vec_conj[j] = Complex::<T>::new(self.eigenvectors.unwrap()[(i,j)].clone(),-self.eigenvectors.unwrap()[(i,j+1)].clone());
-                            }
+        //                     for j in 0..number_of_elements {
+        //                         r1_vec[j] = Complex::<T>::new(self.eigenvectors.unwrap()[(i,j)].clone(),self.eigenvectors.unwrap()[(i,j+1)].clone());
+        //                         r1_vec_conj[j] = Complex::<T>::new(self.eigenvectors.unwrap()[(i,j)].clone(),-self.eigenvectors.unwrap()[(i,j+1)].clone());
+        //                     }
     
-                            eigenvectors.unwrap().push(r1_vec);
-                            eigenvectors.unwrap().push(r1_vec_conj);
-                        }
+        //                     eigenvectors.unwrap().push(r1_vec);
+        //                     eigenvectors.unwrap().push(r1_vec_conj);
+        //                 }
 
 
-                        if left_eigenvectors.is_some() {
-                            //TODO: Do the same for left
-                        }
+        //                 if left_eigenvectors.is_some() {
+        //                     //TODO: Do the same for left
+        //                 }
 
 
-                        i += 1;
-                    }
+        //                 i += 1;
+        //             }
                     
-                }
-                (Some(eigenvalues), left_eigenvectors, eigenvectors)
-            }
-        }
+        //         }
+        //         (Some(eigenvalues), left_eigenvectors, eigenvectors)
+        //     }
+        // }
 
 
     }

From ee3f84abba0fdb027401d0e747f7accf41f2af23 Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Sun, 16 Oct 2022 11:52:32 +0200
Subject: [PATCH 51/91] first version

---
 nalgebra-lapack/src/eigen.rs | 98 ++++++++++++++++++------------------
 1 file changed, 50 insertions(+), 48 deletions(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index d81468ef..c49c6dd3 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -31,7 +31,7 @@ use lapack;
     )
 )]
 #[derive(Clone, Debug)]
-pub struct Eigen<T: Scalar, D: Dim>
+pub struct Eigen<T: Scalar, D: DimName>
 where
     DefaultAllocator: Allocator<T, D> + Allocator<T, D, D>,
 {
@@ -45,7 +45,7 @@ where
     pub left_eigenvectors: Option<OMatrix<T, D, D>>,
 }
 
-impl<T: Scalar + Copy, D: Dim> Copy for Eigen<T, D>
+impl<T: Scalar + Copy, D: DimName> Copy for Eigen<T, D>
 where
     DefaultAllocator: Allocator<T, D> + Allocator<T, D, D>,
     OVector<T, D>: Copy,
@@ -53,7 +53,7 @@ where
 {
 }
 
-impl<T: EigenScalar + RealField, D: Dim> Eigen<T, D>
+impl<T: EigenScalar + RealField, D: DimName> Eigen<T, D>
 where
     DefaultAllocator: Allocator<T, D, D> + Allocator<T, D>,
 {
@@ -171,57 +171,59 @@ where
     /// Returns a tuple of vectors. The elements of the tuple are the complex eigenvalues, complex left eigenvectors and complex right eigenvectors respectively. 
     /// The elements appear as conjugate pairs within each vector, with the positive of the pair always being first.
     pub fn get_complex_elements(&self) -> (Option<Vec<Complex<T>>>, Option<Vec<OVector<Complex<T>, D>>>, Option<Vec<OVector<Complex<T>, D>>>) where DefaultAllocator: Allocator<Complex<T>, D> {
-        panic!("TODO");
-        // match !self.eigenvalues_are_real() {
-        //     true => (None, None, None),
-        //     false => {
-        //         let number_of_elements = self.eigenvalues_re.nrows();
-        //         let number_of_complex_entries = self.eigenvalues_im.iter().fold(0, |acc, e| if !e.is_zero() {acc + 1} else {acc});
-        //         let mut eigenvalues = Vec::<Complex<T>>::with_capacity(2*number_of_complex_entries);
-        //         let mut eigenvectors = match self.eigenvectors.is_some() {
-        //             true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(2*number_of_complex_entries)),
-        //             false => None
-        //         };
-        //         let mut left_eigenvectors = match self.left_eigenvectors.is_some() {
-        //             true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(2*number_of_complex_entries)),
-        //             false => None
-        //         };
+        match !self.eigenvalues_are_real() {
+            true => (None, None, None),
+            false => {
+                let number_of_elements = self.eigenvalues_re.nrows();
+                let number_of_complex_entries = self.eigenvalues_im.iter().fold(0, |acc, e| if !e.is_zero() {acc + 1} else {acc});
+                let mut eigenvalues = Vec::<Complex<T>>::with_capacity(2*number_of_complex_entries);
+                let mut eigenvectors = match self.eigenvectors.is_some() {
+                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(2*number_of_complex_entries)),
+                    false => None
+                };
+                let mut left_eigenvectors = match self.left_eigenvectors.is_some() {
+                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(2*number_of_complex_entries)),
+                    false => None
+                };
 
-        //         let eigenvectors_raw = self.eigenvectors;
-        //         let left_eigenvectors_raw = self.left_eigenvectors;
+                for mut c in 0..number_of_elements {
+                    if self.eigenvalues_im[c] != T::zero() {
+                        //Complex conjugate pairs of eigenvalues appear consecutively with the eigenvalue having the positive imaginary part first.
+                        eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[c].clone(), self.eigenvalues_im[c].clone()));
+                        eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[c].clone(), -self.eigenvalues_im[c].clone()));
 
-        //         for mut i in 0..number_of_elements {
-        //             if self.eigenvalues_im[i] != T::zero() {
-        //                 //Complex conjugate pairs of eigenvalues appear consecutively with the eigenvalue having the positive imaginary part first.
-        //                 eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[i].clone(), self.eigenvalues_im[i].clone()));
-        //                 eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[i].clone(), -self.eigenvalues_im[i].clone()));
+                        if eigenvectors.is_some() {
+                            let mut vec = OVector::<Complex<T>, D>::zeros();
+                            let mut vec_conj = OVector::<Complex<T>, D>::zeros();
 
-        //                 if eigenvectors.is_some() {
-        //                     let mut r1_vec = OVector::<Complex<T>, D>::zeros(number_of_elements);
-        //                     let mut r1_vec_conj = OVector::<Complex<T>, D>::zeros(number_of_elements);
-
-        //                     for j in 0..number_of_elements {
-        //                         r1_vec[j] = Complex::<T>::new(self.eigenvectors.unwrap()[(i,j)].clone(),self.eigenvectors.unwrap()[(i,j+1)].clone());
-        //                         r1_vec_conj[j] = Complex::<T>::new(self.eigenvectors.unwrap()[(i,j)].clone(),-self.eigenvectors.unwrap()[(i,j+1)].clone());
-        //                     }
+                            for r in 0..number_of_elements {
+                                vec[r] = Complex::<T>::new((&self.eigenvectors.as_ref()).unwrap()[(r,c)].clone(),(&self.eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
+                                vec_conj[r] = Complex::<T>::new((&self.eigenvectors.as_ref()).unwrap()[(r,c)].clone(),-(&self.eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
+                            }
     
-        //                     eigenvectors.unwrap().push(r1_vec);
-        //                     eigenvectors.unwrap().push(r1_vec_conj);
-        //                 }
+                            eigenvectors.as_mut().unwrap().push(vec);
+                            eigenvectors.as_mut().unwrap().push(vec_conj);
+                        }
 
+                        if left_eigenvectors.is_some() {
+                            let mut vec = OVector::<Complex<T>, D>::zeros();
+                            let mut vec_conj = OVector::<Complex<T>, D>::zeros();
 
-        //                 if left_eigenvectors.is_some() {
-        //                     //TODO: Do the same for left
-        //                 }
-
-
-        //                 i += 1;
-        //             }
-                    
-        //         }
-        //         (Some(eigenvalues), left_eigenvectors, eigenvectors)
-        //     }
-        // }
+                            for r in 0..number_of_elements {
+                                vec[r] = Complex::<T>::new((&self.left_eigenvectors.as_ref()).unwrap()[(r,c)].clone(),(&self.left_eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
+                                vec_conj[r] = Complex::<T>::new((&self.left_eigenvectors.as_ref()).unwrap()[(r,c)].clone(),-(&self.left_eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
+                            }
+    
+                            left_eigenvectors.as_mut().unwrap().push(vec);
+                            left_eigenvectors.as_mut().unwrap().push(vec_conj);
+                        }
+                        //skip next entry
+                        c += 1;
+                    }
+                }
+                (Some(eigenvalues), left_eigenvectors, eigenvectors)
+            }
+        }
 
 
     }

From 01c5b9ea564d7b5be6c061423c659df9711b550f Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Sun, 16 Oct 2022 11:55:07 +0200
Subject: [PATCH 52/91] switch back to Dim + zero_generic

---
 nalgebra-lapack/src/eigen.rs | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index c49c6dd3..7048ee35 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -7,7 +7,7 @@ use num_complex::Complex;
 use simba::scalar::RealField;
 
 use crate::ComplexHelper;
-use na::dimension::{Const, Dim, DimName};
+use na::dimension::{Const, Dim};
 use na::{DefaultAllocator, Matrix, OMatrix, OVector, Scalar, allocator::Allocator};
 
 use lapack;
@@ -31,7 +31,7 @@ use lapack;
     )
 )]
 #[derive(Clone, Debug)]
-pub struct Eigen<T: Scalar, D: DimName>
+pub struct Eigen<T: Scalar, D: Dim>
 where
     DefaultAllocator: Allocator<T, D> + Allocator<T, D, D>,
 {
@@ -45,7 +45,7 @@ where
     pub left_eigenvectors: Option<OMatrix<T, D, D>>,
 }
 
-impl<T: Scalar + Copy, D: DimName> Copy for Eigen<T, D>
+impl<T: Scalar + Copy, D: Dim> Copy for Eigen<T, D>
 where
     DefaultAllocator: Allocator<T, D> + Allocator<T, D, D>,
     OVector<T, D>: Copy,
@@ -53,7 +53,7 @@ where
 {
 }
 
-impl<T: EigenScalar + RealField, D: DimName> Eigen<T, D>
+impl<T: EigenScalar + RealField, D: Dim> Eigen<T, D>
 where
     DefaultAllocator: Allocator<T, D, D> + Allocator<T, D>,
 {
@@ -174,7 +174,8 @@ where
         match !self.eigenvalues_are_real() {
             true => (None, None, None),
             false => {
-                let number_of_elements = self.eigenvalues_re.nrows();
+                let (number_of_elements, _) = self.eigenvalues_re.shape_generic();
+                let number_of_elements_value = number_of_elements.value();
                 let number_of_complex_entries = self.eigenvalues_im.iter().fold(0, |acc, e| if !e.is_zero() {acc + 1} else {acc});
                 let mut eigenvalues = Vec::<Complex<T>>::with_capacity(2*number_of_complex_entries);
                 let mut eigenvectors = match self.eigenvectors.is_some() {
@@ -186,17 +187,17 @@ where
                     false => None
                 };
 
-                for mut c in 0..number_of_elements {
+                for mut c in 0..number_of_elements_value {
                     if self.eigenvalues_im[c] != T::zero() {
                         //Complex conjugate pairs of eigenvalues appear consecutively with the eigenvalue having the positive imaginary part first.
                         eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[c].clone(), self.eigenvalues_im[c].clone()));
                         eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[c].clone(), -self.eigenvalues_im[c].clone()));
 
                         if eigenvectors.is_some() {
-                            let mut vec = OVector::<Complex<T>, D>::zeros();
-                            let mut vec_conj = OVector::<Complex<T>, D>::zeros();
+                            let mut vec = OVector::<Complex<T>, D>::zeros_generic(number_of_elements, Const::<1>);
+                            let mut vec_conj = OVector::<Complex<T>, D>::zeros_generic(number_of_elements, Const::<1>);
 
-                            for r in 0..number_of_elements {
+                            for r in 0..number_of_elements_value {
                                 vec[r] = Complex::<T>::new((&self.eigenvectors.as_ref()).unwrap()[(r,c)].clone(),(&self.eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
                                 vec_conj[r] = Complex::<T>::new((&self.eigenvectors.as_ref()).unwrap()[(r,c)].clone(),-(&self.eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
                             }
@@ -206,10 +207,10 @@ where
                         }
 
                         if left_eigenvectors.is_some() {
-                            let mut vec = OVector::<Complex<T>, D>::zeros();
-                            let mut vec_conj = OVector::<Complex<T>, D>::zeros();
+                            let mut vec = OVector::<Complex<T>, D>::zeros_generic(number_of_elements, Const::<1>);
+                            let mut vec_conj = OVector::<Complex<T>, D>::zeros_generic(number_of_elements, Const::<1>);
 
-                            for r in 0..number_of_elements {
+                            for r in 0..number_of_elements_value {
                                 vec[r] = Complex::<T>::new((&self.left_eigenvectors.as_ref()).unwrap()[(r,c)].clone(),(&self.left_eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
                                 vec_conj[r] = Complex::<T>::new((&self.left_eigenvectors.as_ref()).unwrap()[(r,c)].clone(),-(&self.left_eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
                             }

From 81f1a6d87e350314c5c293a4aab58fbc156f3b8a Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Sun, 16 Oct 2022 12:03:08 +0200
Subject: [PATCH 53/91] review conjugate indexing

---
 nalgebra-lapack/src/eigen.rs | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index 7048ee35..995d765e 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -177,13 +177,13 @@ where
                 let (number_of_elements, _) = self.eigenvalues_re.shape_generic();
                 let number_of_elements_value = number_of_elements.value();
                 let number_of_complex_entries = self.eigenvalues_im.iter().fold(0, |acc, e| if !e.is_zero() {acc + 1} else {acc});
-                let mut eigenvalues = Vec::<Complex<T>>::with_capacity(2*number_of_complex_entries);
+                let mut eigenvalues = Vec::<Complex<T>>::with_capacity(number_of_complex_entries);
                 let mut eigenvectors = match self.eigenvectors.is_some() {
-                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(2*number_of_complex_entries)),
+                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(number_of_complex_entries)),
                     false => None
                 };
                 let mut left_eigenvectors = match self.left_eigenvectors.is_some() {
-                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(2*number_of_complex_entries)),
+                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(number_of_complex_entries)),
                     false => None
                 };
 
@@ -191,7 +191,7 @@ where
                     if self.eigenvalues_im[c] != T::zero() {
                         //Complex conjugate pairs of eigenvalues appear consecutively with the eigenvalue having the positive imaginary part first.
                         eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[c].clone(), self.eigenvalues_im[c].clone()));
-                        eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[c].clone(), -self.eigenvalues_im[c].clone()));
+                        eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[c+1].clone(), self.eigenvalues_im[c+1].clone()));
 
                         if eigenvectors.is_some() {
                             let mut vec = OVector::<Complex<T>, D>::zeros_generic(number_of_elements, Const::<1>);
@@ -199,7 +199,7 @@ where
 
                             for r in 0..number_of_elements_value {
                                 vec[r] = Complex::<T>::new((&self.eigenvectors.as_ref()).unwrap()[(r,c)].clone(),(&self.eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
-                                vec_conj[r] = Complex::<T>::new((&self.eigenvectors.as_ref()).unwrap()[(r,c)].clone(),-(&self.eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
+                                vec_conj[r] = Complex::<T>::new((&self.eigenvectors.as_ref()).unwrap()[(r,c)].clone(),(&self.eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
                             }
     
                             eigenvectors.as_mut().unwrap().push(vec);
@@ -212,7 +212,7 @@ where
 
                             for r in 0..number_of_elements_value {
                                 vec[r] = Complex::<T>::new((&self.left_eigenvectors.as_ref()).unwrap()[(r,c)].clone(),(&self.left_eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
-                                vec_conj[r] = Complex::<T>::new((&self.left_eigenvectors.as_ref()).unwrap()[(r,c)].clone(),-(&self.left_eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
+                                vec_conj[r] = Complex::<T>::new((&self.left_eigenvectors.as_ref()).unwrap()[(r,c)].clone(),(&self.left_eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
                             }
     
                             left_eigenvectors.as_mut().unwrap().push(vec);
@@ -225,8 +225,6 @@ where
                 (Some(eigenvalues), left_eigenvectors, eigenvectors)
             }
         }
-
-
     }
 
 }

From 9acaa35e33964915507a6124fdae318af6503a7f Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Sat, 22 Oct 2022 21:26:09 +0200
Subject: [PATCH 54/91] fixed iteration

---
 nalgebra-lapack/src/eigen.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index 995d765e..5f621dbf 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -186,8 +186,9 @@ where
                     true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(number_of_complex_entries)),
                     false => None
                 };
-
-                for mut c in 0..number_of_elements_value {
+                
+                let mut c = 0;
+                while c < number_of_elements_value {
                     if self.eigenvalues_im[c] != T::zero() {
                         //Complex conjugate pairs of eigenvalues appear consecutively with the eigenvalue having the positive imaginary part first.
                         eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[c].clone(), self.eigenvalues_im[c].clone()));

From 4a1fd605e40afe7064cc4b3c306a75868466cdfb Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Sun, 23 Oct 2022 19:23:13 +0200
Subject: [PATCH 55/91] fixed iteration

---
 nalgebra-lapack/src/eigen.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index 5f621dbf..3a848d0a 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -222,6 +222,7 @@ where
                         //skip next entry
                         c += 1;
                     }
+                    c+=1;
                 }
                 (Some(eigenvalues), left_eigenvectors, eigenvectors)
             }

From aa89cda0cd9474cf040adbfe55e4c26d75e6d9fd Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Sun, 23 Oct 2022 20:36:06 +0200
Subject: [PATCH 56/91] testing complex eigenvalues

---
 nalgebra-lapack/Cargo.toml                    |  4 +++-
 nalgebra-lapack/examples/complex_eigen.rs     | 24 +++++++++++++++++++
 nalgebra-lapack/src/eigen.rs                  |  3 ++-
 nalgebra-lapack/tests/linalg/complex_eigen.rs | 19 +++++++++++++++
 nalgebra-lapack/tests/linalg/mod.rs           |  1 +
 5 files changed, 49 insertions(+), 2 deletions(-)
 create mode 100644 nalgebra-lapack/examples/complex_eigen.rs
 create mode 100644 nalgebra-lapack/tests/linalg/complex_eigen.rs

diff --git a/nalgebra-lapack/Cargo.toml b/nalgebra-lapack/Cargo.toml
index 91517a8d..3f165f76 100644
--- a/nalgebra-lapack/Cargo.toml
+++ b/nalgebra-lapack/Cargo.toml
@@ -22,7 +22,7 @@ proptest-support = [ "nalgebra/proptest-support" ]
 arbitrary        = [ "nalgebra/arbitrary" ]
 
 # For BLAS/LAPACK
-default    = ["netlib"]
+default    = ["openblas"]
 openblas   = ["lapack-src/openblas"]
 netlib     = ["lapack-src/netlib"]
 accelerate = ["lapack-src/accelerate"]
@@ -36,6 +36,7 @@ simba         = "0.7"
 serde         = { version = "1.0", features = [ "derive" ], optional = true }
 lapack        = { version = "0.19", default-features = false }
 lapack-src    = { version = "0.8", default-features = false }
+openblas-src = {version = "*", features = ["static"]}
 # clippy = "*"
 
 [dev-dependencies]
@@ -44,3 +45,4 @@ proptest   = { version = "1", default-features = false, features = ["std"] }
 quickcheck = "1"
 approx     = "0.5"
 rand       = "0.8"
+
diff --git a/nalgebra-lapack/examples/complex_eigen.rs b/nalgebra-lapack/examples/complex_eigen.rs
new file mode 100644
index 00000000..8a359d69
--- /dev/null
+++ b/nalgebra-lapack/examples/complex_eigen.rs
@@ -0,0 +1,24 @@
+extern crate nalgebra as na;
+extern crate nalgebra_lapack;
+#[macro_use]
+extern crate approx; // for assert_relative_eq
+
+use na::Matrix3;
+use nalgebra_lapack::Eigen;
+use num_complex::Complex;
+
+
+fn main() {
+    let m = Matrix3::<f64>::new(4.0/5.0, -3.0/5.0, 0.0, 3.0/5.0, 4.0/5.0, 0.0, 1.0, 2.0, 2.0);
+    let eigen = Eigen::new(m,true,true).expect("Eigen Creation Failed!");
+    let (some_eigenvalues, some_left_vec, some_right_vec) = eigen.get_complex_elements();
+    let eigenvalues = some_eigenvalues.expect("Eigenvalues Failed");
+    let left_eigenvectors = some_left_vec.expect("Left Eigenvectors Failed");
+    let eigenvectors = some_right_vec.expect("Right Eigenvectors Failed");
+
+    assert_relative_eq!(eigenvalues[0].re, Complex::<f64>::new(4.0/5.0,3.0/5.0).re);
+    assert_relative_eq!(eigenvalues[0].im, Complex::<f64>::new(4.0/5.0,3.0/5.0).im);
+    assert_relative_eq!(eigenvalues[1].re, Complex::<f64>::new(4.0/5.0,-3.0/5.0).re);
+    assert_relative_eq!(eigenvalues[1].im, Complex::<f64>::new(4.0/5.0,-3.0/5.0).im);
+    
+}
\ No newline at end of file
diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index 3a848d0a..d98c500d 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -171,7 +171,8 @@ where
     /// Returns a tuple of vectors. The elements of the tuple are the complex eigenvalues, complex left eigenvectors and complex right eigenvectors respectively. 
     /// The elements appear as conjugate pairs within each vector, with the positive of the pair always being first.
     pub fn get_complex_elements(&self) -> (Option<Vec<Complex<T>>>, Option<Vec<OVector<Complex<T>, D>>>, Option<Vec<OVector<Complex<T>, D>>>) where DefaultAllocator: Allocator<Complex<T>, D> {
-        match !self.eigenvalues_are_real() {
+
+        match self.eigenvalues_are_real() {
             true => (None, None, None),
             false => {
                 let (number_of_elements, _) = self.eigenvalues_re.shape_generic();
diff --git a/nalgebra-lapack/tests/linalg/complex_eigen.rs b/nalgebra-lapack/tests/linalg/complex_eigen.rs
new file mode 100644
index 00000000..10869470
--- /dev/null
+++ b/nalgebra-lapack/tests/linalg/complex_eigen.rs
@@ -0,0 +1,19 @@
+use std::cmp;
+
+use na::{Matrix3};
+use nalgebra_lapack::Eigen;
+
+use crate::proptest::*;
+use proptest::{prop_assert, proptest};
+
+proptest! {
+    //#[test]
+    // fn complex_eigen() {
+    //     let n = cmp::max(1, cmp::min(n, 10));
+    //     let m = DMatrix::<f64>::new_random(n, n);
+    //     let eig = SymmetricEigen::new(m.clone());
+    //     let recomp = eig.recompose();
+    //     prop_assert!(relative_eq!(m.lower_triangle(), recomp.lower_triangle(), epsilon = 1.0e-5))
+    // }
+
+}
diff --git a/nalgebra-lapack/tests/linalg/mod.rs b/nalgebra-lapack/tests/linalg/mod.rs
index 251bbe7b..8fc8deeb 100644
--- a/nalgebra-lapack/tests/linalg/mod.rs
+++ b/nalgebra-lapack/tests/linalg/mod.rs
@@ -7,3 +7,4 @@ mod real_eigensystem;
 mod schur;
 mod svd;
 mod symmetric_eigen;
+mod complex_eigen;

From 84c37b79ddcfb97f961b76da0cee69d1a07f42b9 Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Sun, 23 Oct 2022 21:43:33 +0200
Subject: [PATCH 57/91] testing eigenvectors

---
 nalgebra-lapack/examples/complex_eigen.rs | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/nalgebra-lapack/examples/complex_eigen.rs b/nalgebra-lapack/examples/complex_eigen.rs
index 8a359d69..ebf5e48c 100644
--- a/nalgebra-lapack/examples/complex_eigen.rs
+++ b/nalgebra-lapack/examples/complex_eigen.rs
@@ -7,18 +7,27 @@ use na::Matrix3;
 use nalgebra_lapack::Eigen;
 use num_complex::Complex;
 
-
+//Matrix taken from https://textbooks.math.gatech.edu/ila/1553/complex-eigenvalues.html
 fn main() {
     let m = Matrix3::<f64>::new(4.0/5.0, -3.0/5.0, 0.0, 3.0/5.0, 4.0/5.0, 0.0, 1.0, 2.0, 2.0);
     let eigen = Eigen::new(m,true,true).expect("Eigen Creation Failed!");
     let (some_eigenvalues, some_left_vec, some_right_vec) = eigen.get_complex_elements();
     let eigenvalues = some_eigenvalues.expect("Eigenvalues Failed");
-    let left_eigenvectors = some_left_vec.expect("Left Eigenvectors Failed");
+    let _left_eigenvectors = some_left_vec.expect("Left Eigenvectors Failed");
     let eigenvectors = some_right_vec.expect("Right Eigenvectors Failed");
 
     assert_relative_eq!(eigenvalues[0].re, Complex::<f64>::new(4.0/5.0,3.0/5.0).re);
     assert_relative_eq!(eigenvalues[0].im, Complex::<f64>::new(4.0/5.0,3.0/5.0).im);
     assert_relative_eq!(eigenvalues[1].re, Complex::<f64>::new(4.0/5.0,-3.0/5.0).re);
     assert_relative_eq!(eigenvalues[1].im, Complex::<f64>::new(4.0/5.0,-3.0/5.0).im);
+
+
+    assert_relative_eq!(eigenvectors[0][0].re, -12.0/32.7871926215100059134410999);
+    assert_relative_eq!(eigenvectors[0][0].im, -9.0/32.7871926215100059134410999);
+    assert_relative_eq!(eigenvectors[0][1].re, -9.0/32.7871926215100059134410999);
+    assert_relative_eq!(eigenvectors[0][1].im, 12.0/32.7871926215100059134410999);
+    assert_relative_eq!(eigenvectors[0][2].re, 25.0/32.7871926215100059134410999);
+    assert_relative_eq!(eigenvectors[0][2].im, 0.0);
+
     
 }
\ No newline at end of file

From 9c8b5f0f385a24d8be3e5b1625f511e6957498a8 Mon Sep 17 00:00:00 2001
From: Marc Haubenstock <marc.dhaubenstock@gmail.com>
Date: Wed, 26 Oct 2022 16:26:06 +0200
Subject: [PATCH 58/91] added a function to get all the real elements

---
 nalgebra-lapack/examples/complex_eigen.rs |  4 +--
 nalgebra-lapack/src/eigen.rs              | 37 ++++++++++++++++++++++-
 2 files changed, 37 insertions(+), 4 deletions(-)

diff --git a/nalgebra-lapack/examples/complex_eigen.rs b/nalgebra-lapack/examples/complex_eigen.rs
index ebf5e48c..6c452d66 100644
--- a/nalgebra-lapack/examples/complex_eigen.rs
+++ b/nalgebra-lapack/examples/complex_eigen.rs
@@ -27,7 +27,5 @@ fn main() {
     assert_relative_eq!(eigenvectors[0][1].re, -9.0/32.7871926215100059134410999);
     assert_relative_eq!(eigenvectors[0][1].im, 12.0/32.7871926215100059134410999);
     assert_relative_eq!(eigenvectors[0][2].re, 25.0/32.7871926215100059134410999);
-    assert_relative_eq!(eigenvectors[0][2].im, 0.0);
-
-    
+    assert_relative_eq!(eigenvectors[0][2].im, 0.0); 
 }
\ No newline at end of file
diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index d98c500d..e76b8ef4 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -168,10 +168,45 @@ where
         det
     }
 
+    /// Returns a tuple of vectors. The elements of the tuple are the real parts of the eigenvalues, left eigenvectors and right eigenvectors respectively. 
+    pub fn get_real_elements(&self) -> (Vec<T>, Option<Vec<OVector<T, D>>>, Option<Vec<OVector<T, D>>>) where DefaultAllocator: Allocator<T, D> {
+        let (number_of_elements, _) = self.eigenvalues_re.shape_generic();
+        let number_of_elements_value = number_of_elements.value();
+        let mut eigenvalues = Vec::<T>::with_capacity(number_of_elements_value);
+        let mut eigenvectors = match self.eigenvectors.is_some() {
+            true => Some(Vec::<OVector<T, D>>::with_capacity(number_of_elements_value)),
+            false => None
+        };
+        let mut left_eigenvectors = match self.left_eigenvectors.is_some() {
+            true => Some(Vec::<OVector<T, D>>::with_capacity(number_of_elements_value)),
+            false => None
+        };
+        
+        let mut c = 0;
+        while c < number_of_elements_value {
+            eigenvalues.push(self.eigenvalues_re[c].clone());
+
+            if eigenvectors.is_some() {
+                eigenvectors.as_mut().unwrap().push((&self.eigenvectors.as_ref()).unwrap().column(c).into_owned());
+            }
+
+            if left_eigenvectors.is_some() {
+                left_eigenvectors.as_mut().unwrap().push((&self.left_eigenvectors.as_ref()).unwrap().column(c).into_owned());
+            }
+            if self.eigenvalues_im[c] != T::zero() {
+                //skip next entry
+                c += 1;
+            }
+            c+=1;
+        }
+        (eigenvalues, left_eigenvectors, eigenvectors)
+            
+        
+    }
+
     /// Returns a tuple of vectors. The elements of the tuple are the complex eigenvalues, complex left eigenvectors and complex right eigenvectors respectively. 
     /// The elements appear as conjugate pairs within each vector, with the positive of the pair always being first.
     pub fn get_complex_elements(&self) -> (Option<Vec<Complex<T>>>, Option<Vec<OVector<Complex<T>, D>>>, Option<Vec<OVector<Complex<T>, D>>>) where DefaultAllocator: Allocator<Complex<T>, D> {
-
         match self.eigenvalues_are_real() {
             true => (None, None, None),
             false => {

From c9fa7a35e7d7613cac738f102e85000402b43ba0 Mon Sep 17 00:00:00 2001
From: _ <>
Date: Thu, 27 Oct 2022 19:56:38 +0000
Subject: [PATCH 59/91] Added try_cast() to Matrix

---
 src/base/matrix.rs | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/src/base/matrix.rs b/src/base/matrix.rs
index e9cc5258..659d3a6e 100644
--- a/src/base/matrix.rs
+++ b/src/base/matrix.rs
@@ -739,6 +739,24 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
         crate::convert(self)
     }
 
+    /// Attempts to cast the components of `self` to another type.
+    ///
+    /// # Example
+    /// ```
+    /// # use nalgebra::Vector3;
+    /// let q = Vector3::new(1.0f64, 2.0, 3.0);
+    /// let q2 = q.try_cast::<i32>();
+    /// assert_eq!(q2, Some(Vector3::new(1, 2, 3)));
+    /// ```
+    pub fn try_cast<T2: Scalar>(self) -> Option<OMatrix<T2, R, C>>
+    where
+        T: Scalar,
+        Self: SupersetOf<OMatrix<T2, R, C>>,
+        DefaultAllocator: Allocator<T2, R, C>,
+    {
+        crate::try_convert(self)
+    }
+
     /// Similar to `self.iter().fold(init, f)` except that `init` is replaced by a closure.
     ///
     /// The initialization closure is given the first component of this matrix:

From e32f4ee16f402296e4da0fb2a824ac966c90c89d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sun, 30 Oct 2022 17:22:08 +0100
Subject: [PATCH 60/91] cargo fmt + tests

---
 nalgebra-lapack/examples/complex_eigen.rs     |  31 ----
 nalgebra-lapack/src/eigen.rs                  | 138 +++++++++++++-----
 nalgebra-lapack/tests/linalg/cholesky.rs      |   6 +-
 nalgebra-lapack/tests/linalg/complex_eigen.rs |  56 +++++--
 nalgebra-lapack/tests/linalg/lu.rs            |  16 +-
 nalgebra-lapack/tests/linalg/mod.rs           |   2 +-
 .../tests/linalg/real_eigensystem.rs          |  34 +++--
 nalgebra-lapack/tests/linalg/schur.rs         |  13 +-
 8 files changed, 184 insertions(+), 112 deletions(-)
 delete mode 100644 nalgebra-lapack/examples/complex_eigen.rs

diff --git a/nalgebra-lapack/examples/complex_eigen.rs b/nalgebra-lapack/examples/complex_eigen.rs
deleted file mode 100644
index 6c452d66..00000000
--- a/nalgebra-lapack/examples/complex_eigen.rs
+++ /dev/null
@@ -1,31 +0,0 @@
-extern crate nalgebra as na;
-extern crate nalgebra_lapack;
-#[macro_use]
-extern crate approx; // for assert_relative_eq
-
-use na::Matrix3;
-use nalgebra_lapack::Eigen;
-use num_complex::Complex;
-
-//Matrix taken from https://textbooks.math.gatech.edu/ila/1553/complex-eigenvalues.html
-fn main() {
-    let m = Matrix3::<f64>::new(4.0/5.0, -3.0/5.0, 0.0, 3.0/5.0, 4.0/5.0, 0.0, 1.0, 2.0, 2.0);
-    let eigen = Eigen::new(m,true,true).expect("Eigen Creation Failed!");
-    let (some_eigenvalues, some_left_vec, some_right_vec) = eigen.get_complex_elements();
-    let eigenvalues = some_eigenvalues.expect("Eigenvalues Failed");
-    let _left_eigenvectors = some_left_vec.expect("Left Eigenvectors Failed");
-    let eigenvectors = some_right_vec.expect("Right Eigenvectors Failed");
-
-    assert_relative_eq!(eigenvalues[0].re, Complex::<f64>::new(4.0/5.0,3.0/5.0).re);
-    assert_relative_eq!(eigenvalues[0].im, Complex::<f64>::new(4.0/5.0,3.0/5.0).im);
-    assert_relative_eq!(eigenvalues[1].re, Complex::<f64>::new(4.0/5.0,-3.0/5.0).re);
-    assert_relative_eq!(eigenvalues[1].im, Complex::<f64>::new(4.0/5.0,-3.0/5.0).im);
-
-
-    assert_relative_eq!(eigenvectors[0][0].re, -12.0/32.7871926215100059134410999);
-    assert_relative_eq!(eigenvectors[0][0].im, -9.0/32.7871926215100059134410999);
-    assert_relative_eq!(eigenvectors[0][1].re, -9.0/32.7871926215100059134410999);
-    assert_relative_eq!(eigenvectors[0][1].im, 12.0/32.7871926215100059134410999);
-    assert_relative_eq!(eigenvectors[0][2].re, 25.0/32.7871926215100059134410999);
-    assert_relative_eq!(eigenvectors[0][2].im, 0.0); 
-}
\ No newline at end of file
diff --git a/nalgebra-lapack/src/eigen.rs b/nalgebra-lapack/src/eigen.rs
index e76b8ef4..08f16115 100644
--- a/nalgebra-lapack/src/eigen.rs
+++ b/nalgebra-lapack/src/eigen.rs
@@ -8,7 +8,7 @@ use simba::scalar::RealField;
 
 use crate::ComplexHelper;
 use na::dimension::{Const, Dim};
-use na::{DefaultAllocator, Matrix, OMatrix, OVector, Scalar, allocator::Allocator};
+use na::{allocator::Allocator, DefaultAllocator, Matrix, OMatrix, OVector, Scalar};
 
 use lapack;
 
@@ -147,7 +147,7 @@ where
             eigenvalues_re: wr,
             eigenvalues_im: wi,
             left_eigenvectors: vl,
-            eigenvectors: vr
+            eigenvectors: vr,
         })
     }
 
@@ -168,103 +168,169 @@ where
         det
     }
 
-    /// Returns a tuple of vectors. The elements of the tuple are the real parts of the eigenvalues, left eigenvectors and right eigenvectors respectively. 
-    pub fn get_real_elements(&self) -> (Vec<T>, Option<Vec<OVector<T, D>>>, Option<Vec<OVector<T, D>>>) where DefaultAllocator: Allocator<T, D> {
+    /// Returns a tuple of vectors. The elements of the tuple are the real parts of the eigenvalues, left eigenvectors and right eigenvectors respectively.
+    pub fn get_real_elements(
+        &self,
+    ) -> (
+        Vec<T>,
+        Option<Vec<OVector<T, D>>>,
+        Option<Vec<OVector<T, D>>>,
+    )
+    where
+        DefaultAllocator: Allocator<T, D>,
+    {
         let (number_of_elements, _) = self.eigenvalues_re.shape_generic();
         let number_of_elements_value = number_of_elements.value();
         let mut eigenvalues = Vec::<T>::with_capacity(number_of_elements_value);
         let mut eigenvectors = match self.eigenvectors.is_some() {
-            true => Some(Vec::<OVector<T, D>>::with_capacity(number_of_elements_value)),
-            false => None
+            true => Some(Vec::<OVector<T, D>>::with_capacity(
+                number_of_elements_value,
+            )),
+            false => None,
         };
         let mut left_eigenvectors = match self.left_eigenvectors.is_some() {
-            true => Some(Vec::<OVector<T, D>>::with_capacity(number_of_elements_value)),
-            false => None
+            true => Some(Vec::<OVector<T, D>>::with_capacity(
+                number_of_elements_value,
+            )),
+            false => None,
         };
-        
+
         let mut c = 0;
         while c < number_of_elements_value {
             eigenvalues.push(self.eigenvalues_re[c].clone());
 
             if eigenvectors.is_some() {
-                eigenvectors.as_mut().unwrap().push((&self.eigenvectors.as_ref()).unwrap().column(c).into_owned());
+                eigenvectors.as_mut().unwrap().push(
+                    (&self.eigenvectors.as_ref())
+                        .unwrap()
+                        .column(c)
+                        .into_owned(),
+                );
             }
 
             if left_eigenvectors.is_some() {
-                left_eigenvectors.as_mut().unwrap().push((&self.left_eigenvectors.as_ref()).unwrap().column(c).into_owned());
+                left_eigenvectors.as_mut().unwrap().push(
+                    (&self.left_eigenvectors.as_ref())
+                        .unwrap()
+                        .column(c)
+                        .into_owned(),
+                );
             }
             if self.eigenvalues_im[c] != T::zero() {
                 //skip next entry
                 c += 1;
             }
-            c+=1;
+            c += 1;
         }
         (eigenvalues, left_eigenvectors, eigenvectors)
-            
-        
     }
 
-    /// Returns a tuple of vectors. The elements of the tuple are the complex eigenvalues, complex left eigenvectors and complex right eigenvectors respectively. 
+    /// Returns a tuple of vectors. The elements of the tuple are the complex eigenvalues, complex left eigenvectors and complex right eigenvectors respectively.
     /// The elements appear as conjugate pairs within each vector, with the positive of the pair always being first.
-    pub fn get_complex_elements(&self) -> (Option<Vec<Complex<T>>>, Option<Vec<OVector<Complex<T>, D>>>, Option<Vec<OVector<Complex<T>, D>>>) where DefaultAllocator: Allocator<Complex<T>, D> {
+    pub fn get_complex_elements(
+        &self,
+    ) -> (
+        Option<Vec<Complex<T>>>,
+        Option<Vec<OVector<Complex<T>, D>>>,
+        Option<Vec<OVector<Complex<T>, D>>>,
+    )
+    where
+        DefaultAllocator: Allocator<Complex<T>, D>,
+    {
         match self.eigenvalues_are_real() {
             true => (None, None, None),
             false => {
                 let (number_of_elements, _) = self.eigenvalues_re.shape_generic();
                 let number_of_elements_value = number_of_elements.value();
-                let number_of_complex_entries = self.eigenvalues_im.iter().fold(0, |acc, e| if !e.is_zero() {acc + 1} else {acc});
+                let number_of_complex_entries =
+                    self.eigenvalues_im
+                        .iter()
+                        .fold(0, |acc, e| if !e.is_zero() { acc + 1 } else { acc });
                 let mut eigenvalues = Vec::<Complex<T>>::with_capacity(number_of_complex_entries);
                 let mut eigenvectors = match self.eigenvectors.is_some() {
-                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(number_of_complex_entries)),
-                    false => None
+                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(
+                        number_of_complex_entries,
+                    )),
+                    false => None,
                 };
                 let mut left_eigenvectors = match self.left_eigenvectors.is_some() {
-                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(number_of_complex_entries)),
-                    false => None
+                    true => Some(Vec::<OVector<Complex<T>, D>>::with_capacity(
+                        number_of_complex_entries,
+                    )),
+                    false => None,
                 };
-                
+
                 let mut c = 0;
                 while c < number_of_elements_value {
                     if self.eigenvalues_im[c] != T::zero() {
                         //Complex conjugate pairs of eigenvalues appear consecutively with the eigenvalue having the positive imaginary part first.
-                        eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[c].clone(), self.eigenvalues_im[c].clone()));
-                        eigenvalues.push(Complex::<T>::new(self.eigenvalues_re[c+1].clone(), self.eigenvalues_im[c+1].clone()));
+                        eigenvalues.push(Complex::<T>::new(
+                            self.eigenvalues_re[c].clone(),
+                            self.eigenvalues_im[c].clone(),
+                        ));
+                        eigenvalues.push(Complex::<T>::new(
+                            self.eigenvalues_re[c + 1].clone(),
+                            self.eigenvalues_im[c + 1].clone(),
+                        ));
 
                         if eigenvectors.is_some() {
-                            let mut vec = OVector::<Complex<T>, D>::zeros_generic(number_of_elements, Const::<1>);
-                            let mut vec_conj = OVector::<Complex<T>, D>::zeros_generic(number_of_elements, Const::<1>);
+                            let mut vec = OVector::<Complex<T>, D>::zeros_generic(
+                                number_of_elements,
+                                Const::<1>,
+                            );
+                            let mut vec_conj = OVector::<Complex<T>, D>::zeros_generic(
+                                number_of_elements,
+                                Const::<1>,
+                            );
 
                             for r in 0..number_of_elements_value {
-                                vec[r] = Complex::<T>::new((&self.eigenvectors.as_ref()).unwrap()[(r,c)].clone(),(&self.eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
-                                vec_conj[r] = Complex::<T>::new((&self.eigenvectors.as_ref()).unwrap()[(r,c)].clone(),(&self.eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
+                                vec[r] = Complex::<T>::new(
+                                    (&self.eigenvectors.as_ref()).unwrap()[(r, c)].clone(),
+                                    (&self.eigenvectors.as_ref()).unwrap()[(r, c + 1)].clone(),
+                                );
+                                vec_conj[r] = Complex::<T>::new(
+                                    (&self.eigenvectors.as_ref()).unwrap()[(r, c)].clone(),
+                                    (&self.eigenvectors.as_ref()).unwrap()[(r, c + 1)].clone(),
+                                );
                             }
-    
+
                             eigenvectors.as_mut().unwrap().push(vec);
                             eigenvectors.as_mut().unwrap().push(vec_conj);
                         }
 
                         if left_eigenvectors.is_some() {
-                            let mut vec = OVector::<Complex<T>, D>::zeros_generic(number_of_elements, Const::<1>);
-                            let mut vec_conj = OVector::<Complex<T>, D>::zeros_generic(number_of_elements, Const::<1>);
+                            let mut vec = OVector::<Complex<T>, D>::zeros_generic(
+                                number_of_elements,
+                                Const::<1>,
+                            );
+                            let mut vec_conj = OVector::<Complex<T>, D>::zeros_generic(
+                                number_of_elements,
+                                Const::<1>,
+                            );
 
                             for r in 0..number_of_elements_value {
-                                vec[r] = Complex::<T>::new((&self.left_eigenvectors.as_ref()).unwrap()[(r,c)].clone(),(&self.left_eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
-                                vec_conj[r] = Complex::<T>::new((&self.left_eigenvectors.as_ref()).unwrap()[(r,c)].clone(),(&self.left_eigenvectors.as_ref()).unwrap()[(r,c+1)].clone());
+                                vec[r] = Complex::<T>::new(
+                                    (&self.left_eigenvectors.as_ref()).unwrap()[(r, c)].clone(),
+                                    (&self.left_eigenvectors.as_ref()).unwrap()[(r, c + 1)].clone(),
+                                );
+                                vec_conj[r] = Complex::<T>::new(
+                                    (&self.left_eigenvectors.as_ref()).unwrap()[(r, c)].clone(),
+                                    (&self.left_eigenvectors.as_ref()).unwrap()[(r, c + 1)].clone(),
+                                );
                             }
-    
+
                             left_eigenvectors.as_mut().unwrap().push(vec);
                             left_eigenvectors.as_mut().unwrap().push(vec_conj);
                         }
                         //skip next entry
                         c += 1;
                     }
-                    c+=1;
+                    c += 1;
                 }
                 (Some(eigenvalues), left_eigenvectors, eigenvectors)
             }
         }
     }
-
 }
 
 /*
diff --git a/nalgebra-lapack/tests/linalg/cholesky.rs b/nalgebra-lapack/tests/linalg/cholesky.rs
index 632347b8..0bf74dd4 100644
--- a/nalgebra-lapack/tests/linalg/cholesky.rs
+++ b/nalgebra-lapack/tests/linalg/cholesky.rs
@@ -58,8 +58,8 @@ proptest! {
             let sol1 = chol.solve(&b1).unwrap();
             let sol2 = chol.solve(&b2).unwrap();
 
-            prop_assert!(relative_eq!(m * sol1, b1, epsilon = 1.0e-7));
-            prop_assert!(relative_eq!(m * sol2, b2, epsilon = 1.0e-7));
+            prop_assert!(relative_eq!(m * sol1, b1, epsilon = 1.0e-4));
+            prop_assert!(relative_eq!(m * sol2, b2, epsilon = 1.0e-4));
         }
     }
 
@@ -84,7 +84,7 @@ proptest! {
             let id1 = &m  * &m1;
             let id2 = &m1 * &m;
 
-            prop_assert!(id1.is_identity(1.0e-5) && id2.is_identity(1.0e-5))
+            prop_assert!(id1.is_identity(1.0e-4) && id2.is_identity(1.0e-4))
         }
     }
 }
diff --git a/nalgebra-lapack/tests/linalg/complex_eigen.rs b/nalgebra-lapack/tests/linalg/complex_eigen.rs
index 10869470..aa3474b9 100644
--- a/nalgebra-lapack/tests/linalg/complex_eigen.rs
+++ b/nalgebra-lapack/tests/linalg/complex_eigen.rs
@@ -1,19 +1,47 @@
-use std::cmp;
-
-use na::{Matrix3};
+use na::Matrix3;
 use nalgebra_lapack::Eigen;
+use num_complex::Complex;
 
-use crate::proptest::*;
-use proptest::{prop_assert, proptest};
+#[test]
+fn complex_eigen() {
+    let m = Matrix3::<f64>::new(
+        4.0 / 5.0,
+        -3.0 / 5.0,
+        0.0,
+        3.0 / 5.0,
+        4.0 / 5.0,
+        0.0,
+        1.0,
+        2.0,
+        2.0,
+    );
+    let eigen = Eigen::new(m, true, true).expect("Eigen Creation Failed!");
+    let (some_eigenvalues, some_left_vec, some_right_vec) = eigen.get_complex_elements();
+    let eigenvalues = some_eigenvalues.expect("Eigenvalues Failed");
+    let _left_eigenvectors = some_left_vec.expect("Left Eigenvectors Failed");
+    let eigenvectors = some_right_vec.expect("Right Eigenvectors Failed");
 
-proptest! {
-    //#[test]
-    // fn complex_eigen() {
-    //     let n = cmp::max(1, cmp::min(n, 10));
-    //     let m = DMatrix::<f64>::new_random(n, n);
-    //     let eig = SymmetricEigen::new(m.clone());
-    //     let recomp = eig.recompose();
-    //     prop_assert!(relative_eq!(m.lower_triangle(), recomp.lower_triangle(), epsilon = 1.0e-5))
-    // }
+    assert_relative_eq!(
+        eigenvalues[0].re,
+        Complex::<f64>::new(4.0 / 5.0, 3.0 / 5.0).re
+    );
+    assert_relative_eq!(
+        eigenvalues[0].im,
+        Complex::<f64>::new(4.0 / 5.0, 3.0 / 5.0).im
+    );
+    assert_relative_eq!(
+        eigenvalues[1].re,
+        Complex::<f64>::new(4.0 / 5.0, -3.0 / 5.0).re
+    );
+    assert_relative_eq!(
+        eigenvalues[1].im,
+        Complex::<f64>::new(4.0 / 5.0, -3.0 / 5.0).im
+    );
 
+    assert_relative_eq!(eigenvectors[0][0].re, -12.0 / 32.7871926215100059134410999);
+    assert_relative_eq!(eigenvectors[0][0].im, -9.0 / 32.7871926215100059134410999);
+    assert_relative_eq!(eigenvectors[0][1].re, -9.0 / 32.7871926215100059134410999);
+    assert_relative_eq!(eigenvectors[0][1].im, 12.0 / 32.7871926215100059134410999);
+    assert_relative_eq!(eigenvectors[0][2].re, 25.0 / 32.7871926215100059134410999);
+    assert_relative_eq!(eigenvectors[0][2].im, 0.0);
 }
diff --git a/nalgebra-lapack/tests/linalg/lu.rs b/nalgebra-lapack/tests/linalg/lu.rs
index 9665964e..b9d45208 100644
--- a/nalgebra-lapack/tests/linalg/lu.rs
+++ b/nalgebra-lapack/tests/linalg/lu.rs
@@ -51,10 +51,10 @@ proptest! {
         let tr_sol1 = lup.solve_transpose(&b1).unwrap();
         let tr_sol2 = lup.solve_transpose(&b2).unwrap();
 
-        prop_assert!(relative_eq!(&m * sol1, b1, epsilon = 1.0e-7));
-        prop_assert!(relative_eq!(&m * sol2, b2, epsilon = 1.0e-7));
-        prop_assert!(relative_eq!(m.transpose() * tr_sol1, b1, epsilon = 1.0e-7));
-        prop_assert!(relative_eq!(m.transpose() * tr_sol2, b2, epsilon = 1.0e-7));
+        prop_assert!(relative_eq!(&m * sol1, b1, epsilon = 1.0e-5));
+        prop_assert!(relative_eq!(&m * sol2, b2, epsilon = 1.0e-5));
+        prop_assert!(relative_eq!(m.transpose() * tr_sol1, b1, epsilon = 1.0e-5));
+        prop_assert!(relative_eq!(m.transpose() * tr_sol2, b2, epsilon = 1.0e-5));
     }
 
     #[test]
@@ -68,10 +68,10 @@ proptest! {
         let tr_sol1 = lup.solve_transpose(&b1).unwrap();
         let tr_sol2 = lup.solve_transpose(&b2).unwrap();
 
-        prop_assert!(relative_eq!(m * sol1, b1, epsilon = 1.0e-7));
-        prop_assert!(relative_eq!(m * sol2, b2, epsilon = 1.0e-7));
-        prop_assert!(relative_eq!(m.transpose() * tr_sol1, b1, epsilon = 1.0e-7));
-        prop_assert!(relative_eq!(m.transpose() * tr_sol2, b2, epsilon = 1.0e-7));
+        prop_assert!(relative_eq!(m * sol1, b1, epsilon = 1.0e-5));
+        prop_assert!(relative_eq!(m * sol2, b2, epsilon = 1.0e-5));
+        prop_assert!(relative_eq!(m.transpose() * tr_sol1, b1, epsilon = 1.0e-5));
+        prop_assert!(relative_eq!(m.transpose() * tr_sol2, b2, epsilon = 1.0e-5));
     }
 
     #[test]
diff --git a/nalgebra-lapack/tests/linalg/mod.rs b/nalgebra-lapack/tests/linalg/mod.rs
index 8fc8deeb..92425293 100644
--- a/nalgebra-lapack/tests/linalg/mod.rs
+++ b/nalgebra-lapack/tests/linalg/mod.rs
@@ -1,4 +1,5 @@
 mod cholesky;
+mod complex_eigen;
 mod generalized_eigenvalues;
 mod lu;
 mod qr;
@@ -7,4 +8,3 @@ mod real_eigensystem;
 mod schur;
 mod svd;
 mod symmetric_eigen;
-mod complex_eigen;
diff --git a/nalgebra-lapack/tests/linalg/real_eigensystem.rs b/nalgebra-lapack/tests/linalg/real_eigensystem.rs
index 3d1c91eb..599d1b2a 100644
--- a/nalgebra-lapack/tests/linalg/real_eigensystem.rs
+++ b/nalgebra-lapack/tests/linalg/real_eigensystem.rs
@@ -13,30 +13,36 @@ proptest! {
         let m = DMatrix::<f64>::new_random(n, n);
 
         if let Some(eig) = Eigen::new(m.clone(), true, true) {
-            let eigvals                = DMatrix::from_diagonal(&eig.eigenvalues);
-            let transformed_eigvectors = &m * eig.eigenvectors.as_ref().unwrap();
-            let scaled_eigvectors      = eig.eigenvectors.as_ref().unwrap() * &eigvals;
+            // TODO: test the complex case too.
+            if eig.eigenvalues_are_real() {
+                let eigvals                = DMatrix::from_diagonal(&eig.eigenvalues_re);
+                let transformed_eigvectors = &m * eig.eigenvectors.as_ref().unwrap();
+                let scaled_eigvectors      = eig.eigenvectors.as_ref().unwrap() * &eigvals;
 
-            let transformed_left_eigvectors = m.transpose() * eig.left_eigenvectors.as_ref().unwrap();
-            let scaled_left_eigvectors      = eig.left_eigenvectors.as_ref().unwrap() * &eigvals;
+                let transformed_left_eigvectors = m.transpose() * eig.left_eigenvectors.as_ref().unwrap();
+                let scaled_left_eigvectors      = eig.left_eigenvectors.as_ref().unwrap() * &eigvals;
 
-            prop_assert!(relative_eq!(transformed_eigvectors, scaled_eigvectors, epsilon = 1.0e-7));
-            prop_assert!(relative_eq!(transformed_left_eigvectors, scaled_left_eigvectors, epsilon = 1.0e-7));
+                prop_assert!(relative_eq!(transformed_eigvectors, scaled_eigvectors, epsilon = 1.0e-5));
+                prop_assert!(relative_eq!(transformed_left_eigvectors, scaled_left_eigvectors, epsilon = 1.0e-5));
+            }
         }
     }
 
     #[test]
     fn eigensystem_static(m in matrix4()) {
         if let Some(eig) = Eigen::new(m, true, true) {
-            let eigvals                = Matrix4::from_diagonal(&eig.eigenvalues);
-            let transformed_eigvectors = m * eig.eigenvectors.unwrap();
-            let scaled_eigvectors      = eig.eigenvectors.unwrap() * eigvals;
+            // TODO: test the complex case too.
+            if eig.eigenvalues_are_real() {
+                let eigvals                = Matrix4::from_diagonal(&eig.eigenvalues_re);
+                let transformed_eigvectors = m * eig.eigenvectors.unwrap();
+                let scaled_eigvectors      = eig.eigenvectors.unwrap() * eigvals;
 
-            let transformed_left_eigvectors = m.transpose() * eig.left_eigenvectors.unwrap();
-            let scaled_left_eigvectors      = eig.left_eigenvectors.unwrap() * eigvals;
+                let transformed_left_eigvectors = m.transpose() * eig.left_eigenvectors.unwrap();
+                let scaled_left_eigvectors      = eig.left_eigenvectors.unwrap() * eigvals;
 
-            prop_assert!(relative_eq!(transformed_eigvectors, scaled_eigvectors, epsilon = 1.0e-7));
-            prop_assert!(relative_eq!(transformed_left_eigvectors, scaled_left_eigvectors, epsilon = 1.0e-7));
+                prop_assert!(relative_eq!(transformed_eigvectors, scaled_eigvectors, epsilon = 1.0e-5));
+                prop_assert!(relative_eq!(transformed_left_eigvectors, scaled_left_eigvectors, epsilon = 1.0e-5));
+            }
         }
     }
 }
diff --git a/nalgebra-lapack/tests/linalg/schur.rs b/nalgebra-lapack/tests/linalg/schur.rs
index 0fd1cc33..ee7bad90 100644
--- a/nalgebra-lapack/tests/linalg/schur.rs
+++ b/nalgebra-lapack/tests/linalg/schur.rs
@@ -11,14 +11,17 @@ proptest! {
         let n = cmp::max(1, cmp::min(n, 10));
         let m = DMatrix::<f64>::new_random(n, n);
 
-        let (vecs, vals) = Schur::new(m.clone()).unpack();
-
-        prop_assert!(relative_eq!(&vecs * vals * vecs.transpose(), m, epsilon = 1.0e-7))
+        if let Some(schur) = Schur::try_new(m.clone()) {
+            let (vecs, vals) = schur.unpack();
+            prop_assert!(relative_eq!(&vecs * vals * vecs.transpose(), m, epsilon = 1.0e-5))
+        }
     }
 
     #[test]
     fn schur_static(m in matrix4()) {
-        let (vecs, vals) = Schur::new(m.clone()).unpack();
-        prop_assert!(relative_eq!(vecs * vals * vecs.transpose(), m, epsilon = 1.0e-7))
+        if let Some(schur) = Schur::try_new(m.clone()) {
+            let (vecs, vals) = schur.unpack();
+            prop_assert!(relative_eq!(vecs * vals * vecs.transpose(), m, epsilon = 1.0e-5))
+        }
     }
 }

From 24e85b9883e1bd4793dc9be327e5972a4934e0a0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sun, 30 Oct 2022 17:22:46 +0100
Subject: [PATCH 61/91] Reset nalgebra-lapack cargo.toml to its previous
 defaults

---
 nalgebra-lapack/Cargo.toml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/nalgebra-lapack/Cargo.toml b/nalgebra-lapack/Cargo.toml
index 3f165f76..16baf4b7 100644
--- a/nalgebra-lapack/Cargo.toml
+++ b/nalgebra-lapack/Cargo.toml
@@ -22,7 +22,7 @@ proptest-support = [ "nalgebra/proptest-support" ]
 arbitrary        = [ "nalgebra/arbitrary" ]
 
 # For BLAS/LAPACK
-default    = ["openblas"]
+default    = ["netlib"]
 openblas   = ["lapack-src/openblas"]
 netlib     = ["lapack-src/netlib"]
 accelerate = ["lapack-src/accelerate"]
@@ -36,7 +36,6 @@ simba         = "0.7"
 serde         = { version = "1.0", features = [ "derive" ], optional = true }
 lapack        = { version = "0.19", default-features = false }
 lapack-src    = { version = "0.8", default-features = false }
-openblas-src = {version = "*", features = ["static"]}
 # clippy = "*"
 
 [dev-dependencies]

From 1eb5cc2851289011b6411f8c74aa7c7178563c51 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sun, 30 Oct 2022 17:41:21 +0100
Subject: [PATCH 62/91] Release v0.31.3

---
 CHANGELOG.md | 9 +++++++++
 Cargo.toml   | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e035e084..ac297f20 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,15 @@ documented here.
 
 This project adheres to [Semantic Versioning](https://semver.org/).
 
+
+## [0.31.3] (30 Oct. 2022)
+
+### Added
+- Add `Matrix::try_cast` to attempt casting the inner scalar types when that cast may fail.
+
+### Fixed
+- Fixed the usage of `CheckBytes` with `rkyv`.
+
 ## [0.31.2] (09 Oct. 2022)
 
 ### Modified
diff --git a/Cargo.toml b/Cargo.toml
index 4bd1e12f..746b62b3 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name    = "nalgebra"
-version = "0.31.2"
+version = "0.31.3"
 authors = [ "Sébastien Crozet <developer@crozet.re>" ]
 
 description = "General-purpose linear algebra library with transformations and statically-sized or dynamically-sized matrices."

From 79c85ac4be57103c1aae7780aa0cc699d99205f7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sun, 30 Oct 2022 17:42:59 +0100
Subject: [PATCH 63/91] Release nalgebra-lapack v0.23

---
 nalgebra-lapack/Cargo.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nalgebra-lapack/Cargo.toml b/nalgebra-lapack/Cargo.toml
index 16baf4b7..af86224a 100644
--- a/nalgebra-lapack/Cargo.toml
+++ b/nalgebra-lapack/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name    = "nalgebra-lapack"
-version = "0.22.0"
+version = "0.23.0"
 authors = [ "Sébastien Crozet <developer@crozet.re>", "Andrew Straw <strawman@astraw.com>" ]
 
 description   = "Matrix decompositions using nalgebra matrices and Lapack bindings."

From fd644d914a2af8b120a71f416cce190efb2a65c1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sun, 30 Oct 2022 17:43:24 +0100
Subject: [PATCH 64/91] Release nalgebra-sparse v0.8

---
 nalgebra-sparse/Cargo.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nalgebra-sparse/Cargo.toml b/nalgebra-sparse/Cargo.toml
index b9c343e4..fc95ddad 100644
--- a/nalgebra-sparse/Cargo.toml
+++ b/nalgebra-sparse/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "nalgebra-sparse"
-version = "0.7.1"
+version = "0.8.0"
 authors = [ "Andreas Longva", "Sébastien Crozet <developer@crozet.re>" ]
 edition = "2018"
 description = "Sparse matrix computation based on nalgebra."

From 20dbfbd6f9fcaec47fca3b847994e6889d244bcf Mon Sep 17 00:00:00 2001
From: Allan Zhang <al@ayz.ai>
Date: Fri, 4 Nov 2022 09:32:01 -0400
Subject: [PATCH 65/91] Use parenthesis for exclusive lower bound

Changes `]0, pi]` to `(0, pi]`.

Replaces PR #1173 and resolves Issue #1164.
---
 src/geometry/quaternion.rs              | 2 +-
 src/geometry/rotation_specialization.rs | 2 +-
 src/geometry/unit_complex.rs            | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/geometry/quaternion.rs b/src/geometry/quaternion.rs
index 53da24e3..293ab125 100755
--- a/src/geometry/quaternion.rs
+++ b/src/geometry/quaternion.rs
@@ -1323,7 +1323,7 @@ where
         }
     }
 
-    /// The rotation axis and angle in ]0, pi] of this unit quaternion.
+    /// The rotation axis and angle in (0, pi] of this unit quaternion.
     ///
     /// Returns `None` if the angle is zero.
     ///
diff --git a/src/geometry/rotation_specialization.rs b/src/geometry/rotation_specialization.rs
index c9197fd6..bba92512 100644
--- a/src/geometry/rotation_specialization.rs
+++ b/src/geometry/rotation_specialization.rs
@@ -877,7 +877,7 @@ impl<T: SimdRealField> Rotation3<T> {
         }
     }
 
-    /// The rotation axis and angle in ]0, pi] of this rotation matrix.
+    /// The rotation axis and angle in (0, pi] of this rotation matrix.
     ///
     /// Returns `None` if the angle is zero.
     ///
diff --git a/src/geometry/unit_complex.rs b/src/geometry/unit_complex.rs
index efe0dac2..8e44f71a 100755
--- a/src/geometry/unit_complex.rs
+++ b/src/geometry/unit_complex.rs
@@ -132,7 +132,7 @@ where
         Vector1::new(self.angle())
     }
 
-    /// The rotation axis and angle in ]0, pi] of this complex number.
+    /// The rotation axis and angle in (0, pi] of this complex number.
     ///
     /// This is generally used in the context of generic programming. Using
     /// the `.angle()` method instead is more common.

From 8601c655de48e98bebe499c7009cbb189a1982ca Mon Sep 17 00:00:00 2001
From: devil-ira <justthecooldude@gmail.com>
Date: Sat, 5 Nov 2022 00:33:38 +0100
Subject: [PATCH 66/91] Support conversion for glam 0.22

---
 Cargo.toml                       |  2 ++
 src/third_party/glam/mod.rs      |  2 ++
 src/third_party/glam/v022/mod.rs | 18 ++++++++++++++++++
 3 files changed, 22 insertions(+)
 create mode 100644 src/third_party/glam/v022/mod.rs

diff --git a/Cargo.toml b/Cargo.toml
index 746b62b3..bcfa07d2 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -45,6 +45,7 @@ convert-glam018 = [ "glam018" ]
 convert-glam019 = [ "glam019" ]
 convert-glam020 = [ "glam020" ]
 convert-glam021 = [ "glam021" ]
+convert-glam022 = [ "glam022" ]
 
 # Serialization
 ## To use serde in a #[no-std] environment, enable the
@@ -98,6 +99,7 @@ glam018        = { package = "glam", version = "0.18", optional = true }
 glam019        = { package = "glam", version = "0.19", optional = true }
 glam020        = { package = "glam", version = "0.20", optional = true }
 glam021        = { package = "glam", version = "0.21", optional = true }
+glam022        = { package = "glam", version = "0.22", optional = true }
 cust_core      = { version = "0.1", optional = true }
 
 
diff --git a/src/third_party/glam/mod.rs b/src/third_party/glam/mod.rs
index 06bdcfb7..811e88b2 100644
--- a/src/third_party/glam/mod.rs
+++ b/src/third_party/glam/mod.rs
@@ -14,3 +14,5 @@ mod v019;
 mod v020;
 #[cfg(feature = "glam021")]
 mod v021;
+#[cfg(feature = "glam022")]
+mod v022;
diff --git a/src/third_party/glam/v022/mod.rs b/src/third_party/glam/v022/mod.rs
new file mode 100644
index 00000000..de27f929
--- /dev/null
+++ b/src/third_party/glam/v022/mod.rs
@@ -0,0 +1,18 @@
+#[path = "../common/glam_isometry.rs"]
+mod glam_isometry;
+#[path = "../common/glam_matrix.rs"]
+mod glam_matrix;
+#[path = "../common/glam_point.rs"]
+mod glam_point;
+#[path = "../common/glam_quaternion.rs"]
+mod glam_quaternion;
+#[path = "../common/glam_rotation.rs"]
+mod glam_rotation;
+#[path = "../common/glam_similarity.rs"]
+mod glam_similarity;
+#[path = "../common/glam_translation.rs"]
+mod glam_translation;
+#[path = "../common/glam_unit_complex.rs"]
+mod glam_unit_complex;
+
+pub(self) use glam022 as glam;

From c8dfb5e348432508d6c8bd58bfe3fd7ab0290e1a Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Fri, 11 Nov 2022 15:46:04 +0100
Subject: [PATCH 67/91] Rename SliceStorage(Mut) to ViewStorage(Mut)

Additionally, we add type aliases with the old names to maintain
backwards compatibility with deprecation warnings.
---
 src/base/alias_slice.rs        | 242 ++++++++++++++++-----------------
 src/base/construction_slice.rs |   6 +-
 src/base/conversion.rs         |   8 +-
 src/base/indexing.rs           |   8 +-
 src/base/matrix_slice.rs       |  89 ++++++------
 5 files changed, 182 insertions(+), 171 deletions(-)

diff --git a/src/base/alias_slice.rs b/src/base/alias_slice.rs
index 929d2f03..21cde51c 100644
--- a/src/base/alias_slice.rs
+++ b/src/base/alias_slice.rs
@@ -1,5 +1,5 @@
 use crate::base::dimension::{Dynamic, U1, U2, U3, U4, U5, U6};
-use crate::base::matrix_slice::{SliceStorage, SliceStorageMut};
+use crate::base::matrix_slice::{ViewStorage, ViewStorageMut};
 use crate::base::{Const, Matrix};
 
 /*
@@ -14,285 +14,285 @@ use crate::base::{Const, Matrix};
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type SMatrixSlice<'a, T, const R: usize, const C: usize> =
-    Matrix<T, Const<R>, Const<C>, SliceStorage<'a, T, Const<R>, Const<C>, Const<1>, Const<R>>>;
+    Matrix<T, Const<R>, Const<C>, ViewStorage<'a, T, Const<R>, Const<C>, Const<1>, Const<R>>>;
 
 /// A column-major matrix slice dynamic numbers of rows and columns.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type DMatrixSlice<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, Dynamic, SliceStorage<'a, T, Dynamic, Dynamic, RStride, CStride>>;
+    Matrix<T, Dynamic, Dynamic, ViewStorage<'a, T, Dynamic, Dynamic, RStride, CStride>>;
 
 /// A column-major 1x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice1<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U1, SliceStorage<'a, T, U1, U1, RStride, CStride>>;
+    Matrix<T, U1, U1, ViewStorage<'a, T, U1, U1, RStride, CStride>>;
 /// A column-major 2x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice2<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U2, SliceStorage<'a, T, U2, U2, RStride, CStride>>;
+    Matrix<T, U2, U2, ViewStorage<'a, T, U2, U2, RStride, CStride>>;
 /// A column-major 3x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice3<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U3, SliceStorage<'a, T, U3, U3, RStride, CStride>>;
+    Matrix<T, U3, U3, ViewStorage<'a, T, U3, U3, RStride, CStride>>;
 /// A column-major 4x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice4<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U4, SliceStorage<'a, T, U4, U4, RStride, CStride>>;
+    Matrix<T, U4, U4, ViewStorage<'a, T, U4, U4, RStride, CStride>>;
 /// A column-major 5x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice5<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U5, SliceStorage<'a, T, U5, U5, RStride, CStride>>;
+    Matrix<T, U5, U5, ViewStorage<'a, T, U5, U5, RStride, CStride>>;
 /// A column-major 6x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice6<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U6, SliceStorage<'a, T, U6, U6, RStride, CStride>>;
+    Matrix<T, U6, U6, ViewStorage<'a, T, U6, U6, RStride, CStride>>;
 
 /// A column-major 1x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice1x2<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U2, SliceStorage<'a, T, U1, U2, RStride, CStride>>;
+    Matrix<T, U1, U2, ViewStorage<'a, T, U1, U2, RStride, CStride>>;
 /// A column-major 1x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice1x3<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U3, SliceStorage<'a, T, U1, U3, RStride, CStride>>;
+    Matrix<T, U1, U3, ViewStorage<'a, T, U1, U3, RStride, CStride>>;
 /// A column-major 1x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice1x4<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U4, SliceStorage<'a, T, U1, U4, RStride, CStride>>;
+    Matrix<T, U1, U4, ViewStorage<'a, T, U1, U4, RStride, CStride>>;
 /// A column-major 1x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice1x5<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U5, SliceStorage<'a, T, U1, U5, RStride, CStride>>;
+    Matrix<T, U1, U5, ViewStorage<'a, T, U1, U5, RStride, CStride>>;
 /// A column-major 1x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice1x6<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U6, SliceStorage<'a, T, U1, U6, RStride, CStride>>;
+    Matrix<T, U1, U6, ViewStorage<'a, T, U1, U6, RStride, CStride>>;
 
 /// A column-major 2x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice2x1<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U1, SliceStorage<'a, T, U2, U1, RStride, CStride>>;
+    Matrix<T, U2, U1, ViewStorage<'a, T, U2, U1, RStride, CStride>>;
 /// A column-major 2x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice2x3<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U3, SliceStorage<'a, T, U2, U3, RStride, CStride>>;
+    Matrix<T, U2, U3, ViewStorage<'a, T, U2, U3, RStride, CStride>>;
 /// A column-major 2x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice2x4<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U4, SliceStorage<'a, T, U2, U4, RStride, CStride>>;
+    Matrix<T, U2, U4, ViewStorage<'a, T, U2, U4, RStride, CStride>>;
 /// A column-major 2x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice2x5<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U5, SliceStorage<'a, T, U2, U5, RStride, CStride>>;
+    Matrix<T, U2, U5, ViewStorage<'a, T, U2, U5, RStride, CStride>>;
 /// A column-major 2x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice2x6<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U6, SliceStorage<'a, T, U2, U6, RStride, CStride>>;
+    Matrix<T, U2, U6, ViewStorage<'a, T, U2, U6, RStride, CStride>>;
 
 /// A column-major 3x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice3x1<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U1, SliceStorage<'a, T, U3, U1, RStride, CStride>>;
+    Matrix<T, U3, U1, ViewStorage<'a, T, U3, U1, RStride, CStride>>;
 /// A column-major 3x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice3x2<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U2, SliceStorage<'a, T, U3, U2, RStride, CStride>>;
+    Matrix<T, U3, U2, ViewStorage<'a, T, U3, U2, RStride, CStride>>;
 /// A column-major 3x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice3x4<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U4, SliceStorage<'a, T, U3, U4, RStride, CStride>>;
+    Matrix<T, U3, U4, ViewStorage<'a, T, U3, U4, RStride, CStride>>;
 /// A column-major 3x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice3x5<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U5, SliceStorage<'a, T, U3, U5, RStride, CStride>>;
+    Matrix<T, U3, U5, ViewStorage<'a, T, U3, U5, RStride, CStride>>;
 /// A column-major 3x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice3x6<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U6, SliceStorage<'a, T, U3, U6, RStride, CStride>>;
+    Matrix<T, U3, U6, ViewStorage<'a, T, U3, U6, RStride, CStride>>;
 
 /// A column-major 4x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice4x1<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U1, SliceStorage<'a, T, U4, U1, RStride, CStride>>;
+    Matrix<T, U4, U1, ViewStorage<'a, T, U4, U1, RStride, CStride>>;
 /// A column-major 4x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice4x2<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U2, SliceStorage<'a, T, U4, U2, RStride, CStride>>;
+    Matrix<T, U4, U2, ViewStorage<'a, T, U4, U2, RStride, CStride>>;
 /// A column-major 4x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice4x3<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U3, SliceStorage<'a, T, U4, U3, RStride, CStride>>;
+    Matrix<T, U4, U3, ViewStorage<'a, T, U4, U3, RStride, CStride>>;
 /// A column-major 4x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice4x5<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U5, SliceStorage<'a, T, U4, U5, RStride, CStride>>;
+    Matrix<T, U4, U5, ViewStorage<'a, T, U4, U5, RStride, CStride>>;
 /// A column-major 4x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice4x6<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U6, SliceStorage<'a, T, U4, U6, RStride, CStride>>;
+    Matrix<T, U4, U6, ViewStorage<'a, T, U4, U6, RStride, CStride>>;
 
 /// A column-major 5x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice5x1<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U1, SliceStorage<'a, T, U5, U1, RStride, CStride>>;
+    Matrix<T, U5, U1, ViewStorage<'a, T, U5, U1, RStride, CStride>>;
 /// A column-major 5x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice5x2<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U2, SliceStorage<'a, T, U5, U2, RStride, CStride>>;
+    Matrix<T, U5, U2, ViewStorage<'a, T, U5, U2, RStride, CStride>>;
 /// A column-major 5x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice5x3<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U3, SliceStorage<'a, T, U5, U3, RStride, CStride>>;
+    Matrix<T, U5, U3, ViewStorage<'a, T, U5, U3, RStride, CStride>>;
 /// A column-major 5x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice5x4<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U4, SliceStorage<'a, T, U5, U4, RStride, CStride>>;
+    Matrix<T, U5, U4, ViewStorage<'a, T, U5, U4, RStride, CStride>>;
 /// A column-major 5x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice5x6<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U6, SliceStorage<'a, T, U5, U6, RStride, CStride>>;
+    Matrix<T, U5, U6, ViewStorage<'a, T, U5, U6, RStride, CStride>>;
 
 /// A column-major 6x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice6x1<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U1, SliceStorage<'a, T, U6, U1, RStride, CStride>>;
+    Matrix<T, U6, U1, ViewStorage<'a, T, U6, U1, RStride, CStride>>;
 /// A column-major 6x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice6x2<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U2, SliceStorage<'a, T, U6, U2, RStride, CStride>>;
+    Matrix<T, U6, U2, ViewStorage<'a, T, U6, U2, RStride, CStride>>;
 /// A column-major 6x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice6x3<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U3, SliceStorage<'a, T, U6, U3, RStride, CStride>>;
+    Matrix<T, U6, U3, ViewStorage<'a, T, U6, U3, RStride, CStride>>;
 /// A column-major 6x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice6x4<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U4, SliceStorage<'a, T, U6, U4, RStride, CStride>>;
+    Matrix<T, U6, U4, ViewStorage<'a, T, U6, U4, RStride, CStride>>;
 /// A column-major 6x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSlice6x5<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U5, SliceStorage<'a, T, U6, U5, RStride, CStride>>;
+    Matrix<T, U6, U5, ViewStorage<'a, T, U6, U5, RStride, CStride>>;
 
 /// A column-major matrix slice with 1 row and a number of columns chosen at runtime.
 pub type MatrixSlice1xX<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, Dynamic, SliceStorage<'a, T, U1, Dynamic, RStride, CStride>>;
+    Matrix<T, U1, Dynamic, ViewStorage<'a, T, U1, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 2 rows and a number of columns chosen at runtime.
 pub type MatrixSlice2xX<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, Dynamic, SliceStorage<'a, T, U2, Dynamic, RStride, CStride>>;
+    Matrix<T, U2, Dynamic, ViewStorage<'a, T, U2, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 3 rows and a number of columns chosen at runtime.
 pub type MatrixSlice3xX<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, Dynamic, SliceStorage<'a, T, U3, Dynamic, RStride, CStride>>;
+    Matrix<T, U3, Dynamic, ViewStorage<'a, T, U3, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 4 rows and a number of columns chosen at runtime.
 pub type MatrixSlice4xX<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, Dynamic, SliceStorage<'a, T, U4, Dynamic, RStride, CStride>>;
+    Matrix<T, U4, Dynamic, ViewStorage<'a, T, U4, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 5 rows and a number of columns chosen at runtime.
 pub type MatrixSlice5xX<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, Dynamic, SliceStorage<'a, T, U5, Dynamic, RStride, CStride>>;
+    Matrix<T, U5, Dynamic, ViewStorage<'a, T, U5, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 6 rows and a number of columns chosen at runtime.
 pub type MatrixSlice6xX<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, Dynamic, SliceStorage<'a, T, U6, Dynamic, RStride, CStride>>;
+    Matrix<T, U6, Dynamic, ViewStorage<'a, T, U6, Dynamic, RStride, CStride>>;
 
 /// A column-major matrix slice with a number of rows chosen at runtime and 1 column.
 pub type MatrixSliceXx1<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U1, SliceStorage<'a, T, Dynamic, U1, RStride, CStride>>;
+    Matrix<T, Dynamic, U1, ViewStorage<'a, T, Dynamic, U1, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 2 columns.
 pub type MatrixSliceXx2<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U2, SliceStorage<'a, T, Dynamic, U2, RStride, CStride>>;
+    Matrix<T, Dynamic, U2, ViewStorage<'a, T, Dynamic, U2, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 3 columns.
 pub type MatrixSliceXx3<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U3, SliceStorage<'a, T, Dynamic, U3, RStride, CStride>>;
+    Matrix<T, Dynamic, U3, ViewStorage<'a, T, Dynamic, U3, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 4 columns.
 pub type MatrixSliceXx4<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U4, SliceStorage<'a, T, Dynamic, U4, RStride, CStride>>;
+    Matrix<T, Dynamic, U4, ViewStorage<'a, T, Dynamic, U4, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 5 columns.
 pub type MatrixSliceXx5<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U5, SliceStorage<'a, T, Dynamic, U5, RStride, CStride>>;
+    Matrix<T, Dynamic, U5, ViewStorage<'a, T, Dynamic, U5, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 6 columns.
 pub type MatrixSliceXx6<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U6, SliceStorage<'a, T, Dynamic, U6, RStride, CStride>>;
+    Matrix<T, Dynamic, U6, ViewStorage<'a, T, Dynamic, U6, RStride, CStride>>;
 
 /// A column vector slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSlice<'a, T, D, RStride = U1, CStride = D> =
-    Matrix<T, D, U1, SliceStorage<'a, T, D, U1, RStride, CStride>>;
+    Matrix<T, D, U1, ViewStorage<'a, T, D, U1, RStride, CStride>>;
 
 /// A column vector slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type SVectorSlice<'a, T, const D: usize> =
-    Matrix<T, Const<D>, Const<1>, SliceStorage<'a, T, Const<D>, Const<1>, Const<1>, Const<D>>>;
+    Matrix<T, Const<D>, Const<1>, ViewStorage<'a, T, Const<D>, Const<1>, Const<1>, Const<D>>>;
 
 /// A column vector slice dynamic numbers of rows and columns.
 pub type DVectorSlice<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U1, SliceStorage<'a, T, Dynamic, U1, RStride, CStride>>;
+    Matrix<T, Dynamic, U1, ViewStorage<'a, T, Dynamic, U1, RStride, CStride>>;
 
 /// A 1D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSlice1<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U1, SliceStorage<'a, T, U1, U1, RStride, CStride>>;
+    Matrix<T, U1, U1, ViewStorage<'a, T, U1, U1, RStride, CStride>>;
 /// A 2D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSlice2<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U1, SliceStorage<'a, T, U2, U1, RStride, CStride>>;
+    Matrix<T, U2, U1, ViewStorage<'a, T, U2, U1, RStride, CStride>>;
 /// A 3D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSlice3<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U1, SliceStorage<'a, T, U3, U1, RStride, CStride>>;
+    Matrix<T, U3, U1, ViewStorage<'a, T, U3, U1, RStride, CStride>>;
 /// A 4D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSlice4<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U1, SliceStorage<'a, T, U4, U1, RStride, CStride>>;
+    Matrix<T, U4, U1, ViewStorage<'a, T, U4, U1, RStride, CStride>>;
 /// A 5D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSlice5<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U1, SliceStorage<'a, T, U5, U1, RStride, CStride>>;
+    Matrix<T, U5, U1, ViewStorage<'a, T, U5, U1, RStride, CStride>>;
 /// A 6D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSlice6<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U1, SliceStorage<'a, T, U6, U1, RStride, CStride>>;
+    Matrix<T, U6, U1, ViewStorage<'a, T, U6, U1, RStride, CStride>>;
 
 /*
  *
@@ -305,296 +305,296 @@ pub type VectorSlice6<'a, T, RStride = U1, CStride = U6> =
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMutMN<'a, T, R, C, RStride = U1, CStride = R> =
-    Matrix<T, R, C, SliceStorageMut<'a, T, R, C, RStride, CStride>>;
+    Matrix<T, R, C, ViewStorageMut<'a, T, R, C, RStride, CStride>>;
 
 /// A column-major matrix slice with `D` rows and columns.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMutN<'a, T, D, RStride = U1, CStride = D> =
-    Matrix<T, D, D, SliceStorageMut<'a, T, D, D, RStride, CStride>>;
+    Matrix<T, D, D, ViewStorageMut<'a, T, D, D, RStride, CStride>>;
 
 /// A column-major matrix slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type SMatrixSliceMut<'a, T, const R: usize, const C: usize> =
-    Matrix<T, Const<R>, Const<C>, SliceStorageMut<'a, T, Const<R>, Const<C>, Const<1>, Const<R>>>;
+    Matrix<T, Const<R>, Const<C>, ViewStorageMut<'a, T, Const<R>, Const<C>, Const<1>, Const<R>>>;
 
 /// A column-major matrix slice dynamic numbers of rows and columns.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type DMatrixSliceMut<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, Dynamic, SliceStorageMut<'a, T, Dynamic, Dynamic, RStride, CStride>>;
+    Matrix<T, Dynamic, Dynamic, ViewStorageMut<'a, T, Dynamic, Dynamic, RStride, CStride>>;
 
 /// A column-major 1x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut1<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U1, SliceStorageMut<'a, T, U1, U1, RStride, CStride>>;
+    Matrix<T, U1, U1, ViewStorageMut<'a, T, U1, U1, RStride, CStride>>;
 /// A column-major 2x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut2<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U2, SliceStorageMut<'a, T, U2, U2, RStride, CStride>>;
+    Matrix<T, U2, U2, ViewStorageMut<'a, T, U2, U2, RStride, CStride>>;
 /// A column-major 3x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut3<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U3, SliceStorageMut<'a, T, U3, U3, RStride, CStride>>;
+    Matrix<T, U3, U3, ViewStorageMut<'a, T, U3, U3, RStride, CStride>>;
 /// A column-major 4x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut4<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U4, SliceStorageMut<'a, T, U4, U4, RStride, CStride>>;
+    Matrix<T, U4, U4, ViewStorageMut<'a, T, U4, U4, RStride, CStride>>;
 /// A column-major 5x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut5<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U5, SliceStorageMut<'a, T, U5, U5, RStride, CStride>>;
+    Matrix<T, U5, U5, ViewStorageMut<'a, T, U5, U5, RStride, CStride>>;
 /// A column-major 6x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut6<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U6, SliceStorageMut<'a, T, U6, U6, RStride, CStride>>;
+    Matrix<T, U6, U6, ViewStorageMut<'a, T, U6, U6, RStride, CStride>>;
 
 /// A column-major 1x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut1x2<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U2, SliceStorageMut<'a, T, U1, U2, RStride, CStride>>;
+    Matrix<T, U1, U2, ViewStorageMut<'a, T, U1, U2, RStride, CStride>>;
 /// A column-major 1x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut1x3<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U3, SliceStorageMut<'a, T, U1, U3, RStride, CStride>>;
+    Matrix<T, U1, U3, ViewStorageMut<'a, T, U1, U3, RStride, CStride>>;
 /// A column-major 1x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut1x4<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U4, SliceStorageMut<'a, T, U1, U4, RStride, CStride>>;
+    Matrix<T, U1, U4, ViewStorageMut<'a, T, U1, U4, RStride, CStride>>;
 /// A column-major 1x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut1x5<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U5, SliceStorageMut<'a, T, U1, U5, RStride, CStride>>;
+    Matrix<T, U1, U5, ViewStorageMut<'a, T, U1, U5, RStride, CStride>>;
 /// A column-major 1x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut1x6<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U6, SliceStorageMut<'a, T, U1, U6, RStride, CStride>>;
+    Matrix<T, U1, U6, ViewStorageMut<'a, T, U1, U6, RStride, CStride>>;
 
 /// A column-major 2x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut2x1<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U1, SliceStorageMut<'a, T, U2, U1, RStride, CStride>>;
+    Matrix<T, U2, U1, ViewStorageMut<'a, T, U2, U1, RStride, CStride>>;
 /// A column-major 2x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut2x3<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U3, SliceStorageMut<'a, T, U2, U3, RStride, CStride>>;
+    Matrix<T, U2, U3, ViewStorageMut<'a, T, U2, U3, RStride, CStride>>;
 /// A column-major 2x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut2x4<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U4, SliceStorageMut<'a, T, U2, U4, RStride, CStride>>;
+    Matrix<T, U2, U4, ViewStorageMut<'a, T, U2, U4, RStride, CStride>>;
 /// A column-major 2x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut2x5<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U5, SliceStorageMut<'a, T, U2, U5, RStride, CStride>>;
+    Matrix<T, U2, U5, ViewStorageMut<'a, T, U2, U5, RStride, CStride>>;
 /// A column-major 2x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut2x6<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U6, SliceStorageMut<'a, T, U2, U6, RStride, CStride>>;
+    Matrix<T, U2, U6, ViewStorageMut<'a, T, U2, U6, RStride, CStride>>;
 
 /// A column-major 3x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut3x1<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U1, SliceStorageMut<'a, T, U3, U1, RStride, CStride>>;
+    Matrix<T, U3, U1, ViewStorageMut<'a, T, U3, U1, RStride, CStride>>;
 /// A column-major 3x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut3x2<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U2, SliceStorageMut<'a, T, U3, U2, RStride, CStride>>;
+    Matrix<T, U3, U2, ViewStorageMut<'a, T, U3, U2, RStride, CStride>>;
 /// A column-major 3x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut3x4<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U4, SliceStorageMut<'a, T, U3, U4, RStride, CStride>>;
+    Matrix<T, U3, U4, ViewStorageMut<'a, T, U3, U4, RStride, CStride>>;
 /// A column-major 3x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut3x5<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U5, SliceStorageMut<'a, T, U3, U5, RStride, CStride>>;
+    Matrix<T, U3, U5, ViewStorageMut<'a, T, U3, U5, RStride, CStride>>;
 /// A column-major 3x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut3x6<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U6, SliceStorageMut<'a, T, U3, U6, RStride, CStride>>;
+    Matrix<T, U3, U6, ViewStorageMut<'a, T, U3, U6, RStride, CStride>>;
 
 /// A column-major 4x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut4x1<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U1, SliceStorageMut<'a, T, U4, U1, RStride, CStride>>;
+    Matrix<T, U4, U1, ViewStorageMut<'a, T, U4, U1, RStride, CStride>>;
 /// A column-major 4x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut4x2<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U2, SliceStorageMut<'a, T, U4, U2, RStride, CStride>>;
+    Matrix<T, U4, U2, ViewStorageMut<'a, T, U4, U2, RStride, CStride>>;
 /// A column-major 4x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut4x3<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U3, SliceStorageMut<'a, T, U4, U3, RStride, CStride>>;
+    Matrix<T, U4, U3, ViewStorageMut<'a, T, U4, U3, RStride, CStride>>;
 /// A column-major 4x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut4x5<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U5, SliceStorageMut<'a, T, U4, U5, RStride, CStride>>;
+    Matrix<T, U4, U5, ViewStorageMut<'a, T, U4, U5, RStride, CStride>>;
 /// A column-major 4x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut4x6<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U6, SliceStorageMut<'a, T, U4, U6, RStride, CStride>>;
+    Matrix<T, U4, U6, ViewStorageMut<'a, T, U4, U6, RStride, CStride>>;
 
 /// A column-major 5x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut5x1<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U1, SliceStorageMut<'a, T, U5, U1, RStride, CStride>>;
+    Matrix<T, U5, U1, ViewStorageMut<'a, T, U5, U1, RStride, CStride>>;
 /// A column-major 5x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut5x2<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U2, SliceStorageMut<'a, T, U5, U2, RStride, CStride>>;
+    Matrix<T, U5, U2, ViewStorageMut<'a, T, U5, U2, RStride, CStride>>;
 /// A column-major 5x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut5x3<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U3, SliceStorageMut<'a, T, U5, U3, RStride, CStride>>;
+    Matrix<T, U5, U3, ViewStorageMut<'a, T, U5, U3, RStride, CStride>>;
 /// A column-major 5x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut5x4<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U4, SliceStorageMut<'a, T, U5, U4, RStride, CStride>>;
+    Matrix<T, U5, U4, ViewStorageMut<'a, T, U5, U4, RStride, CStride>>;
 /// A column-major 5x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut5x6<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U6, SliceStorageMut<'a, T, U5, U6, RStride, CStride>>;
+    Matrix<T, U5, U6, ViewStorageMut<'a, T, U5, U6, RStride, CStride>>;
 
 /// A column-major 6x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut6x1<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U1, SliceStorageMut<'a, T, U6, U1, RStride, CStride>>;
+    Matrix<T, U6, U1, ViewStorageMut<'a, T, U6, U1, RStride, CStride>>;
 /// A column-major 6x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut6x2<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U2, SliceStorageMut<'a, T, U6, U2, RStride, CStride>>;
+    Matrix<T, U6, U2, ViewStorageMut<'a, T, U6, U2, RStride, CStride>>;
 /// A column-major 6x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut6x3<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U3, SliceStorageMut<'a, T, U6, U3, RStride, CStride>>;
+    Matrix<T, U6, U3, ViewStorageMut<'a, T, U6, U3, RStride, CStride>>;
 /// A column-major 6x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut6x4<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U4, SliceStorageMut<'a, T, U6, U4, RStride, CStride>>;
+    Matrix<T, U6, U4, ViewStorageMut<'a, T, U6, U4, RStride, CStride>>;
 /// A column-major 6x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type MatrixSliceMut6x5<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U5, SliceStorageMut<'a, T, U6, U5, RStride, CStride>>;
+    Matrix<T, U6, U5, ViewStorageMut<'a, T, U6, U5, RStride, CStride>>;
 
 /// A column-major matrix slice with 1 row and a number of columns chosen at runtime.
 pub type MatrixSliceMut1xX<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, Dynamic, SliceStorageMut<'a, T, U1, Dynamic, RStride, CStride>>;
+    Matrix<T, U1, Dynamic, ViewStorageMut<'a, T, U1, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 2 rows and a number of columns chosen at runtime.
 pub type MatrixSliceMut2xX<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, Dynamic, SliceStorageMut<'a, T, U2, Dynamic, RStride, CStride>>;
+    Matrix<T, U2, Dynamic, ViewStorageMut<'a, T, U2, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 3 rows and a number of columns chosen at runtime.
 pub type MatrixSliceMut3xX<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, Dynamic, SliceStorageMut<'a, T, U3, Dynamic, RStride, CStride>>;
+    Matrix<T, U3, Dynamic, ViewStorageMut<'a, T, U3, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 4 rows and a number of columns chosen at runtime.
 pub type MatrixSliceMut4xX<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, Dynamic, SliceStorageMut<'a, T, U4, Dynamic, RStride, CStride>>;
+    Matrix<T, U4, Dynamic, ViewStorageMut<'a, T, U4, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 5 rows and a number of columns chosen at runtime.
 pub type MatrixSliceMut5xX<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, Dynamic, SliceStorageMut<'a, T, U5, Dynamic, RStride, CStride>>;
+    Matrix<T, U5, Dynamic, ViewStorageMut<'a, T, U5, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 6 rows and a number of columns chosen at runtime.
 pub type MatrixSliceMut6xX<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, Dynamic, SliceStorageMut<'a, T, U6, Dynamic, RStride, CStride>>;
+    Matrix<T, U6, Dynamic, ViewStorageMut<'a, T, U6, Dynamic, RStride, CStride>>;
 
 /// A column-major matrix slice with a number of rows chosen at runtime and 1 column.
 pub type MatrixSliceMutXx1<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U1, SliceStorageMut<'a, T, Dynamic, U1, RStride, CStride>>;
+    Matrix<T, Dynamic, U1, ViewStorageMut<'a, T, Dynamic, U1, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 2 columns.
 pub type MatrixSliceMutXx2<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U2, SliceStorageMut<'a, T, Dynamic, U2, RStride, CStride>>;
+    Matrix<T, Dynamic, U2, ViewStorageMut<'a, T, Dynamic, U2, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 3 columns.
 pub type MatrixSliceMutXx3<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U3, SliceStorageMut<'a, T, Dynamic, U3, RStride, CStride>>;
+    Matrix<T, Dynamic, U3, ViewStorageMut<'a, T, Dynamic, U3, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 4 columns.
 pub type MatrixSliceMutXx4<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U4, SliceStorageMut<'a, T, Dynamic, U4, RStride, CStride>>;
+    Matrix<T, Dynamic, U4, ViewStorageMut<'a, T, Dynamic, U4, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 5 columns.
 pub type MatrixSliceMutXx5<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U5, SliceStorageMut<'a, T, Dynamic, U5, RStride, CStride>>;
+    Matrix<T, Dynamic, U5, ViewStorageMut<'a, T, Dynamic, U5, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 6 columns.
 pub type MatrixSliceMutXx6<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U6, SliceStorageMut<'a, T, Dynamic, U6, RStride, CStride>>;
+    Matrix<T, Dynamic, U6, ViewStorageMut<'a, T, Dynamic, U6, RStride, CStride>>;
 
 /// A column vector slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSliceMut<'a, T, D, RStride = U1, CStride = D> =
-    Matrix<T, D, U1, SliceStorageMut<'a, T, D, U1, RStride, CStride>>;
+    Matrix<T, D, U1, ViewStorageMut<'a, T, D, U1, RStride, CStride>>;
 
 /// A column vector slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type SVectorSliceMut<'a, T, const D: usize> =
-    Matrix<T, Const<D>, Const<1>, SliceStorageMut<'a, T, Const<D>, Const<1>, Const<1>, Const<D>>>;
+    Matrix<T, Const<D>, Const<1>, ViewStorageMut<'a, T, Const<D>, Const<1>, Const<1>, Const<D>>>;
 
 /// A column vector slice dynamic numbers of rows and columns.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type DVectorSliceMut<'a, T, RStride = U1, CStride = Dynamic> =
-    Matrix<T, Dynamic, U1, SliceStorageMut<'a, T, Dynamic, U1, RStride, CStride>>;
+    Matrix<T, Dynamic, U1, ViewStorageMut<'a, T, Dynamic, U1, RStride, CStride>>;
 
 /// A 1D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSliceMut1<'a, T, RStride = U1, CStride = U1> =
-    Matrix<T, U1, U1, SliceStorageMut<'a, T, U1, U1, RStride, CStride>>;
+    Matrix<T, U1, U1, ViewStorageMut<'a, T, U1, U1, RStride, CStride>>;
 /// A 2D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSliceMut2<'a, T, RStride = U1, CStride = U2> =
-    Matrix<T, U2, U1, SliceStorageMut<'a, T, U2, U1, RStride, CStride>>;
+    Matrix<T, U2, U1, ViewStorageMut<'a, T, U2, U1, RStride, CStride>>;
 /// A 3D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSliceMut3<'a, T, RStride = U1, CStride = U3> =
-    Matrix<T, U3, U1, SliceStorageMut<'a, T, U3, U1, RStride, CStride>>;
+    Matrix<T, U3, U1, ViewStorageMut<'a, T, U3, U1, RStride, CStride>>;
 /// A 4D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSliceMut4<'a, T, RStride = U1, CStride = U4> =
-    Matrix<T, U4, U1, SliceStorageMut<'a, T, U4, U1, RStride, CStride>>;
+    Matrix<T, U4, U1, ViewStorageMut<'a, T, U4, U1, RStride, CStride>>;
 /// A 5D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSliceMut5<'a, T, RStride = U1, CStride = U5> =
-    Matrix<T, U5, U1, SliceStorageMut<'a, T, U5, U1, RStride, CStride>>;
+    Matrix<T, U5, U1, ViewStorageMut<'a, T, U5, U1, RStride, CStride>>;
 /// A 6D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
 pub type VectorSliceMut6<'a, T, RStride = U1, CStride = U6> =
-    Matrix<T, U6, U1, SliceStorageMut<'a, T, U6, U1, RStride, CStride>>;
+    Matrix<T, U6, U1, ViewStorageMut<'a, T, U6, U1, RStride, CStride>>;
diff --git a/src/base/construction_slice.rs b/src/base/construction_slice.rs
index 7094bdca..aad50685 100644
--- a/src/base/construction_slice.rs
+++ b/src/base/construction_slice.rs
@@ -1,5 +1,5 @@
 use crate::base::dimension::{Const, Dim, DimName, Dynamic};
-use crate::base::matrix_slice::{SliceStorage, SliceStorageMut};
+use crate::base::matrix_slice::{ViewStorage, ViewStorageMut};
 use crate::base::{MatrixSlice, MatrixSliceMutMN, Scalar};
 
 use num_rational::Ratio;
@@ -22,7 +22,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
         rstride: RStride,
         cstride: CStride,
     ) -> Self {
-        let data = SliceStorage::from_raw_parts(
+        let data = ViewStorage::from_raw_parts(
             data.as_ptr().add(start),
             (nrows, ncols),
             (rstride, cstride),
@@ -160,7 +160,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
         rstride: RStride,
         cstride: CStride,
     ) -> Self {
-        let data = SliceStorageMut::from_raw_parts(
+        let data = ViewStorageMut::from_raw_parts(
             data.as_mut_ptr().add(start),
             (nrows, ncols),
             (rstride, cstride),
diff --git a/src/base/conversion.rs b/src/base/conversion.rs
index dd71186f..26e624a3 100644
--- a/src/base/conversion.rs
+++ b/src/base/conversion.rs
@@ -21,7 +21,7 @@ use crate::base::{
 };
 #[cfg(any(feature = "std", feature = "alloc"))]
 use crate::base::{DVector, RowDVector, VecStorage};
-use crate::base::{SliceStorage, SliceStorageMut};
+use crate::base::{ViewStorage, ViewStorageMut};
 use crate::constraint::DimEq;
 use crate::{IsNotStaticOne, RowSVector, SMatrix, SVector, VectorSlice, VectorSliceMut};
 use std::mem::MaybeUninit;
@@ -397,7 +397,7 @@ where
         let cstride_slice = CStride::from_usize(cstride);
 
         unsafe {
-            let data = SliceStorage::from_raw_parts(
+            let data = ViewStorage::from_raw_parts(
                 m.data.ptr(),
                 (row_slice, col_slice),
                 (rstride_slice, cstride_slice),
@@ -434,7 +434,7 @@ where
         let cstride_slice = CStride::from_usize(cstride);
 
         unsafe {
-            let data = SliceStorage::from_raw_parts(
+            let data = ViewStorage::from_raw_parts(
                 m.data.ptr(),
                 (row_slice, col_slice),
                 (rstride_slice, cstride_slice),
@@ -471,7 +471,7 @@ where
         let cstride_slice = CStride::from_usize(cstride);
 
         unsafe {
-            let data = SliceStorageMut::from_raw_parts(
+            let data = ViewStorageMut::from_raw_parts(
                 m.data.ptr_mut(),
                 (row_slice, col_slice),
                 (rstride_slice, cstride_slice),
diff --git a/src/base/indexing.rs b/src/base/indexing.rs
index 2c691bd1..5cc64db0 100644
--- a/src/base/indexing.rs
+++ b/src/base/indexing.rs
@@ -682,13 +682,13 @@ macro_rules! impl_index_pair {
             #[doc(hidden)]
             #[inline(always)]
             unsafe fn get_unchecked(self, matrix: &'a Matrix<T, $R, $C, S>) -> Self::Output {
-                use crate::base::SliceStorage;
+                use crate::base::ViewStorage;
 
                 let (rows, cols) = self;
                 let (nrows, ncols) = matrix.shape_generic();
 
                 let data =
-                    SliceStorage::new_unchecked(&matrix.data,
+                    ViewStorage::new_unchecked(&matrix.data,
                         (rows.lower(nrows),  cols.lower(ncols)),
                         (rows.length(nrows), cols.length(ncols)));
 
@@ -710,13 +710,13 @@ macro_rules! impl_index_pair {
             #[doc(hidden)]
             #[inline(always)]
             unsafe fn get_unchecked_mut(self, matrix: &'a mut Matrix<T, $R, $C, S>) -> Self::OutputMut {
-                use crate::base::SliceStorageMut;
+                use crate::base::ViewStorageMut;
 
                 let (rows, cols) = self;
                 let (nrows, ncols) = matrix.shape_generic();
 
                 let data =
-                    SliceStorageMut::new_unchecked(&mut matrix.data,
+                    ViewStorageMut::new_unchecked(&mut matrix.data,
                         (rows.lower(nrows),  cols.lower(ncols)),
                         (rows.length(nrows), cols.length(ncols)));
 
diff --git a/src/base/matrix_slice.rs b/src/base/matrix_slice.rs
index 5fbd4b01..be646cee 100644
--- a/src/base/matrix_slice.rs
+++ b/src/base/matrix_slice.rs
@@ -9,17 +9,28 @@ use crate::base::iter::MatrixIter;
 use crate::base::storage::{IsContiguous, Owned, RawStorage, RawStorageMut, Storage};
 use crate::base::{Matrix, Scalar};
 
-macro_rules! slice_storage_impl(
-    ($doc: expr; $Storage: ident as $SRef: ty; $T: ident.$get_addr: ident ($Ptr: ty as $Ref: ty)) => {
+macro_rules! view_storage_impl (
+    ($doc: expr; $Storage: ident as $SRef: ty; $legacy_name:ident => $T: ident.$get_addr: ident ($Ptr: ty as $Ref: ty)) => {
         #[doc = $doc]
         #[derive(Debug)]
-        pub struct $T<'a, T, R: Dim, C: Dim, RStride: Dim, CStride: Dim> {
+        pub struct $T<'a, T, R: Dim, C: Dim, RStride: Dim, CStride: Dim>  {
             ptr:       $Ptr,
             shape:     (R, C),
             strides:   (RStride, CStride),
             _phantoms: PhantomData<$Ref>,
         }
 
+        #[doc = $doc]
+        ///
+        /// This type alias exists only for legacy purposes and is deprecated. It will be removed
+        /// in a future release. Please use
+        /// [`
+        #[doc = stringify!($T)]
+        /// `] instead. See [issue #1076](https://github.com/dimforge/nalgebra/issues/1076)
+        /// for the rationale.
+        #[deprecated = "Use ViewStorage(Mut) instead."]
+        pub type $legacy_name<'a, T, R, C, RStride, CStride> = $T<'a, T, R, C, RStride, CStride>;
+
         unsafe impl<'a, T: Send, R: Dim, C: Dim, RStride: Dim, CStride: Dim> Send
             for $T<'a, T, R, C, RStride, CStride>
         {}
@@ -29,7 +40,7 @@ macro_rules! slice_storage_impl(
         {}
 
         impl<'a, T, R: Dim, C: Dim, RStride: Dim, CStride: Dim> $T<'a, T, R, C, RStride, CStride> {
-            /// Create a new matrix slice without bound checking and from a raw pointer.
+            /// Create a new matrix view without bounds checking and from a raw pointer.
             #[inline]
             pub unsafe fn from_raw_parts(ptr:     $Ptr,
                                          shape:   (R, C),
@@ -49,7 +60,7 @@ macro_rules! slice_storage_impl(
 
         // Dynamic is arbitrary. It's just to be able to call the constructors with `Slice::`
         impl<'a, T, R: Dim, C: Dim> $T<'a, T, R, C, Dynamic, Dynamic> {
-            /// Create a new matrix slice without bound checking.
+            /// Create a new matrix view without bounds checking.
             #[inline]
             pub unsafe fn new_unchecked<RStor, CStor, S>(storage: $SRef, start: (usize, usize), shape: (R, C))
                 -> $T<'a, T, R, C, S::RStride, S::CStride>
@@ -61,7 +72,7 @@ macro_rules! slice_storage_impl(
                 $T::new_with_strides_unchecked(storage, start, shape, strides)
             }
 
-            /// Create a new matrix slice without bound checking.
+            /// Create a new matrix view without bounds checking.
             #[inline]
             pub unsafe fn new_with_strides_unchecked<S, RStor, CStor, RStride, CStride>(storage: $SRef,
                                                                                         start:   (usize, usize),
@@ -82,7 +93,7 @@ macro_rules! slice_storage_impl(
         where
             Self: RawStorage<T, R, C> + IsContiguous
         {
-            /// Extracts the original slice from this storage
+            /// Extracts the original slice from this storage.
             pub fn into_slice(self) -> &'a [T] {
                 let (nrows, ncols) = self.shape();
                 if nrows.value() != 0 && ncols.value() != 0 {
@@ -96,22 +107,22 @@ macro_rules! slice_storage_impl(
     }
 );
 
-slice_storage_impl!("A matrix data storage for a matrix slice. Only contains an internal reference \
+view_storage_impl!("A matrix data storage for a matrix view. Only contains an internal reference \
                      to another matrix data storage.";
-    RawStorage as &'a S; SliceStorage.get_address_unchecked(*const T as &'a T));
+    RawStorage as &'a S; SliceStorage => ViewStorage.get_address_unchecked(*const T as &'a T));
 
-slice_storage_impl!("A mutable matrix data storage for mutable matrix slice. Only contains an \
+view_storage_impl!("A mutable matrix data storage for mutable matrix view. Only contains an \
                      internal mutable reference to another matrix data storage.";
-    RawStorageMut as &'a mut S; SliceStorageMut.get_address_unchecked_mut(*mut T as &'a mut T)
+    RawStorageMut as &'a mut S; SliceStorageMut => ViewStorageMut.get_address_unchecked_mut(*mut T as &'a mut T)
 );
 
 impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim> Copy
-    for SliceStorage<'a, T, R, C, RStride, CStride>
+    for ViewStorage<'a, T, R, C, RStride, CStride>
 {
 }
 
 impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim> Clone
-    for SliceStorage<'a, T, R, C, RStride, CStride>
+    for ViewStorage<'a, T, R, C, RStride, CStride>
 {
     #[inline]
     fn clone(&self) -> Self {
@@ -125,7 +136,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim> Clone
 }
 
 impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
-    SliceStorageMut<'a, T, R, C, RStride, CStride>
+    ViewStorageMut<'a, T, R, C, RStride, CStride>
 where
     Self: RawStorageMut<T, R, C> + IsContiguous,
 {
@@ -212,10 +223,10 @@ macro_rules! storage_impl(
     )*}
 );
 
-storage_impl!(SliceStorage, SliceStorageMut);
+storage_impl!(ViewStorage, ViewStorageMut);
 
 unsafe impl<'a, T, R: Dim, C: Dim, RStride: Dim, CStride: Dim> RawStorageMut<T, R, C>
-    for SliceStorageMut<'a, T, R, C, RStride, CStride>
+    for ViewStorageMut<'a, T, R, C, RStride, CStride>
 {
     #[inline]
     fn ptr_mut(&mut self) -> *mut T {
@@ -234,18 +245,18 @@ unsafe impl<'a, T, R: Dim, C: Dim, RStride: Dim, CStride: Dim> RawStorageMut<T,
     }
 }
 
-unsafe impl<'a, T, R: Dim, CStride: Dim> IsContiguous for SliceStorage<'a, T, R, U1, U1, CStride> {}
+unsafe impl<'a, T, R: Dim, CStride: Dim> IsContiguous for ViewStorage<'a, T, R, U1, U1, CStride> {}
 unsafe impl<'a, T, R: Dim, CStride: Dim> IsContiguous
-    for SliceStorageMut<'a, T, R, U1, U1, CStride>
+    for ViewStorageMut<'a, T, R, U1, U1, CStride>
 {
 }
 
 unsafe impl<'a, T, R: DimName, C: Dim + IsNotStaticOne> IsContiguous
-    for SliceStorage<'a, T, R, C, U1, R>
+    for ViewStorage<'a, T, R, C, U1, R>
 {
 }
 unsafe impl<'a, T, R: DimName, C: Dim + IsNotStaticOne> IsContiguous
-    for SliceStorageMut<'a, T, R, C, U1, R>
+    for ViewStorageMut<'a, T, R, C, U1, R>
 {
 }
 
@@ -273,8 +284,8 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     }
 }
 
-macro_rules! matrix_slice_impl(
-    ($me: ident: $Me: ty, $MatrixSlice: ident, $SliceStorage: ident, $Storage: ident.$get_addr: ident (), $data: expr;
+macro_rules! matrix_slice_impl (
+    ($me: ident: $Me: ty, $MatrixSlice: ident, $ViewStorage: ident, $Storage: ident.$get_addr: ident (), $data: expr;
      $row: ident,
      $row_part: ident,
      $rows: ident,
@@ -361,7 +372,7 @@ macro_rules! matrix_slice_impl(
             let shape = (nrows, my_shape.1);
 
             unsafe {
-                let data = $SliceStorage::new_unchecked($data, (row_start, 0), shape);
+                let data = $ViewStorage::new_unchecked($data, (row_start, 0), shape);
                 Matrix::from_data_statically_unchecked(data)
             }
         }
@@ -381,7 +392,7 @@ macro_rules! matrix_slice_impl(
             let shape   = (nrows, my_shape.1);
 
             unsafe {
-                let data = $SliceStorage::new_with_strides_unchecked($data, (row_start, 0), shape, strides);
+                let data = $ViewStorage::new_with_strides_unchecked($data, (row_start, 0), shape, strides);
                 Matrix::from_data_statically_unchecked(data)
             }
         }
@@ -448,7 +459,7 @@ macro_rules! matrix_slice_impl(
             let shape = (my_shape.0, ncols);
 
             unsafe {
-                let data = $SliceStorage::new_unchecked($data, (0, first_col), shape);
+                let data = $ViewStorage::new_unchecked($data, (0, first_col), shape);
                 Matrix::from_data_statically_unchecked(data)
             }
         }
@@ -469,7 +480,7 @@ macro_rules! matrix_slice_impl(
             let shape   = (my_shape.0, ncols);
 
             unsafe {
-                let data = $SliceStorage::new_with_strides_unchecked($data, (0, first_col), shape, strides);
+                let data = $ViewStorage::new_with_strides_unchecked($data, (0, first_col), shape, strides);
                 Matrix::from_data_statically_unchecked(data)
             }
         }
@@ -489,7 +500,7 @@ macro_rules! matrix_slice_impl(
             let shape = (Dynamic::new(shape.0), Dynamic::new(shape.1));
 
             unsafe {
-                let data = $SliceStorage::new_unchecked($data, start, shape);
+                let data = $ViewStorage::new_unchecked($data, start, shape);
                 Matrix::from_data_statically_unchecked(data)
             }
         }
@@ -517,7 +528,7 @@ macro_rules! matrix_slice_impl(
             let shape = (Const::<RSLICE>, Const::<CSLICE>);
 
             unsafe {
-                let data = $SliceStorage::new_unchecked($data, (irow, icol), shape);
+                let data = $ViewStorage::new_unchecked($data, (irow, icol), shape);
                 Matrix::from_data_statically_unchecked(data)
             }
         }
@@ -543,7 +554,7 @@ macro_rules! matrix_slice_impl(
             $me.assert_slice_index(start, (shape.0.value(), shape.1.value()), (0, 0));
 
             unsafe {
-                let data = $SliceStorage::new_unchecked($data, start, shape);
+                let data = $ViewStorage::new_unchecked($data, start, shape);
                 Matrix::from_data_statically_unchecked(data)
             }
         }
@@ -565,7 +576,7 @@ macro_rules! matrix_slice_impl(
                               Dynamic::new((steps.1 + 1) * my_strides.1.value()));
 
             unsafe {
-                let data = $SliceStorage::new_with_strides_unchecked($data, start, shape, strides);
+                let data = $ViewStorage::new_with_strides_unchecked($data, start, shape, strides);
                 Matrix::from_data_statically_unchecked(data)
             }
         }
@@ -602,8 +613,8 @@ macro_rules! matrix_slice_impl(
                 let ptr1 = $data.$get_addr(start1, 0);
                 let ptr2 = $data.$get_addr(start2, 0);
 
-                let data1  = $SliceStorage::from_raw_parts(ptr1, (nrows1, ncols), strides);
-                let data2  = $SliceStorage::from_raw_parts(ptr2, (nrows2, ncols), strides);
+                let data1  = $ViewStorage::from_raw_parts(ptr1, (nrows1, ncols), strides);
+                let data2  = $ViewStorage::from_raw_parts(ptr2, (nrows2, ncols), strides);
                 let slice1 = Matrix::from_data_statically_unchecked(data1);
                 let slice2 = Matrix::from_data_statically_unchecked(data2);
 
@@ -638,8 +649,8 @@ macro_rules! matrix_slice_impl(
                 let ptr1 = $data.$get_addr(0, start1);
                 let ptr2 = $data.$get_addr(0, start2);
 
-                let data1  = $SliceStorage::from_raw_parts(ptr1, (nrows, ncols1), strides);
-                let data2  = $SliceStorage::from_raw_parts(ptr2, (nrows, ncols2), strides);
+                let data1  = $ViewStorage::from_raw_parts(ptr1, (nrows, ncols1), strides);
+                let data2  = $ViewStorage::from_raw_parts(ptr2, (nrows, ncols2), strides);
                 let slice1 = Matrix::from_data_statically_unchecked(data1);
                 let slice2 = Matrix::from_data_statically_unchecked(data2);
 
@@ -651,15 +662,15 @@ macro_rules! matrix_slice_impl(
 
 /// A matrix slice.
 pub type MatrixSlice<'a, T, R, C, RStride = U1, CStride = R> =
-    Matrix<T, R, C, SliceStorage<'a, T, R, C, RStride, CStride>>;
+    Matrix<T, R, C, ViewStorage<'a, T, R, C, RStride, CStride>>;
 /// A mutable matrix slice.
 pub type MatrixSliceMut<'a, T, R, C, RStride = U1, CStride = R> =
-    Matrix<T, R, C, SliceStorageMut<'a, T, R, C, RStride, CStride>>;
+    Matrix<T, R, C, ViewStorageMut<'a, T, R, C, RStride, CStride>>;
 
 /// # Slicing based on index and length
 impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     matrix_slice_impl!(
-     self: &Self, MatrixSlice, SliceStorage, RawStorage.get_address_unchecked(), &self.data;
+     self: &Self, MatrixSlice, ViewStorage, RawStorage.get_address_unchecked(), &self.data;
      row,
      row_part,
      rows,
@@ -689,7 +700,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
 /// # Mutable slicing based on index and length
 impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
     matrix_slice_impl!(
-     self: &mut Self, MatrixSliceMut, SliceStorageMut, RawStorageMut.get_address_unchecked_mut(), &mut self.data;
+     self: &mut Self, MatrixSliceMut, ViewStorageMut, RawStorageMut.get_address_unchecked_mut(), &mut self.data;
      row_mut,
      row_part_mut,
      rows_mut,
@@ -943,7 +954,7 @@ where
     CStride: Dim,
 {
     fn from(slice_mut: MatrixSliceMut<'a, T, R, C, RStride, CStride>) -> Self {
-        let data = SliceStorage {
+        let data = ViewStorage {
             ptr: slice_mut.data.ptr,
             shape: slice_mut.data.shape,
             strides: slice_mut.data.strides,

From 29bff32d2dc3050a758d70c13e8d4b89e1f6a3e3 Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Fri, 11 Nov 2022 16:10:39 +0100
Subject: [PATCH 68/91] Rename MatrixSlice(Mut) to MatrixView(Mut)

Additionally introduce deprecated type aliases with the old names to avoid
a breaking change.
---
 src/base/construction_slice.rs | 10 ++--
 src/base/conversion.rs         | 42 +++++++--------
 src/base/indexing.rs           |  6 +--
 src/base/iter.rs               | 10 ++--
 src/base/matrix_slice.rs       | 97 +++++++++++++++++++++-------------
 src/geometry/quaternion.rs     |  6 +--
 6 files changed, 96 insertions(+), 75 deletions(-)

diff --git a/src/base/construction_slice.rs b/src/base/construction_slice.rs
index aad50685..e54d824c 100644
--- a/src/base/construction_slice.rs
+++ b/src/base/construction_slice.rs
@@ -1,12 +1,12 @@
 use crate::base::dimension::{Const, Dim, DimName, Dynamic};
 use crate::base::matrix_slice::{ViewStorage, ViewStorageMut};
-use crate::base::{MatrixSlice, MatrixSliceMutMN, Scalar};
+use crate::base::{MatrixView, MatrixSliceMutMN, Scalar};
 
 use num_rational::Ratio;
 
 /// # Creating matrix slices from `&[T]`
 impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
-    MatrixSlice<'a, T, R, C, RStride, CStride>
+    MatrixView<'a, T, R, C, RStride, CStride>
 {
     /// Creates, without bound-checking, a matrix slice from an array and with dimensions and strides specified by generic types instances.
     ///
@@ -57,7 +57,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
     }
 }
 
-impl<'a, T: Scalar, R: Dim, C: Dim> MatrixSlice<'a, T, R, C> {
+impl<'a, T: Scalar, R: Dim, C: Dim> MatrixView<'a, T, R, C> {
     /// Creates, without bound-checking, a matrix slice from an array and with dimensions specified by generic types instances.
     ///
     /// # Safety
@@ -87,7 +87,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim> MatrixSlice<'a, T, R, C> {
 
 macro_rules! impl_constructors(
     ($($Dims: ty),*; $(=> $DimIdent: ident: $DimBound: ident),*; $($gargs: expr),*; $($args: ident),*) => {
-        impl<'a, T: Scalar, $($DimIdent: $DimBound),*> MatrixSlice<'a, T, $($Dims),*> {
+        impl<'a, T: Scalar, $($DimIdent: $DimBound),*> MatrixView<'a, T, $($Dims),*> {
             /// Creates a new matrix slice from the given data array.
             ///
             /// Panics if `data` does not contain enough elements.
@@ -103,7 +103,7 @@ macro_rules! impl_constructors(
             }
         }
 
-        impl<'a, T: Scalar, $($DimIdent: $DimBound, )*> MatrixSlice<'a, T, $($Dims,)* Dynamic, Dynamic> {
+        impl<'a, T: Scalar, $($DimIdent: $DimBound, )*> MatrixView<'a, T, $($Dims,)* Dynamic, Dynamic> {
             /// Creates a new matrix slice with the specified strides from the given data array.
             ///
             /// Panics if `data` does not contain enough elements.
diff --git a/src/base/conversion.rs b/src/base/conversion.rs
index 26e624a3..9b6df2c2 100644
--- a/src/base/conversion.rs
+++ b/src/base/conversion.rs
@@ -16,8 +16,8 @@ use crate::base::dimension::{
 use crate::base::iter::{MatrixIter, MatrixIterMut};
 use crate::base::storage::{IsContiguous, RawStorage, RawStorageMut};
 use crate::base::{
-    ArrayStorage, DVectorSlice, DVectorSliceMut, DefaultAllocator, Matrix, MatrixSlice,
-    MatrixSliceMut, OMatrix, Scalar,
+    ArrayStorage, DVectorSlice, DVectorSliceMut, DefaultAllocator, Matrix, MatrixView,
+    MatrixViewMut, OMatrix, Scalar,
 };
 #[cfg(any(feature = "std", feature = "alloc"))]
 use crate::base::{DVector, RowDVector, VecStorage};
@@ -221,19 +221,19 @@ impl<T: Scalar, const R: usize, const C: usize> From<SMatrix<T, R, C>> for [[T;
 }
 
 impl<'a, T: Scalar, RStride: Dim, CStride: Dim, const R: usize, const C: usize>
-    From<MatrixSlice<'a, T, Const<R>, Const<C>, RStride, CStride>> for [[T; R]; C]
+    From<MatrixView<'a, T, Const<R>, Const<C>, RStride, CStride>> for [[T; R]; C]
 {
     #[inline]
-    fn from(mat: MatrixSlice<'a, T, Const<R>, Const<C>, RStride, CStride>) -> Self {
+    fn from(mat: MatrixView<'a, T, Const<R>, Const<C>, RStride, CStride>) -> Self {
         mat.into_owned().into()
     }
 }
 
 impl<'a, T: Scalar, RStride: Dim, CStride: Dim, const R: usize, const C: usize>
-    From<MatrixSliceMut<'a, T, Const<R>, Const<C>, RStride, CStride>> for [[T; R]; C]
+    From<MatrixViewMut<'a, T, Const<R>, Const<C>, RStride, CStride>> for [[T; R]; C]
 {
     #[inline]
-    fn from(mat: MatrixSliceMut<'a, T, Const<R>, Const<C>, RStride, CStride>) -> Self {
+    fn from(mat: MatrixViewMut<'a, T, Const<R>, Const<C>, RStride, CStride>) -> Self {
         mat.into_owned().into()
     }
 }
@@ -289,20 +289,20 @@ impl_from_into_asref_borrow_2D!(
 );
 
 impl<'a, T, RStride, CStride, const R: usize, const C: usize>
-    From<MatrixSlice<'a, T, Const<R>, Const<C>, RStride, CStride>>
+    From<MatrixView<'a, T, Const<R>, Const<C>, RStride, CStride>>
     for Matrix<T, Const<R>, Const<C>, ArrayStorage<T, R, C>>
 where
     T: Scalar,
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(matrix_slice: MatrixSlice<'a, T, Const<R>, Const<C>, RStride, CStride>) -> Self {
+    fn from(matrix_slice: MatrixView<'a, T, Const<R>, Const<C>, RStride, CStride>) -> Self {
         matrix_slice.into_owned()
     }
 }
 
 #[cfg(any(feature = "std", feature = "alloc"))]
-impl<'a, T, C, RStride, CStride> From<MatrixSlice<'a, T, Dynamic, C, RStride, CStride>>
+impl<'a, T, C, RStride, CStride> From<MatrixView<'a, T, Dynamic, C, RStride, CStride>>
     for Matrix<T, Dynamic, C, VecStorage<T, Dynamic, C>>
 where
     T: Scalar,
@@ -310,13 +310,13 @@ where
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(matrix_slice: MatrixSlice<'a, T, Dynamic, C, RStride, CStride>) -> Self {
+    fn from(matrix_slice: MatrixView<'a, T, Dynamic, C, RStride, CStride>) -> Self {
         matrix_slice.into_owned()
     }
 }
 
 #[cfg(any(feature = "std", feature = "alloc"))]
-impl<'a, T, R, RStride, CStride> From<MatrixSlice<'a, T, R, Dynamic, RStride, CStride>>
+impl<'a, T, R, RStride, CStride> From<MatrixView<'a, T, R, Dynamic, RStride, CStride>>
     for Matrix<T, R, Dynamic, VecStorage<T, R, Dynamic>>
 where
     T: Scalar,
@@ -324,26 +324,26 @@ where
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(matrix_slice: MatrixSlice<'a, T, R, Dynamic, RStride, CStride>) -> Self {
+    fn from(matrix_slice: MatrixView<'a, T, R, Dynamic, RStride, CStride>) -> Self {
         matrix_slice.into_owned()
     }
 }
 
 impl<'a, T, RStride, CStride, const R: usize, const C: usize>
-    From<MatrixSliceMut<'a, T, Const<R>, Const<C>, RStride, CStride>>
+    From<MatrixViewMut<'a, T, Const<R>, Const<C>, RStride, CStride>>
     for Matrix<T, Const<R>, Const<C>, ArrayStorage<T, R, C>>
 where
     T: Scalar,
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(matrix_slice: MatrixSliceMut<'a, T, Const<R>, Const<C>, RStride, CStride>) -> Self {
+    fn from(matrix_slice: MatrixViewMut<'a, T, Const<R>, Const<C>, RStride, CStride>) -> Self {
         matrix_slice.into_owned()
     }
 }
 
 #[cfg(any(feature = "std", feature = "alloc"))]
-impl<'a, T, C, RStride, CStride> From<MatrixSliceMut<'a, T, Dynamic, C, RStride, CStride>>
+impl<'a, T, C, RStride, CStride> From<MatrixViewMut<'a, T, Dynamic, C, RStride, CStride>>
     for Matrix<T, Dynamic, C, VecStorage<T, Dynamic, C>>
 where
     T: Scalar,
@@ -351,13 +351,13 @@ where
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(matrix_slice: MatrixSliceMut<'a, T, Dynamic, C, RStride, CStride>) -> Self {
+    fn from(matrix_slice: MatrixViewMut<'a, T, Dynamic, C, RStride, CStride>) -> Self {
         matrix_slice.into_owned()
     }
 }
 
 #[cfg(any(feature = "std", feature = "alloc"))]
-impl<'a, T, R, RStride, CStride> From<MatrixSliceMut<'a, T, R, Dynamic, RStride, CStride>>
+impl<'a, T, R, RStride, CStride> From<MatrixViewMut<'a, T, R, Dynamic, RStride, CStride>>
     for Matrix<T, R, Dynamic, VecStorage<T, R, Dynamic>>
 where
     T: Scalar,
@@ -365,13 +365,13 @@ where
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(matrix_slice: MatrixSliceMut<'a, T, R, Dynamic, RStride, CStride>) -> Self {
+    fn from(matrix_slice: MatrixViewMut<'a, T, R, Dynamic, RStride, CStride>) -> Self {
         matrix_slice.into_owned()
     }
 }
 
 impl<'a, T, R, C, RSlice, CSlice, RStride, CStride, S> From<&'a Matrix<T, R, C, S>>
-    for MatrixSlice<'a, T, RSlice, CSlice, RStride, CStride>
+    for MatrixView<'a, T, RSlice, CSlice, RStride, CStride>
 where
     T: Scalar,
     R: Dim,
@@ -408,7 +408,7 @@ where
 }
 
 impl<'a, T, R, C, RSlice, CSlice, RStride, CStride, S> From<&'a mut Matrix<T, R, C, S>>
-    for MatrixSlice<'a, T, RSlice, CSlice, RStride, CStride>
+    for MatrixView<'a, T, RSlice, CSlice, RStride, CStride>
 where
     T: Scalar,
     R: Dim,
@@ -445,7 +445,7 @@ where
 }
 
 impl<'a, T, R, C, RSlice, CSlice, RStride, CStride, S> From<&'a mut Matrix<T, R, C, S>>
-    for MatrixSliceMut<'a, T, RSlice, CSlice, RStride, CStride>
+    for MatrixViewMut<'a, T, RSlice, CSlice, RStride, CStride>
 where
     T: Scalar,
     R: Dim,
diff --git a/src/base/indexing.rs b/src/base/indexing.rs
index 5cc64db0..df769163 100644
--- a/src/base/indexing.rs
+++ b/src/base/indexing.rs
@@ -3,7 +3,7 @@
 
 use crate::base::storage::{RawStorage, RawStorageMut};
 use crate::base::{
-    Const, Dim, DimDiff, DimName, DimSub, Dynamic, Matrix, MatrixSlice, MatrixSliceMut, Scalar, U1,
+    Const, Dim, DimDiff, DimName, DimSub, Dynamic, Matrix, MatrixView, MatrixViewMut, Scalar, U1,
 };
 
 use std::ops;
@@ -669,7 +669,7 @@ macro_rules! impl_index_pair {
             $( $RConstraintType: $RConstraintBound $(<$( $RConstraintBoundParams $( = $REqBound )*),*>)* ,)*
             $( $CConstraintType: $CConstraintBound $(<$( $CConstraintBoundParams $( = $CEqBound )*),*>)* ),*
         {
-            type Output = MatrixSlice<'a, T, $ROut, $COut, S::RStride, S::CStride>;
+            type Output = MatrixView<'a, T, $ROut, $COut, S::RStride, S::CStride>;
 
             #[doc(hidden)]
             #[inline(always)]
@@ -705,7 +705,7 @@ macro_rules! impl_index_pair {
             $( $RConstraintType: $RConstraintBound $(<$( $RConstraintBoundParams $( = $REqBound )*),*>)* ,)*
             $( $CConstraintType: $CConstraintBound $(<$( $CConstraintBoundParams $( = $CEqBound )*),*>)* ),*
         {
-            type OutputMut = MatrixSliceMut<'a, T, $ROut, $COut, S::RStride, S::CStride>;
+            type OutputMut = MatrixViewMut<'a, T, $ROut, $COut, S::RStride, S::CStride>;
 
             #[doc(hidden)]
             #[inline(always)]
diff --git a/src/base/iter.rs b/src/base/iter.rs
index b68e1051..991c24dc 100644
--- a/src/base/iter.rs
+++ b/src/base/iter.rs
@@ -6,7 +6,7 @@ use std::mem;
 
 use crate::base::dimension::{Dim, U1};
 use crate::base::storage::{RawStorage, RawStorageMut};
-use crate::base::{Matrix, MatrixSlice, MatrixSliceMut, Scalar};
+use crate::base::{Matrix, MatrixView, MatrixViewMut, Scalar};
 
 macro_rules! iterator {
     (struct $Name:ident for $Storage:ident.$ptr: ident -> $Ptr:ty, $Ref:ty, $SRef: ty) => {
@@ -193,7 +193,7 @@ impl<'a, T, R: Dim, C: Dim, S: 'a + RawStorage<T, R, C>> RowIter<'a, T, R, C, S>
 }
 
 impl<'a, T, R: Dim, C: Dim, S: 'a + RawStorage<T, R, C>> Iterator for RowIter<'a, T, R, C, S> {
-    type Item = MatrixSlice<'a, T, U1, C, S::RStride, S::CStride>;
+    type Item = MatrixView<'a, T, U1, C, S::RStride, S::CStride>;
 
     #[inline]
     fn next(&mut self) -> Option<Self::Item> {
@@ -254,7 +254,7 @@ impl<'a, T, R: Dim, C: Dim, S: 'a + RawStorageMut<T, R, C>> RowIterMut<'a, T, R,
 impl<'a, T, R: Dim, C: Dim, S: 'a + RawStorageMut<T, R, C>> Iterator
     for RowIterMut<'a, T, R, C, S>
 {
-    type Item = MatrixSliceMut<'a, T, U1, C, S::RStride, S::CStride>;
+    type Item = MatrixViewMut<'a, T, U1, C, S::RStride, S::CStride>;
 
     #[inline]
     fn next(&mut self) -> Option<Self::Item> {
@@ -306,7 +306,7 @@ impl<'a, T, R: Dim, C: Dim, S: 'a + RawStorage<T, R, C>> ColumnIter<'a, T, R, C,
 }
 
 impl<'a, T, R: Dim, C: Dim, S: 'a + RawStorage<T, R, C>> Iterator for ColumnIter<'a, T, R, C, S> {
-    type Item = MatrixSlice<'a, T, R, U1, S::RStride, S::CStride>;
+    type Item = MatrixView<'a, T, R, U1, S::RStride, S::CStride>;
 
     #[inline]
     fn next(&mut self) -> Option<Self::Item> {
@@ -367,7 +367,7 @@ impl<'a, T, R: Dim, C: Dim, S: 'a + RawStorageMut<T, R, C>> ColumnIterMut<'a, T,
 impl<'a, T, R: Dim, C: Dim, S: 'a + RawStorageMut<T, R, C>> Iterator
     for ColumnIterMut<'a, T, R, C, S>
 {
-    type Item = MatrixSliceMut<'a, T, R, U1, S::RStride, S::CStride>;
+    type Item = MatrixViewMut<'a, T, R, U1, S::RStride, S::CStride>;
 
     #[inline]
     fn next(&mut self) -> Option<Self::Item> {
diff --git a/src/base/matrix_slice.rs b/src/base/matrix_slice.rs
index be646cee..03d06778 100644
--- a/src/base/matrix_slice.rs
+++ b/src/base/matrix_slice.rs
@@ -285,7 +285,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
 }
 
 macro_rules! matrix_slice_impl (
-    ($me: ident: $Me: ty, $MatrixSlice: ident, $ViewStorage: ident, $Storage: ident.$get_addr: ident (), $data: expr;
+    ($me: ident: $Me: ty, $MatrixView: ident, $ViewStorage: ident, $Storage: ident.$get_addr: ident (), $data: expr;
      $row: ident,
      $row_part: ident,
      $rows: ident,
@@ -317,20 +317,20 @@ macro_rules! matrix_slice_impl (
          */
         /// Returns a slice containing the i-th row of this matrix.
         #[inline]
-        pub fn $row($me: $Me, i: usize) -> $MatrixSlice<'_, T, U1, C, S::RStride, S::CStride> {
+        pub fn $row($me: $Me, i: usize) -> $MatrixView<'_, T, U1, C, S::RStride, S::CStride> {
             $me.$fixed_rows::<1>(i)
         }
 
         /// Returns a slice containing the `n` first elements of the i-th row of this matrix.
         #[inline]
-        pub fn $row_part($me: $Me, i: usize, n: usize) -> $MatrixSlice<'_, T, U1, Dynamic, S::RStride, S::CStride> {
+        pub fn $row_part($me: $Me, i: usize, n: usize) -> $MatrixView<'_, T, U1, Dynamic, S::RStride, S::CStride> {
             $me.$generic_slice((i, 0), (Const::<1>, Dynamic::new(n)))
         }
 
         /// Extracts from this matrix a set of consecutive rows.
         #[inline]
         pub fn $rows($me: $Me, first_row: usize, nrows: usize)
-            -> $MatrixSlice<'_, T, Dynamic, C, S::RStride, S::CStride> {
+            -> $MatrixView<'_, T, Dynamic, C, S::RStride, S::CStride> {
 
             $me.$rows_generic(first_row, Dynamic::new(nrows))
         }
@@ -338,7 +338,7 @@ macro_rules! matrix_slice_impl (
         /// Extracts from this matrix a set of consecutive rows regularly skipping `step` rows.
         #[inline]
         pub fn $rows_with_step($me: $Me, first_row: usize, nrows: usize, step: usize)
-            -> $MatrixSlice<'_, T, Dynamic, C, Dynamic, S::CStride> {
+            -> $MatrixView<'_, T, Dynamic, C, Dynamic, S::CStride> {
 
             $me.$rows_generic_with_step(first_row, Dynamic::new(nrows), step)
         }
@@ -346,7 +346,7 @@ macro_rules! matrix_slice_impl (
         /// Extracts a compile-time number of consecutive rows from this matrix.
         #[inline]
         pub fn $fixed_rows<const RSLICE: usize>($me: $Me, first_row: usize)
-            -> $MatrixSlice<'_, T, Const<RSLICE>, C, S::RStride, S::CStride> {
+            -> $MatrixView<'_, T, Const<RSLICE>, C, S::RStride, S::CStride> {
 
             $me.$rows_generic(first_row, Const::<RSLICE>)
         }
@@ -355,7 +355,7 @@ macro_rules! matrix_slice_impl (
         /// rows.
         #[inline]
         pub fn $fixed_rows_with_step<const RSLICE: usize>($me: $Me, first_row: usize, step: usize)
-            -> $MatrixSlice<'_, T, Const<RSLICE>, C, Dynamic, S::CStride> {
+            -> $MatrixView<'_, T, Const<RSLICE>, C, Dynamic, S::CStride> {
 
             $me.$rows_generic_with_step(first_row, Const::<RSLICE>, step)
         }
@@ -364,7 +364,7 @@ macro_rules! matrix_slice_impl (
         /// argument may or may not be values known at compile-time.
         #[inline]
         pub fn $rows_generic<RSlice: Dim>($me: $Me, row_start: usize, nrows: RSlice)
-            -> $MatrixSlice<'_, T, RSlice, C, S::RStride, S::CStride> {
+            -> $MatrixView<'_, T, RSlice, C, S::RStride, S::CStride> {
 
             let my_shape   = $me.shape_generic();
             $me.assert_slice_index((row_start, 0), (nrows.value(), my_shape.1.value()), (0, 0));
@@ -381,7 +381,7 @@ macro_rules! matrix_slice_impl (
         /// argument may or may not be values known at compile-time.
         #[inline]
         pub fn $rows_generic_with_step<RSlice>($me: $Me, row_start: usize, nrows: RSlice, step: usize)
-            -> $MatrixSlice<'_, T, RSlice, C, Dynamic, S::CStride>
+            -> $MatrixView<'_, T, RSlice, C, Dynamic, S::CStride>
             where RSlice: Dim {
 
             let my_shape   = $me.shape_generic();
@@ -404,20 +404,20 @@ macro_rules! matrix_slice_impl (
          */
         /// Returns a slice containing the i-th column of this matrix.
         #[inline]
-        pub fn $column($me: $Me, i: usize) -> $MatrixSlice<'_, T, R, U1, S::RStride, S::CStride> {
+        pub fn $column($me: $Me, i: usize) -> $MatrixView<'_, T, R, U1, S::RStride, S::CStride> {
             $me.$fixed_columns::<1>(i)
         }
 
         /// Returns a slice containing the `n` first elements of the i-th column of this matrix.
         #[inline]
-        pub fn $column_part($me: $Me, i: usize, n: usize) -> $MatrixSlice<'_, T, Dynamic, U1, S::RStride, S::CStride> {
+        pub fn $column_part($me: $Me, i: usize, n: usize) -> $MatrixView<'_, T, Dynamic, U1, S::RStride, S::CStride> {
             $me.$generic_slice((0, i), (Dynamic::new(n), Const::<1>))
         }
 
         /// Extracts from this matrix a set of consecutive columns.
         #[inline]
         pub fn $columns($me: $Me, first_col: usize, ncols: usize)
-            -> $MatrixSlice<'_, T, R, Dynamic, S::RStride, S::CStride> {
+            -> $MatrixView<'_, T, R, Dynamic, S::RStride, S::CStride> {
 
             $me.$columns_generic(first_col, Dynamic::new(ncols))
         }
@@ -426,7 +426,7 @@ macro_rules! matrix_slice_impl (
         /// columns.
         #[inline]
         pub fn $columns_with_step($me: $Me, first_col: usize, ncols: usize, step: usize)
-            -> $MatrixSlice<'_, T, R, Dynamic, S::RStride, Dynamic> {
+            -> $MatrixView<'_, T, R, Dynamic, S::RStride, Dynamic> {
 
             $me.$columns_generic_with_step(first_col, Dynamic::new(ncols), step)
         }
@@ -434,7 +434,7 @@ macro_rules! matrix_slice_impl (
         /// Extracts a compile-time number of consecutive columns from this matrix.
         #[inline]
         pub fn $fixed_columns<const CSLICE: usize>($me: $Me, first_col: usize)
-            -> $MatrixSlice<'_, T, R, Const<CSLICE>, S::RStride, S::CStride> {
+            -> $MatrixView<'_, T, R, Const<CSLICE>, S::RStride, S::CStride> {
 
             $me.$columns_generic(first_col, Const::<CSLICE>)
         }
@@ -443,7 +443,7 @@ macro_rules! matrix_slice_impl (
         /// `step` columns.
         #[inline]
         pub fn $fixed_columns_with_step<const CSLICE: usize>($me: $Me, first_col: usize, step: usize)
-            -> $MatrixSlice<'_, T, R, Const<CSLICE>, S::RStride, Dynamic> {
+            -> $MatrixView<'_, T, R, Const<CSLICE>, S::RStride, Dynamic> {
 
             $me.$columns_generic_with_step(first_col, Const::<CSLICE>, step)
         }
@@ -452,7 +452,7 @@ macro_rules! matrix_slice_impl (
         /// known at compile-time.
         #[inline]
         pub fn $columns_generic<CSlice: Dim>($me: $Me, first_col: usize, ncols: CSlice)
-            -> $MatrixSlice<'_, T, R, CSlice, S::RStride, S::CStride> {
+            -> $MatrixView<'_, T, R, CSlice, S::RStride, S::CStride> {
 
             let my_shape = $me.shape_generic();
             $me.assert_slice_index((0, first_col), (my_shape.0.value(), ncols.value()), (0, 0));
@@ -469,7 +469,7 @@ macro_rules! matrix_slice_impl (
         /// or may not be values known at compile-time.
         #[inline]
         pub fn $columns_generic_with_step<CSlice: Dim>($me: $Me, first_col: usize, ncols: CSlice, step: usize)
-            -> $MatrixSlice<'_, T, R, CSlice, S::RStride, Dynamic> {
+            -> $MatrixView<'_, T, R, CSlice, S::RStride, Dynamic> {
 
             let my_shape   = $me.shape_generic();
             let my_strides = $me.data.strides();
@@ -494,7 +494,7 @@ macro_rules! matrix_slice_impl (
         /// consecutive elements.
         #[inline]
         pub fn $slice($me: $Me, start: (usize, usize), shape: (usize, usize))
-            -> $MatrixSlice<'_, T, Dynamic, Dynamic, S::RStride, S::CStride> {
+            -> $MatrixView<'_, T, Dynamic, Dynamic, S::RStride, S::CStride> {
 
             $me.assert_slice_index(start, shape, (0, 0));
             let shape = (Dynamic::new(shape.0), Dynamic::new(shape.1));
@@ -512,7 +512,7 @@ macro_rules! matrix_slice_impl (
         /// original matrix.
         #[inline]
         pub fn $slice_with_steps($me: $Me, start: (usize, usize), shape: (usize, usize), steps: (usize, usize))
-            -> $MatrixSlice<'_, T, Dynamic, Dynamic, Dynamic, Dynamic> {
+            -> $MatrixView<'_, T, Dynamic, Dynamic, Dynamic, Dynamic> {
             let shape = (Dynamic::new(shape.0), Dynamic::new(shape.1));
 
             $me.$generic_slice_with_steps(start, shape, steps)
@@ -522,7 +522,7 @@ macro_rules! matrix_slice_impl (
         /// CSlice::dim())` consecutive components.
         #[inline]
         pub fn $fixed_slice<const RSLICE: usize, const CSLICE: usize>($me: $Me, irow: usize, icol: usize)
-            -> $MatrixSlice<'_, T, Const<RSLICE>, Const<CSLICE>, S::RStride, S::CStride> {
+            -> $MatrixView<'_, T, Const<RSLICE>, Const<CSLICE>, S::RStride, S::CStride> {
 
             $me.assert_slice_index((irow, icol), (RSLICE, CSLICE), (0, 0));
             let shape = (Const::<RSLICE>, Const::<CSLICE>);
@@ -539,7 +539,7 @@ macro_rules! matrix_slice_impl (
         /// the original matrix.
         #[inline]
         pub fn $fixed_slice_with_steps<const RSLICE: usize, const CSLICE: usize>($me: $Me, start: (usize, usize), steps: (usize, usize))
-            -> $MatrixSlice<'_, T, Const<RSLICE>, Const<CSLICE>, Dynamic, Dynamic> {
+            -> $MatrixView<'_, T, Const<RSLICE>, Const<CSLICE>, Dynamic, Dynamic> {
             let shape = (Const::<RSLICE>, Const::<CSLICE>);
             $me.$generic_slice_with_steps(start, shape, steps)
         }
@@ -547,7 +547,7 @@ macro_rules! matrix_slice_impl (
         /// Creates a slice that may or may not have a fixed size and stride.
         #[inline]
         pub fn $generic_slice<RSlice, CSlice>($me: $Me, start: (usize, usize), shape: (RSlice, CSlice))
-            -> $MatrixSlice<'_, T, RSlice, CSlice, S::RStride, S::CStride>
+            -> $MatrixView<'_, T, RSlice, CSlice, S::RStride, S::CStride>
             where RSlice: Dim,
                   CSlice: Dim {
 
@@ -565,7 +565,7 @@ macro_rules! matrix_slice_impl (
                                                          start: (usize, usize),
                                                          shape: (RSlice, CSlice),
                                                          steps: (usize, usize))
-            -> $MatrixSlice<'_, T, RSlice, CSlice, Dynamic, Dynamic>
+            -> $MatrixView<'_, T, RSlice, CSlice, Dynamic, Dynamic>
             where RSlice: Dim,
                   CSlice: Dim {
 
@@ -591,8 +591,8 @@ macro_rules! matrix_slice_impl (
         /// Panics if the ranges overlap or if the first range is empty.
         #[inline]
         pub fn $rows_range_pair<Range1: SliceRange<R>, Range2: SliceRange<R>>($me: $Me, r1: Range1, r2: Range2)
-            -> ($MatrixSlice<'_, T, Range1::Size, C, S::RStride, S::CStride>,
-                $MatrixSlice<'_, T, Range2::Size, C, S::RStride, S::CStride>) {
+            -> ($MatrixView<'_, T, Range1::Size, C, S::RStride, S::CStride>,
+                $MatrixView<'_, T, Range2::Size, C, S::RStride, S::CStride>) {
 
             let (nrows, ncols) = $me.shape_generic();
             let strides        = $me.data.strides();
@@ -627,8 +627,8 @@ macro_rules! matrix_slice_impl (
         /// Panics if the ranges overlap or if the first range is empty.
         #[inline]
         pub fn $columns_range_pair<Range1: SliceRange<C>, Range2: SliceRange<C>>($me: $Me, r1: Range1, r2: Range2)
-            -> ($MatrixSlice<'_, T, R, Range1::Size, S::RStride, S::CStride>,
-                $MatrixSlice<'_, T, R, Range2::Size, S::RStride, S::CStride>) {
+            -> ($MatrixView<'_, T, R, Range1::Size, S::RStride, S::CStride>,
+                $MatrixView<'_, T, R, Range2::Size, S::RStride, S::CStride>) {
 
             let (nrows, ncols) = $me.shape_generic();
             let strides        = $me.data.strides();
@@ -661,16 +661,37 @@ macro_rules! matrix_slice_impl (
 );
 
 /// A matrix slice.
+///
+/// This type alias exists only for legacy purposes and is deprecated. It will be removed
+/// in a future release. Please use [`MatrixView`] instead.
+/// See [issue #1076](https://github.com/dimforge/nalgebra/issues/1076)
+/// for the rationale.
+#[deprecated = "Use MatrixView instead."]
 pub type MatrixSlice<'a, T, R, C, RStride = U1, CStride = R> =
+    MatrixView<'a, T, R, C, RStride, CStride>;
+
+/// A matrix view.
+pub type MatrixView<'a, T, R, C, RStride = U1, CStride = R> =
     Matrix<T, R, C, ViewStorage<'a, T, R, C, RStride, CStride>>;
+
 /// A mutable matrix slice.
+///
+/// This type alias exists only for legacy purposes and is deprecated. It will be removed
+/// in a future release. Please use [`MatrixViewMut`] instead.
+/// See [issue #1076](https://github.com/dimforge/nalgebra/issues/1076)
+/// for the rationale.
+#[deprecated = "Use MatrixViewMut instead."]
 pub type MatrixSliceMut<'a, T, R, C, RStride = U1, CStride = R> =
+    MatrixViewMut<'a, T, R, C, RStride, CStride>;
+
+/// A mutable matrix view.
+pub type MatrixViewMut<'a, T, R, C, RStride = U1, CStride = R> =
     Matrix<T, R, C, ViewStorageMut<'a, T, R, C, RStride, CStride>>;
 
 /// # Slicing based on index and length
 impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     matrix_slice_impl!(
-     self: &Self, MatrixSlice, ViewStorage, RawStorage.get_address_unchecked(), &self.data;
+     self: &Self, MatrixView, ViewStorage, RawStorage.get_address_unchecked(), &self.data;
      row,
      row_part,
      rows,
@@ -700,7 +721,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
 /// # Mutable slicing based on index and length
 impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
     matrix_slice_impl!(
-     self: &mut Self, MatrixSliceMut, ViewStorageMut, RawStorageMut.get_address_unchecked_mut(), &mut self.data;
+     self: &mut Self, MatrixViewMut, ViewStorageMut, RawStorageMut.get_address_unchecked_mut(), &mut self.data;
      row_mut,
      row_part_mut,
      rows_mut,
@@ -872,7 +893,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
         &self,
         rows: RowRange,
         cols: ColRange,
-    ) -> MatrixSlice<'_, T, RowRange::Size, ColRange::Size, S::RStride, S::CStride>
+    ) -> MatrixView<'_, T, RowRange::Size, ColRange::Size, S::RStride, S::CStride>
     where
         RowRange: SliceRange<R>,
         ColRange: SliceRange<C>,
@@ -890,7 +911,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     pub fn rows_range<RowRange: SliceRange<R>>(
         &self,
         rows: RowRange,
-    ) -> MatrixSlice<'_, T, RowRange::Size, C, S::RStride, S::CStride> {
+    ) -> MatrixView<'_, T, RowRange::Size, C, S::RStride, S::CStride> {
         self.slice_range(rows, ..)
     }
 
@@ -900,7 +921,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     pub fn columns_range<ColRange: SliceRange<C>>(
         &self,
         cols: ColRange,
-    ) -> MatrixSlice<'_, T, R, ColRange::Size, S::RStride, S::CStride> {
+    ) -> MatrixView<'_, T, R, ColRange::Size, S::RStride, S::CStride> {
         self.slice_range(.., cols)
     }
 }
@@ -914,7 +935,7 @@ impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
         &mut self,
         rows: RowRange,
         cols: ColRange,
-    ) -> MatrixSliceMut<'_, T, RowRange::Size, ColRange::Size, S::RStride, S::CStride>
+    ) -> MatrixViewMut<'_, T, RowRange::Size, ColRange::Size, S::RStride, S::CStride>
     where
         RowRange: SliceRange<R>,
         ColRange: SliceRange<C>,
@@ -931,7 +952,7 @@ impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
     pub fn rows_range_mut<RowRange: SliceRange<R>>(
         &mut self,
         rows: RowRange,
-    ) -> MatrixSliceMut<'_, T, RowRange::Size, C, S::RStride, S::CStride> {
+    ) -> MatrixViewMut<'_, T, RowRange::Size, C, S::RStride, S::CStride> {
         self.slice_range_mut(rows, ..)
     }
 
@@ -940,20 +961,20 @@ impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
     pub fn columns_range_mut<ColRange: SliceRange<C>>(
         &mut self,
         cols: ColRange,
-    ) -> MatrixSliceMut<'_, T, R, ColRange::Size, S::RStride, S::CStride> {
+    ) -> MatrixViewMut<'_, T, R, ColRange::Size, S::RStride, S::CStride> {
         self.slice_range_mut(.., cols)
     }
 }
 
-impl<'a, T, R, C, RStride, CStride> From<MatrixSliceMut<'a, T, R, C, RStride, CStride>>
-    for MatrixSlice<'a, T, R, C, RStride, CStride>
+impl<'a, T, R, C, RStride, CStride> From<MatrixViewMut<'a, T, R, C, RStride, CStride>>
+    for MatrixView<'a, T, R, C, RStride, CStride>
 where
     R: Dim,
     C: Dim,
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(slice_mut: MatrixSliceMut<'a, T, R, C, RStride, CStride>) -> Self {
+    fn from(slice_mut: MatrixViewMut<'a, T, R, C, RStride, CStride>) -> Self {
         let data = ViewStorage {
             ptr: slice_mut.data.ptr,
             shape: slice_mut.data.shape,
diff --git a/src/geometry/quaternion.rs b/src/geometry/quaternion.rs
index 293ab125..34eda897 100755
--- a/src/geometry/quaternion.rs
+++ b/src/geometry/quaternion.rs
@@ -14,7 +14,7 @@ use simba::simd::{SimdBool, SimdOption, SimdRealField};
 use crate::base::dimension::{U1, U3, U4};
 use crate::base::storage::{CStride, RStride};
 use crate::base::{
-    Matrix3, Matrix4, MatrixSlice, MatrixSliceMut, Normed, Scalar, Unit, Vector3, Vector4,
+    Matrix3, Matrix4, MatrixView, MatrixViewMut, Normed, Scalar, Unit, Vector3, Vector4,
 };
 
 use crate::geometry::{Point3, Rotation};
@@ -191,7 +191,7 @@ where
     /// ```
     #[inline]
     #[must_use]
-    pub fn vector(&self) -> MatrixSlice<'_, T, U3, U1, RStride<T, U4, U1>, CStride<T, U4, U1>> {
+    pub fn vector(&self) -> MatrixView<'_, T, U3, U1, RStride<T, U4, U1>, CStride<T, U4, U1>> {
         self.coords.fixed_rows::<3>(0)
     }
 
@@ -584,7 +584,7 @@ where
     #[inline]
     pub fn vector_mut(
         &mut self,
-    ) -> MatrixSliceMut<'_, T, U3, U1, RStride<T, U4, U1>, CStride<T, U4, U1>> {
+    ) -> MatrixViewMut<'_, T, U3, U1, RStride<T, U4, U1>, CStride<T, U4, U1>> {
         self.coords.fixed_rows_mut::<3>(0)
     }
 

From 9a7e92e90232cac0ec2d5635c2dc705b0faae1d4 Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Fri, 11 Nov 2022 17:29:55 +0100
Subject: [PATCH 69/91] Rename matrix_slice.rs to matrix_view.rs

---
 src/base/alias_slice.rs                      | 2 +-
 src/base/construction_slice.rs               | 2 +-
 src/base/{matrix_slice.rs => matrix_view.rs} | 0
 src/base/mod.rs                              | 4 ++--
 4 files changed, 4 insertions(+), 4 deletions(-)
 rename src/base/{matrix_slice.rs => matrix_view.rs} (100%)

diff --git a/src/base/alias_slice.rs b/src/base/alias_slice.rs
index 21cde51c..6ed967b6 100644
--- a/src/base/alias_slice.rs
+++ b/src/base/alias_slice.rs
@@ -1,5 +1,5 @@
 use crate::base::dimension::{Dynamic, U1, U2, U3, U4, U5, U6};
-use crate::base::matrix_slice::{ViewStorage, ViewStorageMut};
+use crate::base::matrix_view::{ViewStorage, ViewStorageMut};
 use crate::base::{Const, Matrix};
 
 /*
diff --git a/src/base/construction_slice.rs b/src/base/construction_slice.rs
index e54d824c..d6a1f708 100644
--- a/src/base/construction_slice.rs
+++ b/src/base/construction_slice.rs
@@ -1,5 +1,5 @@
 use crate::base::dimension::{Const, Dim, DimName, Dynamic};
-use crate::base::matrix_slice::{ViewStorage, ViewStorageMut};
+use crate::base::matrix_view::{ViewStorage, ViewStorageMut};
 use crate::base::{MatrixView, MatrixSliceMutMN, Scalar};
 
 use num_rational::Ratio;
diff --git a/src/base/matrix_slice.rs b/src/base/matrix_view.rs
similarity index 100%
rename from src/base/matrix_slice.rs
rename to src/base/matrix_view.rs
diff --git a/src/base/mod.rs b/src/base/mod.rs
index c6279ba3..ed1b5d44 100644
--- a/src/base/mod.rs
+++ b/src/base/mod.rs
@@ -23,7 +23,7 @@ mod edition;
 pub mod indexing;
 mod matrix;
 mod matrix_simba;
-mod matrix_slice;
+mod matrix_view;
 mod norm;
 mod properties;
 mod scalar;
@@ -52,7 +52,7 @@ pub use self::dimension::*;
 pub use self::alias::*;
 pub use self::alias_slice::*;
 pub use self::array_storage::*;
-pub use self::matrix_slice::*;
+pub use self::matrix_view::*;
 pub use self::storage::*;
 #[cfg(any(feature = "std", feature = "alloc"))]
 pub use self::vec_storage::*;

From 4234883d234aed7389215ce5f1dc05b331c8a83c Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Fri, 11 Nov 2022 17:36:50 +0100
Subject: [PATCH 70/91] Add View type aliases

---
 src/base/alias_view.rs | 589 +++++++++++++++++++++++++++++++++++++++++
 src/base/mod.rs        |   2 +
 2 files changed, 591 insertions(+)
 create mode 100644 src/base/alias_view.rs

diff --git a/src/base/alias_view.rs b/src/base/alias_view.rs
new file mode 100644
index 00000000..1bbee3f8
--- /dev/null
+++ b/src/base/alias_view.rs
@@ -0,0 +1,589 @@
+use crate::base::dimension::{Dynamic, U1, U2, U3, U4, U5, U6};
+use crate::base::matrix_view::{ViewStorage, ViewStorageMut};
+use crate::base::{Const, Matrix};
+
+/*
+ *
+ *
+ * Matrix view aliases.
+ *
+ *
+ */
+// NOTE: we can't provide defaults for the strides because it's not supported yet by min_const_generics.
+/// A column-major matrix view with dimensions known at compile-time.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type SMatrixView<'a, T, const R: usize, const C: usize> =
+    Matrix<T, Const<R>, Const<C>, ViewStorage<'a, T, Const<R>, Const<C>, Const<1>, Const<R>>>;
+
+/// A column-major matrix view dynamic numbers of rows and columns.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type DMatrixView<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, Dynamic, ViewStorage<'a, T, Dynamic, Dynamic, RStride, CStride>>;
+
+/// A column-major 1x1 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView1<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U1, ViewStorage<'a, T, U1, U1, RStride, CStride>>;
+/// A column-major 2x2 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView2<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U2, ViewStorage<'a, T, U2, U2, RStride, CStride>>;
+/// A column-major 3x3 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView3<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U3, ViewStorage<'a, T, U3, U3, RStride, CStride>>;
+/// A column-major 4x4 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView4<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U4, ViewStorage<'a, T, U4, U4, RStride, CStride>>;
+/// A column-major 5x5 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView5<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U5, ViewStorage<'a, T, U5, U5, RStride, CStride>>;
+/// A column-major 6x6 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView6<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U6, ViewStorage<'a, T, U6, U6, RStride, CStride>>;
+
+/// A column-major 1x2 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView1x2<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U2, ViewStorage<'a, T, U1, U2, RStride, CStride>>;
+/// A column-major 1x3 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView1x3<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U3, ViewStorage<'a, T, U1, U3, RStride, CStride>>;
+/// A column-major 1x4 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView1x4<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U4, ViewStorage<'a, T, U1, U4, RStride, CStride>>;
+/// A column-major 1x5 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView1x5<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U5, ViewStorage<'a, T, U1, U5, RStride, CStride>>;
+/// A column-major 1x6 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView1x6<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U6, ViewStorage<'a, T, U1, U6, RStride, CStride>>;
+
+/// A column-major 2x1 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView2x1<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U1, ViewStorage<'a, T, U2, U1, RStride, CStride>>;
+/// A column-major 2x3 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView2x3<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U3, ViewStorage<'a, T, U2, U3, RStride, CStride>>;
+/// A column-major 2x4 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView2x4<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U4, ViewStorage<'a, T, U2, U4, RStride, CStride>>;
+/// A column-major 2x5 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView2x5<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U5, ViewStorage<'a, T, U2, U5, RStride, CStride>>;
+/// A column-major 2x6 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView2x6<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U6, ViewStorage<'a, T, U2, U6, RStride, CStride>>;
+
+/// A column-major 3x1 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView3x1<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U1, ViewStorage<'a, T, U3, U1, RStride, CStride>>;
+/// A column-major 3x2 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView3x2<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U2, ViewStorage<'a, T, U3, U2, RStride, CStride>>;
+/// A column-major 3x4 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView3x4<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U4, ViewStorage<'a, T, U3, U4, RStride, CStride>>;
+/// A column-major 3x5 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView3x5<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U5, ViewStorage<'a, T, U3, U5, RStride, CStride>>;
+/// A column-major 3x6 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView3x6<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U6, ViewStorage<'a, T, U3, U6, RStride, CStride>>;
+
+/// A column-major 4x1 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView4x1<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U1, ViewStorage<'a, T, U4, U1, RStride, CStride>>;
+/// A column-major 4x2 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView4x2<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U2, ViewStorage<'a, T, U4, U2, RStride, CStride>>;
+/// A column-major 4x3 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView4x3<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U3, ViewStorage<'a, T, U4, U3, RStride, CStride>>;
+/// A column-major 4x5 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView4x5<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U5, ViewStorage<'a, T, U4, U5, RStride, CStride>>;
+/// A column-major 4x6 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView4x6<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U6, ViewStorage<'a, T, U4, U6, RStride, CStride>>;
+
+/// A column-major 5x1 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView5x1<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U1, ViewStorage<'a, T, U5, U1, RStride, CStride>>;
+/// A column-major 5x2 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView5x2<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U2, ViewStorage<'a, T, U5, U2, RStride, CStride>>;
+/// A column-major 5x3 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView5x3<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U3, ViewStorage<'a, T, U5, U3, RStride, CStride>>;
+/// A column-major 5x4 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView5x4<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U4, ViewStorage<'a, T, U5, U4, RStride, CStride>>;
+/// A column-major 5x6 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView5x6<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U6, ViewStorage<'a, T, U5, U6, RStride, CStride>>;
+
+/// A column-major 6x1 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView6x1<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U1, ViewStorage<'a, T, U6, U1, RStride, CStride>>;
+/// A column-major 6x2 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView6x2<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U2, ViewStorage<'a, T, U6, U2, RStride, CStride>>;
+/// A column-major 6x3 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView6x3<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U3, ViewStorage<'a, T, U6, U3, RStride, CStride>>;
+/// A column-major 6x4 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView6x4<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U4, ViewStorage<'a, T, U6, U4, RStride, CStride>>;
+/// A column-major 6x5 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixView6x5<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U5, ViewStorage<'a, T, U6, U5, RStride, CStride>>;
+
+/// A column-major matrix view with 1 row and a number of columns chosen at runtime.
+pub type MatrixView1xX<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, Dynamic, ViewStorage<'a, T, U1, Dynamic, RStride, CStride>>;
+/// A column-major matrix view with 2 rows and a number of columns chosen at runtime.
+pub type MatrixView2xX<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, Dynamic, ViewStorage<'a, T, U2, Dynamic, RStride, CStride>>;
+/// A column-major matrix view with 3 rows and a number of columns chosen at runtime.
+pub type MatrixView3xX<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, Dynamic, ViewStorage<'a, T, U3, Dynamic, RStride, CStride>>;
+/// A column-major matrix view with 4 rows and a number of columns chosen at runtime.
+pub type MatrixView4xX<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, Dynamic, ViewStorage<'a, T, U4, Dynamic, RStride, CStride>>;
+/// A column-major matrix view with 5 rows and a number of columns chosen at runtime.
+pub type MatrixView5xX<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, Dynamic, ViewStorage<'a, T, U5, Dynamic, RStride, CStride>>;
+/// A column-major matrix view with 6 rows and a number of columns chosen at runtime.
+pub type MatrixView6xX<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, Dynamic, ViewStorage<'a, T, U6, Dynamic, RStride, CStride>>;
+
+/// A column-major matrix view with a number of rows chosen at runtime and 1 column.
+pub type MatrixViewXx1<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U1, ViewStorage<'a, T, Dynamic, U1, RStride, CStride>>;
+/// A column-major matrix view with a number of rows chosen at runtime and 2 columns.
+pub type MatrixViewXx2<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U2, ViewStorage<'a, T, Dynamic, U2, RStride, CStride>>;
+/// A column-major matrix view with a number of rows chosen at runtime and 3 columns.
+pub type MatrixViewXx3<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U3, ViewStorage<'a, T, Dynamic, U3, RStride, CStride>>;
+/// A column-major matrix view with a number of rows chosen at runtime and 4 columns.
+pub type MatrixViewXx4<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U4, ViewStorage<'a, T, Dynamic, U4, RStride, CStride>>;
+/// A column-major matrix view with a number of rows chosen at runtime and 5 columns.
+pub type MatrixViewXx5<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U5, ViewStorage<'a, T, Dynamic, U5, RStride, CStride>>;
+/// A column-major matrix view with a number of rows chosen at runtime and 6 columns.
+pub type MatrixViewXx6<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U6, ViewStorage<'a, T, Dynamic, U6, RStride, CStride>>;
+
+/// A column vector view with dimensions known at compile-time.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorView<'a, T, D, RStride = U1, CStride = D> =
+    Matrix<T, D, U1, ViewStorage<'a, T, D, U1, RStride, CStride>>;
+
+/// A column vector view with dimensions known at compile-time.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type SVectorView<'a, T, const D: usize> =
+    Matrix<T, Const<D>, Const<1>, ViewStorage<'a, T, Const<D>, Const<1>, Const<1>, Const<D>>>;
+
+/// A column vector view dynamic numbers of rows and columns.
+pub type DVectorView<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U1, ViewStorage<'a, T, Dynamic, U1, RStride, CStride>>;
+
+/// A 1D column vector view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorView1<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U1, ViewStorage<'a, T, U1, U1, RStride, CStride>>;
+/// A 2D column vector view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorView2<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U1, ViewStorage<'a, T, U2, U1, RStride, CStride>>;
+/// A 3D column vector view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorView3<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U1, ViewStorage<'a, T, U3, U1, RStride, CStride>>;
+/// A 4D column vector view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorView4<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U1, ViewStorage<'a, T, U4, U1, RStride, CStride>>;
+/// A 5D column vector view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorView5<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U1, ViewStorage<'a, T, U5, U1, RStride, CStride>>;
+/// A 6D column vector view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorView6<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U1, ViewStorage<'a, T, U6, U1, RStride, CStride>>;
+
+/*
+ *
+ *
+ * Same thing, but for mutable views.
+ *
+ *
+ */
+
+/// A column-major matrix view with dimensions known at compile-time.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type SMatrixViewMut<'a, T, const R: usize, const C: usize> =
+    Matrix<T, Const<R>, Const<C>, ViewStorageMut<'a, T, Const<R>, Const<C>, Const<1>, Const<R>>>;
+
+/// A column-major matrix view dynamic numbers of rows and columns.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type DMatrixViewMut<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, Dynamic, ViewStorageMut<'a, T, Dynamic, Dynamic, RStride, CStride>>;
+
+/// A column-major 1x1 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut1<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U1, ViewStorageMut<'a, T, U1, U1, RStride, CStride>>;
+/// A column-major 2x2 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut2<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U2, ViewStorageMut<'a, T, U2, U2, RStride, CStride>>;
+/// A column-major 3x3 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut3<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U3, ViewStorageMut<'a, T, U3, U3, RStride, CStride>>;
+/// A column-major 4x4 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut4<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U4, ViewStorageMut<'a, T, U4, U4, RStride, CStride>>;
+/// A column-major 5x5 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut5<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U5, ViewStorageMut<'a, T, U5, U5, RStride, CStride>>;
+/// A column-major 6x6 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut6<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U6, ViewStorageMut<'a, T, U6, U6, RStride, CStride>>;
+
+/// A column-major 1x2 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut1x2<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U2, ViewStorageMut<'a, T, U1, U2, RStride, CStride>>;
+/// A column-major 1x3 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut1x3<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U3, ViewStorageMut<'a, T, U1, U3, RStride, CStride>>;
+/// A column-major 1x4 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut1x4<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U4, ViewStorageMut<'a, T, U1, U4, RStride, CStride>>;
+/// A column-major 1x5 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut1x5<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U5, ViewStorageMut<'a, T, U1, U5, RStride, CStride>>;
+/// A column-major 1x6 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut1x6<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U6, ViewStorageMut<'a, T, U1, U6, RStride, CStride>>;
+
+/// A column-major 2x1 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut2x1<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U1, ViewStorageMut<'a, T, U2, U1, RStride, CStride>>;
+/// A column-major 2x3 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut2x3<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U3, ViewStorageMut<'a, T, U2, U3, RStride, CStride>>;
+/// A column-major 2x4 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut2x4<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U4, ViewStorageMut<'a, T, U2, U4, RStride, CStride>>;
+/// A column-major 2x5 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut2x5<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U5, ViewStorageMut<'a, T, U2, U5, RStride, CStride>>;
+/// A column-major 2x6 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut2x6<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U6, ViewStorageMut<'a, T, U2, U6, RStride, CStride>>;
+
+/// A column-major 3x1 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut3x1<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U1, ViewStorageMut<'a, T, U3, U1, RStride, CStride>>;
+/// A column-major 3x2 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut3x2<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U2, ViewStorageMut<'a, T, U3, U2, RStride, CStride>>;
+/// A column-major 3x4 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut3x4<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U4, ViewStorageMut<'a, T, U3, U4, RStride, CStride>>;
+/// A column-major 3x5 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut3x5<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U5, ViewStorageMut<'a, T, U3, U5, RStride, CStride>>;
+/// A column-major 3x6 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut3x6<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U6, ViewStorageMut<'a, T, U3, U6, RStride, CStride>>;
+
+/// A column-major 4x1 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut4x1<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U1, ViewStorageMut<'a, T, U4, U1, RStride, CStride>>;
+/// A column-major 4x2 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut4x2<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U2, ViewStorageMut<'a, T, U4, U2, RStride, CStride>>;
+/// A column-major 4x3 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut4x3<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U3, ViewStorageMut<'a, T, U4, U3, RStride, CStride>>;
+/// A column-major 4x5 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut4x5<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U5, ViewStorageMut<'a, T, U4, U5, RStride, CStride>>;
+/// A column-major 4x6 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut4x6<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U6, ViewStorageMut<'a, T, U4, U6, RStride, CStride>>;
+
+/// A column-major 5x1 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut5x1<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U1, ViewStorageMut<'a, T, U5, U1, RStride, CStride>>;
+/// A column-major 5x2 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut5x2<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U2, ViewStorageMut<'a, T, U5, U2, RStride, CStride>>;
+/// A column-major 5x3 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut5x3<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U3, ViewStorageMut<'a, T, U5, U3, RStride, CStride>>;
+/// A column-major 5x4 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut5x4<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U4, ViewStorageMut<'a, T, U5, U4, RStride, CStride>>;
+/// A column-major 5x6 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut5x6<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U6, ViewStorageMut<'a, T, U5, U6, RStride, CStride>>;
+
+/// A column-major 6x1 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut6x1<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U1, ViewStorageMut<'a, T, U6, U1, RStride, CStride>>;
+/// A column-major 6x2 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut6x2<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U2, ViewStorageMut<'a, T, U6, U2, RStride, CStride>>;
+/// A column-major 6x3 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut6x3<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U3, ViewStorageMut<'a, T, U6, U3, RStride, CStride>>;
+/// A column-major 6x4 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut6x4<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U4, ViewStorageMut<'a, T, U6, U4, RStride, CStride>>;
+/// A column-major 6x5 matrix view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type MatrixViewMut6x5<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U5, ViewStorageMut<'a, T, U6, U5, RStride, CStride>>;
+
+/// A column-major matrix view with 1 row and a number of columns chosen at runtime.
+pub type MatrixViewMut1xX<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, Dynamic, ViewStorageMut<'a, T, U1, Dynamic, RStride, CStride>>;
+/// A column-major matrix view with 2 rows and a number of columns chosen at runtime.
+pub type MatrixViewMut2xX<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, Dynamic, ViewStorageMut<'a, T, U2, Dynamic, RStride, CStride>>;
+/// A column-major matrix view with 3 rows and a number of columns chosen at runtime.
+pub type MatrixViewMut3xX<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, Dynamic, ViewStorageMut<'a, T, U3, Dynamic, RStride, CStride>>;
+/// A column-major matrix view with 4 rows and a number of columns chosen at runtime.
+pub type MatrixViewMut4xX<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, Dynamic, ViewStorageMut<'a, T, U4, Dynamic, RStride, CStride>>;
+/// A column-major matrix view with 5 rows and a number of columns chosen at runtime.
+pub type MatrixViewMut5xX<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, Dynamic, ViewStorageMut<'a, T, U5, Dynamic, RStride, CStride>>;
+/// A column-major matrix view with 6 rows and a number of columns chosen at runtime.
+pub type MatrixViewMut6xX<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, Dynamic, ViewStorageMut<'a, T, U6, Dynamic, RStride, CStride>>;
+
+/// A column-major matrix view with a number of rows chosen at runtime and 1 column.
+pub type MatrixViewMutXx1<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U1, ViewStorageMut<'a, T, Dynamic, U1, RStride, CStride>>;
+/// A column-major matrix view with a number of rows chosen at runtime and 2 columns.
+pub type MatrixViewMutXx2<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U2, ViewStorageMut<'a, T, Dynamic, U2, RStride, CStride>>;
+/// A column-major matrix view with a number of rows chosen at runtime and 3 columns.
+pub type MatrixViewMutXx3<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U3, ViewStorageMut<'a, T, Dynamic, U3, RStride, CStride>>;
+/// A column-major matrix view with a number of rows chosen at runtime and 4 columns.
+pub type MatrixViewMutXx4<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U4, ViewStorageMut<'a, T, Dynamic, U4, RStride, CStride>>;
+/// A column-major matrix view with a number of rows chosen at runtime and 5 columns.
+pub type MatrixViewMutXx5<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U5, ViewStorageMut<'a, T, Dynamic, U5, RStride, CStride>>;
+/// A column-major matrix view with a number of rows chosen at runtime and 6 columns.
+pub type MatrixViewMutXx6<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U6, ViewStorageMut<'a, T, Dynamic, U6, RStride, CStride>>;
+
+/// A column vector view with dimensions known at compile-time.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorViewMut<'a, T, D, RStride = U1, CStride = D> =
+    Matrix<T, D, U1, ViewStorageMut<'a, T, D, U1, RStride, CStride>>;
+
+/// A column vector view with dimensions known at compile-time.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type SVectorViewMut<'a, T, const D: usize> =
+    Matrix<T, Const<D>, Const<1>, ViewStorageMut<'a, T, Const<D>, Const<1>, Const<1>, Const<D>>>;
+
+/// A column vector view dynamic numbers of rows and columns.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type DVectorViewMut<'a, T, RStride = U1, CStride = Dynamic> =
+    Matrix<T, Dynamic, U1, ViewStorageMut<'a, T, Dynamic, U1, RStride, CStride>>;
+
+/// A 1D column vector view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorViewMut1<'a, T, RStride = U1, CStride = U1> =
+    Matrix<T, U1, U1, ViewStorageMut<'a, T, U1, U1, RStride, CStride>>;
+/// A 2D column vector view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorViewMut2<'a, T, RStride = U1, CStride = U2> =
+    Matrix<T, U2, U1, ViewStorageMut<'a, T, U2, U1, RStride, CStride>>;
+/// A 3D column vector view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorViewMut3<'a, T, RStride = U1, CStride = U3> =
+    Matrix<T, U3, U1, ViewStorageMut<'a, T, U3, U1, RStride, CStride>>;
+/// A 4D column vector view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorViewMut4<'a, T, RStride = U1, CStride = U4> =
+    Matrix<T, U4, U1, ViewStorageMut<'a, T, U4, U1, RStride, CStride>>;
+/// A 5D column vector view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorViewMut5<'a, T, RStride = U1, CStride = U5> =
+    Matrix<T, U5, U1, ViewStorageMut<'a, T, U5, U1, RStride, CStride>>;
+/// A 6D column vector view.
+///
+/// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+pub type VectorViewMut6<'a, T, RStride = U1, CStride = U6> =
+    Matrix<T, U6, U1, ViewStorageMut<'a, T, U6, U1, RStride, CStride>>;
diff --git a/src/base/mod.rs b/src/base/mod.rs
index ed1b5d44..6fb3685d 100644
--- a/src/base/mod.rs
+++ b/src/base/mod.rs
@@ -12,6 +12,7 @@ pub mod storage;
 
 mod alias;
 mod alias_slice;
+mod alias_view;
 mod array_storage;
 mod cg;
 mod componentwise;
@@ -51,6 +52,7 @@ pub use self::dimension::*;
 
 pub use self::alias::*;
 pub use self::alias_slice::*;
+pub use self::alias_view::*;
 pub use self::array_storage::*;
 pub use self::matrix_view::*;
 pub use self::storage::*;

From 0981f9c66098958ae887220f9972fdde58395182 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Crozet?= <developer@crozet.re>
Date: Sun, 13 Nov 2022 18:40:03 +0100
Subject: [PATCH 71/91] Release v0.31.4

---
 CHANGELOG.md | 6 ++++++
 Cargo.toml   | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ac297f20..45c48063 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -5,6 +5,12 @@ documented here.
 This project adheres to [Semantic Versioning](https://semver.org/).
 
 
+## [0.31.4] (13 Nov. 2022)
+
+### Added
+- Add a `convert-glam022` feature to enable conversion between `nalgebra` and `glam v0.22`.
+
+
 ## [0.31.3] (30 Oct. 2022)
 
 ### Added
diff --git a/Cargo.toml b/Cargo.toml
index bcfa07d2..985a8918 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name    = "nalgebra"
-version = "0.31.3"
+version = "0.31.4"
 authors = [ "Sébastien Crozet <developer@crozet.re>" ]
 
 description = "General-purpose linear algebra library with transformations and statically-sized or dynamically-sized matrices."

From e245e1148a07cffc2e4752d6679fd5b8495338eb Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 09:26:45 +0100
Subject: [PATCH 72/91] Deprecate slice type aliases

---
 src/base/alias_slice.rs | 126 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 126 insertions(+)

diff --git a/src/base/alias_slice.rs b/src/base/alias_slice.rs
index 6ed967b6..d0fb6676 100644
--- a/src/base/alias_slice.rs
+++ b/src/base/alias_slice.rs
@@ -2,6 +2,14 @@ use crate::base::dimension::{Dynamic, U1, U2, U3, U4, U5, U6};
 use crate::base::matrix_view::{ViewStorage, ViewStorageMut};
 use crate::base::{Const, Matrix};
 
+/// Generates an appropriate deprecation note with a suggestion for replacement.
+macro_rules! deprecation_note {
+    ($replacement:ident) => {
+        concat!("Use ", stringify!($replacement),
+            r###" instead. See [issue #1076](https://github.com/dimforge/nalgebra/issues/1076) for more information."###)
+    }
+}
+
 /*
  *
  *
@@ -13,284 +21,343 @@ use crate::base::{Const, Matrix};
 /// A column-major matrix slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(SMatrixView)]
 pub type SMatrixSlice<'a, T, const R: usize, const C: usize> =
     Matrix<T, Const<R>, Const<C>, ViewStorage<'a, T, Const<R>, Const<C>, Const<1>, Const<R>>>;
 
 /// A column-major matrix slice dynamic numbers of rows and columns.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(DMatrixView)]
 pub type DMatrixSlice<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, Dynamic, ViewStorage<'a, T, Dynamic, Dynamic, RStride, CStride>>;
 
 /// A column-major 1x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView1)]
 pub type MatrixSlice1<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U1, ViewStorage<'a, T, U1, U1, RStride, CStride>>;
 /// A column-major 2x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView2)]
 pub type MatrixSlice2<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U2, ViewStorage<'a, T, U2, U2, RStride, CStride>>;
 /// A column-major 3x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView3)]
 pub type MatrixSlice3<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U3, ViewStorage<'a, T, U3, U3, RStride, CStride>>;
 /// A column-major 4x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView4)]
 pub type MatrixSlice4<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U4, ViewStorage<'a, T, U4, U4, RStride, CStride>>;
 /// A column-major 5x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView5)]
 pub type MatrixSlice5<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U5, ViewStorage<'a, T, U5, U5, RStride, CStride>>;
 /// A column-major 6x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView6)]
 pub type MatrixSlice6<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U6, ViewStorage<'a, T, U6, U6, RStride, CStride>>;
 
 /// A column-major 1x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView1x2)]
 pub type MatrixSlice1x2<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U2, ViewStorage<'a, T, U1, U2, RStride, CStride>>;
 /// A column-major 1x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView1x3)]
 pub type MatrixSlice1x3<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U3, ViewStorage<'a, T, U1, U3, RStride, CStride>>;
 /// A column-major 1x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView1x4)]
 pub type MatrixSlice1x4<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U4, ViewStorage<'a, T, U1, U4, RStride, CStride>>;
 /// A column-major 1x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView1x5)]
 pub type MatrixSlice1x5<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U5, ViewStorage<'a, T, U1, U5, RStride, CStride>>;
 /// A column-major 1x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView1x6)]
 pub type MatrixSlice1x6<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U6, ViewStorage<'a, T, U1, U6, RStride, CStride>>;
 
 /// A column-major 2x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView2x1)]
 pub type MatrixSlice2x1<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U1, ViewStorage<'a, T, U2, U1, RStride, CStride>>;
 /// A column-major 2x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView2x3)]
 pub type MatrixSlice2x3<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U3, ViewStorage<'a, T, U2, U3, RStride, CStride>>;
 /// A column-major 2x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView2x4)]
 pub type MatrixSlice2x4<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U4, ViewStorage<'a, T, U2, U4, RStride, CStride>>;
 /// A column-major 2x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView2x5)]
 pub type MatrixSlice2x5<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U5, ViewStorage<'a, T, U2, U5, RStride, CStride>>;
 /// A column-major 2x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView2x6)]
 pub type MatrixSlice2x6<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U6, ViewStorage<'a, T, U2, U6, RStride, CStride>>;
 
 /// A column-major 3x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView3x1)]
 pub type MatrixSlice3x1<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U1, ViewStorage<'a, T, U3, U1, RStride, CStride>>;
 /// A column-major 3x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView3x2)]
 pub type MatrixSlice3x2<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U2, ViewStorage<'a, T, U3, U2, RStride, CStride>>;
 /// A column-major 3x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView3x4)]
 pub type MatrixSlice3x4<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U4, ViewStorage<'a, T, U3, U4, RStride, CStride>>;
 /// A column-major 3x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView3x5)]
 pub type MatrixSlice3x5<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U5, ViewStorage<'a, T, U3, U5, RStride, CStride>>;
 /// A column-major 3x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView3x6)]
 pub type MatrixSlice3x6<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U6, ViewStorage<'a, T, U3, U6, RStride, CStride>>;
 
 /// A column-major 4x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView4x1)]
 pub type MatrixSlice4x1<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U1, ViewStorage<'a, T, U4, U1, RStride, CStride>>;
 /// A column-major 4x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView4x2)]
 pub type MatrixSlice4x2<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U2, ViewStorage<'a, T, U4, U2, RStride, CStride>>;
 /// A column-major 4x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView4x3)]
 pub type MatrixSlice4x3<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U3, ViewStorage<'a, T, U4, U3, RStride, CStride>>;
 /// A column-major 4x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView4x5)]
 pub type MatrixSlice4x5<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U5, ViewStorage<'a, T, U4, U5, RStride, CStride>>;
 /// A column-major 4x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView4x6)]
 pub type MatrixSlice4x6<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U6, ViewStorage<'a, T, U4, U6, RStride, CStride>>;
 
 /// A column-major 5x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView5x1)]
 pub type MatrixSlice5x1<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U1, ViewStorage<'a, T, U5, U1, RStride, CStride>>;
 /// A column-major 5x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView5x2)]
 pub type MatrixSlice5x2<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U2, ViewStorage<'a, T, U5, U2, RStride, CStride>>;
 /// A column-major 5x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView5x3)]
 pub type MatrixSlice5x3<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U3, ViewStorage<'a, T, U5, U3, RStride, CStride>>;
 /// A column-major 5x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView5x4)]
 pub type MatrixSlice5x4<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U4, ViewStorage<'a, T, U5, U4, RStride, CStride>>;
 /// A column-major 5x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView5x6)]
 pub type MatrixSlice5x6<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U6, ViewStorage<'a, T, U5, U6, RStride, CStride>>;
 
 /// A column-major 6x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView6x1)]
 pub type MatrixSlice6x1<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U1, ViewStorage<'a, T, U6, U1, RStride, CStride>>;
 /// A column-major 6x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView6x2)]
 pub type MatrixSlice6x2<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U2, ViewStorage<'a, T, U6, U2, RStride, CStride>>;
 /// A column-major 6x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView6x3)]
 pub type MatrixSlice6x3<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U3, ViewStorage<'a, T, U6, U3, RStride, CStride>>;
 /// A column-major 6x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView6x4)]
 pub type MatrixSlice6x4<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U4, ViewStorage<'a, T, U6, U4, RStride, CStride>>;
 /// A column-major 6x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixView6x5)]
 pub type MatrixSlice6x5<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U5, ViewStorage<'a, T, U6, U5, RStride, CStride>>;
 
 /// A column-major matrix slice with 1 row and a number of columns chosen at runtime.
+#[deprecated = deprecation_note!(MatrixView1xX)]
 pub type MatrixSlice1xX<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, Dynamic, ViewStorage<'a, T, U1, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 2 rows and a number of columns chosen at runtime.
+#[deprecated = deprecation_note!(MatrixView2xX)]
 pub type MatrixSlice2xX<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, Dynamic, ViewStorage<'a, T, U2, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 3 rows and a number of columns chosen at runtime.
+#[deprecated = deprecation_note!(MatrixView3xX)]
 pub type MatrixSlice3xX<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, Dynamic, ViewStorage<'a, T, U3, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 4 rows and a number of columns chosen at runtime.
+#[deprecated = deprecation_note!(MatrixView4xX)]
 pub type MatrixSlice4xX<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, Dynamic, ViewStorage<'a, T, U4, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 5 rows and a number of columns chosen at runtime.
+#[deprecated = deprecation_note!(MatrixView5xX)]
 pub type MatrixSlice5xX<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, Dynamic, ViewStorage<'a, T, U5, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 6 rows and a number of columns chosen at runtime.
+#[deprecated = deprecation_note!(MatrixView6xX)]
 pub type MatrixSlice6xX<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, Dynamic, ViewStorage<'a, T, U6, Dynamic, RStride, CStride>>;
 
 /// A column-major matrix slice with a number of rows chosen at runtime and 1 column.
+#[deprecated = deprecation_note!(MatrixViewXx1)]
 pub type MatrixSliceXx1<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U1, ViewStorage<'a, T, Dynamic, U1, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 2 columns.
+#[deprecated = deprecation_note!(MatrixViewXx2)]
 pub type MatrixSliceXx2<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U2, ViewStorage<'a, T, Dynamic, U2, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 3 columns.
+#[deprecated = deprecation_note!(MatrixViewXx3)]
 pub type MatrixSliceXx3<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U3, ViewStorage<'a, T, Dynamic, U3, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 4 columns.
+#[deprecated = deprecation_note!(MatrixViewXx4)]
 pub type MatrixSliceXx4<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U4, ViewStorage<'a, T, Dynamic, U4, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 5 columns.
+#[deprecated = deprecation_note!(MatrixViewXx5)]
 pub type MatrixSliceXx5<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U5, ViewStorage<'a, T, Dynamic, U5, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 6 columns.
+#[deprecated = deprecation_note!(MatrixViewXx6)]
 pub type MatrixSliceXx6<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U6, ViewStorage<'a, T, Dynamic, U6, RStride, CStride>>;
 
 /// A column vector slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorView)]
 pub type VectorSlice<'a, T, D, RStride = U1, CStride = D> =
     Matrix<T, D, U1, ViewStorage<'a, T, D, U1, RStride, CStride>>;
 
 /// A column vector slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(SVectorView)]
 pub type SVectorSlice<'a, T, const D: usize> =
     Matrix<T, Const<D>, Const<1>, ViewStorage<'a, T, Const<D>, Const<1>, Const<1>, Const<D>>>;
 
 /// A column vector slice dynamic numbers of rows and columns.
+#[deprecated = deprecation_note!(DVectorView)]
 pub type DVectorSlice<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U1, ViewStorage<'a, T, Dynamic, U1, RStride, CStride>>;
 
 /// A 1D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorView1)]
 pub type VectorSlice1<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U1, ViewStorage<'a, T, U1, U1, RStride, CStride>>;
 /// A 2D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorView2)]
 pub type VectorSlice2<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U1, ViewStorage<'a, T, U2, U1, RStride, CStride>>;
 /// A 3D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorView3)]
 pub type VectorSlice3<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U1, ViewStorage<'a, T, U3, U1, RStride, CStride>>;
 /// A 4D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorView4)]
 pub type VectorSlice4<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U1, ViewStorage<'a, T, U4, U1, RStride, CStride>>;
 /// A 5D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorView5)]
 pub type VectorSlice5<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U1, ViewStorage<'a, T, U5, U1, RStride, CStride>>;
 /// A 6D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorView6)]
 pub type VectorSlice6<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U1, ViewStorage<'a, T, U6, U1, RStride, CStride>>;
 
@@ -316,285 +383,344 @@ pub type MatrixSliceMutN<'a, T, D, RStride = U1, CStride = D> =
 /// A column-major matrix slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(SMatrixViewMut)]
 pub type SMatrixSliceMut<'a, T, const R: usize, const C: usize> =
     Matrix<T, Const<R>, Const<C>, ViewStorageMut<'a, T, Const<R>, Const<C>, Const<1>, Const<R>>>;
 
 /// A column-major matrix slice dynamic numbers of rows and columns.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(DMatrixViewMut)]
 pub type DMatrixSliceMut<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, Dynamic, ViewStorageMut<'a, T, Dynamic, Dynamic, RStride, CStride>>;
 
 /// A column-major 1x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut1)]
 pub type MatrixSliceMut1<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U1, ViewStorageMut<'a, T, U1, U1, RStride, CStride>>;
 /// A column-major 2x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut2)]
 pub type MatrixSliceMut2<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U2, ViewStorageMut<'a, T, U2, U2, RStride, CStride>>;
 /// A column-major 3x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut3)]
 pub type MatrixSliceMut3<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U3, ViewStorageMut<'a, T, U3, U3, RStride, CStride>>;
 /// A column-major 4x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut4)]
 pub type MatrixSliceMut4<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U4, ViewStorageMut<'a, T, U4, U4, RStride, CStride>>;
 /// A column-major 5x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut5)]
 pub type MatrixSliceMut5<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U5, ViewStorageMut<'a, T, U5, U5, RStride, CStride>>;
 /// A column-major 6x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut6)]
 pub type MatrixSliceMut6<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U6, ViewStorageMut<'a, T, U6, U6, RStride, CStride>>;
 
 /// A column-major 1x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut1x2)]
 pub type MatrixSliceMut1x2<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U2, ViewStorageMut<'a, T, U1, U2, RStride, CStride>>;
 /// A column-major 1x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut1x3)]
 pub type MatrixSliceMut1x3<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U3, ViewStorageMut<'a, T, U1, U3, RStride, CStride>>;
 /// A column-major 1x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut1x4)]
 pub type MatrixSliceMut1x4<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U4, ViewStorageMut<'a, T, U1, U4, RStride, CStride>>;
 /// A column-major 1x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut1x5)]
 pub type MatrixSliceMut1x5<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U5, ViewStorageMut<'a, T, U1, U5, RStride, CStride>>;
 /// A column-major 1x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut1x6)]
 pub type MatrixSliceMut1x6<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U6, ViewStorageMut<'a, T, U1, U6, RStride, CStride>>;
 
 /// A column-major 2x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut2x1)]
 pub type MatrixSliceMut2x1<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U1, ViewStorageMut<'a, T, U2, U1, RStride, CStride>>;
 /// A column-major 2x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut2x3)]
 pub type MatrixSliceMut2x3<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U3, ViewStorageMut<'a, T, U2, U3, RStride, CStride>>;
 /// A column-major 2x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut2x4)]
 pub type MatrixSliceMut2x4<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U4, ViewStorageMut<'a, T, U2, U4, RStride, CStride>>;
 /// A column-major 2x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut2x5)]
 pub type MatrixSliceMut2x5<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U5, ViewStorageMut<'a, T, U2, U5, RStride, CStride>>;
 /// A column-major 2x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut2x6)]
 pub type MatrixSliceMut2x6<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U6, ViewStorageMut<'a, T, U2, U6, RStride, CStride>>;
 
 /// A column-major 3x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut3x1)]
 pub type MatrixSliceMut3x1<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U1, ViewStorageMut<'a, T, U3, U1, RStride, CStride>>;
 /// A column-major 3x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut3x2)]
 pub type MatrixSliceMut3x2<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U2, ViewStorageMut<'a, T, U3, U2, RStride, CStride>>;
 /// A column-major 3x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut3x4)]
 pub type MatrixSliceMut3x4<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U4, ViewStorageMut<'a, T, U3, U4, RStride, CStride>>;
 /// A column-major 3x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut3x5)]
 pub type MatrixSliceMut3x5<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U5, ViewStorageMut<'a, T, U3, U5, RStride, CStride>>;
 /// A column-major 3x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut3x6)]
 pub type MatrixSliceMut3x6<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U6, ViewStorageMut<'a, T, U3, U6, RStride, CStride>>;
 
 /// A column-major 4x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut4x1)]
 pub type MatrixSliceMut4x1<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U1, ViewStorageMut<'a, T, U4, U1, RStride, CStride>>;
 /// A column-major 4x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut4x2)]
 pub type MatrixSliceMut4x2<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U2, ViewStorageMut<'a, T, U4, U2, RStride, CStride>>;
 /// A column-major 4x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut4x3)]
 pub type MatrixSliceMut4x3<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U3, ViewStorageMut<'a, T, U4, U3, RStride, CStride>>;
 /// A column-major 4x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut4x5)]
 pub type MatrixSliceMut4x5<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U5, ViewStorageMut<'a, T, U4, U5, RStride, CStride>>;
 /// A column-major 4x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut4x6)]
 pub type MatrixSliceMut4x6<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U6, ViewStorageMut<'a, T, U4, U6, RStride, CStride>>;
 
 /// A column-major 5x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut5x1)]
 pub type MatrixSliceMut5x1<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U1, ViewStorageMut<'a, T, U5, U1, RStride, CStride>>;
 /// A column-major 5x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut5x2)]
 pub type MatrixSliceMut5x2<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U2, ViewStorageMut<'a, T, U5, U2, RStride, CStride>>;
 /// A column-major 5x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut5x3)]
 pub type MatrixSliceMut5x3<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U3, ViewStorageMut<'a, T, U5, U3, RStride, CStride>>;
 /// A column-major 5x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut5x4)]
 pub type MatrixSliceMut5x4<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U4, ViewStorageMut<'a, T, U5, U4, RStride, CStride>>;
 /// A column-major 5x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut5x6)]
 pub type MatrixSliceMut5x6<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U6, ViewStorageMut<'a, T, U5, U6, RStride, CStride>>;
 
 /// A column-major 6x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut6x1)]
 pub type MatrixSliceMut6x1<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U1, ViewStorageMut<'a, T, U6, U1, RStride, CStride>>;
 /// A column-major 6x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut6x2)]
 pub type MatrixSliceMut6x2<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U2, ViewStorageMut<'a, T, U6, U2, RStride, CStride>>;
 /// A column-major 6x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut6x3)]
 pub type MatrixSliceMut6x3<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U3, ViewStorageMut<'a, T, U6, U3, RStride, CStride>>;
 /// A column-major 6x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut6x4)]
 pub type MatrixSliceMut6x4<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U4, ViewStorageMut<'a, T, U6, U4, RStride, CStride>>;
 /// A column-major 6x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(MatrixViewMut6x5)]
 pub type MatrixSliceMut6x5<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U5, ViewStorageMut<'a, T, U6, U5, RStride, CStride>>;
 
 /// A column-major matrix slice with 1 row and a number of columns chosen at runtime.
+#[deprecated = deprecation_note!(MatrixViewMut1xX)]
 pub type MatrixSliceMut1xX<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, Dynamic, ViewStorageMut<'a, T, U1, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 2 rows and a number of columns chosen at runtime.
+#[deprecated = deprecation_note!(MatrixViewMut2xX)]
 pub type MatrixSliceMut2xX<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, Dynamic, ViewStorageMut<'a, T, U2, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 3 rows and a number of columns chosen at runtime.
+#[deprecated = deprecation_note!(MatrixViewMut3xX)]
 pub type MatrixSliceMut3xX<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, Dynamic, ViewStorageMut<'a, T, U3, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 4 rows and a number of columns chosen at runtime.
+#[deprecated = deprecation_note!(MatrixViewMut4xX)]
 pub type MatrixSliceMut4xX<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, Dynamic, ViewStorageMut<'a, T, U4, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 5 rows and a number of columns chosen at runtime.
+#[deprecated = deprecation_note!(MatrixViewMut5xX)]
 pub type MatrixSliceMut5xX<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, Dynamic, ViewStorageMut<'a, T, U5, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 6 rows and a number of columns chosen at runtime.
+#[deprecated = deprecation_note!(MatrixViewMut6xX)]
 pub type MatrixSliceMut6xX<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, Dynamic, ViewStorageMut<'a, T, U6, Dynamic, RStride, CStride>>;
 
 /// A column-major matrix slice with a number of rows chosen at runtime and 1 column.
+#[deprecated = deprecation_note!(MatrixViewMutXx1)]
 pub type MatrixSliceMutXx1<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U1, ViewStorageMut<'a, T, Dynamic, U1, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 2 columns.
+#[deprecated = deprecation_note!(MatrixViewMutXx2)]
 pub type MatrixSliceMutXx2<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U2, ViewStorageMut<'a, T, Dynamic, U2, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 3 columns.
+#[deprecated = deprecation_note!(MatrixViewMutXx3)]
 pub type MatrixSliceMutXx3<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U3, ViewStorageMut<'a, T, Dynamic, U3, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 4 columns.
+#[deprecated = deprecation_note!(MatrixViewMutXx4)]
 pub type MatrixSliceMutXx4<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U4, ViewStorageMut<'a, T, Dynamic, U4, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 5 columns.
+#[deprecated = deprecation_note!(MatrixViewMutXx5)]
 pub type MatrixSliceMutXx5<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U5, ViewStorageMut<'a, T, Dynamic, U5, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 6 columns.
+#[deprecated = deprecation_note!(MatrixViewMutXx6)]
 pub type MatrixSliceMutXx6<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U6, ViewStorageMut<'a, T, Dynamic, U6, RStride, CStride>>;
 
 /// A column vector slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorViewMut)]
 pub type VectorSliceMut<'a, T, D, RStride = U1, CStride = D> =
     Matrix<T, D, U1, ViewStorageMut<'a, T, D, U1, RStride, CStride>>;
 
 /// A column vector slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(SVectorViewMut)]
 pub type SVectorSliceMut<'a, T, const D: usize> =
     Matrix<T, Const<D>, Const<1>, ViewStorageMut<'a, T, Const<D>, Const<1>, Const<1>, Const<D>>>;
 
 /// A column vector slice dynamic numbers of rows and columns.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(DVectorViewMut)]
 pub type DVectorSliceMut<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U1, ViewStorageMut<'a, T, Dynamic, U1, RStride, CStride>>;
 
 /// A 1D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorViewMut1)]
 pub type VectorSliceMut1<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U1, ViewStorageMut<'a, T, U1, U1, RStride, CStride>>;
 /// A 2D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorViewMut2)]
 pub type VectorSliceMut2<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U1, ViewStorageMut<'a, T, U2, U1, RStride, CStride>>;
 /// A 3D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorViewMut3)]
 pub type VectorSliceMut3<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U1, ViewStorageMut<'a, T, U3, U1, RStride, CStride>>;
 /// A 4D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorViewMut4)]
 pub type VectorSliceMut4<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U1, ViewStorageMut<'a, T, U4, U1, RStride, CStride>>;
 /// A 5D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorViewMut5)]
 pub type VectorSliceMut5<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U1, ViewStorageMut<'a, T, U5, U1, RStride, CStride>>;
 /// A 6D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = deprecation_note!(VectorViewMut6)]
 pub type VectorSliceMut6<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U1, ViewStorageMut<'a, T, U6, U1, RStride, CStride>>;

From 7d5097b0b2b98e0a17867ed28086dcb3c927cb6a Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 09:33:08 +0100
Subject: [PATCH 73/91] Remove use of deprecated *Slice aliases in nalgebra

---
 src/base/blas.rs       |  8 ++++----
 src/base/conversion.rs | 24 ++++++++++++------------
 src/base/ops.rs        |  6 +++---
 src/base/statistics.rs |  8 ++++----
 src/linalg/solve.rs    | 18 +++++++++---------
 5 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/src/base/blas.rs b/src/base/blas.rs
index e65304b5..5f51cea9 100644
--- a/src/base/blas.rs
+++ b/src/base/blas.rs
@@ -11,7 +11,7 @@ use crate::base::dimension::{Const, Dim, Dynamic, U1, U2, U3, U4};
 use crate::base::storage::{Storage, StorageMut};
 use crate::base::uninit::Init;
 use crate::base::{
-    DVectorSlice, DefaultAllocator, Matrix, Scalar, SquareMatrix, Vector, VectorSlice,
+    DVectorView, DefaultAllocator, Matrix, Scalar, SquareMatrix, Vector, VectorView,
 };
 
 /// # Dot/scalar product
@@ -363,8 +363,8 @@ where
         x: &Vector<T, D3, SC>,
         beta: T,
         dot: impl Fn(
-            &DVectorSlice<'_, T, SB::RStride, SB::CStride>,
-            &DVectorSlice<'_, T, SC::RStride, SC::CStride>,
+            &DVectorView<'_, T, SB::RStride, SB::CStride>,
+            &DVectorView<'_, T, SC::RStride, SC::CStride>,
         ) -> T,
     ) where
         T: One,
@@ -506,7 +506,7 @@ where
         a: &Matrix<T, R2, C2, SB>,
         x: &Vector<T, D3, SC>,
         beta: T,
-        dot: impl Fn(&VectorSlice<'_, T, R2, SB::RStride, SB::CStride>, &Vector<T, D3, SC>) -> T,
+        dot: impl Fn(&VectorView<'_, T, R2, SB::RStride, SB::CStride>, &Vector<T, D3, SC>) -> T,
     ) where
         T: One,
         SB: Storage<T, R2, C2>,
diff --git a/src/base/conversion.rs b/src/base/conversion.rs
index 9b6df2c2..4c83796e 100644
--- a/src/base/conversion.rs
+++ b/src/base/conversion.rs
@@ -16,14 +16,14 @@ use crate::base::dimension::{
 use crate::base::iter::{MatrixIter, MatrixIterMut};
 use crate::base::storage::{IsContiguous, RawStorage, RawStorageMut};
 use crate::base::{
-    ArrayStorage, DVectorSlice, DVectorSliceMut, DefaultAllocator, Matrix, MatrixView,
+    ArrayStorage, DVectorView, DVectorViewMut, DefaultAllocator, Matrix, MatrixView,
     MatrixViewMut, OMatrix, Scalar,
 };
 #[cfg(any(feature = "std", feature = "alloc"))]
 use crate::base::{DVector, RowDVector, VecStorage};
 use crate::base::{ViewStorage, ViewStorageMut};
 use crate::constraint::DimEq;
-use crate::{IsNotStaticOne, RowSVector, SMatrix, SVector, VectorSlice, VectorSliceMut};
+use crate::{IsNotStaticOne, RowSVector, SMatrix, SVector, VectorView, VectorViewMut};
 use std::mem::MaybeUninit;
 
 // TODO: too bad this won't work for slice conversions.
@@ -126,19 +126,19 @@ impl<T: Scalar, const D: usize> From<SVector<T, D>> for [T; D] {
 }
 
 impl<'a, T: Scalar, RStride: Dim, CStride: Dim, const D: usize>
-    From<VectorSlice<'a, T, Const<D>, RStride, CStride>> for [T; D]
+    From<VectorView<'a, T, Const<D>, RStride, CStride>> for [T; D]
 {
     #[inline]
-    fn from(vec: VectorSlice<'a, T, Const<D>, RStride, CStride>) -> Self {
+    fn from(vec: VectorView<'a, T, Const<D>, RStride, CStride>) -> Self {
         vec.into_owned().into()
     }
 }
 
 impl<'a, T: Scalar, RStride: Dim, CStride: Dim, const D: usize>
-    From<VectorSliceMut<'a, T, Const<D>, RStride, CStride>> for [T; D]
+    From<VectorViewMut<'a, T, Const<D>, RStride, CStride>> for [T; D]
 {
     #[inline]
-    fn from(vec: VectorSliceMut<'a, T, Const<D>, RStride, CStride>) -> Self {
+    fn from(vec: VectorViewMut<'a, T, Const<D>, RStride, CStride>) -> Self {
         vec.into_owned().into()
     }
 }
@@ -515,28 +515,28 @@ impl<'a, T: Scalar + Copy, R: Dim, C: Dim, S: RawStorageMut<T, R, C> + IsContigu
     }
 }
 
-impl<'a, T: Scalar + Copy> From<&'a [T]> for DVectorSlice<'a, T> {
+impl<'a, T: Scalar + Copy> From<&'a [T]> for DVectorView<'a, T> {
     #[inline]
     fn from(slice: &'a [T]) -> Self {
         Self::from_slice(slice, slice.len())
     }
 }
 
-impl<'a, T: Scalar> From<DVectorSlice<'a, T>> for &'a [T] {
-    fn from(vec: DVectorSlice<'a, T>) -> &'a [T] {
+impl<'a, T: Scalar> From<DVectorView<'a, T>> for &'a [T] {
+    fn from(vec: DVectorView<'a, T>) -> &'a [T] {
         vec.data.into_slice()
     }
 }
 
-impl<'a, T: Scalar + Copy> From<&'a mut [T]> for DVectorSliceMut<'a, T> {
+impl<'a, T: Scalar + Copy> From<&'a mut [T]> for DVectorViewMut<'a, T> {
     #[inline]
     fn from(slice: &'a mut [T]) -> Self {
         Self::from_slice(slice, slice.len())
     }
 }
 
-impl<'a, T: Scalar> From<DVectorSliceMut<'a, T>> for &'a mut [T] {
-    fn from(vec: DVectorSliceMut<'a, T>) -> &'a mut [T] {
+impl<'a, T: Scalar> From<DVectorViewMut<'a, T>> for &'a mut [T] {
+    fn from(vec: DVectorViewMut<'a, T>) -> &'a mut [T] {
         vec.data.into_slice_mut()
     }
 }
diff --git a/src/base/ops.rs b/src/base/ops.rs
index 6b6d0c45..60ed5e26 100644
--- a/src/base/ops.rs
+++ b/src/base/ops.rs
@@ -14,7 +14,7 @@ use crate::base::constraint::{
 use crate::base::dimension::{Dim, DimMul, DimName, DimProd, Dynamic};
 use crate::base::storage::{Storage, StorageMut};
 use crate::base::uninit::Uninit;
-use crate::base::{DefaultAllocator, Matrix, MatrixSum, OMatrix, Scalar, VectorSlice};
+use crate::base::{DefaultAllocator, Matrix, MatrixSum, OMatrix, Scalar, VectorView};
 use crate::storage::IsContiguous;
 use crate::uninit::{Init, InitStatus};
 use crate::{RawStorage, RawStorageMut, SimdComplexField};
@@ -703,8 +703,8 @@ where
         rhs: &Matrix<T, R2, C2, SB>,
         out: &mut Matrix<Status::Value, R3, C3, SC>,
         dot: impl Fn(
-            &VectorSlice<'_, T, R1, SA::RStride, SA::CStride>,
-            &VectorSlice<'_, T, R2, SB::RStride, SB::CStride>,
+            &VectorView<'_, T, R1, SA::RStride, SA::CStride>,
+            &VectorView<'_, T, R2, SB::RStride, SB::CStride>,
         ) -> T,
     ) where
         Status: InitStatus<T>,
diff --git a/src/base/statistics.rs b/src/base/statistics.rs
index 320cd12f..9f0e0ee6 100644
--- a/src/base/statistics.rs
+++ b/src/base/statistics.rs
@@ -1,6 +1,6 @@
 use crate::allocator::Allocator;
 use crate::storage::RawStorage;
-use crate::{Const, DefaultAllocator, Dim, Matrix, OVector, RowOVector, Scalar, VectorSlice, U1};
+use crate::{Const, DefaultAllocator, Dim, Matrix, OVector, RowOVector, Scalar, VectorView, U1};
 use num::{One, Zero};
 use simba::scalar::{ClosedAdd, ClosedMul, Field, SupersetOf};
 use std::mem::MaybeUninit;
@@ -13,7 +13,7 @@ impl<T: Scalar, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     #[must_use]
     pub fn compress_rows(
         &self,
-        f: impl Fn(VectorSlice<'_, T, R, S::RStride, S::CStride>) -> T,
+        f: impl Fn(VectorView<'_, T, R, S::RStride, S::CStride>) -> T,
     ) -> RowOVector<T, C>
     where
         DefaultAllocator: Allocator<T, U1, C>,
@@ -41,7 +41,7 @@ impl<T: Scalar, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     #[must_use]
     pub fn compress_rows_tr(
         &self,
-        f: impl Fn(VectorSlice<'_, T, R, S::RStride, S::CStride>) -> T,
+        f: impl Fn(VectorView<'_, T, R, S::RStride, S::CStride>) -> T,
     ) -> OVector<T, C>
     where
         DefaultAllocator: Allocator<T, C>,
@@ -67,7 +67,7 @@ impl<T: Scalar, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     pub fn compress_columns(
         &self,
         init: OVector<T, R>,
-        f: impl Fn(&mut OVector<T, R>, VectorSlice<'_, T, R, S::RStride, S::CStride>),
+        f: impl Fn(&mut OVector<T, R>, VectorView<'_, T, R, S::RStride, S::CStride>),
     ) -> OVector<T, R>
     where
         DefaultAllocator: Allocator<T, R>,
diff --git a/src/linalg/solve.rs b/src/linalg/solve.rs
index 7409e7fb..c355f2d0 100644
--- a/src/linalg/solve.rs
+++ b/src/linalg/solve.rs
@@ -5,7 +5,7 @@ use crate::base::allocator::Allocator;
 use crate::base::constraint::{SameNumberOfRows, ShapeConstraint};
 use crate::base::dimension::{Dim, U1};
 use crate::base::storage::{Storage, StorageMut};
-use crate::base::{DVectorSlice, DefaultAllocator, Matrix, OMatrix, SquareMatrix, Vector};
+use crate::base::{DVectorView, DefaultAllocator, Matrix, OMatrix, SquareMatrix, Vector};
 
 impl<T: ComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
     /// Computes the solution of the linear system `self . x = b` where `x` is the unknown and only
@@ -376,8 +376,8 @@ impl<T: ComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
         b: &mut Vector<T, R2, S2>,
         conjugate: impl Fn(T) -> T,
         dot: impl Fn(
-            &DVectorSlice<'_, T, S::RStride, S::CStride>,
-            &DVectorSlice<'_, T, S2::RStride, S2::CStride>,
+            &DVectorView<'_, T, S::RStride, S::CStride>,
+            &DVectorView<'_, T, S2::RStride, S2::CStride>,
         ) -> T,
     ) -> bool
     where
@@ -411,8 +411,8 @@ impl<T: ComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
         b: &mut Vector<T, R2, S2>,
         conjugate: impl Fn(T) -> T,
         dot: impl Fn(
-            &DVectorSlice<'_, T, S::RStride, S::CStride>,
-            &DVectorSlice<'_, T, S2::RStride, S2::CStride>,
+            &DVectorView<'_, T, S::RStride, S::CStride>,
+            &DVectorView<'_, T, S2::RStride, S2::CStride>,
         ) -> T,
     ) -> bool
     where
@@ -734,8 +734,8 @@ impl<T: SimdComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
         b: &mut Vector<T, R2, S2>,
         conjugate: impl Fn(T) -> T,
         dot: impl Fn(
-            &DVectorSlice<'_, T, S::RStride, S::CStride>,
-            &DVectorSlice<'_, T, S2::RStride, S2::CStride>,
+            &DVectorView<'_, T, S::RStride, S::CStride>,
+            &DVectorView<'_, T, S2::RStride, S2::CStride>,
         ) -> T,
     ) where
         S2: StorageMut<T, R2, U1>,
@@ -760,8 +760,8 @@ impl<T: SimdComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
         b: &mut Vector<T, R2, S2>,
         conjugate: impl Fn(T) -> T,
         dot: impl Fn(
-            &DVectorSlice<'_, T, S::RStride, S::CStride>,
-            &DVectorSlice<'_, T, S2::RStride, S2::CStride>,
+            &DVectorView<'_, T, S::RStride, S::CStride>,
+            &DVectorView<'_, T, S2::RStride, S2::CStride>,
         ) -> T,
     ) where
         S2: StorageMut<T, R2, U1>,

From f792b5f5684f85c4eabacd5be6292361a69c4d5f Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 09:37:21 +0100
Subject: [PATCH 74/91] Deprecate MatrixSliceMutMN

In the past, MatrixSliceMut did not have the same defaults. However,
for a while now MatrixSliceMut has served the exact same purpose
(in fact their definitions are identical), so we should
deprecate MatrixSliceMutMN.
---
 src/base/alias_slice.rs        |  1 +
 src/base/construction_slice.rs | 10 +++++-----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/base/alias_slice.rs b/src/base/alias_slice.rs
index d0fb6676..3fb5d793 100644
--- a/src/base/alias_slice.rs
+++ b/src/base/alias_slice.rs
@@ -371,6 +371,7 @@ pub type VectorSlice6<'a, T, RStride = U1, CStride = U6> =
 /// A column-major matrix slice with `R` rows and `C` columns.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = "Use MatrixViewMut instead, which has an identical definition."]
 pub type MatrixSliceMutMN<'a, T, R, C, RStride = U1, CStride = R> =
     Matrix<T, R, C, ViewStorageMut<'a, T, R, C, RStride, CStride>>;
 
diff --git a/src/base/construction_slice.rs b/src/base/construction_slice.rs
index d6a1f708..aa355264 100644
--- a/src/base/construction_slice.rs
+++ b/src/base/construction_slice.rs
@@ -1,6 +1,6 @@
 use crate::base::dimension::{Const, Dim, DimName, Dynamic};
 use crate::base::matrix_view::{ViewStorage, ViewStorageMut};
-use crate::base::{MatrixView, MatrixSliceMutMN, Scalar};
+use crate::base::{MatrixView, MatrixViewMut, Scalar};
 
 use num_rational::Ratio;
 
@@ -144,7 +144,7 @@ impl_constructors!(Dynamic, Dynamic;
 
 /// # Creating mutable matrix slices from `&mut [T]`
 impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
-    MatrixSliceMutMN<'a, T, R, C, RStride, CStride>
+    MatrixViewMut<'a, T, R, C, RStride, CStride>
 {
     /// Creates, without bound-checking, a mutable matrix slice from an array and with dimensions and strides specified by generic types instances.
     ///
@@ -217,7 +217,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
     }
 }
 
-impl<'a, T: Scalar, R: Dim, C: Dim> MatrixSliceMutMN<'a, T, R, C> {
+impl<'a, T: Scalar, R: Dim, C: Dim> MatrixViewMut<'a, T, R, C> {
     /// Creates, without bound-checking, a mutable matrix slice from an array and with dimensions specified by generic types instances.
     ///
     /// # Safety
@@ -247,7 +247,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim> MatrixSliceMutMN<'a, T, R, C> {
 
 macro_rules! impl_constructors_mut(
     ($($Dims: ty),*; $(=> $DimIdent: ident: $DimBound: ident),*; $($gargs: expr),*; $($args: ident),*) => {
-        impl<'a, T: Scalar, $($DimIdent: $DimBound),*> MatrixSliceMutMN<'a, T, $($Dims),*> {
+        impl<'a, T: Scalar, $($DimIdent: $DimBound),*> MatrixViewMut<'a, T, $($Dims),*> {
             /// Creates a new mutable matrix slice from the given data array.
             ///
             /// Panics if `data` does not contain enough elements.
@@ -263,7 +263,7 @@ macro_rules! impl_constructors_mut(
             }
         }
 
-        impl<'a, T: Scalar, $($DimIdent: $DimBound, )*> MatrixSliceMutMN<'a, T, $($Dims,)* Dynamic, Dynamic> {
+        impl<'a, T: Scalar, $($DimIdent: $DimBound, )*> MatrixViewMut<'a, T, $($Dims,)* Dynamic, Dynamic> {
             /// Creates a new mutable matrix slice with the specified strides from the given data array.
             ///
             /// Panics if `data` does not contain enough elements.

From 2ca4b3b02d8ad96ebe9be1896ef9e4c2b44ae192 Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 09:41:03 +0100
Subject: [PATCH 75/91] Deprecate MatrixSliceMutN

There is no other type alias with this naming convention. I believe it
is a remnant from the past, when we had e.g. MatrixN type aliases. But
these no longer exist, therefore I believe this alias should also be
removed, instead of updated to "MatrixViewMutN".
---
 src/base/alias_slice.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/base/alias_slice.rs b/src/base/alias_slice.rs
index 3fb5d793..f71262d4 100644
--- a/src/base/alias_slice.rs
+++ b/src/base/alias_slice.rs
@@ -378,6 +378,7 @@ pub type MatrixSliceMutMN<'a, T, R, C, RStride = U1, CStride = R> =
 /// A column-major matrix slice with `D` rows and columns.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
+#[deprecated = "Use MatrixViewMut instead."]
 pub type MatrixSliceMutN<'a, T, D, RStride = U1, CStride = D> =
     Matrix<T, D, D, ViewStorageMut<'a, T, D, D, RStride, CStride>>;
 

From a68d9b5dedf84101b4ad4f0d6f10a3ef6c4f26e8 Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 09:42:59 +0100
Subject: [PATCH 76/91] Rename construction_slice.rs -> construction_view.rs

---
 src/base/{construction_slice.rs => construction_view.rs} | 0
 src/base/mod.rs                                          | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename src/base/{construction_slice.rs => construction_view.rs} (100%)

diff --git a/src/base/construction_slice.rs b/src/base/construction_view.rs
similarity index 100%
rename from src/base/construction_slice.rs
rename to src/base/construction_view.rs
diff --git a/src/base/mod.rs b/src/base/mod.rs
index 6fb3685d..dfe7cc8d 100644
--- a/src/base/mod.rs
+++ b/src/base/mod.rs
@@ -18,7 +18,7 @@ mod cg;
 mod componentwise;
 #[macro_use]
 mod construction;
-mod construction_slice;
+mod construction_view;
 mod conversion;
 mod edition;
 pub mod indexing;

From eb456f18bb89490f6538d383fcdfe87a46ed886b Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 10:56:13 +0100
Subject: [PATCH 77/91] Move slice deprecation macro to lib.rs

This way we can use it across the library, in changes that
will follow this commit.
---
 src/base/alias_slice.rs | 245 +++++++++++++++++++---------------------
 src/lib.rs              |  13 +++
 2 files changed, 132 insertions(+), 126 deletions(-)

diff --git a/src/base/alias_slice.rs b/src/base/alias_slice.rs
index f71262d4..d3f8879a 100644
--- a/src/base/alias_slice.rs
+++ b/src/base/alias_slice.rs
@@ -1,14 +1,7 @@
 use crate::base::dimension::{Dynamic, U1, U2, U3, U4, U5, U6};
 use crate::base::matrix_view::{ViewStorage, ViewStorageMut};
 use crate::base::{Const, Matrix};
-
-/// Generates an appropriate deprecation note with a suggestion for replacement.
-macro_rules! deprecation_note {
-    ($replacement:ident) => {
-        concat!("Use ", stringify!($replacement),
-            r###" instead. See [issue #1076](https://github.com/dimforge/nalgebra/issues/1076) for more information."###)
-    }
-}
+use crate::slice_deprecation_note;
 
 /*
  *
@@ -21,343 +14,343 @@ macro_rules! deprecation_note {
 /// A column-major matrix slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(SMatrixView)]
+#[deprecated = slice_deprecation_note!(SMatrixView)]
 pub type SMatrixSlice<'a, T, const R: usize, const C: usize> =
     Matrix<T, Const<R>, Const<C>, ViewStorage<'a, T, Const<R>, Const<C>, Const<1>, Const<R>>>;
 
 /// A column-major matrix slice dynamic numbers of rows and columns.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(DMatrixView)]
+#[deprecated = slice_deprecation_note!(DMatrixView)]
 pub type DMatrixSlice<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, Dynamic, ViewStorage<'a, T, Dynamic, Dynamic, RStride, CStride>>;
 
 /// A column-major 1x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView1)]
+#[deprecated = slice_deprecation_note!(MatrixView1)]
 pub type MatrixSlice1<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U1, ViewStorage<'a, T, U1, U1, RStride, CStride>>;
 /// A column-major 2x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView2)]
+#[deprecated = slice_deprecation_note!(MatrixView2)]
 pub type MatrixSlice2<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U2, ViewStorage<'a, T, U2, U2, RStride, CStride>>;
 /// A column-major 3x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView3)]
+#[deprecated = slice_deprecation_note!(MatrixView3)]
 pub type MatrixSlice3<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U3, ViewStorage<'a, T, U3, U3, RStride, CStride>>;
 /// A column-major 4x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView4)]
+#[deprecated = slice_deprecation_note!(MatrixView4)]
 pub type MatrixSlice4<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U4, ViewStorage<'a, T, U4, U4, RStride, CStride>>;
 /// A column-major 5x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView5)]
+#[deprecated = slice_deprecation_note!(MatrixView5)]
 pub type MatrixSlice5<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U5, ViewStorage<'a, T, U5, U5, RStride, CStride>>;
 /// A column-major 6x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView6)]
+#[deprecated = slice_deprecation_note!(MatrixView6)]
 pub type MatrixSlice6<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U6, ViewStorage<'a, T, U6, U6, RStride, CStride>>;
 
 /// A column-major 1x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView1x2)]
+#[deprecated = slice_deprecation_note!(MatrixView1x2)]
 pub type MatrixSlice1x2<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U2, ViewStorage<'a, T, U1, U2, RStride, CStride>>;
 /// A column-major 1x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView1x3)]
+#[deprecated = slice_deprecation_note!(MatrixView1x3)]
 pub type MatrixSlice1x3<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U3, ViewStorage<'a, T, U1, U3, RStride, CStride>>;
 /// A column-major 1x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView1x4)]
+#[deprecated = slice_deprecation_note!(MatrixView1x4)]
 pub type MatrixSlice1x4<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U4, ViewStorage<'a, T, U1, U4, RStride, CStride>>;
 /// A column-major 1x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView1x5)]
+#[deprecated = slice_deprecation_note!(MatrixView1x5)]
 pub type MatrixSlice1x5<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U5, ViewStorage<'a, T, U1, U5, RStride, CStride>>;
 /// A column-major 1x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView1x6)]
+#[deprecated = slice_deprecation_note!(MatrixView1x6)]
 pub type MatrixSlice1x6<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U6, ViewStorage<'a, T, U1, U6, RStride, CStride>>;
 
 /// A column-major 2x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView2x1)]
+#[deprecated = slice_deprecation_note!(MatrixView2x1)]
 pub type MatrixSlice2x1<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U1, ViewStorage<'a, T, U2, U1, RStride, CStride>>;
 /// A column-major 2x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView2x3)]
+#[deprecated = slice_deprecation_note!(MatrixView2x3)]
 pub type MatrixSlice2x3<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U3, ViewStorage<'a, T, U2, U3, RStride, CStride>>;
 /// A column-major 2x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView2x4)]
+#[deprecated = slice_deprecation_note!(MatrixView2x4)]
 pub type MatrixSlice2x4<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U4, ViewStorage<'a, T, U2, U4, RStride, CStride>>;
 /// A column-major 2x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView2x5)]
+#[deprecated = slice_deprecation_note!(MatrixView2x5)]
 pub type MatrixSlice2x5<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U5, ViewStorage<'a, T, U2, U5, RStride, CStride>>;
 /// A column-major 2x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView2x6)]
+#[deprecated = slice_deprecation_note!(MatrixView2x6)]
 pub type MatrixSlice2x6<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U6, ViewStorage<'a, T, U2, U6, RStride, CStride>>;
 
 /// A column-major 3x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView3x1)]
+#[deprecated = slice_deprecation_note!(MatrixView3x1)]
 pub type MatrixSlice3x1<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U1, ViewStorage<'a, T, U3, U1, RStride, CStride>>;
 /// A column-major 3x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView3x2)]
+#[deprecated = slice_deprecation_note!(MatrixView3x2)]
 pub type MatrixSlice3x2<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U2, ViewStorage<'a, T, U3, U2, RStride, CStride>>;
 /// A column-major 3x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView3x4)]
+#[deprecated = slice_deprecation_note!(MatrixView3x4)]
 pub type MatrixSlice3x4<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U4, ViewStorage<'a, T, U3, U4, RStride, CStride>>;
 /// A column-major 3x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView3x5)]
+#[deprecated = slice_deprecation_note!(MatrixView3x5)]
 pub type MatrixSlice3x5<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U5, ViewStorage<'a, T, U3, U5, RStride, CStride>>;
 /// A column-major 3x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView3x6)]
+#[deprecated = slice_deprecation_note!(MatrixView3x6)]
 pub type MatrixSlice3x6<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U6, ViewStorage<'a, T, U3, U6, RStride, CStride>>;
 
 /// A column-major 4x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView4x1)]
+#[deprecated = slice_deprecation_note!(MatrixView4x1)]
 pub type MatrixSlice4x1<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U1, ViewStorage<'a, T, U4, U1, RStride, CStride>>;
 /// A column-major 4x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView4x2)]
+#[deprecated = slice_deprecation_note!(MatrixView4x2)]
 pub type MatrixSlice4x2<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U2, ViewStorage<'a, T, U4, U2, RStride, CStride>>;
 /// A column-major 4x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView4x3)]
+#[deprecated = slice_deprecation_note!(MatrixView4x3)]
 pub type MatrixSlice4x3<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U3, ViewStorage<'a, T, U4, U3, RStride, CStride>>;
 /// A column-major 4x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView4x5)]
+#[deprecated = slice_deprecation_note!(MatrixView4x5)]
 pub type MatrixSlice4x5<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U5, ViewStorage<'a, T, U4, U5, RStride, CStride>>;
 /// A column-major 4x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView4x6)]
+#[deprecated = slice_deprecation_note!(MatrixView4x6)]
 pub type MatrixSlice4x6<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U6, ViewStorage<'a, T, U4, U6, RStride, CStride>>;
 
 /// A column-major 5x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView5x1)]
+#[deprecated = slice_deprecation_note!(MatrixView5x1)]
 pub type MatrixSlice5x1<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U1, ViewStorage<'a, T, U5, U1, RStride, CStride>>;
 /// A column-major 5x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView5x2)]
+#[deprecated = slice_deprecation_note!(MatrixView5x2)]
 pub type MatrixSlice5x2<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U2, ViewStorage<'a, T, U5, U2, RStride, CStride>>;
 /// A column-major 5x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView5x3)]
+#[deprecated = slice_deprecation_note!(MatrixView5x3)]
 pub type MatrixSlice5x3<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U3, ViewStorage<'a, T, U5, U3, RStride, CStride>>;
 /// A column-major 5x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView5x4)]
+#[deprecated = slice_deprecation_note!(MatrixView5x4)]
 pub type MatrixSlice5x4<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U4, ViewStorage<'a, T, U5, U4, RStride, CStride>>;
 /// A column-major 5x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView5x6)]
+#[deprecated = slice_deprecation_note!(MatrixView5x6)]
 pub type MatrixSlice5x6<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U6, ViewStorage<'a, T, U5, U6, RStride, CStride>>;
 
 /// A column-major 6x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView6x1)]
+#[deprecated = slice_deprecation_note!(MatrixView6x1)]
 pub type MatrixSlice6x1<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U1, ViewStorage<'a, T, U6, U1, RStride, CStride>>;
 /// A column-major 6x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView6x2)]
+#[deprecated = slice_deprecation_note!(MatrixView6x2)]
 pub type MatrixSlice6x2<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U2, ViewStorage<'a, T, U6, U2, RStride, CStride>>;
 /// A column-major 6x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView6x3)]
+#[deprecated = slice_deprecation_note!(MatrixView6x3)]
 pub type MatrixSlice6x3<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U3, ViewStorage<'a, T, U6, U3, RStride, CStride>>;
 /// A column-major 6x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView6x4)]
+#[deprecated = slice_deprecation_note!(MatrixView6x4)]
 pub type MatrixSlice6x4<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U4, ViewStorage<'a, T, U6, U4, RStride, CStride>>;
 /// A column-major 6x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixView6x5)]
+#[deprecated = slice_deprecation_note!(MatrixView6x5)]
 pub type MatrixSlice6x5<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U5, ViewStorage<'a, T, U6, U5, RStride, CStride>>;
 
 /// A column-major matrix slice with 1 row and a number of columns chosen at runtime.
-#[deprecated = deprecation_note!(MatrixView1xX)]
+#[deprecated = slice_deprecation_note!(MatrixView1xX)]
 pub type MatrixSlice1xX<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, Dynamic, ViewStorage<'a, T, U1, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 2 rows and a number of columns chosen at runtime.
-#[deprecated = deprecation_note!(MatrixView2xX)]
+#[deprecated = slice_deprecation_note!(MatrixView2xX)]
 pub type MatrixSlice2xX<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, Dynamic, ViewStorage<'a, T, U2, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 3 rows and a number of columns chosen at runtime.
-#[deprecated = deprecation_note!(MatrixView3xX)]
+#[deprecated = slice_deprecation_note!(MatrixView3xX)]
 pub type MatrixSlice3xX<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, Dynamic, ViewStorage<'a, T, U3, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 4 rows and a number of columns chosen at runtime.
-#[deprecated = deprecation_note!(MatrixView4xX)]
+#[deprecated = slice_deprecation_note!(MatrixView4xX)]
 pub type MatrixSlice4xX<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, Dynamic, ViewStorage<'a, T, U4, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 5 rows and a number of columns chosen at runtime.
-#[deprecated = deprecation_note!(MatrixView5xX)]
+#[deprecated = slice_deprecation_note!(MatrixView5xX)]
 pub type MatrixSlice5xX<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, Dynamic, ViewStorage<'a, T, U5, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 6 rows and a number of columns chosen at runtime.
-#[deprecated = deprecation_note!(MatrixView6xX)]
+#[deprecated = slice_deprecation_note!(MatrixView6xX)]
 pub type MatrixSlice6xX<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, Dynamic, ViewStorage<'a, T, U6, Dynamic, RStride, CStride>>;
 
 /// A column-major matrix slice with a number of rows chosen at runtime and 1 column.
-#[deprecated = deprecation_note!(MatrixViewXx1)]
+#[deprecated = slice_deprecation_note!(MatrixViewXx1)]
 pub type MatrixSliceXx1<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U1, ViewStorage<'a, T, Dynamic, U1, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 2 columns.
-#[deprecated = deprecation_note!(MatrixViewXx2)]
+#[deprecated = slice_deprecation_note!(MatrixViewXx2)]
 pub type MatrixSliceXx2<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U2, ViewStorage<'a, T, Dynamic, U2, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 3 columns.
-#[deprecated = deprecation_note!(MatrixViewXx3)]
+#[deprecated = slice_deprecation_note!(MatrixViewXx3)]
 pub type MatrixSliceXx3<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U3, ViewStorage<'a, T, Dynamic, U3, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 4 columns.
-#[deprecated = deprecation_note!(MatrixViewXx4)]
+#[deprecated = slice_deprecation_note!(MatrixViewXx4)]
 pub type MatrixSliceXx4<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U4, ViewStorage<'a, T, Dynamic, U4, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 5 columns.
-#[deprecated = deprecation_note!(MatrixViewXx5)]
+#[deprecated = slice_deprecation_note!(MatrixViewXx5)]
 pub type MatrixSliceXx5<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U5, ViewStorage<'a, T, Dynamic, U5, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 6 columns.
-#[deprecated = deprecation_note!(MatrixViewXx6)]
+#[deprecated = slice_deprecation_note!(MatrixViewXx6)]
 pub type MatrixSliceXx6<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U6, ViewStorage<'a, T, Dynamic, U6, RStride, CStride>>;
 
 /// A column vector slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorView)]
+#[deprecated = slice_deprecation_note!(VectorView)]
 pub type VectorSlice<'a, T, D, RStride = U1, CStride = D> =
     Matrix<T, D, U1, ViewStorage<'a, T, D, U1, RStride, CStride>>;
 
 /// A column vector slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(SVectorView)]
+#[deprecated = slice_deprecation_note!(SVectorView)]
 pub type SVectorSlice<'a, T, const D: usize> =
     Matrix<T, Const<D>, Const<1>, ViewStorage<'a, T, Const<D>, Const<1>, Const<1>, Const<D>>>;
 
 /// A column vector slice dynamic numbers of rows and columns.
-#[deprecated = deprecation_note!(DVectorView)]
+#[deprecated = slice_deprecation_note!(DVectorView)]
 pub type DVectorSlice<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U1, ViewStorage<'a, T, Dynamic, U1, RStride, CStride>>;
 
 /// A 1D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorView1)]
+#[deprecated = slice_deprecation_note!(VectorView1)]
 pub type VectorSlice1<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U1, ViewStorage<'a, T, U1, U1, RStride, CStride>>;
 /// A 2D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorView2)]
+#[deprecated = slice_deprecation_note!(VectorView2)]
 pub type VectorSlice2<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U1, ViewStorage<'a, T, U2, U1, RStride, CStride>>;
 /// A 3D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorView3)]
+#[deprecated = slice_deprecation_note!(VectorView3)]
 pub type VectorSlice3<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U1, ViewStorage<'a, T, U3, U1, RStride, CStride>>;
 /// A 4D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorView4)]
+#[deprecated = slice_deprecation_note!(VectorView4)]
 pub type VectorSlice4<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U1, ViewStorage<'a, T, U4, U1, RStride, CStride>>;
 /// A 5D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorView5)]
+#[deprecated = slice_deprecation_note!(VectorView5)]
 pub type VectorSlice5<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U1, ViewStorage<'a, T, U5, U1, RStride, CStride>>;
 /// A 6D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorView6)]
+#[deprecated = slice_deprecation_note!(VectorView6)]
 pub type VectorSlice6<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U1, ViewStorage<'a, T, U6, U1, RStride, CStride>>;
 
@@ -385,344 +378,344 @@ pub type MatrixSliceMutN<'a, T, D, RStride = U1, CStride = D> =
 /// A column-major matrix slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(SMatrixViewMut)]
+#[deprecated = slice_deprecation_note!(SMatrixViewMut)]
 pub type SMatrixSliceMut<'a, T, const R: usize, const C: usize> =
     Matrix<T, Const<R>, Const<C>, ViewStorageMut<'a, T, Const<R>, Const<C>, Const<1>, Const<R>>>;
 
 /// A column-major matrix slice dynamic numbers of rows and columns.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(DMatrixViewMut)]
+#[deprecated = slice_deprecation_note!(DMatrixViewMut)]
 pub type DMatrixSliceMut<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, Dynamic, ViewStorageMut<'a, T, Dynamic, Dynamic, RStride, CStride>>;
 
 /// A column-major 1x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut1)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut1)]
 pub type MatrixSliceMut1<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U1, ViewStorageMut<'a, T, U1, U1, RStride, CStride>>;
 /// A column-major 2x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut2)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut2)]
 pub type MatrixSliceMut2<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U2, ViewStorageMut<'a, T, U2, U2, RStride, CStride>>;
 /// A column-major 3x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut3)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut3)]
 pub type MatrixSliceMut3<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U3, ViewStorageMut<'a, T, U3, U3, RStride, CStride>>;
 /// A column-major 4x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut4)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut4)]
 pub type MatrixSliceMut4<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U4, ViewStorageMut<'a, T, U4, U4, RStride, CStride>>;
 /// A column-major 5x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut5)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut5)]
 pub type MatrixSliceMut5<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U5, ViewStorageMut<'a, T, U5, U5, RStride, CStride>>;
 /// A column-major 6x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut6)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut6)]
 pub type MatrixSliceMut6<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U6, ViewStorageMut<'a, T, U6, U6, RStride, CStride>>;
 
 /// A column-major 1x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut1x2)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut1x2)]
 pub type MatrixSliceMut1x2<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U2, ViewStorageMut<'a, T, U1, U2, RStride, CStride>>;
 /// A column-major 1x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut1x3)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut1x3)]
 pub type MatrixSliceMut1x3<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U3, ViewStorageMut<'a, T, U1, U3, RStride, CStride>>;
 /// A column-major 1x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut1x4)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut1x4)]
 pub type MatrixSliceMut1x4<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U4, ViewStorageMut<'a, T, U1, U4, RStride, CStride>>;
 /// A column-major 1x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut1x5)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut1x5)]
 pub type MatrixSliceMut1x5<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U5, ViewStorageMut<'a, T, U1, U5, RStride, CStride>>;
 /// A column-major 1x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut1x6)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut1x6)]
 pub type MatrixSliceMut1x6<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U6, ViewStorageMut<'a, T, U1, U6, RStride, CStride>>;
 
 /// A column-major 2x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut2x1)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut2x1)]
 pub type MatrixSliceMut2x1<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U1, ViewStorageMut<'a, T, U2, U1, RStride, CStride>>;
 /// A column-major 2x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut2x3)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut2x3)]
 pub type MatrixSliceMut2x3<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U3, ViewStorageMut<'a, T, U2, U3, RStride, CStride>>;
 /// A column-major 2x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut2x4)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut2x4)]
 pub type MatrixSliceMut2x4<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U4, ViewStorageMut<'a, T, U2, U4, RStride, CStride>>;
 /// A column-major 2x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut2x5)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut2x5)]
 pub type MatrixSliceMut2x5<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U5, ViewStorageMut<'a, T, U2, U5, RStride, CStride>>;
 /// A column-major 2x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut2x6)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut2x6)]
 pub type MatrixSliceMut2x6<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U6, ViewStorageMut<'a, T, U2, U6, RStride, CStride>>;
 
 /// A column-major 3x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut3x1)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut3x1)]
 pub type MatrixSliceMut3x1<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U1, ViewStorageMut<'a, T, U3, U1, RStride, CStride>>;
 /// A column-major 3x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut3x2)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut3x2)]
 pub type MatrixSliceMut3x2<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U2, ViewStorageMut<'a, T, U3, U2, RStride, CStride>>;
 /// A column-major 3x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut3x4)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut3x4)]
 pub type MatrixSliceMut3x4<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U4, ViewStorageMut<'a, T, U3, U4, RStride, CStride>>;
 /// A column-major 3x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut3x5)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut3x5)]
 pub type MatrixSliceMut3x5<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U5, ViewStorageMut<'a, T, U3, U5, RStride, CStride>>;
 /// A column-major 3x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut3x6)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut3x6)]
 pub type MatrixSliceMut3x6<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U6, ViewStorageMut<'a, T, U3, U6, RStride, CStride>>;
 
 /// A column-major 4x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut4x1)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut4x1)]
 pub type MatrixSliceMut4x1<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U1, ViewStorageMut<'a, T, U4, U1, RStride, CStride>>;
 /// A column-major 4x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut4x2)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut4x2)]
 pub type MatrixSliceMut4x2<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U2, ViewStorageMut<'a, T, U4, U2, RStride, CStride>>;
 /// A column-major 4x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut4x3)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut4x3)]
 pub type MatrixSliceMut4x3<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U3, ViewStorageMut<'a, T, U4, U3, RStride, CStride>>;
 /// A column-major 4x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut4x5)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut4x5)]
 pub type MatrixSliceMut4x5<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U5, ViewStorageMut<'a, T, U4, U5, RStride, CStride>>;
 /// A column-major 4x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut4x6)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut4x6)]
 pub type MatrixSliceMut4x6<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U6, ViewStorageMut<'a, T, U4, U6, RStride, CStride>>;
 
 /// A column-major 5x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut5x1)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut5x1)]
 pub type MatrixSliceMut5x1<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U1, ViewStorageMut<'a, T, U5, U1, RStride, CStride>>;
 /// A column-major 5x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut5x2)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut5x2)]
 pub type MatrixSliceMut5x2<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U2, ViewStorageMut<'a, T, U5, U2, RStride, CStride>>;
 /// A column-major 5x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut5x3)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut5x3)]
 pub type MatrixSliceMut5x3<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U3, ViewStorageMut<'a, T, U5, U3, RStride, CStride>>;
 /// A column-major 5x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut5x4)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut5x4)]
 pub type MatrixSliceMut5x4<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U4, ViewStorageMut<'a, T, U5, U4, RStride, CStride>>;
 /// A column-major 5x6 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut5x6)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut5x6)]
 pub type MatrixSliceMut5x6<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U6, ViewStorageMut<'a, T, U5, U6, RStride, CStride>>;
 
 /// A column-major 6x1 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut6x1)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut6x1)]
 pub type MatrixSliceMut6x1<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U1, ViewStorageMut<'a, T, U6, U1, RStride, CStride>>;
 /// A column-major 6x2 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut6x2)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut6x2)]
 pub type MatrixSliceMut6x2<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U2, ViewStorageMut<'a, T, U6, U2, RStride, CStride>>;
 /// A column-major 6x3 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut6x3)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut6x3)]
 pub type MatrixSliceMut6x3<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U3, ViewStorageMut<'a, T, U6, U3, RStride, CStride>>;
 /// A column-major 6x4 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut6x4)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut6x4)]
 pub type MatrixSliceMut6x4<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U4, ViewStorageMut<'a, T, U6, U4, RStride, CStride>>;
 /// A column-major 6x5 matrix slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(MatrixViewMut6x5)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut6x5)]
 pub type MatrixSliceMut6x5<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U5, ViewStorageMut<'a, T, U6, U5, RStride, CStride>>;
 
 /// A column-major matrix slice with 1 row and a number of columns chosen at runtime.
-#[deprecated = deprecation_note!(MatrixViewMut1xX)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut1xX)]
 pub type MatrixSliceMut1xX<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, Dynamic, ViewStorageMut<'a, T, U1, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 2 rows and a number of columns chosen at runtime.
-#[deprecated = deprecation_note!(MatrixViewMut2xX)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut2xX)]
 pub type MatrixSliceMut2xX<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, Dynamic, ViewStorageMut<'a, T, U2, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 3 rows and a number of columns chosen at runtime.
-#[deprecated = deprecation_note!(MatrixViewMut3xX)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut3xX)]
 pub type MatrixSliceMut3xX<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, Dynamic, ViewStorageMut<'a, T, U3, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 4 rows and a number of columns chosen at runtime.
-#[deprecated = deprecation_note!(MatrixViewMut4xX)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut4xX)]
 pub type MatrixSliceMut4xX<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, Dynamic, ViewStorageMut<'a, T, U4, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 5 rows and a number of columns chosen at runtime.
-#[deprecated = deprecation_note!(MatrixViewMut5xX)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut5xX)]
 pub type MatrixSliceMut5xX<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, Dynamic, ViewStorageMut<'a, T, U5, Dynamic, RStride, CStride>>;
 /// A column-major matrix slice with 6 rows and a number of columns chosen at runtime.
-#[deprecated = deprecation_note!(MatrixViewMut6xX)]
+#[deprecated = slice_deprecation_note!(MatrixViewMut6xX)]
 pub type MatrixSliceMut6xX<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, Dynamic, ViewStorageMut<'a, T, U6, Dynamic, RStride, CStride>>;
 
 /// A column-major matrix slice with a number of rows chosen at runtime and 1 column.
-#[deprecated = deprecation_note!(MatrixViewMutXx1)]
+#[deprecated = slice_deprecation_note!(MatrixViewMutXx1)]
 pub type MatrixSliceMutXx1<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U1, ViewStorageMut<'a, T, Dynamic, U1, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 2 columns.
-#[deprecated = deprecation_note!(MatrixViewMutXx2)]
+#[deprecated = slice_deprecation_note!(MatrixViewMutXx2)]
 pub type MatrixSliceMutXx2<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U2, ViewStorageMut<'a, T, Dynamic, U2, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 3 columns.
-#[deprecated = deprecation_note!(MatrixViewMutXx3)]
+#[deprecated = slice_deprecation_note!(MatrixViewMutXx3)]
 pub type MatrixSliceMutXx3<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U3, ViewStorageMut<'a, T, Dynamic, U3, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 4 columns.
-#[deprecated = deprecation_note!(MatrixViewMutXx4)]
+#[deprecated = slice_deprecation_note!(MatrixViewMutXx4)]
 pub type MatrixSliceMutXx4<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U4, ViewStorageMut<'a, T, Dynamic, U4, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 5 columns.
-#[deprecated = deprecation_note!(MatrixViewMutXx5)]
+#[deprecated = slice_deprecation_note!(MatrixViewMutXx5)]
 pub type MatrixSliceMutXx5<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U5, ViewStorageMut<'a, T, Dynamic, U5, RStride, CStride>>;
 /// A column-major matrix slice with a number of rows chosen at runtime and 6 columns.
-#[deprecated = deprecation_note!(MatrixViewMutXx6)]
+#[deprecated = slice_deprecation_note!(MatrixViewMutXx6)]
 pub type MatrixSliceMutXx6<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U6, ViewStorageMut<'a, T, Dynamic, U6, RStride, CStride>>;
 
 /// A column vector slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorViewMut)]
+#[deprecated = slice_deprecation_note!(VectorViewMut)]
 pub type VectorSliceMut<'a, T, D, RStride = U1, CStride = D> =
     Matrix<T, D, U1, ViewStorageMut<'a, T, D, U1, RStride, CStride>>;
 
 /// A column vector slice with dimensions known at compile-time.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(SVectorViewMut)]
+#[deprecated = slice_deprecation_note!(SVectorViewMut)]
 pub type SVectorSliceMut<'a, T, const D: usize> =
     Matrix<T, Const<D>, Const<1>, ViewStorageMut<'a, T, Const<D>, Const<1>, Const<1>, Const<D>>>;
 
 /// A column vector slice dynamic numbers of rows and columns.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(DVectorViewMut)]
+#[deprecated = slice_deprecation_note!(DVectorViewMut)]
 pub type DVectorSliceMut<'a, T, RStride = U1, CStride = Dynamic> =
     Matrix<T, Dynamic, U1, ViewStorageMut<'a, T, Dynamic, U1, RStride, CStride>>;
 
 /// A 1D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorViewMut1)]
+#[deprecated = slice_deprecation_note!(VectorViewMut1)]
 pub type VectorSliceMut1<'a, T, RStride = U1, CStride = U1> =
     Matrix<T, U1, U1, ViewStorageMut<'a, T, U1, U1, RStride, CStride>>;
 /// A 2D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorViewMut2)]
+#[deprecated = slice_deprecation_note!(VectorViewMut2)]
 pub type VectorSliceMut2<'a, T, RStride = U1, CStride = U2> =
     Matrix<T, U2, U1, ViewStorageMut<'a, T, U2, U1, RStride, CStride>>;
 /// A 3D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorViewMut3)]
+#[deprecated = slice_deprecation_note!(VectorViewMut3)]
 pub type VectorSliceMut3<'a, T, RStride = U1, CStride = U3> =
     Matrix<T, U3, U1, ViewStorageMut<'a, T, U3, U1, RStride, CStride>>;
 /// A 4D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorViewMut4)]
+#[deprecated = slice_deprecation_note!(VectorViewMut4)]
 pub type VectorSliceMut4<'a, T, RStride = U1, CStride = U4> =
     Matrix<T, U4, U1, ViewStorageMut<'a, T, U4, U1, RStride, CStride>>;
 /// A 5D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorViewMut5)]
+#[deprecated = slice_deprecation_note!(VectorViewMut5)]
 pub type VectorSliceMut5<'a, T, RStride = U1, CStride = U5> =
     Matrix<T, U5, U1, ViewStorageMut<'a, T, U5, U1, RStride, CStride>>;
 /// A 6D column vector slice.
 ///
 /// **Because this is an alias, not all its methods are listed here. See the [`Matrix`](crate::base::Matrix) type too.**
-#[deprecated = deprecation_note!(VectorViewMut6)]
+#[deprecated = slice_deprecation_note!(VectorViewMut6)]
 pub type VectorSliceMut6<'a, T, RStride = U1, CStride = U6> =
     Matrix<T, U6, U1, ViewStorageMut<'a, T, U6, U1, RStride, CStride>>;
diff --git a/src/lib.rs b/src/lib.rs
index 86a5dc6b..e3e6b66b 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -97,6 +97,19 @@ an optimized set of tools for computer graphics and physics. Those features incl
 )]
 #![cfg_attr(not(feature = "std"), no_std)]
 
+/// Generates an appropriate deprecation note with a suggestion for replacement.
+///
+/// Used for deprecating slice types in various locations throughout the library.
+/// See #1076 for more information.
+macro_rules! slice_deprecation_note {
+    ($replacement:ident) => {
+        concat!("Use ", stringify!($replacement),
+            r###" instead. See [issue #1076](https://github.com/dimforge/nalgebra/issues/1076) for more information."###)
+    }
+}
+
+pub(crate) use slice_deprecation_note;
+
 #[cfg(feature = "rand-no-std")]
 extern crate rand_package as rand;
 

From 0319d236af74b3960b493829ca245d37a8de7629 Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 14:02:36 +0100
Subject: [PATCH 78/91] Deprecate+rename methods for slicing

---
 src/base/construction_view.rs |  36 ++---
 src/base/indexing.rs          |   2 +-
 src/base/matrix.rs            |  14 +-
 src/base/matrix_view.rs       | 277 +++++++++++++++++++++++-----------
 4 files changed, 213 insertions(+), 116 deletions(-)

diff --git a/src/base/construction_view.rs b/src/base/construction_view.rs
index aa355264..fbb038cb 100644
--- a/src/base/construction_view.rs
+++ b/src/base/construction_view.rs
@@ -4,11 +4,11 @@ use crate::base::{MatrixView, MatrixViewMut, Scalar};
 
 use num_rational::Ratio;
 
-/// # Creating matrix slices from `&[T]`
+/// # Creating matrix views from `&[T]`
 impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
     MatrixView<'a, T, R, C, RStride, CStride>
 {
-    /// Creates, without bound-checking, a matrix slice from an array and with dimensions and strides specified by generic types instances.
+    /// Creates, without bounds checking, a matrix view from an array and with dimensions and strides specified by generic types instances.
     ///
     /// # Safety
     /// This method is unsafe because the input data array is not checked to contain enough elements.
@@ -30,7 +30,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
         Self::from_data(data)
     }
 
-    /// Creates a matrix slice from an array and with dimensions and strides specified by generic types instances.
+    /// Creates a matrix view from an array and with dimensions and strides specified by generic types instances.
     ///
     /// Panics if the input data array dose not contain enough elements.
     /// The generic types `R`, `C`, `RStride`, `CStride` can either be type-level integers or integers wrapped with `Dynamic::new()`.
@@ -58,7 +58,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
 }
 
 impl<'a, T: Scalar, R: Dim, C: Dim> MatrixView<'a, T, R, C> {
-    /// Creates, without bound-checking, a matrix slice from an array and with dimensions specified by generic types instances.
+    /// Creates, without bound-checking, a matrix view from an array and with dimensions specified by generic types instances.
     ///
     /// # Safety
     /// This method is unsafe because the input data array is not checked to contain enough elements.
@@ -75,7 +75,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim> MatrixView<'a, T, R, C> {
         )
     }
 
-    /// Creates a matrix slice from an array and with dimensions and strides specified by generic types instances.
+    /// Creates a matrix view from an array and with dimensions and strides specified by generic types instances.
     ///
     /// Panics if the input data array dose not contain enough elements.
     /// The generic types `R` and `C` can either be type-level integers or integers wrapped with `Dynamic::new()`.
@@ -88,7 +88,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim> MatrixView<'a, T, R, C> {
 macro_rules! impl_constructors(
     ($($Dims: ty),*; $(=> $DimIdent: ident: $DimBound: ident),*; $($gargs: expr),*; $($args: ident),*) => {
         impl<'a, T: Scalar, $($DimIdent: $DimBound),*> MatrixView<'a, T, $($Dims),*> {
-            /// Creates a new matrix slice from the given data array.
+            /// Creates a new matrix view from the given data array.
             ///
             /// Panics if `data` does not contain enough elements.
             #[inline]
@@ -96,7 +96,7 @@ macro_rules! impl_constructors(
                 Self::from_slice_generic(data, $($gargs),*)
             }
 
-            /// Creates, without bound checking, a new matrix slice from the given data array.
+            /// Creates, without bound checking, a new matrix view from the given data array.
             #[inline]
             pub unsafe fn from_slice_unchecked(data: &'a [T], start: usize, $($args: usize),*) -> Self {
                 Self::from_slice_generic_unchecked(data, start, $($gargs),*)
@@ -104,7 +104,7 @@ macro_rules! impl_constructors(
         }
 
         impl<'a, T: Scalar, $($DimIdent: $DimBound, )*> MatrixView<'a, T, $($Dims,)* Dynamic, Dynamic> {
-            /// Creates a new matrix slice with the specified strides from the given data array.
+            /// Creates a new matrix view with the specified strides from the given data array.
             ///
             /// Panics if `data` does not contain enough elements.
             #[inline]
@@ -112,7 +112,7 @@ macro_rules! impl_constructors(
                 Self::from_slice_with_strides_generic(data, $($gargs,)* Dynamic::new(rstride), Dynamic::new(cstride))
             }
 
-            /// Creates, without bound checking, a new matrix slice with the specified strides from the given data array.
+            /// Creates, without bound checking, a new matrix view with the specified strides from the given data array.
             #[inline]
             pub unsafe fn from_slice_with_strides_unchecked(data: &'a [T], start: usize, $($args: usize,)* rstride: usize, cstride: usize) -> Self {
                 Self::from_slice_with_strides_generic_unchecked(data, start, $($gargs,)* Dynamic::new(rstride), Dynamic::new(cstride))
@@ -142,11 +142,11 @@ impl_constructors!(Dynamic, Dynamic;
                    Dynamic::new(nrows), Dynamic::new(ncols);
                    nrows, ncols);
 
-/// # Creating mutable matrix slices from `&mut [T]`
+/// # Creating mutable matrix views from `&mut [T]`
 impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
     MatrixViewMut<'a, T, R, C, RStride, CStride>
 {
-    /// Creates, without bound-checking, a mutable matrix slice from an array and with dimensions and strides specified by generic types instances.
+    /// Creates, without bound-checking, a mutable matrix view from an array and with dimensions and strides specified by generic types instances.
     ///
     /// # Safety
     /// This method is unsafe because the input data array is not checked to contain enough elements.
@@ -168,7 +168,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
         Self::from_data(data)
     }
 
-    /// Creates a mutable matrix slice from an array and with dimensions and strides specified by generic types instances.
+    /// Creates a mutable matrix view from an array and with dimensions and strides specified by generic types instances.
     ///
     /// Panics if the input data array dose not contain enough elements.
     /// The generic types `R`, `C`, `RStride`, `CStride` can either be type-level integers or integers wrapped with `Dynamic::new()`.
@@ -218,7 +218,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
 }
 
 impl<'a, T: Scalar, R: Dim, C: Dim> MatrixViewMut<'a, T, R, C> {
-    /// Creates, without bound-checking, a mutable matrix slice from an array and with dimensions specified by generic types instances.
+    /// Creates, without bound-checking, a mutable matrix view from an array and with dimensions specified by generic types instances.
     ///
     /// # Safety
     /// This method is unsafe because the input data array is not checked to contain enough elements.
@@ -235,7 +235,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim> MatrixViewMut<'a, T, R, C> {
         )
     }
 
-    /// Creates a mutable matrix slice from an array and with dimensions and strides specified by generic types instances.
+    /// Creates a mutable matrix view from an array and with dimensions and strides specified by generic types instances.
     ///
     /// Panics if the input data array dose not contain enough elements.
     /// The generic types `R` and `C` can either be type-level integers or integers wrapped with `Dynamic::new()`.
@@ -248,7 +248,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim> MatrixViewMut<'a, T, R, C> {
 macro_rules! impl_constructors_mut(
     ($($Dims: ty),*; $(=> $DimIdent: ident: $DimBound: ident),*; $($gargs: expr),*; $($args: ident),*) => {
         impl<'a, T: Scalar, $($DimIdent: $DimBound),*> MatrixViewMut<'a, T, $($Dims),*> {
-            /// Creates a new mutable matrix slice from the given data array.
+            /// Creates a new mutable matrix view from the given data array.
             ///
             /// Panics if `data` does not contain enough elements.
             #[inline]
@@ -256,7 +256,7 @@ macro_rules! impl_constructors_mut(
                 Self::from_slice_generic(data, $($gargs),*)
             }
 
-            /// Creates, without bound checking, a new mutable matrix slice from the given data array.
+            /// Creates, without bound checking, a new mutable matrix view from the given data array.
             #[inline]
             pub unsafe fn from_slice_unchecked(data: &'a mut [T], start: usize, $($args: usize),*) -> Self {
                 Self::from_slice_generic_unchecked(data, start, $($gargs),*)
@@ -264,7 +264,7 @@ macro_rules! impl_constructors_mut(
         }
 
         impl<'a, T: Scalar, $($DimIdent: $DimBound, )*> MatrixViewMut<'a, T, $($Dims,)* Dynamic, Dynamic> {
-            /// Creates a new mutable matrix slice with the specified strides from the given data array.
+            /// Creates a new mutable matrix view with the specified strides from the given data array.
             ///
             /// Panics if `data` does not contain enough elements.
             #[inline]
@@ -273,7 +273,7 @@ macro_rules! impl_constructors_mut(
                     data, $($gargs,)* Dynamic::new(rstride), Dynamic::new(cstride))
             }
 
-            /// Creates, without bound checking, a new mutable matrix slice with the specified strides from the given data array.
+            /// Creates, without bound checking, a new mutable matrix view with the specified strides from the given data array.
             #[inline]
             pub unsafe fn from_slice_with_strides_unchecked(data: &'a mut [T], start: usize, $($args: usize,)* rstride: usize, cstride: usize) -> Self {
                 Self::from_slice_with_strides_generic_unchecked(
diff --git a/src/base/indexing.rs b/src/base/indexing.rs
index df769163..ceefe91e 100644
--- a/src/base/indexing.rs
+++ b/src/base/indexing.rs
@@ -378,7 +378,7 @@ pub trait MatrixIndexMut<'a, T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>>:
     }
 }
 
-/// # Slicing based on ranges
+/// # Views based on ranges
 /// ## Indices to Individual Elements
 /// ### Two-Dimensional Indices
 /// ```
diff --git a/src/base/matrix.rs b/src/base/matrix.rs
index 659d3a6e..ae2f51e9 100644
--- a/src/base/matrix.rs
+++ b/src/base/matrix.rs
@@ -99,13 +99,13 @@ pub type MatrixCross<T, R1, C1, R2, C2> =
 /// - [Elementwise mapping and folding <span style="float:right;">`map`, `fold`, `zip_map`…</span>](#elementwise-mapping-and-folding)
 /// - [Folding or columns and rows <span style="float:right;">`compress_rows`, `compress_columns`…</span>](#folding-on-columns-and-rows)
 ///
-/// #### Vector and matrix slicing
-/// - [Creating matrix slices from `&[T]` <span style="float:right;">`from_slice`, `from_slice_with_strides`…</span>](#creating-matrix-slices-from-t)
-/// - [Creating mutable matrix slices from `&mut [T]` <span style="float:right;">`from_slice_mut`, `from_slice_with_strides_mut`…</span>](#creating-mutable-matrix-slices-from-mut-t)
-/// - [Slicing based on index and length <span style="float:right;">`row`, `columns`, `slice`…</span>](#slicing-based-on-index-and-length)
-/// - [Mutable slicing based on index and length <span style="float:right;">`row_mut`, `columns_mut`, `slice_mut`…</span>](#mutable-slicing-based-on-index-and-length)
-/// - [Slicing based on ranges <span style="float:right;">`rows_range`, `columns_range`…</span>](#slicing-based-on-ranges)
-/// - [Mutable slicing based on ranges <span style="float:right;">`rows_range_mut`, `columns_range_mut`…</span>](#mutable-slicing-based-on-ranges)
+/// #### Vector and matrix views
+/// - [Creating matrix views from `&[T]` <span style="float:right;">`from_slice`, `from_slice_with_strides`…</span>](#creating-matrix-views-from-t)
+/// - [Creating mutable matrix views from `&mut [T]` <span style="float:right;">`from_slice_mut`, `from_slice_with_strides_mut`…</span>](#creating-mutable-matrix-views-from-mut-t)
+/// - [Views based on index and length <span style="float:right;">`row`, `columns`, `view`…</span>](#views-based-on-index-and-length)
+/// - [Mutable views based on index and length <span style="float:right;">`row_mut`, `columns_mut`, `view_mut`…</span>](#mutable-views-based-on-index-and-length)
+/// - [Views based on ranges <span style="float:right;">`rows_range`, `columns_range`…</span>](#views-based-on-ranges)
+/// - [Mutable views based on ranges <span style="float:right;">`rows_range_mut`, `columns_range_mut`…</span>](#mutable-views-based-on-ranges)
 ///
 /// #### In-place modification of a single matrix or vector
 /// - [In-place filling <span style="float:right;">`fill`, `fill_diagonal`, `fill_with_identity`…</span>](#in-place-filling)
diff --git a/src/base/matrix_view.rs b/src/base/matrix_view.rs
index 03d06778..d37346a6 100644
--- a/src/base/matrix_view.rs
+++ b/src/base/matrix_view.rs
@@ -284,7 +284,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     }
 }
 
-macro_rules! matrix_slice_impl (
+macro_rules! matrix_view_impl (
     ($me: ident: $Me: ty, $MatrixView: ident, $ViewStorage: ident, $Storage: ident.$get_addr: ident (), $data: expr;
      $row: ident,
      $row_part: ident,
@@ -302,12 +302,12 @@ macro_rules! matrix_slice_impl (
      $fixed_columns_with_step: ident,
      $columns_generic: ident,
      $columns_generic_with_step: ident,
-     $slice: ident,
-     $slice_with_steps: ident,
-     $fixed_slice: ident,
-     $fixed_slice_with_steps: ident,
-     $generic_slice: ident,
-     $generic_slice_with_steps: ident,
+     $slice: ident => $view:ident,
+     $slice_with_steps: ident => $view_with_steps:ident,
+     $fixed_slice: ident => $fixed_view:ident,
+     $fixed_slice_with_steps: ident => $fixed_view_with_steps:ident,
+     $generic_slice: ident => $generic_view:ident,
+     $generic_slice_with_steps: ident => $generic_view_with_steps:ident,
      $rows_range_pair: ident,
      $columns_range_pair: ident) => {
         /*
@@ -315,13 +315,13 @@ macro_rules! matrix_slice_impl (
          * Row slicing.
          *
          */
-        /// Returns a slice containing the i-th row of this matrix.
+        /// Returns a view containing the i-th row of this matrix.
         #[inline]
         pub fn $row($me: $Me, i: usize) -> $MatrixView<'_, T, U1, C, S::RStride, S::CStride> {
             $me.$fixed_rows::<1>(i)
         }
 
-        /// Returns a slice containing the `n` first elements of the i-th row of this matrix.
+        /// Returns a view containing the `n` first elements of the i-th row of this matrix.
         #[inline]
         pub fn $row_part($me: $Me, i: usize, n: usize) -> $MatrixView<'_, T, U1, Dynamic, S::RStride, S::CStride> {
             $me.$generic_slice((i, 0), (Const::<1>, Dynamic::new(n)))
@@ -345,26 +345,26 @@ macro_rules! matrix_slice_impl (
 
         /// Extracts a compile-time number of consecutive rows from this matrix.
         #[inline]
-        pub fn $fixed_rows<const RSLICE: usize>($me: $Me, first_row: usize)
-            -> $MatrixView<'_, T, Const<RSLICE>, C, S::RStride, S::CStride> {
+        pub fn $fixed_rows<const RVIEW: usize>($me: $Me, first_row: usize)
+            -> $MatrixView<'_, T, Const<RVIEW>, C, S::RStride, S::CStride> {
 
-            $me.$rows_generic(first_row, Const::<RSLICE>)
+            $me.$rows_generic(first_row, Const::<RVIEW>)
         }
 
         /// Extracts from this matrix a compile-time number of rows regularly skipping `step`
         /// rows.
         #[inline]
-        pub fn $fixed_rows_with_step<const RSLICE: usize>($me: $Me, first_row: usize, step: usize)
-            -> $MatrixView<'_, T, Const<RSLICE>, C, Dynamic, S::CStride> {
+        pub fn $fixed_rows_with_step<const RVIEW: usize>($me: $Me, first_row: usize, step: usize)
+            -> $MatrixView<'_, T, Const<RVIEW>, C, Dynamic, S::CStride> {
 
-            $me.$rows_generic_with_step(first_row, Const::<RSLICE>, step)
+            $me.$rows_generic_with_step(first_row, Const::<RVIEW>, step)
         }
 
         /// Extracts from this matrix `nrows` rows regularly skipping `step` rows. Both
         /// argument may or may not be values known at compile-time.
         #[inline]
-        pub fn $rows_generic<RSlice: Dim>($me: $Me, row_start: usize, nrows: RSlice)
-            -> $MatrixView<'_, T, RSlice, C, S::RStride, S::CStride> {
+        pub fn $rows_generic<RView: Dim>($me: $Me, row_start: usize, nrows: RView)
+            -> $MatrixView<'_, T, RView, C, S::RStride, S::CStride> {
 
             let my_shape   = $me.shape_generic();
             $me.assert_slice_index((row_start, 0), (nrows.value(), my_shape.1.value()), (0, 0));
@@ -380,9 +380,9 @@ macro_rules! matrix_slice_impl (
         /// Extracts from this matrix `nrows` rows regularly skipping `step` rows. Both
         /// argument may or may not be values known at compile-time.
         #[inline]
-        pub fn $rows_generic_with_step<RSlice>($me: $Me, row_start: usize, nrows: RSlice, step: usize)
-            -> $MatrixView<'_, T, RSlice, C, Dynamic, S::CStride>
-            where RSlice: Dim {
+        pub fn $rows_generic_with_step<RView>($me: $Me, row_start: usize, nrows: RView, step: usize)
+            -> $MatrixView<'_, T, RView, C, Dynamic, S::CStride>
+            where RView: Dim {
 
             let my_shape   = $me.shape_generic();
             let my_strides = $me.data.strides();
@@ -402,16 +402,16 @@ macro_rules! matrix_slice_impl (
          * Column slicing.
          *
          */
-        /// Returns a slice containing the i-th column of this matrix.
+        /// Returns a view containing the i-th column of this matrix.
         #[inline]
         pub fn $column($me: $Me, i: usize) -> $MatrixView<'_, T, R, U1, S::RStride, S::CStride> {
             $me.$fixed_columns::<1>(i)
         }
 
-        /// Returns a slice containing the `n` first elements of the i-th column of this matrix.
+        /// Returns a view containing the `n` first elements of the i-th column of this matrix.
         #[inline]
         pub fn $column_part($me: $Me, i: usize, n: usize) -> $MatrixView<'_, T, Dynamic, U1, S::RStride, S::CStride> {
-            $me.$generic_slice((0, i), (Dynamic::new(n), Const::<1>))
+            $me.$generic_view((0, i), (Dynamic::new(n), Const::<1>))
         }
 
         /// Extracts from this matrix a set of consecutive columns.
@@ -433,26 +433,26 @@ macro_rules! matrix_slice_impl (
 
         /// Extracts a compile-time number of consecutive columns from this matrix.
         #[inline]
-        pub fn $fixed_columns<const CSLICE: usize>($me: $Me, first_col: usize)
-            -> $MatrixView<'_, T, R, Const<CSLICE>, S::RStride, S::CStride> {
+        pub fn $fixed_columns<const CVIEW: usize>($me: $Me, first_col: usize)
+            -> $MatrixView<'_, T, R, Const<CVIEW>, S::RStride, S::CStride> {
 
-            $me.$columns_generic(first_col, Const::<CSLICE>)
+            $me.$columns_generic(first_col, Const::<CVIEW>)
         }
 
         /// Extracts from this matrix a compile-time number of columns regularly skipping
         /// `step` columns.
         #[inline]
-        pub fn $fixed_columns_with_step<const CSLICE: usize>($me: $Me, first_col: usize, step: usize)
-            -> $MatrixView<'_, T, R, Const<CSLICE>, S::RStride, Dynamic> {
+        pub fn $fixed_columns_with_step<const CVIEW: usize>($me: $Me, first_col: usize, step: usize)
+            -> $MatrixView<'_, T, R, Const<CVIEW>, S::RStride, Dynamic> {
 
-            $me.$columns_generic_with_step(first_col, Const::<CSLICE>, step)
+            $me.$columns_generic_with_step(first_col, Const::<CVIEW>, step)
         }
 
         /// Extracts from this matrix `ncols` columns. The number of columns may or may not be
         /// known at compile-time.
         #[inline]
-        pub fn $columns_generic<CSlice: Dim>($me: $Me, first_col: usize, ncols: CSlice)
-            -> $MatrixView<'_, T, R, CSlice, S::RStride, S::CStride> {
+        pub fn $columns_generic<CView: Dim>($me: $Me, first_col: usize, ncols: CView)
+            -> $MatrixView<'_, T, R, CView, S::RStride, S::CStride> {
 
             let my_shape = $me.shape_generic();
             $me.assert_slice_index((0, first_col), (my_shape.0.value(), ncols.value()), (0, 0));
@@ -468,8 +468,8 @@ macro_rules! matrix_slice_impl (
         /// Extracts from this matrix `ncols` columns skipping `step` columns. Both argument may
         /// or may not be values known at compile-time.
         #[inline]
-        pub fn $columns_generic_with_step<CSlice: Dim>($me: $Me, first_col: usize, ncols: CSlice, step: usize)
-            -> $MatrixView<'_, T, R, CSlice, S::RStride, Dynamic> {
+        pub fn $columns_generic_with_step<CView: Dim>($me: $Me, first_col: usize, ncols: CView, step: usize)
+            -> $MatrixView<'_, T, R, CView, S::RStride, Dynamic> {
 
             let my_shape   = $me.shape_generic();
             let my_strides = $me.data.strides();
@@ -493,8 +493,17 @@ macro_rules! matrix_slice_impl (
         /// Slices this matrix starting at its component `(irow, icol)` and with `(nrows, ncols)`
         /// consecutive elements.
         #[inline]
+        #[deprecated = slice_deprecation_note!($view)]
         pub fn $slice($me: $Me, start: (usize, usize), shape: (usize, usize))
             -> $MatrixView<'_, T, Dynamic, Dynamic, S::RStride, S::CStride> {
+            $me.$view(start, shape)
+        }
+
+        /// Return a view of this matrix starting at its component `(irow, icol)` and with `(nrows, ncols)`
+        /// consecutive elements.
+        #[inline]
+        pub fn $view($me: $Me, start: (usize, usize), shape: (usize, usize))
+            -> $MatrixView<'_, T, Dynamic, Dynamic, S::RStride, S::CStride> {
 
             $me.assert_slice_index(start, shape, (0, 0));
             let shape = (Dynamic::new(shape.0), Dynamic::new(shape.1));
@@ -505,27 +514,45 @@ macro_rules! matrix_slice_impl (
             }
         }
 
-
         /// Slices this matrix starting at its component `(start.0, start.1)` and with
         /// `(shape.0, shape.1)` components. Each row (resp. column) of the sliced matrix is
         /// separated by `steps.0` (resp. `steps.1`) ignored rows (resp. columns) of the
         /// original matrix.
         #[inline]
+        #[deprecated = slice_deprecation_note!($view_with_steps)]
         pub fn $slice_with_steps($me: $Me, start: (usize, usize), shape: (usize, usize), steps: (usize, usize))
             -> $MatrixView<'_, T, Dynamic, Dynamic, Dynamic, Dynamic> {
-            let shape = (Dynamic::new(shape.0), Dynamic::new(shape.1));
+            $me.$view_with_steps(start, shape, steps)
+        }
 
-            $me.$generic_slice_with_steps(start, shape, steps)
+        /// Return a view of this matrix starting at its component `(start.0, start.1)` and with
+        /// `(shape.0, shape.1)` components. Each row (resp. column) of the matrix view is
+        /// separated by `steps.0` (resp. `steps.1`) ignored rows (resp. columns) of the
+        /// original matrix.
+        #[inline]
+        pub fn $view_with_steps($me: $Me, start: (usize, usize), shape: (usize, usize), steps: (usize, usize))
+            -> $MatrixView<'_, T, Dynamic, Dynamic, Dynamic, Dynamic> {
+            let shape = (Dynamic::new(shape.0), Dynamic::new(shape.1));
+            $me.$generic_view_with_steps(start, shape, steps)
         }
 
         /// Slices this matrix starting at its component `(irow, icol)` and with `(R::dim(),
-        /// CSlice::dim())` consecutive components.
+        /// CView::dim())` consecutive components.
         #[inline]
-        pub fn $fixed_slice<const RSLICE: usize, const CSLICE: usize>($me: $Me, irow: usize, icol: usize)
-            -> $MatrixView<'_, T, Const<RSLICE>, Const<CSLICE>, S::RStride, S::CStride> {
+        #[deprecated = slice_deprecation_note!($fixed_view)]
+        pub fn $fixed_slice<const RVIEW: usize, const CVIEW: usize>($me: $Me, irow: usize, icol: usize)
+            -> $MatrixView<'_, T, Const<RVIEW>, Const<CVIEW>, S::RStride, S::CStride> {
+            $me.$fixed_view(irow, icol)
+        }
 
-            $me.assert_slice_index((irow, icol), (RSLICE, CSLICE), (0, 0));
-            let shape = (Const::<RSLICE>, Const::<CSLICE>);
+        /// Return a view of this matrix starting at its component `(irow, icol)` and with `(R::dim(),
+        /// CView::dim())` consecutive components.
+        #[inline]
+        pub fn $fixed_view<const RVIEW: usize, const CVIEW: usize>($me: $Me, irow: usize, icol: usize)
+            -> $MatrixView<'_, T, Const<RVIEW>, Const<CVIEW>, S::RStride, S::CStride> {
+
+            $me.assert_slice_index((irow, icol), (RVIEW, CVIEW), (0, 0));
+            let shape = (Const::<RVIEW>, Const::<CVIEW>);
 
             unsafe {
                 let data = $ViewStorage::new_unchecked($data, (irow, icol), shape);
@@ -534,22 +561,43 @@ macro_rules! matrix_slice_impl (
         }
 
         /// Slices this matrix starting at its component `(start.0, start.1)` and with
-        /// `(RSLICE, CSLICE)` components. Each row (resp. column) of the sliced
+        /// `(RVIEW, CVIEW)` components. Each row (resp. column) of the sliced
         /// matrix is separated by `steps.0` (resp. `steps.1`) ignored rows (resp. columns) of
         /// the original matrix.
         #[inline]
-        pub fn $fixed_slice_with_steps<const RSLICE: usize, const CSLICE: usize>($me: $Me, start: (usize, usize), steps: (usize, usize))
-            -> $MatrixView<'_, T, Const<RSLICE>, Const<CSLICE>, Dynamic, Dynamic> {
-            let shape = (Const::<RSLICE>, Const::<CSLICE>);
-            $me.$generic_slice_with_steps(start, shape, steps)
+        #[deprecated = slice_deprecation_note!($fixed_view_with_steps)]
+        pub fn $fixed_slice_with_steps<const RVIEW: usize, const CVIEW: usize>($me: $Me, start: (usize, usize), steps: (usize, usize))
+            -> $MatrixView<'_, T, Const<RVIEW>, Const<CVIEW>, Dynamic, Dynamic> {
+            $me.$fixed_view_with_steps(start, steps)
+        }
+
+        /// Returns a view of this matrix starting at its component `(start.0, start.1)` and with
+        /// `(RVIEW, CVIEW)` components. Each row (resp. column) of the matrix view
+        /// is separated by `steps.0` (resp. `steps.1`) ignored rows (resp. columns) of
+        /// the original matrix.
+        #[inline]
+        pub fn $fixed_view_with_steps<const RVIEW: usize, const CVIEW: usize>($me: $Me, start: (usize, usize), steps: (usize, usize))
+            -> $MatrixView<'_, T, Const<RVIEW>, Const<CVIEW>, Dynamic, Dynamic> {
+            let shape = (Const::<RVIEW>, Const::<CVIEW>);
+            $me.$generic_view_with_steps(start, shape, steps)
         }
 
         /// Creates a slice that may or may not have a fixed size and stride.
         #[inline]
-        pub fn $generic_slice<RSlice, CSlice>($me: $Me, start: (usize, usize), shape: (RSlice, CSlice))
-            -> $MatrixView<'_, T, RSlice, CSlice, S::RStride, S::CStride>
-            where RSlice: Dim,
-                  CSlice: Dim {
+        #[deprecated = slice_deprecation_note!($generic_view)]
+        pub fn $generic_slice<RView, CView>($me: $Me, start: (usize, usize), shape: (RView, CView))
+            -> $MatrixView<'_, T, RView, CView, S::RStride, S::CStride>
+            where RView: Dim,
+                  CView: Dim {
+            $me.$generic_view(start, shape)
+        }
+
+        /// Creates a matrix view that may or may not have a fixed size and stride.
+        #[inline]
+        pub fn $generic_view<RView, CView>($me: $Me, start: (usize, usize), shape: (RView, CView))
+            -> $MatrixView<'_, T, RView, CView, S::RStride, S::CStride>
+            where RView: Dim,
+                  CView: Dim {
 
             $me.assert_slice_index(start, (shape.0.value(), shape.1.value()), (0, 0));
 
@@ -561,13 +609,26 @@ macro_rules! matrix_slice_impl (
 
         /// Creates a slice that may or may not have a fixed size and stride.
         #[inline]
-        pub fn $generic_slice_with_steps<RSlice, CSlice>($me: $Me,
+        #[deprecated = slice_deprecation_note!($generic_view_with_steps)]
+        pub fn $generic_slice_with_steps<RView, CView>($me: $Me,
                                                          start: (usize, usize),
-                                                         shape: (RSlice, CSlice),
+                                                         shape: (RView, CView),
                                                          steps: (usize, usize))
-            -> $MatrixView<'_, T, RSlice, CSlice, Dynamic, Dynamic>
-            where RSlice: Dim,
-                  CSlice: Dim {
+            -> $MatrixView<'_, T, RView, CView, Dynamic, Dynamic>
+            where RView: Dim,
+                  CView: Dim {
+            $me.$generic_view_with_steps(start, shape, steps)
+        }
+
+        /// Creates a matrix view that may or may not have a fixed size and stride.
+        #[inline]
+        pub fn $generic_view_with_steps<RView, CView>($me: $Me,
+                                                         start: (usize, usize),
+                                                         shape: (RView, CView),
+                                                         steps: (usize, usize))
+            -> $MatrixView<'_, T, RView, CView, Dynamic, Dynamic>
+            where RView: Dim,
+                  CView: Dim {
 
             $me.assert_slice_index(start, (shape.0.value(), shape.1.value()), steps);
 
@@ -615,10 +676,10 @@ macro_rules! matrix_slice_impl (
 
                 let data1  = $ViewStorage::from_raw_parts(ptr1, (nrows1, ncols), strides);
                 let data2  = $ViewStorage::from_raw_parts(ptr2, (nrows2, ncols), strides);
-                let slice1 = Matrix::from_data_statically_unchecked(data1);
-                let slice2 = Matrix::from_data_statically_unchecked(data2);
+                let view1 = Matrix::from_data_statically_unchecked(data1);
+                let view2 = Matrix::from_data_statically_unchecked(data2);
 
-                (slice1, slice2)
+                (view1, view2)
             }
         }
 
@@ -651,10 +712,10 @@ macro_rules! matrix_slice_impl (
 
                 let data1  = $ViewStorage::from_raw_parts(ptr1, (nrows, ncols1), strides);
                 let data2  = $ViewStorage::from_raw_parts(ptr2, (nrows, ncols2), strides);
-                let slice1 = Matrix::from_data_statically_unchecked(data1);
-                let slice2 = Matrix::from_data_statically_unchecked(data2);
+                let view1 = Matrix::from_data_statically_unchecked(data1);
+                let view2 = Matrix::from_data_statically_unchecked(data2);
 
-                (slice1, slice2)
+                (view1, view2)
             }
         }
     }
@@ -688,9 +749,9 @@ pub type MatrixSliceMut<'a, T, R, C, RStride = U1, CStride = R> =
 pub type MatrixViewMut<'a, T, R, C, RStride = U1, CStride = R> =
     Matrix<T, R, C, ViewStorageMut<'a, T, R, C, RStride, CStride>>;
 
-/// # Slicing based on index and length
+/// # Views based on index and length
 impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
-    matrix_slice_impl!(
+    matrix_view_impl!(
      self: &Self, MatrixView, ViewStorage, RawStorage.get_address_unchecked(), &self.data;
      row,
      row_part,
@@ -708,19 +769,19 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
      fixed_columns_with_step,
      columns_generic,
      columns_generic_with_step,
-     slice,
-     slice_with_steps,
-     fixed_slice,
-     fixed_slice_with_steps,
-     generic_slice,
-     generic_slice_with_steps,
+     slice => view,
+     slice_with_steps => view_with_steps,
+     fixed_slice => fixed_view,
+     fixed_slice_with_steps => fixed_view_with_steps,
+     generic_slice => generic_view,
+     generic_slice_with_steps => generic_view_with_steps,
      rows_range_pair,
      columns_range_pair);
 }
 
-/// # Mutable slicing based on index and length
+/// # Mutable views based on index and length
 impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
-    matrix_slice_impl!(
+    matrix_view_impl!(
      self: &mut Self, MatrixViewMut, ViewStorageMut, RawStorageMut.get_address_unchecked_mut(), &mut self.data;
      row_mut,
      row_part_mut,
@@ -738,12 +799,12 @@ impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
      fixed_columns_with_step_mut,
      columns_generic_mut,
      columns_generic_with_step_mut,
-     slice_mut,
-     slice_with_steps_mut,
-     fixed_slice_mut,
-     fixed_slice_with_steps_mut,
-     generic_slice_mut,
-     generic_slice_with_steps_mut,
+     slice_mut => view_mut,
+     slice_with_steps_mut => view_with_steps_mut,
+     fixed_slice_mut => fixed_view_mut,
+     fixed_slice_with_steps_mut => fixed_view_with_steps_mut,
+     generic_slice_mut => generic_view_mut,
+     generic_slice_with_steps_mut => generic_view_with_steps_mut,
      rows_range_pair_mut,
      columns_range_pair_mut);
 }
@@ -889,6 +950,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     /// by the range `cols`.
     #[inline]
     #[must_use]
+    #[deprecated = slice_deprecation_note!(view_range)]
     pub fn slice_range<RowRange, ColRange>(
         &self,
         rows: RowRange,
@@ -905,24 +967,44 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
         )
     }
 
-    /// Slice containing all the rows indexed by the range `rows`.
+    /// Returns a view containing the rows indexed by the range `rows` and the columns indexed
+    /// by the range `cols`.
+    #[inline]
+    #[must_use]
+    pub fn view_range<RowRange, ColRange>(
+        &self,
+        rows: RowRange,
+        cols: ColRange,
+    ) -> MatrixView<'_, T, RowRange::Size, ColRange::Size, S::RStride, S::CStride>
+        where
+            RowRange: SliceRange<R>,
+            ColRange: SliceRange<C>,
+    {
+        let (nrows, ncols) = self.shape_generic();
+        self.generic_view(
+            (rows.begin(nrows), cols.begin(ncols)),
+            (rows.size(nrows), cols.size(ncols)),
+        )
+    }
+
+    /// View containing all the rows indexed by the range `rows`.
     #[inline]
     #[must_use]
     pub fn rows_range<RowRange: SliceRange<R>>(
         &self,
         rows: RowRange,
     ) -> MatrixView<'_, T, RowRange::Size, C, S::RStride, S::CStride> {
-        self.slice_range(rows, ..)
+        self.view_range(rows, ..)
     }
 
-    /// Slice containing all the columns indexed by the range `rows`.
+    /// View containing all the columns indexed by the range `rows`.
     #[inline]
     #[must_use]
     pub fn columns_range<ColRange: SliceRange<C>>(
         &self,
         cols: ColRange,
     ) -> MatrixView<'_, T, R, ColRange::Size, S::RStride, S::CStride> {
-        self.slice_range(.., cols)
+        self.view_range(.., cols)
     }
 }
 
@@ -931,6 +1013,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
 impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
     /// Slices a mutable sub-matrix containing the rows indexed by the range `rows` and the columns
     /// indexed by the range `cols`.
+    #[deprecated = slice_deprecation_note!(view_range_mut)]
     pub fn slice_range_mut<RowRange, ColRange>(
         &mut self,
         rows: RowRange,
@@ -939,30 +1022,44 @@ impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
     where
         RowRange: SliceRange<R>,
         ColRange: SliceRange<C>,
+    {
+        self.view_range_mut(rows, cols)
+    }
+
+    /// Return a mutable view containing the rows indexed by the range `rows` and the columns
+    /// indexed by the range `cols`.
+    pub fn view_range_mut<RowRange, ColRange>(
+        &mut self,
+        rows: RowRange,
+        cols: ColRange,
+    ) -> MatrixViewMut<'_, T, RowRange::Size, ColRange::Size, S::RStride, S::CStride>
+        where
+            RowRange: SliceRange<R>,
+            ColRange: SliceRange<C>,
     {
         let (nrows, ncols) = self.shape_generic();
-        self.generic_slice_mut(
+        self.generic_view_mut(
             (rows.begin(nrows), cols.begin(ncols)),
             (rows.size(nrows), cols.size(ncols)),
         )
     }
 
-    /// Slice containing all the rows indexed by the range `rows`.
+    /// Mutable view containing all the rows indexed by the range `rows`.
     #[inline]
     pub fn rows_range_mut<RowRange: SliceRange<R>>(
         &mut self,
         rows: RowRange,
     ) -> MatrixViewMut<'_, T, RowRange::Size, C, S::RStride, S::CStride> {
-        self.slice_range_mut(rows, ..)
+        self.view_range_mut(rows, ..)
     }
 
-    /// Slice containing all the columns indexed by the range `cols`.
+    /// Mutable view containing all the columns indexed by the range `cols`.
     #[inline]
     pub fn columns_range_mut<ColRange: SliceRange<C>>(
         &mut self,
         cols: ColRange,
     ) -> MatrixViewMut<'_, T, R, ColRange::Size, S::RStride, S::CStride> {
-        self.slice_range_mut(.., cols)
+        self.view_range_mut(.., cols)
     }
 }
 
@@ -974,11 +1071,11 @@ where
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(slice_mut: MatrixViewMut<'a, T, R, C, RStride, CStride>) -> Self {
+    fn from(view_mut: MatrixViewMut<'a, T, R, C, RStride, CStride>) -> Self {
         let data = ViewStorage {
-            ptr: slice_mut.data.ptr,
-            shape: slice_mut.data.shape,
-            strides: slice_mut.data.strides,
+            ptr: view_mut.data.ptr,
+            shape: view_mut.data.shape,
+            strides: view_mut.data.strides,
             _phantoms: PhantomData,
         };
 

From 34f453737653c3e273ad472fe72b4e45ee5e4b2f Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 14:14:42 +0100
Subject: [PATCH 79/91] Use view* instead of slice* methods in src/

---
 src/base/blas.rs                       |  4 +-
 src/base/cg.rs                         | 24 ++++++------
 src/base/edition.rs                    |  2 +-
 src/base/matrix.rs                     |  8 ++--
 src/base/matrix_view.rs                |  4 +-
 src/geometry/isometry.rs               |  2 +-
 src/geometry/isometry_conversion.rs    |  6 +--
 src/geometry/point.rs                  |  2 +-
 src/geometry/point_construction.rs     |  2 +-
 src/geometry/point_conversion.rs       |  2 +-
 src/geometry/rotation.rs               |  2 +-
 src/geometry/rotation_conversion.rs    |  6 +--
 src/geometry/scale_conversion.rs       |  2 +-
 src/geometry/similarity.rs             |  2 +-
 src/geometry/similarity_conversion.rs  | 20 +++++-----
 src/geometry/transform_ops.rs          | 10 ++---
 src/geometry/translation.rs            |  2 +-
 src/geometry/translation_conversion.rs |  4 +-
 src/linalg/bidiagonal.rs               | 12 +++---
 src/linalg/cholesky.rs                 | 52 +++++++++++++-------------
 src/linalg/col_piv_qr.rs               | 10 ++---
 src/linalg/full_piv_lu.rs              |  2 +-
 src/linalg/hessenberg.rs               |  4 +-
 src/linalg/householder.rs              |  4 +-
 src/linalg/lu.rs                       |  8 ++--
 src/linalg/qr.rs                       |  8 ++--
 src/linalg/schur.rs                    | 26 ++++++-------
 src/linalg/solve.rs                    | 20 +++++-----
 28 files changed, 125 insertions(+), 125 deletions(-)

diff --git a/src/base/blas.rs b/src/base/blas.rs
index 5f51cea9..9d9dd2bd 100644
--- a/src/base/blas.rs
+++ b/src/base/blas.rs
@@ -393,7 +393,7 @@ where
         let col2 = a.column(0);
         let val = unsafe { x.vget_unchecked(0).clone() };
         self.axpy(alpha.clone() * val, &col2, beta);
-        self[0] += alpha.clone() * dot(&a.slice_range(1.., 0), &x.rows_range(1..));
+        self[0] += alpha.clone() * dot(&a.view_range(1.., 0), &x.rows_range(1..));
 
         for j in 1..dim2 {
             let col2 = a.column(j);
@@ -892,7 +892,7 @@ where
             let val = unsafe { conjugate(y.vget_unchecked(j).clone()) };
             let subdim = Dynamic::new(dim1 - j);
             // TODO: avoid bound checks.
-            self.generic_slice_mut((j, j), (subdim, Const::<1>)).axpy(
+            self.generic_view_mut((j, j), (subdim, Const::<1>)).axpy(
                 alpha.clone() * val,
                 &x.rows_range(j..),
                 beta.clone(),
diff --git a/src/base/cg.rs b/src/base/cg.rs
index ef3ad5b5..586c923e 100644
--- a/src/base/cg.rs
+++ b/src/base/cg.rs
@@ -59,7 +59,7 @@ where
         SB: Storage<T, DimNameDiff<D, U1>>,
     {
         let mut res = Self::identity();
-        res.generic_slice_mut(
+        res.generic_view_mut(
             (0, D::dim() - 1),
             (DimNameDiff::<D, U1>::name(), Const::<1>),
         )
@@ -382,19 +382,19 @@ impl<T: Scalar + Zero + One + ClosedMul + ClosedAdd, D: DimName, S: Storage<T, D
         DefaultAllocator: Allocator<T, DimNameDiff<D, U1>>,
     {
         let scale = self
-            .generic_slice(
+            .generic_view(
                 (D::dim() - 1, 0),
                 (Const::<1>, DimNameDiff::<D, U1>::name()),
             )
             .tr_dot(shift);
-        let post_translation = self.generic_slice(
+        let post_translation = self.generic_view(
             (0, 0),
             (DimNameDiff::<D, U1>::name(), DimNameDiff::<D, U1>::name()),
         ) * shift;
 
         self[(D::dim() - 1, D::dim() - 1)] += scale;
 
-        let mut translation = self.generic_slice_mut(
+        let mut translation = self.generic_view_mut(
             (0, D::dim() - 1),
             (DimNameDiff::<D, U1>::name(), Const::<1>),
         );
@@ -415,11 +415,11 @@ where
         &self,
         v: &OVector<T, DimNameDiff<D, U1>>,
     ) -> OVector<T, DimNameDiff<D, U1>> {
-        let transform = self.generic_slice(
+        let transform = self.generic_view(
             (0, 0),
             (DimNameDiff::<D, U1>::name(), DimNameDiff::<D, U1>::name()),
         );
-        let normalizer = self.generic_slice(
+        let normalizer = self.generic_view(
             (D::dim() - 1, 0),
             (Const::<1>, DimNameDiff::<D, U1>::name()),
         );
@@ -437,9 +437,9 @@ impl<T: RealField, S: Storage<T, Const<3>, Const<3>>> SquareMatrix<T, Const<3>,
     /// Transforms the given point, assuming the matrix `self` uses homogeneous coordinates.
     #[inline]
     pub fn transform_point(&self, pt: &Point<T, 2>) -> Point<T, 2> {
-        let transform = self.fixed_slice::<2, 2>(0, 0);
-        let translation = self.fixed_slice::<2, 1>(0, 2);
-        let normalizer = self.fixed_slice::<1, 2>(2, 0);
+        let transform = self.fixed_view::<2, 2>(0, 0);
+        let translation = self.fixed_view::<2, 1>(0, 2);
+        let normalizer = self.fixed_view::<1, 2>(2, 0);
         let n = normalizer.tr_dot(&pt.coords) + unsafe { self.get_unchecked((2, 2)).clone() };
 
         if !n.is_zero() {
@@ -454,9 +454,9 @@ impl<T: RealField, S: Storage<T, Const<4>, Const<4>>> SquareMatrix<T, Const<4>,
     /// Transforms the given point, assuming the matrix `self` uses homogeneous coordinates.
     #[inline]
     pub fn transform_point(&self, pt: &Point<T, 3>) -> Point<T, 3> {
-        let transform = self.fixed_slice::<3, 3>(0, 0);
-        let translation = self.fixed_slice::<3, 1>(0, 3);
-        let normalizer = self.fixed_slice::<1, 3>(3, 0);
+        let transform = self.fixed_view::<3, 3>(0, 0);
+        let translation = self.fixed_view::<3, 1>(0, 3);
+        let normalizer = self.fixed_view::<1, 3>(3, 0);
         let n = normalizer.tr_dot(&pt.coords) + unsafe { self.get_unchecked((3, 3)).clone() };
 
         if !n.is_zero() {
diff --git a/src/base/edition.rs b/src/base/edition.rs
index 760b3950..104bd7fb 100644
--- a/src/base/edition.rs
+++ b/src/base/edition.rs
@@ -938,7 +938,7 @@ impl<T: Scalar, R: Dim, C: Dim, S: Storage<T, R, C>> Matrix<T, R, C, S> {
             }
 
             if new_nrows.value() > nrows {
-                res.slice_range_mut(nrows.., ..cmp::min(ncols, new_ncols.value()))
+                res.view_range_mut(nrows.., ..cmp::min(ncols, new_ncols.value()))
                     .fill_with(|| MaybeUninit::new(val.clone()));
             }
 
diff --git a/src/base/matrix.rs b/src/base/matrix.rs
index ae2f51e9..a263d761 100644
--- a/src/base/matrix.rs
+++ b/src/base/matrix.rs
@@ -446,7 +446,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     /// ```
     /// # use nalgebra::DMatrix;
     /// let mat = DMatrix::<f32>::zeros(10, 10);
-    /// let slice = mat.slice_with_steps((0, 0), (5, 3), (1, 2));
+    /// let view = mat.view_with_steps((0, 0), (5, 3), (1, 2));
     /// // The column strides is the number of steps (here 2) multiplied by the corresponding dimension.
     /// assert_eq!(mat.strides(), (1, 10));
     /// ```
@@ -1633,7 +1633,7 @@ impl<T: Scalar + Zero + One, D: DimAdd<U1> + IsNotStaticOne, S: RawStorage<T, D,
         );
         let dim = DimSum::<D, U1>::from_usize(self.nrows() + 1);
         let mut res = OMatrix::identity_generic(dim, dim);
-        res.generic_slice_mut::<D, D>((0, 0), self.shape_generic())
+        res.generic_view_mut::<D, D>((0, 0), self.shape_generic())
             .copy_from(self);
         res
     }
@@ -1661,7 +1661,7 @@ impl<T: Scalar + Zero, D: DimAdd<U1>, S: RawStorage<T, D>> Vector<T, D, S> {
     {
         if v[v.len() - 1].is_zero() {
             let nrows = D::from_usize(v.len() - 1);
-            Some(v.generic_slice((0, 0), (nrows, Const::<1>)).into_owned())
+            Some(v.generic_view((0, 0), (nrows, Const::<1>)).into_owned())
         } else {
             None
         }
@@ -1681,7 +1681,7 @@ impl<T: Scalar, D: DimAdd<U1>, S: RawStorage<T, D>> Vector<T, D, S> {
         let mut res = Matrix::uninit(hnrows, Const::<1>);
         // This is basically a copy_from except that we warp the copied
         // values into MaybeUninit.
-        res.generic_slice_mut((0, 0), self.shape_generic())
+        res.generic_view_mut((0, 0), self.shape_generic())
             .zip_apply(self, |out, e| *out = MaybeUninit::new(e));
         res[(len, 0)] = MaybeUninit::new(element);
 
diff --git a/src/base/matrix_view.rs b/src/base/matrix_view.rs
index d37346a6..0580546e 100644
--- a/src/base/matrix_view.rs
+++ b/src/base/matrix_view.rs
@@ -324,7 +324,7 @@ macro_rules! matrix_view_impl (
         /// Returns a view containing the `n` first elements of the i-th row of this matrix.
         #[inline]
         pub fn $row_part($me: $Me, i: usize, n: usize) -> $MatrixView<'_, T, U1, Dynamic, S::RStride, S::CStride> {
-            $me.$generic_slice((i, 0), (Const::<1>, Dynamic::new(n)))
+            $me.$generic_view((i, 0), (Const::<1>, Dynamic::new(n)))
         }
 
         /// Extracts from this matrix a set of consecutive rows.
@@ -961,7 +961,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
         ColRange: SliceRange<C>,
     {
         let (nrows, ncols) = self.shape_generic();
-        self.generic_slice(
+        self.generic_view(
             (rows.begin(nrows), cols.begin(ncols)),
             (rows.size(nrows), cols.size(ncols)),
         )
diff --git a/src/geometry/isometry.rs b/src/geometry/isometry.rs
index d245c99b..67660800 100755
--- a/src/geometry/isometry.rs
+++ b/src/geometry/isometry.rs
@@ -428,7 +428,7 @@ impl<T: SimdRealField, R, const D: usize> Isometry<T, R, D> {
         DefaultAllocator: Allocator<T, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>,
     {
         let mut res: OMatrix<T, _, _> = crate::convert_ref(&self.rotation);
-        res.fixed_slice_mut::<D, 1>(0, D)
+        res.fixed_view_mut::<D, 1>(0, D)
             .copy_from(&self.translation.vector);
 
         res
diff --git a/src/geometry/isometry_conversion.rs b/src/geometry/isometry_conversion.rs
index 627ea3ee..06507631 100644
--- a/src/geometry/isometry_conversion.rs
+++ b/src/geometry/isometry_conversion.rs
@@ -153,8 +153,8 @@ where
 
     #[inline]
     fn is_in_subset(m: &OMatrix<T2, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>) -> bool {
-        let rot = m.fixed_slice::<D, D>(0, 0);
-        let bottom = m.fixed_slice::<1, D>(D, 0);
+        let rot = m.fixed_view::<D, D>(0, 0);
+        let bottom = m.fixed_view::<1, D>(D, 0);
 
         // Scalar types agree.
         m.iter().all(|e| SupersetOf::<T1>::is_in_subset(e)) &&
@@ -168,7 +168,7 @@ where
     fn from_superset_unchecked(
         m: &OMatrix<T2, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>,
     ) -> Self {
-        let t = m.fixed_slice::<D, 1>(0, D).into_owned();
+        let t = m.fixed_view::<D, 1>(0, D).into_owned();
         let t = Translation {
             vector: crate::convert_unchecked(t),
         };
diff --git a/src/geometry/point.rs b/src/geometry/point.rs
index e9a21439..3dd54b98 100644
--- a/src/geometry/point.rs
+++ b/src/geometry/point.rs
@@ -207,7 +207,7 @@ where
         let mut res = crate::Matrix::uninit(DimNameSum::<D, U1>::name(), Const::<1>);
         // This is basically a copy_from except that we warp the copied
         // values into MaybeUninit.
-        res.generic_slice_mut((0, 0), self.coords.shape_generic())
+        res.generic_view_mut((0, 0), self.coords.shape_generic())
             .zip_apply(&self.coords, |out, e| *out = MaybeUninit::new(e));
         res[(len, 0)] = MaybeUninit::new(T::one());
 
diff --git a/src/geometry/point_construction.rs b/src/geometry/point_construction.rs
index 598cf4ed..04228cd2 100644
--- a/src/geometry/point_construction.rs
+++ b/src/geometry/point_construction.rs
@@ -113,7 +113,7 @@ where
         DefaultAllocator: Allocator<T, DimNameSum<D, U1>>,
     {
         if !v[D::dim()].is_zero() {
-            let coords = v.generic_slice((0, 0), (D::name(), Const::<1>)) / v[D::dim()].clone();
+            let coords = v.generic_view((0, 0), (D::name(), Const::<1>)) / v[D::dim()].clone();
             Some(Self::from(coords))
         } else {
             None
diff --git a/src/geometry/point_conversion.rs b/src/geometry/point_conversion.rs
index ce1bd930..81870379 100644
--- a/src/geometry/point_conversion.rs
+++ b/src/geometry/point_conversion.rs
@@ -66,7 +66,7 @@ where
 
     #[inline]
     fn from_superset_unchecked(v: &OVector<T2, DimNameSum<D, U1>>) -> Self {
-        let coords = v.generic_slice((0, 0), (D::name(), Const::<1>)) / v[D::dim()].clone();
+        let coords = v.generic_view((0, 0), (D::name(), Const::<1>)) / v[D::dim()].clone();
         Self {
             coords: crate::convert_unchecked(coords),
         }
diff --git a/src/geometry/rotation.rs b/src/geometry/rotation.rs
index 4a71da0f..79f14eda 100755
--- a/src/geometry/rotation.rs
+++ b/src/geometry/rotation.rs
@@ -261,7 +261,7 @@ impl<T: Scalar, const D: usize> Rotation<T, D> {
         // adding the additional traits `DimAdd` and `IsNotStaticOne`. Maybe
         // these things will get nicer once specialization lands in Rust.
         let mut res = OMatrix::<T, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>::identity();
-        res.fixed_slice_mut::<D, D>(0, 0).copy_from(&self.matrix);
+        res.fixed_view_mut::<D, D>(0, 0).copy_from(&self.matrix);
 
         res
     }
diff --git a/src/geometry/rotation_conversion.rs b/src/geometry/rotation_conversion.rs
index 517010a0..c37b5cdd 100644
--- a/src/geometry/rotation_conversion.rs
+++ b/src/geometry/rotation_conversion.rs
@@ -211,8 +211,8 @@ where
 
     #[inline]
     fn is_in_subset(m: &OMatrix<T2, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>) -> bool {
-        let rot = m.fixed_slice::<D, D>(0, 0);
-        let bottom = m.fixed_slice::<1, D>(D, 0);
+        let rot = m.fixed_view::<D, D>(0, 0);
+        let bottom = m.fixed_view::<1, D>(D, 0);
 
         // Scalar types agree.
         m.iter().all(|e| SupersetOf::<T1>::is_in_subset(e)) &&
@@ -226,7 +226,7 @@ where
     fn from_superset_unchecked(
         m: &OMatrix<T2, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>,
     ) -> Self {
-        let r = m.fixed_slice::<D, D>(0, 0);
+        let r = m.fixed_view::<D, D>(0, 0);
         Self::from_matrix_unchecked(crate::convert_unchecked(r.into_owned()))
     }
 }
diff --git a/src/geometry/scale_conversion.rs b/src/geometry/scale_conversion.rs
index 2dc670a1..2d807e3a 100644
--- a/src/geometry/scale_conversion.rs
+++ b/src/geometry/scale_conversion.rs
@@ -102,7 +102,7 @@ where
     fn from_superset_unchecked(
         m: &OMatrix<T2, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>,
     ) -> Self {
-        let v = m.fixed_slice::<D, D>(0, 0).diagonal();
+        let v = m.fixed_view::<D, D>(0, 0).diagonal();
         Self {
             vector: crate::convert_unchecked(v),
         }
diff --git a/src/geometry/similarity.rs b/src/geometry/similarity.rs
index a827246e..763f1db9 100755
--- a/src/geometry/similarity.rs
+++ b/src/geometry/similarity.rs
@@ -304,7 +304,7 @@ impl<T: SimdRealField, R, const D: usize> Similarity<T, R, D> {
     {
         let mut res = self.isometry.to_homogeneous();
 
-        for e in res.fixed_slice_mut::<D, D>(0, 0).iter_mut() {
+        for e in res.fixed_view_mut::<D, D>(0, 0).iter_mut() {
             *e *= self.scaling.clone()
         }
 
diff --git a/src/geometry/similarity_conversion.rs b/src/geometry/similarity_conversion.rs
index 6bc12814..e5d28906 100644
--- a/src/geometry/similarity_conversion.rs
+++ b/src/geometry/similarity_conversion.rs
@@ -106,7 +106,7 @@ where
 
     #[inline]
     fn is_in_subset(m: &OMatrix<T2, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>) -> bool {
-        let mut rot = m.fixed_slice::<D, D>(0, 0).clone_owned();
+        let mut rot = m.fixed_view::<D, D>(0, 0).clone_owned();
         if rot
             .fixed_columns_mut::<1>(0)
             .try_normalize_mut(T2::zero())
@@ -128,7 +128,7 @@ where
                 rot.fixed_columns_mut::<1>(2).neg_mut();
             }
 
-            let bottom = m.fixed_slice::<1, D>(D, 0);
+            let bottom = m.fixed_view::<1, D>(D, 0);
             // Scalar types agree.
             m.iter().all(|e| SupersetOf::<T1>::is_in_subset(e)) &&
             // The normalized block part is a rotation.
@@ -145,22 +145,22 @@ where
         m: &OMatrix<T2, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>,
     ) -> Self {
         let mut mm = m.clone_owned();
-        let na = mm.fixed_slice_mut::<D, 1>(0, 0).normalize_mut();
-        let nb = mm.fixed_slice_mut::<D, 1>(0, 1).normalize_mut();
-        let nc = mm.fixed_slice_mut::<D, 1>(0, 2).normalize_mut();
+        let na = mm.fixed_view_mut::<D, 1>(0, 0).normalize_mut();
+        let nb = mm.fixed_view_mut::<D, 1>(0, 1).normalize_mut();
+        let nc = mm.fixed_view_mut::<D, 1>(0, 2).normalize_mut();
 
         let mut scale = (na + nb + nc) / crate::convert(3.0); // We take the mean, for robustness.
 
         // TODO: could we avoid the explicit computation of the determinant?
         // (its sign is needed to see if the scaling factor is negative).
-        if mm.fixed_slice::<D, D>(0, 0).determinant() < T2::zero() {
-            mm.fixed_slice_mut::<D, 1>(0, 0).neg_mut();
-            mm.fixed_slice_mut::<D, 1>(0, 1).neg_mut();
-            mm.fixed_slice_mut::<D, 1>(0, 2).neg_mut();
+        if mm.fixed_view::<D, D>(0, 0).determinant() < T2::zero() {
+            mm.fixed_view_mut::<D, 1>(0, 0).neg_mut();
+            mm.fixed_view_mut::<D, 1>(0, 1).neg_mut();
+            mm.fixed_view_mut::<D, 1>(0, 2).neg_mut();
             scale = -scale;
         }
 
-        let t = m.fixed_slice::<D, 1>(0, D).into_owned();
+        let t = m.fixed_view::<D, 1>(0, D).into_owned();
         let t = Translation {
             vector: crate::convert_unchecked(t),
         };
diff --git a/src/geometry/transform_ops.rs b/src/geometry/transform_ops.rs
index 8a500676..4c6284d0 100644
--- a/src/geometry/transform_ops.rs
+++ b/src/geometry/transform_ops.rs
@@ -120,10 +120,10 @@ md_impl_all!(
     [ref val] =>  self * &rhs;
     [val ref] => &self *  rhs;
     [ref ref] => {
-        let transform = self.matrix().fixed_slice::<D, D>(0, 0);
+        let transform = self.matrix().fixed_view::<D, D>(0, 0);
 
         if C::has_normalizer() {
-            let normalizer = self.matrix().fixed_slice::<1, D>(D, 0);
+            let normalizer = self.matrix().fixed_view::<1, D>(D, 0);
             let n = normalizer.tr_dot(rhs);
 
             if !n.is_zero() {
@@ -148,11 +148,11 @@ md_impl_all!(
     [ref val] =>  self * &rhs;
     [val ref] => &self *  rhs;
     [ref ref] => {
-        let transform   = self.matrix().fixed_slice::<D, D>(0, 0);
-        let translation = self.matrix().fixed_slice::<D, 1>(0, D);
+        let transform   = self.matrix().fixed_view::<D, D>(0, 0);
+        let translation = self.matrix().fixed_view::<D, 1>(0, D);
 
         if C::has_normalizer() {
-            let normalizer = self.matrix().fixed_slice::<1, D>(D, 0);
+            let normalizer = self.matrix().fixed_view::<1, D>(D, 0);
             #[allow(clippy::suspicious_arithmetic_impl)]
             let n = normalizer.tr_dot(&rhs.coords) + unsafe { self.matrix().get_unchecked((D, D)).clone() };
 
diff --git a/src/geometry/translation.rs b/src/geometry/translation.rs
index 7e10ac4c..482d45ed 100755
--- a/src/geometry/translation.rs
+++ b/src/geometry/translation.rs
@@ -150,7 +150,7 @@ impl<T: Scalar, const D: usize> Translation<T, D> {
         DefaultAllocator: Allocator<T, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>,
     {
         let mut res = OMatrix::<T, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>::identity();
-        res.fixed_slice_mut::<D, 1>(0, D).copy_from(&self.vector);
+        res.fixed_view_mut::<D, 1>(0, D).copy_from(&self.vector);
 
         res
     }
diff --git a/src/geometry/translation_conversion.rs b/src/geometry/translation_conversion.rs
index 70000efb..73646780 100644
--- a/src/geometry/translation_conversion.rs
+++ b/src/geometry/translation_conversion.rs
@@ -159,7 +159,7 @@ where
 
     #[inline]
     fn is_in_subset(m: &OMatrix<T2, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>) -> bool {
-        let id = m.generic_slice((0, 0), (DimNameSum::<Const<D>, U1>::name(), Const::<D>));
+        let id = m.generic_view((0, 0), (DimNameSum::<Const<D>, U1>::name(), Const::<D>));
 
         // Scalar types agree.
         m.iter().all(|e| SupersetOf::<T1>::is_in_subset(e)) &&
@@ -173,7 +173,7 @@ where
     fn from_superset_unchecked(
         m: &OMatrix<T2, DimNameSum<Const<D>, U1>, DimNameSum<Const<D>, U1>>,
     ) -> Self {
-        let t = m.fixed_slice::<D, 1>(0, D);
+        let t = m.fixed_view::<D, 1>(0, D);
         Self {
             vector: crate::convert_unchecked(t.into_owned()),
         }
diff --git a/src/linalg/bidiagonal.rs b/src/linalg/bidiagonal.rs
index c6b02975..56591ab1 100644
--- a/src/linalg/bidiagonal.rs
+++ b/src/linalg/bidiagonal.rs
@@ -202,7 +202,7 @@ where
         );
 
         let start = self.axis_shift();
-        res.slice_mut(start, (d.value() - 1, d.value() - 1))
+        res.view_mut(start, (d.value() - 1, d.value() - 1))
             .set_partial_diagonal(
                 self.off_diagonal
                     .iter()
@@ -226,11 +226,11 @@ where
         let shift = self.axis_shift().0;
 
         for i in (0..dim - shift).rev() {
-            let axis = self.uv.slice_range(i + shift.., i);
+            let axis = self.uv.view_range(i + shift.., i);
             // TODO: sometimes, the axis might have a zero magnitude.
             let refl = Reflection::new(Unit::new_unchecked(axis), T::zero());
 
-            let mut res_rows = res.slice_range_mut(i + shift.., i..);
+            let mut res_rows = res.view_range_mut(i + shift.., i..);
 
             let sign = if self.upper_diagonal {
                 self.diagonal[i].clone().signum()
@@ -260,13 +260,13 @@ where
         let shift = self.axis_shift().1;
 
         for i in (0..min_nrows_ncols.value() - shift).rev() {
-            let axis = self.uv.slice_range(i, i + shift..);
+            let axis = self.uv.view_range(i, i + shift..);
             let mut axis_packed = axis_packed.rows_range_mut(i + shift..);
             axis_packed.tr_copy_from(&axis);
             // TODO: sometimes, the axis might have a zero magnitude.
             let refl = Reflection::new(Unit::new_unchecked(axis_packed), T::zero());
 
-            let mut res_rows = res.slice_range_mut(i.., i + shift..);
+            let mut res_rows = res.view_range_mut(i.., i + shift..);
 
             let sign = if self.upper_diagonal {
                 self.off_diagonal[i].clone().signum()
@@ -346,7 +346,7 @@ where
 //                     *b.vget_unchecked_mut(i) = coeff;
 //                 }
 //
-//                 b.rows_range_mut(.. i).axpy(-coeff, &self.uv.slice_range(.. i, i), T::one());
+//                 b.rows_range_mut(.. i).axpy(-coeff, &self.uv.view_range(.. i, i), T::one());
 //             }
 //         }
 //     }
diff --git a/src/linalg/cholesky.rs b/src/linalg/cholesky.rs
index f61a4e63..4d530927 100644
--- a/src/linalg/cholesky.rs
+++ b/src/linalg/cholesky.rs
@@ -67,7 +67,7 @@ where
                 *matrix.get_unchecked_mut((j, j)) = denom.clone();
             }
 
-            let mut col = matrix.slice_range_mut(j + 1.., j);
+            let mut col = matrix.view_range_mut(j + 1.., j);
             col /= denom;
         }
 
@@ -228,7 +228,7 @@ where
                     *matrix.get_unchecked_mut((j, j)) = denom.clone();
                 }
 
-                let mut col = matrix.slice_range_mut(j + 1.., j);
+                let mut col = matrix.view_range_mut(j + 1.., j);
                 col /= denom;
                 continue;
             }
@@ -283,17 +283,17 @@ where
             self.chol.shape_generic().0.add(Const::<1>),
             self.chol.shape_generic().1.add(Const::<1>),
         );
-        chol.slice_range_mut(..j, ..j)
-            .copy_from(&self.chol.slice_range(..j, ..j));
-        chol.slice_range_mut(..j, j + 1..)
-            .copy_from(&self.chol.slice_range(..j, j..));
-        chol.slice_range_mut(j + 1.., ..j)
-            .copy_from(&self.chol.slice_range(j.., ..j));
-        chol.slice_range_mut(j + 1.., j + 1..)
-            .copy_from(&self.chol.slice_range(j.., j..));
+        chol.view_range_mut(..j, ..j)
+            .copy_from(&self.chol.view_range(..j, ..j));
+        chol.view_range_mut(..j, j + 1..)
+            .copy_from(&self.chol.view_range(..j, j..));
+        chol.view_range_mut(j + 1.., ..j)
+            .copy_from(&self.chol.view_range(j.., ..j));
+        chol.view_range_mut(j + 1.., j + 1..)
+            .copy_from(&self.chol.view_range(j.., j..));
 
         // update the jth row
-        let top_left_corner = self.chol.slice_range(..j, ..j);
+        let top_left_corner = self.chol.view_range(..j, ..j);
 
         let col_j = col[j].clone();
         let (mut new_rowj_adjoint, mut new_colj) = col.rows_range_pair_mut(..j, j + 1..);
@@ -302,14 +302,14 @@ where
             "Cholesky::insert_column : Unable to solve lower triangular system!"
         );
 
-        new_rowj_adjoint.adjoint_to(&mut chol.slice_range_mut(j, ..j));
+        new_rowj_adjoint.adjoint_to(&mut chol.view_range_mut(j, ..j));
 
         // update the center element
         let center_element = T::sqrt(col_j - T::from_real(new_rowj_adjoint.norm_squared()));
         chol[(j, j)] = center_element.clone();
 
         // update the jth column
-        let bottom_left_corner = self.chol.slice_range(j.., ..j);
+        let bottom_left_corner = self.chol.view_range(j.., ..j);
         // new_colj = (col_jplus - bottom_left_corner * new_rowj.adjoint()) / center_element;
         new_colj.gemm(
             -T::one() / center_element.clone(),
@@ -317,10 +317,10 @@ where
             &new_rowj_adjoint,
             T::one() / center_element,
         );
-        chol.slice_range_mut(j + 1.., j).copy_from(&new_colj);
+        chol.view_range_mut(j + 1.., j).copy_from(&new_colj);
 
         // update the bottom right corner
-        let mut bottom_right_corner = chol.slice_range_mut(j + 1.., j + 1..);
+        let mut bottom_right_corner = chol.view_range_mut(j + 1.., j + 1..);
         Self::xx_rank_one_update(
             &mut bottom_right_corner,
             &mut new_colj,
@@ -348,17 +348,17 @@ where
             self.chol.shape_generic().0.sub(Const::<1>),
             self.chol.shape_generic().1.sub(Const::<1>),
         );
-        chol.slice_range_mut(..j, ..j)
-            .copy_from(&self.chol.slice_range(..j, ..j));
-        chol.slice_range_mut(..j, j..)
-            .copy_from(&self.chol.slice_range(..j, j + 1..));
-        chol.slice_range_mut(j.., ..j)
-            .copy_from(&self.chol.slice_range(j + 1.., ..j));
-        chol.slice_range_mut(j.., j..)
-            .copy_from(&self.chol.slice_range(j + 1.., j + 1..));
+        chol.view_range_mut(..j, ..j)
+            .copy_from(&self.chol.view_range(..j, ..j));
+        chol.view_range_mut(..j, j..)
+            .copy_from(&self.chol.view_range(..j, j + 1..));
+        chol.view_range_mut(j.., ..j)
+            .copy_from(&self.chol.view_range(j + 1.., ..j));
+        chol.view_range_mut(j.., j..)
+            .copy_from(&self.chol.view_range(j + 1.., j + 1..));
 
         // updates the bottom right corner
-        let mut bottom_right_corner = chol.slice_range_mut(j.., j..);
+        let mut bottom_right_corner = chol.view_range_mut(j.., j..);
         let mut workspace = self.chol.column(j).clone_owned();
         let mut old_colj = workspace.rows_range_mut(j + 1..);
         Self::xx_rank_one_update(&mut bottom_right_corner, &mut old_colj, T::RealField::one());
@@ -370,7 +370,7 @@ where
     /// performs a rank one update such that we end up with the decomposition of `M + sigma * (x * x.adjoint())`.
     ///
     /// This helper method is called by `rank_one_update` but also `insert_column` and `remove_column`
-    /// where it is used on a square slice of the decomposition
+    /// where it is used on a square view of the decomposition
     fn xx_rank_one_update<Dm, Sm, Rx, Sx>(
         chol: &mut Matrix<T, Dm, Dm, Sm>,
         x: &mut Vector<T, Rx, Sx>,
@@ -404,7 +404,7 @@ where
             beta += sigma_xj2 / diag2;
             // updates the terms of L
             let mut xjplus = x.rows_range_mut(j + 1..);
-            let mut col_j = chol.slice_range_mut(j + 1.., j);
+            let mut col_j = chol.view_range_mut(j + 1.., j);
             // temp_jplus -= (wj / T::from_real(diag)) * col_j;
             xjplus.axpy(-xj.clone() / T::from_real(diag.clone()), &col_j, T::one());
             if gamma != crate::zero::<T::RealField>() {
diff --git a/src/linalg/col_piv_qr.rs b/src/linalg/col_piv_qr.rs
index 822448e3..bd234b60 100644
--- a/src/linalg/col_piv_qr.rs
+++ b/src/linalg/col_piv_qr.rs
@@ -78,7 +78,7 @@ where
         let mut diag = Matrix::uninit(min_nrows_ncols, Const::<1>);
 
         for i in 0..min_nrows_ncols.value() {
-            let piv = matrix.slice_range(i.., i..).icamax_full();
+            let piv = matrix.view_range(i.., i..).icamax_full();
             let col_piv = piv.1 + i;
             matrix.swap_columns(i, col_piv);
             p.append_permutation(i, col_piv);
@@ -144,11 +144,11 @@ where
         let dim = self.diag.len();
 
         for i in (0..dim).rev() {
-            let axis = self.col_piv_qr.slice_range(i.., i);
+            let axis = self.col_piv_qr.view_range(i.., i);
             // TODO: sometimes, the axis might have a zero magnitude.
             let refl = Reflection::new(Unit::new_unchecked(axis), T::zero());
 
-            let mut res_rows = res.slice_range_mut(i.., i..);
+            let mut res_rows = res.view_range_mut(i.., i..);
             refl.reflect_with_sign(&mut res_rows, self.diag[i].clone().signum());
         }
 
@@ -191,7 +191,7 @@ where
         let dim = self.diag.len();
 
         for i in 0..dim {
-            let axis = self.col_piv_qr.slice_range(i.., i);
+            let axis = self.col_piv_qr.view_range(i.., i);
             let refl = Reflection::new(Unit::new_unchecked(axis), T::zero());
 
             let mut rhs_rows = rhs.rows_range_mut(i..);
@@ -281,7 +281,7 @@ where
                 }
 
                 b.rows_range_mut(..i)
-                    .axpy(-coeff, &self.col_piv_qr.slice_range(..i, i), T::one());
+                    .axpy(-coeff, &self.col_piv_qr.view_range(..i, i), T::one());
             }
         }
 
diff --git a/src/linalg/full_piv_lu.rs b/src/linalg/full_piv_lu.rs
index b11bf4d6..2037e285 100644
--- a/src/linalg/full_piv_lu.rs
+++ b/src/linalg/full_piv_lu.rs
@@ -64,7 +64,7 @@ where
         }
 
         for i in 0..min_nrows_ncols.value() {
-            let piv = matrix.slice_range(i.., i..).icamax_full();
+            let piv = matrix.view_range(i.., i..).icamax_full();
             let row_piv = piv.0 + i;
             let col_piv = piv.1 + i;
             let diag = matrix[(row_piv, col_piv)].clone();
diff --git a/src/linalg/hessenberg.rs b/src/linalg/hessenberg.rs
index 2f85d462..0313a0bb 100644
--- a/src/linalg/hessenberg.rs
+++ b/src/linalg/hessenberg.rs
@@ -113,7 +113,7 @@ where
         let dim = self.hess.nrows();
         self.hess.fill_lower_triangle(T::zero(), 2);
         self.hess
-            .slice_mut((1, 0), (dim - 1, dim - 1))
+            .view_mut((1, 0), (dim - 1, dim - 1))
             .set_partial_diagonal(
                 self.subdiag
                     .iter()
@@ -132,7 +132,7 @@ where
         let dim = self.hess.nrows();
         let mut res = self.hess.clone();
         res.fill_lower_triangle(T::zero(), 2);
-        res.slice_mut((1, 0), (dim - 1, dim - 1))
+        res.view_mut((1, 0), (dim - 1, dim - 1))
             .set_partial_diagonal(
                 self.subdiag
                     .iter()
diff --git a/src/linalg/householder.rs b/src/linalg/householder.rs
index 688930a3..79d7c768 100644
--- a/src/linalg/householder.rs
+++ b/src/linalg/householder.rs
@@ -128,10 +128,10 @@ where
     let mut res = OMatrix::identity_generic(dim, dim);
 
     for i in (0..dim.value() - 1).rev() {
-        let axis = m.slice_range(i + 1.., i);
+        let axis = m.view_range(i + 1.., i);
         let refl = Reflection::new(Unit::new_unchecked(axis), T::zero());
 
-        let mut res_rows = res.slice_range_mut(i + 1.., i..);
+        let mut res_rows = res.view_range_mut(i + 1.., i..);
         refl.reflect_with_sign(&mut res_rows, signs[i].clone().signum());
     }
 
diff --git a/src/linalg/lu.rs b/src/linalg/lu.rs
index 01ae46f0..a5e87072 100644
--- a/src/linalg/lu.rs
+++ b/src/linalg/lu.rs
@@ -64,7 +64,7 @@ where
     out.fill_with_identity();
 
     for i in 0..dim {
-        let piv = matrix.slice_range(i.., i).icamax() + i;
+        let piv = matrix.view_range(i.., i).icamax() + i;
         let diag = matrix[(piv, i)].clone();
 
         if diag.is_zero() {
@@ -100,7 +100,7 @@ where
         }
 
         for i in 0..min_nrows_ncols.value() {
-            let piv = matrix.slice_range(i.., i).icamax() + i;
+            let piv = matrix.view_range(i.., i).icamax() + i;
             let diag = matrix[(piv, i)].clone();
 
             if diag.is_zero() {
@@ -338,7 +338,7 @@ where
     T: Scalar + Field,
     S: StorageMut<T, R, C>,
 {
-    let mut submat = matrix.slice_range_mut(i.., i..);
+    let mut submat = matrix.view_range_mut(i.., i..);
 
     let inv_diag = T::one() / diag;
 
@@ -368,7 +368,7 @@ pub fn gauss_step_swap<T, R: Dim, C: Dim, S>(
     S: StorageMut<T, R, C>,
 {
     let piv = piv - i;
-    let mut submat = matrix.slice_range_mut(i.., i..);
+    let mut submat = matrix.view_range_mut(i.., i..);
 
     let inv_diag = T::one() / diag;
 
diff --git a/src/linalg/qr.rs b/src/linalg/qr.rs
index 1b06e34b..54921939 100644
--- a/src/linalg/qr.rs
+++ b/src/linalg/qr.rs
@@ -116,11 +116,11 @@ where
         let dim = self.diag.len();
 
         for i in (0..dim).rev() {
-            let axis = self.qr.slice_range(i.., i);
+            let axis = self.qr.view_range(i.., i);
             // TODO: sometimes, the axis might have a zero magnitude.
             let refl = Reflection::new(Unit::new_unchecked(axis), T::zero());
 
-            let mut res_rows = res.slice_range_mut(i.., i..);
+            let mut res_rows = res.view_range_mut(i.., i..);
             refl.reflect_with_sign(&mut res_rows, self.diag[i].clone().signum());
         }
 
@@ -161,7 +161,7 @@ where
         let dim = self.diag.len();
 
         for i in 0..dim {
-            let axis = self.qr.slice_range(i.., i);
+            let axis = self.qr.view_range(i.., i);
             let refl = Reflection::new(Unit::new_unchecked(axis), T::zero());
 
             let mut rhs_rows = rhs.rows_range_mut(i..);
@@ -247,7 +247,7 @@ where
                 }
 
                 b.rows_range_mut(..i)
-                    .axpy(-coeff, &self.qr.slice_range(..i, i), T::one());
+                    .axpy(-coeff, &self.qr.view_range(..i, i), T::one());
             }
         }
 
diff --git a/src/linalg/schur.rs b/src/linalg/schur.rs
index c7753cee..3388e7cf 100644
--- a/src/linalg/schur.rs
+++ b/src/linalg/schur.rs
@@ -174,19 +174,19 @@ where
                         {
                             let krows = cmp::min(k + 4, end + 1);
                             let mut work = work.rows_mut(0, krows);
-                            refl.reflect(&mut t.generic_slice_mut(
+                            refl.reflect(&mut t.generic_view_mut(
                                 (k, k),
                                 (Const::<3>, Dynamic::new(dim.value() - k)),
                             ));
                             refl.reflect_rows(
-                                &mut t.generic_slice_mut((0, k), (Dynamic::new(krows), Const::<3>)),
+                                &mut t.generic_view_mut((0, k), (Dynamic::new(krows), Const::<3>)),
                                 &mut work,
                             );
                         }
 
                         if let Some(ref mut q) = q {
                             refl.reflect_rows(
-                                &mut q.generic_slice_mut((0, k), (dim, Const::<3>)),
+                                &mut q.generic_view_mut((0, k), (dim, Const::<3>)),
                                 work,
                             );
                         }
@@ -211,38 +211,38 @@ where
 
                     {
                         let mut work = work.rows_mut(0, end + 1);
-                        refl.reflect(&mut t.generic_slice_mut(
+                        refl.reflect(&mut t.generic_view_mut(
                             (m, m),
                             (Const::<2>, Dynamic::new(dim.value() - m)),
                         ));
                         refl.reflect_rows(
-                            &mut t.generic_slice_mut((0, m), (Dynamic::new(end + 1), Const::<2>)),
+                            &mut t.generic_view_mut((0, m), (Dynamic::new(end + 1), Const::<2>)),
                             &mut work,
                         );
                     }
 
                     if let Some(ref mut q) = q {
                         refl.reflect_rows(
-                            &mut q.generic_slice_mut((0, m), (dim, Const::<2>)),
+                            &mut q.generic_view_mut((0, m), (dim, Const::<2>)),
                             work,
                         );
                     }
                 }
             } else {
                 // Decouple the 2x2 block if it has real eigenvalues.
-                if let Some(rot) = compute_2x2_basis(&t.fixed_slice::<2, 2>(start, start)) {
+                if let Some(rot) = compute_2x2_basis(&t.fixed_view::<2, 2>(start, start)) {
                     let inv_rot = rot.inverse();
-                    inv_rot.rotate(&mut t.generic_slice_mut(
+                    inv_rot.rotate(&mut t.generic_view_mut(
                         (start, start),
                         (Const::<2>, Dynamic::new(dim.value() - start)),
                     ));
                     rot.rotate_rows(
-                        &mut t.generic_slice_mut((0, start), (Dynamic::new(end + 1), Const::<2>)),
+                        &mut t.generic_view_mut((0, start), (Dynamic::new(end + 1), Const::<2>)),
                     );
                     t[(end, start)] = T::zero();
 
                     if let Some(ref mut q) = q {
-                        rot.rotate_rows(&mut q.generic_slice_mut((0, start), (dim, Const::<2>)));
+                        rot.rotate_rows(&mut q.generic_view_mut((0, start), (dim, Const::<2>)));
                     }
                 }
 
@@ -427,9 +427,9 @@ where
 {
     let dim = m.shape_generic().0;
     let mut q = None;
-    match compute_2x2_basis(&m.fixed_slice::<2, 2>(0, 0)) {
+    match compute_2x2_basis(&m.fixed_view::<2, 2>(0, 0)) {
         Some(rot) => {
-            let mut m = m.fixed_slice_mut::<2, 2>(0, 0);
+            let mut m = m.fixed_view_mut::<2, 2>(0, 0);
             let inv_rot = rot.inverse();
             inv_rot.rotate(&mut m);
             rot.rotate_rows(&mut m);
@@ -530,7 +530,7 @@ where
         if self.nrows() == 2 {
             // TODO: can we avoid this slicing
             // (which is needed here just to transform D to U2)?
-            let me = self.fixed_slice::<2, 2>(0, 0);
+            let me = self.fixed_view::<2, 2>(0, 0);
             return match compute_2x2_eigvals(&me) {
                 Some((a, b)) => {
                     work[0] = a;
diff --git a/src/linalg/solve.rs b/src/linalg/solve.rs
index c355f2d0..237986a8 100644
--- a/src/linalg/solve.rs
+++ b/src/linalg/solve.rs
@@ -93,7 +93,7 @@ impl<T: ComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
             }
 
             b.rows_range_mut(i + 1..)
-                .axpy(-coeff, &self.slice_range(i + 1.., i), T::one());
+                .axpy(-coeff, &self.view_range(i + 1.., i), T::one());
         }
 
         true
@@ -125,7 +125,7 @@ impl<T: ComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
             for i in 0..dim - 1 {
                 let coeff = unsafe { bcol.vget_unchecked(i).clone() } / diag.clone();
                 bcol.rows_range_mut(i + 1..)
-                    .axpy(-coeff, &self.slice_range(i + 1.., i), T::one());
+                    .axpy(-coeff, &self.view_range(i + 1.., i), T::one());
             }
         }
 
@@ -175,7 +175,7 @@ impl<T: ComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
             }
 
             b.rows_range_mut(..i)
-                .axpy(-coeff, &self.slice_range(..i, i), T::one());
+                .axpy(-coeff, &self.view_range(..i, i), T::one());
         }
 
         true
@@ -387,7 +387,7 @@ impl<T: ComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
         let dim = self.nrows();
 
         for i in (0..dim).rev() {
-            let dot = dot(&self.slice_range(i + 1.., i), &b.slice_range(i + 1.., 0));
+            let dot = dot(&self.view_range(i + 1.., i), &b.view_range(i + 1.., 0));
 
             unsafe {
                 let b_i = b.vget_unchecked_mut(i);
@@ -422,7 +422,7 @@ impl<T: ComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
         let dim = self.nrows();
 
         for i in 0..dim {
-            let dot = dot(&self.slice_range(..i, i), &b.slice_range(..i, 0));
+            let dot = dot(&self.view_range(..i, i), &b.view_range(..i, 0));
 
             unsafe {
                 let b_i = b.vget_unchecked_mut(i);
@@ -514,7 +514,7 @@ impl<T: SimdComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
             }
 
             b.rows_range_mut(i + 1..)
-                .axpy(-coeff.clone(), &self.slice_range(i + 1.., i), T::one());
+                .axpy(-coeff.clone(), &self.view_range(i + 1.., i), T::one());
         }
     }
 
@@ -539,7 +539,7 @@ impl<T: SimdComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
             for i in 0..dim - 1 {
                 let coeff = unsafe { bcol.vget_unchecked(i).clone() } / diag.clone();
                 bcol.rows_range_mut(i + 1..)
-                    .axpy(-coeff, &self.slice_range(i + 1.., i), T::one());
+                    .axpy(-coeff, &self.view_range(i + 1.., i), T::one());
             }
         }
     }
@@ -575,7 +575,7 @@ impl<T: SimdComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
             }
 
             b.rows_range_mut(..i)
-                .axpy(-coeff, &self.slice_range(..i, i), T::one());
+                .axpy(-coeff, &self.view_range(..i, i), T::one());
         }
     }
 
@@ -744,7 +744,7 @@ impl<T: SimdComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
         let dim = self.nrows();
 
         for i in (0..dim).rev() {
-            let dot = dot(&self.slice_range(i + 1.., i), &b.slice_range(i + 1.., 0));
+            let dot = dot(&self.view_range(i + 1.., i), &b.view_range(i + 1.., 0));
 
             unsafe {
                 let b_i = b.vget_unchecked_mut(i);
@@ -768,7 +768,7 @@ impl<T: SimdComplexField, D: Dim, S: Storage<T, D, D>> SquareMatrix<T, D, S> {
         ShapeConstraint: SameNumberOfRows<R2, D>,
     {
         for i in 0..self.nrows() {
-            let dot = dot(&self.slice_range(..i, i), &b.slice_range(..i, 0));
+            let dot = dot(&self.view_range(..i, i), &b.view_range(..i, 0));
 
             unsafe {
                 let b_i = b.vget_unchecked_mut(i);

From 8867b365e3a824981363a00ec62fc37237c7a21a Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 14:40:53 +0100
Subject: [PATCH 80/91] Rename slice -> view in parameter names, comments etc.

---
 src/base/construction_view.rs |  6 +--
 src/base/conversion.rs        | 96 +++++++++++++++++------------------
 src/base/matrix_view.rs       |  4 +-
 src/base/storage.rs           |  4 +-
 4 files changed, 55 insertions(+), 55 deletions(-)

diff --git a/src/base/construction_view.rs b/src/base/construction_view.rs
index fbb038cb..910b2873 100644
--- a/src/base/construction_view.rs
+++ b/src/base/construction_view.rs
@@ -48,7 +48,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
         assert!(
             data.len() + cstride.value() + rstride.value()
                 >= ncols.value() * cstride.value() + nrows.value() * rstride.value() + 1,
-            "Matrix slice: input data buffer to small."
+            "Matrix view: input data buffer too small."
         );
 
         unsafe {
@@ -186,7 +186,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
         assert!(
             data.len() + cstride.value() + rstride.value()
                 >= ncols.value() * cstride.value() + nrows.value() * rstride.value() + 1,
-            "Matrix slice: input data buffer to small."
+            "Matrix view: input data buffer too small."
         );
 
         assert!(
@@ -208,7 +208,7 @@ impl<'a, T: Scalar, R: Dim, C: Dim, RStride: Dim, CStride: Dim>
                         }
                     }
             },
-            "Matrix slice: dimensions and strides result in aliased indices."
+            "Matrix view: dimensions and strides result in aliased indices."
         );
 
         unsafe {
diff --git a/src/base/conversion.rs b/src/base/conversion.rs
index 4c83796e..79a61461 100644
--- a/src/base/conversion.rs
+++ b/src/base/conversion.rs
@@ -296,8 +296,8 @@ where
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(matrix_slice: MatrixView<'a, T, Const<R>, Const<C>, RStride, CStride>) -> Self {
-        matrix_slice.into_owned()
+    fn from(matrix_view: MatrixView<'a, T, Const<R>, Const<C>, RStride, CStride>) -> Self {
+        matrix_view.into_owned()
     }
 }
 
@@ -310,8 +310,8 @@ where
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(matrix_slice: MatrixView<'a, T, Dynamic, C, RStride, CStride>) -> Self {
-        matrix_slice.into_owned()
+    fn from(matrix_view: MatrixView<'a, T, Dynamic, C, RStride, CStride>) -> Self {
+        matrix_view.into_owned()
     }
 }
 
@@ -324,8 +324,8 @@ where
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(matrix_slice: MatrixView<'a, T, R, Dynamic, RStride, CStride>) -> Self {
-        matrix_slice.into_owned()
+    fn from(matrix_view: MatrixView<'a, T, R, Dynamic, RStride, CStride>) -> Self {
+        matrix_view.into_owned()
     }
 }
 
@@ -337,8 +337,8 @@ where
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(matrix_slice: MatrixViewMut<'a, T, Const<R>, Const<C>, RStride, CStride>) -> Self {
-        matrix_slice.into_owned()
+    fn from(matrix_view: MatrixViewMut<'a, T, Const<R>, Const<C>, RStride, CStride>) -> Self {
+        matrix_view.into_owned()
     }
 }
 
@@ -351,8 +351,8 @@ where
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(matrix_slice: MatrixViewMut<'a, T, Dynamic, C, RStride, CStride>) -> Self {
-        matrix_slice.into_owned()
+    fn from(matrix_view: MatrixViewMut<'a, T, Dynamic, C, RStride, CStride>) -> Self {
+        matrix_view.into_owned()
     }
 }
 
@@ -365,116 +365,116 @@ where
     RStride: Dim,
     CStride: Dim,
 {
-    fn from(matrix_slice: MatrixViewMut<'a, T, R, Dynamic, RStride, CStride>) -> Self {
-        matrix_slice.into_owned()
+    fn from(matrix_view: MatrixViewMut<'a, T, R, Dynamic, RStride, CStride>) -> Self {
+        matrix_view.into_owned()
     }
 }
 
-impl<'a, T, R, C, RSlice, CSlice, RStride, CStride, S> From<&'a Matrix<T, R, C, S>>
-    for MatrixView<'a, T, RSlice, CSlice, RStride, CStride>
+impl<'a, T, R, C, RView, CView, RStride, CStride, S> From<&'a Matrix<T, R, C, S>>
+    for MatrixView<'a, T, RView, CView, RStride, CStride>
 where
     T: Scalar,
     R: Dim,
     C: Dim,
-    RSlice: Dim,
-    CSlice: Dim,
+    RView: Dim,
+    CView: Dim,
     RStride: Dim,
     CStride: Dim,
     S: RawStorage<T, R, C>,
-    ShapeConstraint: DimEq<R, RSlice>
-        + DimEq<C, CSlice>
+    ShapeConstraint: DimEq<R, RView>
+        + DimEq<C, CView>
         + DimEq<RStride, S::RStride>
         + DimEq<CStride, S::CStride>,
 {
     fn from(m: &'a Matrix<T, R, C, S>) -> Self {
         let (row, col) = m.shape_generic();
-        let row_slice = RSlice::from_usize(row.value());
-        let col_slice = CSlice::from_usize(col.value());
+        let rows_result = RView::from_usize(row.value());
+        let cols_result = CView::from_usize(col.value());
 
         let (rstride, cstride) = m.strides();
 
-        let rstride_slice = RStride::from_usize(rstride);
-        let cstride_slice = CStride::from_usize(cstride);
+        let rstride_result = RStride::from_usize(rstride);
+        let cstride_result = CStride::from_usize(cstride);
 
         unsafe {
             let data = ViewStorage::from_raw_parts(
                 m.data.ptr(),
-                (row_slice, col_slice),
-                (rstride_slice, cstride_slice),
+                (rows_result, cols_result),
+                (rstride_result, cstride_result),
             );
             Matrix::from_data_statically_unchecked(data)
         }
     }
 }
 
-impl<'a, T, R, C, RSlice, CSlice, RStride, CStride, S> From<&'a mut Matrix<T, R, C, S>>
-    for MatrixView<'a, T, RSlice, CSlice, RStride, CStride>
+impl<'a, T, R, C, RView, CView, RStride, CStride, S> From<&'a mut Matrix<T, R, C, S>>
+    for MatrixView<'a, T, RView, CView, RStride, CStride>
 where
     T: Scalar,
     R: Dim,
     C: Dim,
-    RSlice: Dim,
-    CSlice: Dim,
+    RView: Dim,
+    CView: Dim,
     RStride: Dim,
     CStride: Dim,
     S: RawStorage<T, R, C>,
-    ShapeConstraint: DimEq<R, RSlice>
-        + DimEq<C, CSlice>
+    ShapeConstraint: DimEq<R, RView>
+        + DimEq<C, CView>
         + DimEq<RStride, S::RStride>
         + DimEq<CStride, S::CStride>,
 {
     fn from(m: &'a mut Matrix<T, R, C, S>) -> Self {
         let (row, col) = m.shape_generic();
-        let row_slice = RSlice::from_usize(row.value());
-        let col_slice = CSlice::from_usize(col.value());
+        let rows_result = RView::from_usize(row.value());
+        let cols_result = CView::from_usize(col.value());
 
         let (rstride, cstride) = m.strides();
 
-        let rstride_slice = RStride::from_usize(rstride);
-        let cstride_slice = CStride::from_usize(cstride);
+        let rstride_result = RStride::from_usize(rstride);
+        let cstride_result = CStride::from_usize(cstride);
 
         unsafe {
             let data = ViewStorage::from_raw_parts(
                 m.data.ptr(),
-                (row_slice, col_slice),
-                (rstride_slice, cstride_slice),
+                (rows_result, cols_result),
+                (rstride_result, cstride_result),
             );
             Matrix::from_data_statically_unchecked(data)
         }
     }
 }
 
-impl<'a, T, R, C, RSlice, CSlice, RStride, CStride, S> From<&'a mut Matrix<T, R, C, S>>
-    for MatrixViewMut<'a, T, RSlice, CSlice, RStride, CStride>
+impl<'a, T, R, C, RView, CView, RStride, CStride, S> From<&'a mut Matrix<T, R, C, S>>
+    for MatrixViewMut<'a, T, RView, CView, RStride, CStride>
 where
     T: Scalar,
     R: Dim,
     C: Dim,
-    RSlice: Dim,
-    CSlice: Dim,
+    RView: Dim,
+    CView: Dim,
     RStride: Dim,
     CStride: Dim,
     S: RawStorageMut<T, R, C>,
-    ShapeConstraint: DimEq<R, RSlice>
-        + DimEq<C, CSlice>
+    ShapeConstraint: DimEq<R, RView>
+        + DimEq<C, CView>
         + DimEq<RStride, S::RStride>
         + DimEq<CStride, S::CStride>,
 {
     fn from(m: &'a mut Matrix<T, R, C, S>) -> Self {
         let (row, col) = m.shape_generic();
-        let row_slice = RSlice::from_usize(row.value());
-        let col_slice = CSlice::from_usize(col.value());
+        let rows_result = RView::from_usize(row.value());
+        let cols_result = CView::from_usize(col.value());
 
         let (rstride, cstride) = m.strides();
 
-        let rstride_slice = RStride::from_usize(rstride);
-        let cstride_slice = CStride::from_usize(cstride);
+        let rstride_result = RStride::from_usize(rstride);
+        let cstride_result = CStride::from_usize(cstride);
 
         unsafe {
             let data = ViewStorageMut::from_raw_parts(
                 m.data.ptr_mut(),
-                (row_slice, col_slice),
-                (rstride_slice, cstride_slice),
+                (rows_result, cols_result),
+                (rstride_result, cstride_result),
             );
             Matrix::from_data_statically_unchecked(data)
         }
diff --git a/src/base/matrix_view.rs b/src/base/matrix_view.rs
index 0580546e..4af0a7e9 100644
--- a/src/base/matrix_view.rs
+++ b/src/base/matrix_view.rs
@@ -667,7 +667,7 @@ macro_rules! matrix_view_impl (
             let nrows1 = r1.size(nrows);
             let nrows2 = r2.size(nrows);
 
-            assert!(start2 >= end1 || start1 >= end2, "Rows range pair: the slice ranges must not overlap.");
+            assert!(start2 >= end1 || start1 >= end2, "Rows range pair: the ranges must not overlap.");
             assert!(end2 <= nrows.value(), "Rows range pair: index out of range.");
 
             unsafe {
@@ -703,7 +703,7 @@ macro_rules! matrix_view_impl (
             let ncols1 = r1.size(ncols);
             let ncols2 = r2.size(ncols);
 
-            assert!(start2 >= end1 || start1 >= end2, "Columns range pair: the slice ranges must not overlap.");
+            assert!(start2 >= end1 || start1 >= end2, "Columns range pair: the ranges must not overlap.");
             assert!(end2 <= ncols.value(), "Columns range pair: index out of range.");
 
             unsafe {
diff --git a/src/base/storage.rs b/src/base/storage.rs
index 76a60ce3..dd335014 100644
--- a/src/base/storage.rs
+++ b/src/base/storage.rs
@@ -122,7 +122,7 @@ pub unsafe trait RawStorage<T, R: Dim, C: Dim = U1>: Sized {
     /// # Safety
     /// The matrix components may not be stored in a contiguous way, depending on the strides.
     /// This method is unsafe because this can yield to invalid aliasing when called on some pairs
-    /// of matrix slices originating from the same matrix with strides.
+    /// of matrix views originating from the same matrix with strides.
     ///
     /// Call the safe alternative `matrix.as_slice()` instead.
     unsafe fn as_slice_unchecked(&self) -> &[T];
@@ -148,7 +148,7 @@ pub unsafe trait Storage<T, R: Dim, C: Dim = U1>: RawStorage<T, R, C> {
 /// contains `MaybeUninit<T>` elements.
 ///
 /// Note that a mutable access does not mean that the matrix owns its data. For example, a mutable
-/// matrix slice can provide mutable access to its elements even if it does not own its data (it
+/// matrix view can provide mutable access to its elements even if it does not own its data (it
 /// contains only an internal reference to them).
 pub unsafe trait RawStorageMut<T, R: Dim, C: Dim = U1>: RawStorage<T, R, C> {
     /// The matrix mutable data pointer.

From 0c402318ec16f67a3ebfb4387b93db9c27921d54 Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 14:42:23 +0100
Subject: [PATCH 81/91] Rename internal assert_slice_index -> assert_view_index

---
 src/base/matrix_view.rs | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/base/matrix_view.rs b/src/base/matrix_view.rs
index 4af0a7e9..497a1553 100644
--- a/src/base/matrix_view.rs
+++ b/src/base/matrix_view.rs
@@ -262,7 +262,7 @@ unsafe impl<'a, T, R: DimName, C: Dim + IsNotStaticOne> IsContiguous
 
 impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     #[inline]
-    fn assert_slice_index(
+    fn assert_view_index(
         &self,
         start: (usize, usize),
         shape: (usize, usize),
@@ -367,7 +367,7 @@ macro_rules! matrix_view_impl (
             -> $MatrixView<'_, T, RView, C, S::RStride, S::CStride> {
 
             let my_shape   = $me.shape_generic();
-            $me.assert_slice_index((row_start, 0), (nrows.value(), my_shape.1.value()), (0, 0));
+            $me.assert_view_index((row_start, 0), (nrows.value(), my_shape.1.value()), (0, 0));
 
             let shape = (nrows, my_shape.1);
 
@@ -386,7 +386,7 @@ macro_rules! matrix_view_impl (
 
             let my_shape   = $me.shape_generic();
             let my_strides = $me.data.strides();
-            $me.assert_slice_index((row_start, 0), (nrows.value(), my_shape.1.value()), (step, 0));
+            $me.assert_view_index((row_start, 0), (nrows.value(), my_shape.1.value()), (step, 0));
 
             let strides = (Dynamic::new((step + 1) * my_strides.0.value()), my_strides.1);
             let shape   = (nrows, my_shape.1);
@@ -455,7 +455,7 @@ macro_rules! matrix_view_impl (
             -> $MatrixView<'_, T, R, CView, S::RStride, S::CStride> {
 
             let my_shape = $me.shape_generic();
-            $me.assert_slice_index((0, first_col), (my_shape.0.value(), ncols.value()), (0, 0));
+            $me.assert_view_index((0, first_col), (my_shape.0.value(), ncols.value()), (0, 0));
             let shape = (my_shape.0, ncols);
 
             unsafe {
@@ -474,7 +474,7 @@ macro_rules! matrix_view_impl (
             let my_shape   = $me.shape_generic();
             let my_strides = $me.data.strides();
 
-            $me.assert_slice_index((0, first_col), (my_shape.0.value(), ncols.value()), (0, step));
+            $me.assert_view_index((0, first_col), (my_shape.0.value(), ncols.value()), (0, step));
 
             let strides = (my_strides.0, Dynamic::new((step + 1) * my_strides.1.value()));
             let shape   = (my_shape.0, ncols);
@@ -505,7 +505,7 @@ macro_rules! matrix_view_impl (
         pub fn $view($me: $Me, start: (usize, usize), shape: (usize, usize))
             -> $MatrixView<'_, T, Dynamic, Dynamic, S::RStride, S::CStride> {
 
-            $me.assert_slice_index(start, shape, (0, 0));
+            $me.assert_view_index(start, shape, (0, 0));
             let shape = (Dynamic::new(shape.0), Dynamic::new(shape.1));
 
             unsafe {
@@ -551,7 +551,7 @@ macro_rules! matrix_view_impl (
         pub fn $fixed_view<const RVIEW: usize, const CVIEW: usize>($me: $Me, irow: usize, icol: usize)
             -> $MatrixView<'_, T, Const<RVIEW>, Const<CVIEW>, S::RStride, S::CStride> {
 
-            $me.assert_slice_index((irow, icol), (RVIEW, CVIEW), (0, 0));
+            $me.assert_view_index((irow, icol), (RVIEW, CVIEW), (0, 0));
             let shape = (Const::<RVIEW>, Const::<CVIEW>);
 
             unsafe {
@@ -599,7 +599,7 @@ macro_rules! matrix_view_impl (
             where RView: Dim,
                   CView: Dim {
 
-            $me.assert_slice_index(start, (shape.0.value(), shape.1.value()), (0, 0));
+            $me.assert_view_index(start, (shape.0.value(), shape.1.value()), (0, 0));
 
             unsafe {
                 let data = $ViewStorage::new_unchecked($data, start, shape);
@@ -630,7 +630,7 @@ macro_rules! matrix_view_impl (
             where RView: Dim,
                   CView: Dim {
 
-            $me.assert_slice_index(start, (shape.0.value(), shape.1.value()), steps);
+            $me.assert_view_index(start, (shape.0.value(), shape.1.value()), steps);
 
             let my_strides = $me.data.strides();
             let strides    = (Dynamic::new((steps.0 + 1) * my_strides.0.value()),

From 234d61faa20e41de8327820a107cb38fcb45abef Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 14:47:43 +0100
Subject: [PATCH 82/91] Rename SliceRange to DimRange

---
 src/base/matrix_view.rs | 51 ++++++++++++++++++++++++-----------------
 1 file changed, 30 insertions(+), 21 deletions(-)

diff --git a/src/base/matrix_view.rs b/src/base/matrix_view.rs
index 497a1553..ef024f19 100644
--- a/src/base/matrix_view.rs
+++ b/src/base/matrix_view.rs
@@ -651,7 +651,7 @@ macro_rules! matrix_view_impl (
         ///
         /// Panics if the ranges overlap or if the first range is empty.
         #[inline]
-        pub fn $rows_range_pair<Range1: SliceRange<R>, Range2: SliceRange<R>>($me: $Me, r1: Range1, r2: Range2)
+        pub fn $rows_range_pair<Range1: DimRange<R>, Range2: DimRange<R>>($me: $Me, r1: Range1, r2: Range2)
             -> ($MatrixView<'_, T, Range1::Size, C, S::RStride, S::CStride>,
                 $MatrixView<'_, T, Range2::Size, C, S::RStride, S::CStride>) {
 
@@ -687,7 +687,7 @@ macro_rules! matrix_view_impl (
         ///
         /// Panics if the ranges overlap or if the first range is empty.
         #[inline]
-        pub fn $columns_range_pair<Range1: SliceRange<C>, Range2: SliceRange<C>>($me: $Me, r1: Range1, r2: Range2)
+        pub fn $columns_range_pair<Range1: DimRange<C>, Range2: DimRange<C>>($me: $Me, r1: Range1, r2: Range2)
             -> ($MatrixView<'_, T, R, Range1::Size, S::RStride, S::CStride>,
                 $MatrixView<'_, T, R, Range2::Size, S::RStride, S::CStride>) {
 
@@ -816,7 +816,7 @@ impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
 /// * A left-open range `std::ops::RangeTo`, e.g., `.. 4`
 /// * A right-open range `std::ops::RangeFrom`, e.g., `4 ..`
 /// * A full range `std::ops::RangeFull`, e.g., `..`
-pub trait SliceRange<D: Dim> {
+pub trait DimRange<D: Dim> {
     /// Type of the range size. May be a type-level integer.
     type Size: Dim;
 
@@ -829,7 +829,16 @@ pub trait SliceRange<D: Dim> {
     fn size(&self, shape: D) -> Self::Size;
 }
 
-impl<D: Dim> SliceRange<D> for usize {
+/// A range with a size that may be known at compile-time.
+///
+/// This is merely a legacy trait alias to minimize breakage. Use the [`DimRange`] trait instead.
+#[deprecated = slice_deprecation_note!(DimRange)]
+pub trait SliceRange<D: Dim>: DimRange<D> {}
+
+#[allow(deprecated)]
+impl<R: DimRange<D>, D: Dim> SliceRange<D> for R {}
+
+impl<D: Dim> DimRange<D> for usize {
     type Size = U1;
 
     #[inline(always)]
@@ -848,7 +857,7 @@ impl<D: Dim> SliceRange<D> for usize {
     }
 }
 
-impl<D: Dim> SliceRange<D> for Range<usize> {
+impl<D: Dim> DimRange<D> for Range<usize> {
     type Size = Dynamic;
 
     #[inline(always)]
@@ -867,7 +876,7 @@ impl<D: Dim> SliceRange<D> for Range<usize> {
     }
 }
 
-impl<D: Dim> SliceRange<D> for RangeFrom<usize> {
+impl<D: Dim> DimRange<D> for RangeFrom<usize> {
     type Size = Dynamic;
 
     #[inline(always)]
@@ -886,7 +895,7 @@ impl<D: Dim> SliceRange<D> for RangeFrom<usize> {
     }
 }
 
-impl<D: Dim> SliceRange<D> for RangeTo<usize> {
+impl<D: Dim> DimRange<D> for RangeTo<usize> {
     type Size = Dynamic;
 
     #[inline(always)]
@@ -905,7 +914,7 @@ impl<D: Dim> SliceRange<D> for RangeTo<usize> {
     }
 }
 
-impl<D: Dim> SliceRange<D> for RangeFull {
+impl<D: Dim> DimRange<D> for RangeFull {
     type Size = D;
 
     #[inline(always)]
@@ -924,7 +933,7 @@ impl<D: Dim> SliceRange<D> for RangeFull {
     }
 }
 
-impl<D: Dim> SliceRange<D> for RangeInclusive<usize> {
+impl<D: Dim> DimRange<D> for RangeInclusive<usize> {
     type Size = Dynamic;
 
     #[inline(always)]
@@ -957,8 +966,8 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
         cols: ColRange,
     ) -> MatrixView<'_, T, RowRange::Size, ColRange::Size, S::RStride, S::CStride>
     where
-        RowRange: SliceRange<R>,
-        ColRange: SliceRange<C>,
+        RowRange: DimRange<R>,
+        ColRange: DimRange<C>,
     {
         let (nrows, ncols) = self.shape_generic();
         self.generic_view(
@@ -977,8 +986,8 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
         cols: ColRange,
     ) -> MatrixView<'_, T, RowRange::Size, ColRange::Size, S::RStride, S::CStride>
         where
-            RowRange: SliceRange<R>,
-            ColRange: SliceRange<C>,
+            RowRange: DimRange<R>,
+            ColRange: DimRange<C>,
     {
         let (nrows, ncols) = self.shape_generic();
         self.generic_view(
@@ -990,7 +999,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     /// View containing all the rows indexed by the range `rows`.
     #[inline]
     #[must_use]
-    pub fn rows_range<RowRange: SliceRange<R>>(
+    pub fn rows_range<RowRange: DimRange<R>>(
         &self,
         rows: RowRange,
     ) -> MatrixView<'_, T, RowRange::Size, C, S::RStride, S::CStride> {
@@ -1000,7 +1009,7 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
     /// View containing all the columns indexed by the range `rows`.
     #[inline]
     #[must_use]
-    pub fn columns_range<ColRange: SliceRange<C>>(
+    pub fn columns_range<ColRange: DimRange<C>>(
         &self,
         cols: ColRange,
     ) -> MatrixView<'_, T, R, ColRange::Size, S::RStride, S::CStride> {
@@ -1020,8 +1029,8 @@ impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
         cols: ColRange,
     ) -> MatrixViewMut<'_, T, RowRange::Size, ColRange::Size, S::RStride, S::CStride>
     where
-        RowRange: SliceRange<R>,
-        ColRange: SliceRange<C>,
+        RowRange: DimRange<R>,
+        ColRange: DimRange<C>,
     {
         self.view_range_mut(rows, cols)
     }
@@ -1034,8 +1043,8 @@ impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
         cols: ColRange,
     ) -> MatrixViewMut<'_, T, RowRange::Size, ColRange::Size, S::RStride, S::CStride>
         where
-            RowRange: SliceRange<R>,
-            ColRange: SliceRange<C>,
+            RowRange: DimRange<R>,
+            ColRange: DimRange<C>,
     {
         let (nrows, ncols) = self.shape_generic();
         self.generic_view_mut(
@@ -1046,7 +1055,7 @@ impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
 
     /// Mutable view containing all the rows indexed by the range `rows`.
     #[inline]
-    pub fn rows_range_mut<RowRange: SliceRange<R>>(
+    pub fn rows_range_mut<RowRange: DimRange<R>>(
         &mut self,
         rows: RowRange,
     ) -> MatrixViewMut<'_, T, RowRange::Size, C, S::RStride, S::CStride> {
@@ -1055,7 +1064,7 @@ impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
 
     /// Mutable view containing all the columns indexed by the range `cols`.
     #[inline]
-    pub fn columns_range_mut<ColRange: SliceRange<C>>(
+    pub fn columns_range_mut<ColRange: DimRange<C>>(
         &mut self,
         cols: ColRange,
     ) -> MatrixViewMut<'_, T, R, ColRange::Size, S::RStride, S::CStride> {

From 6c8947ccc08d3dfdd48a6ca32400ea76e64c0c1f Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 15:16:23 +0100
Subject: [PATCH 83/91] Replace slice->view in tests and benches

---
 benches/core/matrix.rs     |  2 +-
 tests/core/conversion.rs   | 70 ++++++++++++++++----------------
 tests/core/matrix.rs       | 48 +++++++++++-----------
 tests/core/matrix_slice.rs | 82 +++++++++++++++++++-------------------
 4 files changed, 101 insertions(+), 101 deletions(-)

diff --git a/benches/core/matrix.rs b/benches/core/matrix.rs
index 3c483c35..8f3d6305 100644
--- a/benches/core/matrix.rs
+++ b/benches/core/matrix.rs
@@ -53,7 +53,7 @@ fn mat_div_scalar(b: &mut criterion::Criterion) {
     b.bench_function("mat_div_scalar", move |bh| {
         bh.iter(|| {
             let mut aa = a.clone();
-            let mut b = aa.slice_mut((0, 0), (1000, 1000));
+            let mut b = aa.view_mut((0, 0), (1000, 1000));
             b /= n
         })
     });
diff --git a/tests/core/conversion.rs b/tests/core/conversion.rs
index 5374c399..096f235b 100644
--- a/tests/core/conversion.rs
+++ b/tests/core/conversion.rs
@@ -7,7 +7,7 @@ use na::{
     RowVector5, RowVector6, Similarity3, Transform3, UnitQuaternion, Vector1, Vector2, Vector3,
     Vector4, Vector5, Vector6,
 };
-use na::{DMatrix, DMatrixSlice, DMatrixSliceMut, MatrixSlice, MatrixSliceMut};
+use na::{DMatrix, DMatrixView, DMatrixViewMut, MatrixView, MatrixViewMut};
 use na::{U1, U3, U4};
 
 use crate::proptest::*;
@@ -266,24 +266,24 @@ fn matrix_slice_from_matrix_ref() {
     // Note: these have to be macros, and not functions, because the input type is different
     // across the different tests. Moreover, the output type depends on the stride of the input,
     // which is different for static and dynamic matrices.
-    macro_rules! dynamic_slice {
+    macro_rules! dynamic_view {
         ($mref:expr) => {
-            DMatrixSlice::<_>::from($mref)
+            DMatrixView::<_>::from($mref)
         };
     }
-    macro_rules! dynamic_slice_mut {
+    macro_rules! dynamic_view_mut {
         ($mref:expr) => {
-            DMatrixSliceMut::<_>::from($mref)
+            DMatrixViewMut::<_>::from($mref)
         };
     }
-    macro_rules! fixed_slice {
+    macro_rules! fixed_view {
         ($mref:expr) => {
-            MatrixSlice::<_, U3, U4, U1, U3>::from($mref)
+            MatrixView::<_, U3, U4, U1, U3>::from($mref)
         };
     }
-    macro_rules! fixed_slice_mut {
+    macro_rules! fixed_view_mut {
         ($mref:expr) => {
-            MatrixSliceMut::<_, U3, U4, U1, U3>::from($mref)
+            MatrixViewMut::<_, U3, U4, U1, U3>::from($mref)
         };
     }
 
@@ -291,66 +291,66 @@ fn matrix_slice_from_matrix_ref() {
     // Self and RHS. See issue #674. Once this is implemented, we can remove `into_owned`
     // from the below tests.
 
-    // Construct slices from reference to a
+    // Construct views from reference to a
     {
-        assert_eq!(a, fixed_slice!(&a).into_owned());
-        assert_eq!(d, dynamic_slice!(&a).into_owned());
+        assert_eq!(a, fixed_view!(&a).into_owned());
+        assert_eq!(d, dynamic_view!(&a).into_owned());
     }
 
-    // Construct slices from mutable reference to a
+    // Construct views from mutable reference to a
     {
         let mut a_clone = a.clone();
-        assert_eq!(a, fixed_slice!(&mut a_clone).into_owned());
-        assert_eq!(d, dynamic_slice!(&mut a_clone).into_owned());
+        assert_eq!(a, fixed_view!(&mut a_clone).into_owned());
+        assert_eq!(d, dynamic_view!(&mut a_clone).into_owned());
     }
 
     // Construct mutable slices from mutable reference to a
     {
         let mut a_clone = a.clone();
-        assert_eq!(a, fixed_slice_mut!(&mut a_clone).into_owned());
-        assert_eq!(d, dynamic_slice_mut!(&mut a_clone).into_owned());
+        assert_eq!(a, fixed_view_mut!(&mut a_clone).into_owned());
+        assert_eq!(d, dynamic_view_mut!(&mut a_clone).into_owned());
     }
 
     // Construct slices from reference to d
     {
-        assert_eq!(a, fixed_slice!(&d).into_owned());
-        assert_eq!(d, dynamic_slice!(&d).into_owned());
+        assert_eq!(a, fixed_view!(&d).into_owned());
+        assert_eq!(d, dynamic_view!(&d).into_owned());
     }
 
     // Construct slices from mutable reference to d
     {
         let mut d_clone = a.clone();
-        assert_eq!(a, fixed_slice!(&mut d_clone).into_owned());
-        assert_eq!(d, dynamic_slice!(&mut d_clone).into_owned());
+        assert_eq!(a, fixed_view!(&mut d_clone).into_owned());
+        assert_eq!(d, dynamic_view!(&mut d_clone).into_owned());
     }
 
     // Construct mutable slices from mutable reference to d
     {
         let mut d_clone = d.clone();
-        assert_eq!(a, fixed_slice_mut!(&mut d_clone).into_owned());
-        assert_eq!(d, dynamic_slice_mut!(&mut d_clone).into_owned());
+        assert_eq!(a, fixed_view_mut!(&mut d_clone).into_owned());
+        assert_eq!(d, dynamic_view_mut!(&mut d_clone).into_owned());
     }
 
     // Construct slices from a slice of a
     {
-        let mut a_slice = fixed_slice!(&a);
-        assert_eq!(a, fixed_slice!(&a_slice).into_owned());
-        assert_eq!(a, fixed_slice!(&mut a_slice).into_owned());
-        assert_eq!(d, dynamic_slice!(&a_slice).into_owned());
-        assert_eq!(d, dynamic_slice!(&mut a_slice).into_owned());
+        let mut a_slice = fixed_view!(&a);
+        assert_eq!(a, fixed_view!(&a_slice).into_owned());
+        assert_eq!(a, fixed_view!(&mut a_slice).into_owned());
+        assert_eq!(d, dynamic_view!(&a_slice).into_owned());
+        assert_eq!(d, dynamic_view!(&mut a_slice).into_owned());
     }
 
     // Construct slices from a slice mut of a
     {
         // Need a clone of a here, so that we can both have a mutable borrow and compare equality
         let mut a_clone = a.clone();
-        let mut a_slice = fixed_slice_mut!(&mut a_clone);
+        let mut a_slice = fixed_view_mut!(&mut a_clone);
 
-        assert_eq!(a, fixed_slice!(&a_slice).into_owned());
-        assert_eq!(a, fixed_slice!(&mut a_slice).into_owned());
-        assert_eq!(d, dynamic_slice!(&a_slice).into_owned());
-        assert_eq!(d, dynamic_slice!(&mut a_slice).into_owned());
-        assert_eq!(a, fixed_slice_mut!(&mut a_slice).into_owned());
-        assert_eq!(d, dynamic_slice_mut!(&mut a_slice).into_owned());
+        assert_eq!(a, fixed_view!(&a_slice).into_owned());
+        assert_eq!(a, fixed_view!(&mut a_slice).into_owned());
+        assert_eq!(d, dynamic_view!(&a_slice).into_owned());
+        assert_eq!(d, dynamic_view!(&mut a_slice).into_owned());
+        assert_eq!(a, fixed_view_mut!(&mut a_slice).into_owned());
+        assert_eq!(d, dynamic_view_mut!(&mut a_slice).into_owned());
     }
 }
diff --git a/tests/core/matrix.rs b/tests/core/matrix.rs
index 8a545e97..219845d4 100644
--- a/tests/core/matrix.rs
+++ b/tests/core/matrix.rs
@@ -1066,43 +1066,43 @@ fn partial_eq_different_types() {
     let static_mat = Matrix2x4::new(1, 2, 3, 4, 5, 6, 7, 8);
 
     let mut typenum_static_mat = OMatrix::<u8, Const<1024>, Const<4>>::zeros();
-    let mut slice = typenum_static_mat.slice_mut((0, 0), (2, 4));
-    slice += static_mat;
+    let mut view = typenum_static_mat.view_mut((0, 0), (2, 4));
+    view += static_mat;
 
-    let fslice_of_dmat = dynamic_mat.fixed_slice::<2, 2>(0, 0);
-    let dslice_of_dmat = dynamic_mat.slice((0, 0), (2, 2));
-    let fslice_of_smat = static_mat.fixed_slice::<2, 2>(0, 0);
-    let dslice_of_smat = static_mat.slice((0, 0), (2, 2));
+    let fview_of_dmat = dynamic_mat.fixed_view::<2, 2>(0, 0);
+    let dview_of_dmat = dynamic_mat.view((0, 0), (2, 2));
+    let fview_of_smat = static_mat.fixed_view::<2, 2>(0, 0);
+    let dview_of_smat = static_mat.view((0, 0), (2, 2));
 
     assert_eq!(dynamic_mat, static_mat);
     assert_eq!(static_mat, dynamic_mat);
 
-    assert_eq!(dynamic_mat, slice);
-    assert_eq!(slice, dynamic_mat);
+    assert_eq!(dynamic_mat, view);
+    assert_eq!(view, dynamic_mat);
 
-    assert_eq!(static_mat, slice);
-    assert_eq!(slice, static_mat);
+    assert_eq!(static_mat, view);
+    assert_eq!(view, static_mat);
 
-    assert_eq!(fslice_of_dmat, dslice_of_dmat);
-    assert_eq!(dslice_of_dmat, fslice_of_dmat);
+    assert_eq!(fview_of_dmat, dview_of_dmat);
+    assert_eq!(dview_of_dmat, fview_of_dmat);
 
-    assert_eq!(fslice_of_dmat, fslice_of_smat);
-    assert_eq!(fslice_of_smat, fslice_of_dmat);
+    assert_eq!(fview_of_dmat, fview_of_smat);
+    assert_eq!(fview_of_smat, fview_of_dmat);
 
-    assert_eq!(fslice_of_dmat, dslice_of_smat);
-    assert_eq!(dslice_of_smat, fslice_of_dmat);
+    assert_eq!(fview_of_dmat, dview_of_smat);
+    assert_eq!(dview_of_smat, fview_of_dmat);
 
-    assert_eq!(dslice_of_dmat, fslice_of_smat);
-    assert_eq!(fslice_of_smat, dslice_of_dmat);
+    assert_eq!(dview_of_dmat, fview_of_smat);
+    assert_eq!(fview_of_smat, dview_of_dmat);
 
-    assert_eq!(dslice_of_dmat, dslice_of_smat);
-    assert_eq!(dslice_of_smat, dslice_of_dmat);
+    assert_eq!(dview_of_dmat, dview_of_smat);
+    assert_eq!(dview_of_smat, dview_of_dmat);
 
-    assert_eq!(fslice_of_smat, dslice_of_smat);
-    assert_eq!(dslice_of_smat, fslice_of_smat);
+    assert_eq!(fview_of_smat, dview_of_smat);
+    assert_eq!(dview_of_smat, fview_of_smat);
 
-    assert_ne!(dynamic_mat, dslice_of_smat);
-    assert_ne!(dslice_of_smat, dynamic_mat);
+    assert_ne!(dynamic_mat, dview_of_smat);
+    assert_ne!(dview_of_smat, dynamic_mat);
 
     // TODO - implement those comparisons
     // assert_ne!(static_mat, typenum_static_mat);
diff --git a/tests/core/matrix_slice.rs b/tests/core/matrix_slice.rs
index ada5297e..ce3a1c37 100644
--- a/tests/core/matrix_slice.rs
+++ b/tests/core/matrix_slice.rs
@@ -1,22 +1,22 @@
 #![allow(non_snake_case)]
 
 use na::{
-    DMatrix, DMatrixSlice, DMatrixSliceMut, Matrix2, Matrix2x3, Matrix2x4, Matrix2x6, Matrix3,
-    Matrix3x2, Matrix3x4, Matrix4x2, Matrix6x2, MatrixSlice2, MatrixSlice2x3, MatrixSlice2xX,
-    MatrixSlice3, MatrixSlice3x2, MatrixSliceMut2, MatrixSliceMut2x3, MatrixSliceMut2xX,
-    MatrixSliceMut3, MatrixSliceMut3x2, MatrixSliceMutXx3, MatrixSliceXx3, RowVector4, Vector3,
+    DMatrix, DMatrixView, DMatrixViewMut, Matrix2, Matrix2x3, Matrix2x4, Matrix2x6, Matrix3,
+    Matrix3x2, Matrix3x4, Matrix4x2, Matrix6x2, MatrixView2, MatrixView2x3, MatrixView2xX,
+    MatrixView3, MatrixView3x2, MatrixViewMut2, MatrixViewMut2x3, MatrixViewMut2xX,
+    MatrixViewMut3, MatrixViewMut3x2, MatrixViewMutXx3, MatrixViewXx3, RowVector4, Vector3,
 };
 
 #[test]
 #[rustfmt::skip]
-fn nested_fixed_slices() {
+fn nested_fixed_views() {
     let a = Matrix3x4::new(11.0, 12.0, 13.0, 14.0,
                            21.0, 22.0, 23.0, 24.0,
                            31.0, 32.0, 33.0, 34.0);
 
-    let s1 = a.fixed_slice::<3, 3>(0, 1);                       // Simple slice.
-    let s2 = s1.fixed_slice::<2, 2>(1, 1);                      // Slice of slice.
-    let s3 = s1.fixed_slice_with_steps::<2, 2>((0, 0), (1, 1)); // Slice of slice with steps.
+    let s1 = a.fixed_view::<3, 3>(0, 1);                       // Simple view.
+    let s2 = s1.fixed_view::<2, 2>(1, 1);                      // View of view.
+    let s3 = s1.fixed_view_with_steps::<2, 2>((0, 0), (1, 1)); // View of view with steps.
 
     let expected_owned_s1 = Matrix3::new(12.0, 13.0, 14.0,
                                          22.0, 23.0, 24.0,
@@ -35,14 +35,14 @@ fn nested_fixed_slices() {
 
 #[test]
 #[rustfmt::skip]
-fn nested_slices() {
+fn nested_views() {
     let a = Matrix3x4::new(11.0, 12.0, 13.0, 14.0,
                            21.0, 22.0, 23.0, 24.0,
                            31.0, 32.0, 33.0, 34.0);
 
-    let s1 = a.slice((0, 1), (3, 3));
-    let s2 = s1.slice((1, 1), (2, 2));
-    let s3 = s1.slice_with_steps((0, 0), (2, 2), (1, 1));
+    let s1 = a.view((0, 1), (3, 3));
+    let s2 = s1.view((1, 1), (2, 2));
+    let s3 = s1.view_with_steps((0, 0), (2, 2), (1, 1));
 
     let expected_owned_s1 = DMatrix::from_row_slice(3, 3, &[ 12.0, 13.0, 14.0,
                                                              22.0, 23.0, 24.0,
@@ -61,14 +61,14 @@ fn nested_slices() {
 
 #[test]
 #[rustfmt::skip]
-fn slice_mut() {
+fn view_mut() {
     let mut a = Matrix3x4::new(11.0, 12.0, 13.0, 14.0,
                                21.0, 22.0, 23.0, 24.0,
                                31.0, 32.0, 33.0, 34.0);
 
     {
-        // We modify `a` through the mutable slice.
-        let mut s1 = a.slice_with_steps_mut((0, 1), (2, 2), (1, 1));
+        // We modify `a` through the mutable view.
+        let mut s1 = a.view_with_steps_mut((0, 1), (2, 2), (1, 1));
         s1.fill(0.0);
     }
 
@@ -81,7 +81,7 @@ fn slice_mut() {
 
 #[test]
 #[rustfmt::skip]
-fn nested_row_slices() {
+fn nested_row_views() {
     let a = Matrix6x2::new(11.0, 12.0,
                            21.0, 22.0,
                            31.0, 32.0,
@@ -105,7 +105,7 @@ fn nested_row_slices() {
 
 #[test]
 #[rustfmt::skip]
-fn row_slice_mut() {
+fn row_view_mut() {
     let mut a = Matrix6x2::new(11.0, 12.0,
                                21.0, 22.0,
                                31.0, 32.0,
@@ -113,7 +113,7 @@ fn row_slice_mut() {
                                51.0, 52.0,
                                61.0, 62.0);
     {
-        // We modify `a` through the mutable slice.
+        // We modify `a` through the mutable view.
         let mut s1 = a.rows_with_step_mut(1, 3, 1);
         s1.fill(0.0);
     }
@@ -130,7 +130,7 @@ fn row_slice_mut() {
 
 #[test]
 #[rustfmt::skip]
-fn nested_col_slices() {
+fn nested_col_views() {
     let a = Matrix2x6::new(11.0, 12.0, 13.0, 14.0, 15.0, 16.0,
                            21.0, 22.0, 23.0, 24.0, 25.0, 26.0);
     let s1 = a.fixed_columns::<4>(1);
@@ -148,12 +148,12 @@ fn nested_col_slices() {
 
 #[test]
 #[rustfmt::skip]
-fn col_slice_mut() {
+fn col_view_mut() {
     let mut a = Matrix2x6::new(11.0, 12.0, 13.0, 14.0, 15.0, 16.0,
                                21.0, 22.0, 23.0, 24.0, 25.0, 26.0);
 
     {
-        // We modify `a` through the mutable slice.
+        // We modify `a` through the mutable view.
         let mut s1 = a.columns_with_step_mut(1, 3, 1);
         s1.fill(0.0);
     }
@@ -203,7 +203,7 @@ fn columns_range_pair() {
 
 #[test]
 #[rustfmt::skip]
-fn new_slice() {
+fn new_from_slice() {
     let data = [ 1.0, 2.0,  3.0,  4.0,
                  5.0, 6.0,  7.0,  8.0,
                  9.0, 10.0, 11.0, 12.0 ];
@@ -214,13 +214,13 @@ fn new_slice() {
     let expected3x2 = Matrix3x2::from_column_slice(&data);
 
     {
-        let m2   = MatrixSlice2::from_slice(&data);
-        let m3   = MatrixSlice3::from_slice(&data);
-        let m2x3 = MatrixSlice2x3::from_slice(&data);
-        let m3x2 = MatrixSlice3x2::from_slice(&data);
-        let m2xX = MatrixSlice2xX::from_slice(&data, 3);
-        let mXx3 = MatrixSliceXx3::from_slice(&data, 2);
-        let mXxX = DMatrixSlice::from_slice(&data, 2, 3);
+        let m2   = MatrixView2::from_slice(&data);
+        let m3   = MatrixView3::from_slice(&data);
+        let m2x3 = MatrixView2x3::from_slice(&data);
+        let m3x2 = MatrixView3x2::from_slice(&data);
+        let m2xX = MatrixView2xX::from_slice(&data, 3);
+        let mXx3 = MatrixViewXx3::from_slice(&data, 2);
+        let mXxX = DMatrixView::from_slice(&data, 2, 3);
 
         assert!(m2.eq(&expected2));
         assert!(m3.eq(&expected3));
@@ -234,7 +234,7 @@ fn new_slice() {
 
 #[test]
 #[rustfmt::skip]
-fn new_slice_mut() {
+fn new_from_slice_mut() {
     let data = [ 1.0, 2.0,  3.0,  4.0,
                  5.0, 6.0,  7.0,  8.0,
                  9.0, 10.0, 11.0, 12.0 ];
@@ -252,31 +252,31 @@ fn new_slice_mut() {
                         9.0, 10.0, 11.0, 12.0 ];
 
     let mut data_mut = data.clone();
-    MatrixSliceMut2::from_slice(&mut data_mut).fill(0.0);
+    MatrixViewMut2::from_slice(&mut data_mut).fill(0.0);
     assert!(data_mut == expected2);
 
     let mut data_mut = data.clone();
-    MatrixSliceMut3::from_slice(&mut data_mut).fill(0.0);
+    MatrixViewMut3::from_slice(&mut data_mut).fill(0.0);
     assert!(data_mut == expected3);
 
     let mut data_mut = data.clone();
-    MatrixSliceMut2x3::from_slice(&mut data_mut).fill(0.0);
+    MatrixViewMut2x3::from_slice(&mut data_mut).fill(0.0);
     assert!(data_mut == expected2x3);
 
     let mut data_mut = data.clone();
-    MatrixSliceMut3x2::from_slice(&mut data_mut).fill(0.0);
+    MatrixViewMut3x2::from_slice(&mut data_mut).fill(0.0);
     assert!(data_mut == expected3x2);
 
     let mut data_mut = data.clone();
-    MatrixSliceMut2xX::from_slice(&mut data_mut, 3).fill(0.0);
+    MatrixViewMut2xX::from_slice(&mut data_mut, 3).fill(0.0);
     assert!(data_mut == expected2x3);
 
     let mut data_mut = data.clone();
-    MatrixSliceMutXx3::from_slice(&mut data_mut, 2).fill(0.0);
+    MatrixViewMutXx3::from_slice(&mut data_mut, 2).fill(0.0);
     assert!(data_mut == expected2x3);
 
     let mut data_mut = data.clone();
-    DMatrixSliceMut::from_slice(&mut data_mut, 2, 3).fill(0.0);
+    DMatrixViewMut::from_slice(&mut data_mut, 2, 3).fill(0.0);
     assert!(data_mut == expected2x3);
 }
 
@@ -324,14 +324,14 @@ fn columns_with_step_out_of_bounds() {
 
 #[test]
 #[should_panic]
-fn slice_out_of_bounds() {
+fn view_out_of_bounds() {
     let a = Matrix3x4::<f32>::zeros();
-    a.slice((1, 2), (3, 1));
+    a.view((1, 2), (3, 1));
 }
 
 #[test]
 #[should_panic]
-fn slice_with_steps_out_of_bounds() {
+fn view_with_steps_out_of_bounds() {
     let a = Matrix3x4::<f32>::zeros();
-    a.slice_with_steps((1, 2), (2, 2), (0, 1));
+    a.view_with_steps((1, 2), (2, 2), (0, 1));
 }

From f007772f4bce94ac1878fc6a73f23eba829aae0a Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 15:18:28 +0100
Subject: [PATCH 84/91] Update slice->view in nalgebra-glm

---
 nalgebra-glm/src/gtx/quaternion.rs | 2 +-
 nalgebra-glm/src/gtx/transform2.rs | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/nalgebra-glm/src/gtx/quaternion.rs b/nalgebra-glm/src/gtx/quaternion.rs
index f912c409..d4f82af2 100644
--- a/nalgebra-glm/src/gtx/quaternion.rs
+++ b/nalgebra-glm/src/gtx/quaternion.rs
@@ -93,6 +93,6 @@ pub fn mat3_to_quat<T: RealNumber>(x: &TMat3<T>) -> Qua<T> {
 
 /// Converts a rotation matrix in homogeneous coordinates to a quaternion.
 pub fn to_quat<T: RealNumber>(x: &TMat4<T>) -> Qua<T> {
-    let rot = x.fixed_slice::<3, 3>(0, 0).into_owned();
+    let rot = x.fixed_view::<3, 3>(0, 0).into_owned();
     mat3_to_quat(&rot)
 }
diff --git a/nalgebra-glm/src/gtx/transform2.rs b/nalgebra-glm/src/gtx/transform2.rs
index f389e4b1..56f736d7 100644
--- a/nalgebra-glm/src/gtx/transform2.rs
+++ b/nalgebra-glm/src/gtx/transform2.rs
@@ -7,7 +7,7 @@ pub fn proj2d<T: Number>(m: &TMat3<T>, normal: &TVec2<T>) -> TMat3<T> {
     let mut res = TMat3::identity();
 
     {
-        let mut part = res.fixed_slice_mut::<2, 2>(0, 0);
+        let mut part = res.fixed_view_mut::<2, 2>(0, 0);
         part -= normal * normal.transpose();
     }
 
@@ -19,7 +19,7 @@ pub fn proj<T: Number>(m: &TMat4<T>, normal: &TVec3<T>) -> TMat4<T> {
     let mut res = TMat4::identity();
 
     {
-        let mut part = res.fixed_slice_mut::<3, 3>(0, 0);
+        let mut part = res.fixed_view_mut::<3, 3>(0, 0);
         part -= normal * normal.transpose();
     }
 
@@ -31,7 +31,7 @@ pub fn reflect2d<T: RealNumber>(m: &TMat3<T>, normal: &TVec2<T>) -> TMat3<T> {
     let mut res = TMat3::identity();
 
     {
-        let mut part = res.fixed_slice_mut::<2, 2>(0, 0);
+        let mut part = res.fixed_view_mut::<2, 2>(0, 0);
         part -= (normal * T::from_subset(&2.0)) * normal.transpose();
     }
 
@@ -43,7 +43,7 @@ pub fn reflect<T: RealNumber>(m: &TMat4<T>, normal: &TVec3<T>) -> TMat4<T> {
     let mut res = TMat4::identity();
 
     {
-        let mut part = res.fixed_slice_mut::<3, 3>(0, 0);
+        let mut part = res.fixed_view_mut::<3, 3>(0, 0);
         part -= (normal * T::from_subset(&2.0)) * normal.transpose();
     }
 

From 660ee9c6f262a7bee2414441685385517c767bc7 Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 15:21:20 +0100
Subject: [PATCH 85/91] Update slice->view in nalgebra-lapack

---
 nalgebra-lapack/src/qr.rs  | 2 +-
 nalgebra-lapack/src/svd.rs | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/nalgebra-lapack/src/qr.rs b/nalgebra-lapack/src/qr.rs
index 895e34f3..ade2e452 100644
--- a/nalgebra-lapack/src/qr.rs
+++ b/nalgebra-lapack/src/qr.rs
@@ -126,7 +126,7 @@ where
 
         let mut q = self
             .qr
-            .generic_slice((0, 0), (nrows, min_nrows_ncols))
+            .generic_view((0, 0), (nrows, min_nrows_ncols))
             .into_owned();
 
         let mut info = 0;
diff --git a/nalgebra-lapack/src/svd.rs b/nalgebra-lapack/src/svd.rs
index 972ffa1b..804284d9 100644
--- a/nalgebra-lapack/src/svd.rs
+++ b/nalgebra-lapack/src/svd.rs
@@ -157,7 +157,7 @@ macro_rules! svd_impl(
                 let mut res: OMatrix<_, R, C> = Matrix::zeros_generic(nrows, ncols);
 
                 {
-                    let mut sres = res.generic_slice_mut((0, 0), (min_nrows_ncols, ncols));
+                    let mut sres = res.generic_view_mut((0, 0), (min_nrows_ncols, ncols));
                     sres.copy_from(&self.vt.rows_generic(0, min_nrows_ncols));
 
                     for i in 0 .. min_nrows_ncols.value() {
@@ -183,7 +183,7 @@ macro_rules! svd_impl(
                 let mut res: OMatrix<_, C, R> = Matrix::zeros_generic(ncols, nrows);
 
                 {
-                    let mut sres = res.generic_slice_mut((0, 0), (min_nrows_ncols, nrows));
+                    let mut sres = res.generic_view_mut((0, 0), (min_nrows_ncols, nrows));
                     self.u.columns_generic(0, min_nrows_ncols).transpose_to(&mut sres);
 
                     for i in 0 .. min_nrows_ncols.value() {

From 02caca0ece5809f7082bcdfd70015081c8212d16 Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 15:26:48 +0100
Subject: [PATCH 86/91] Update slice->view in nalgebra-sparse

---
 nalgebra-sparse/src/factorization/cholesky.rs |  6 +++---
 nalgebra-sparse/src/ops/serial/cs.rs          |  6 +++---
 nalgebra-sparse/src/ops/serial/csc.rs         | 16 ++++++++--------
 nalgebra-sparse/src/ops/serial/csr.rs         | 10 +++++-----
 nalgebra-sparse/tests/unit_tests/coo.rs       |  4 ++--
 nalgebra-sparse/tests/unit_tests/ops.rs       |  8 ++++----
 6 files changed, 25 insertions(+), 25 deletions(-)

diff --git a/nalgebra-sparse/src/factorization/cholesky.rs b/nalgebra-sparse/src/factorization/cholesky.rs
index 1f653278..f84e621f 100644
--- a/nalgebra-sparse/src/factorization/cholesky.rs
+++ b/nalgebra-sparse/src/factorization/cholesky.rs
@@ -3,7 +3,7 @@ use crate::ops::serial::spsolve_csc_lower_triangular;
 use crate::ops::Op;
 use crate::pattern::SparsityPattern;
 use core::{iter, mem};
-use nalgebra::{DMatrix, DMatrixSlice, DMatrixSliceMut, RealField};
+use nalgebra::{DMatrix, DMatrixView, DMatrixViewMut, RealField};
 use std::fmt::{Display, Formatter};
 
 /// A symbolic sparse Cholesky factorization of a CSC matrix.
@@ -264,7 +264,7 @@ impl<T: RealField> CscCholesky<T> {
     ///
     /// Panics if `B` is not square.
     #[must_use = "Did you mean to use solve_mut()?"]
-    pub fn solve<'a>(&'a self, b: impl Into<DMatrixSlice<'a, T>>) -> DMatrix<T> {
+    pub fn solve<'a>(&'a self, b: impl Into<DMatrixView<'a, T>>) -> DMatrix<T> {
         let b = b.into();
         let mut output = b.clone_owned();
         self.solve_mut(&mut output);
@@ -278,7 +278,7 @@ impl<T: RealField> CscCholesky<T> {
     /// # Panics
     ///
     /// Panics if `b` is not square.
-    pub fn solve_mut<'a>(&'a self, b: impl Into<DMatrixSliceMut<'a, T>>) {
+    pub fn solve_mut<'a>(&'a self, b: impl Into<DMatrixViewMut<'a, T>>) {
         let expect_msg = "If the Cholesky factorization succeeded,\
             then the triangular solve should never fail";
         // Solve LY = B
diff --git a/nalgebra-sparse/src/ops/serial/cs.rs b/nalgebra-sparse/src/ops/serial/cs.rs
index cc13c168..a2a132fc 100644
--- a/nalgebra-sparse/src/ops/serial/cs.rs
+++ b/nalgebra-sparse/src/ops/serial/cs.rs
@@ -2,7 +2,7 @@ use crate::cs::CsMatrix;
 use crate::ops::serial::{OperationError, OperationErrorKind};
 use crate::ops::Op;
 use crate::SparseEntryMut;
-use nalgebra::{ClosedAdd, ClosedMul, DMatrixSlice, DMatrixSliceMut, Scalar};
+use nalgebra::{ClosedAdd, ClosedMul, DMatrixView, DMatrixViewMut, Scalar};
 use num_traits::{One, Zero};
 
 fn spmm_cs_unexpected_entry() -> OperationError {
@@ -176,10 +176,10 @@ where
 /// the transposed operation must be specified for the CSC matrix.
 pub fn spmm_cs_dense<T>(
     beta: T,
-    mut c: DMatrixSliceMut<'_, T>,
+    mut c: DMatrixViewMut<'_, T>,
     alpha: T,
     a: Op<&CsMatrix<T>>,
-    b: Op<DMatrixSlice<'_, T>>,
+    b: Op<DMatrixView<'_, T>>,
 ) where
     T: Scalar + ClosedAdd + ClosedMul + Zero + One,
 {
diff --git a/nalgebra-sparse/src/ops/serial/csc.rs b/nalgebra-sparse/src/ops/serial/csc.rs
index 6a691ef9..5cf8ab23 100644
--- a/nalgebra-sparse/src/ops/serial/csc.rs
+++ b/nalgebra-sparse/src/ops/serial/csc.rs
@@ -4,7 +4,7 @@ use crate::ops::serial::cs::{
 };
 use crate::ops::serial::{OperationError, OperationErrorKind};
 use crate::ops::Op;
-use nalgebra::{ClosedAdd, ClosedMul, DMatrixSlice, DMatrixSliceMut, RealField, Scalar};
+use nalgebra::{ClosedAdd, ClosedMul, DMatrixView, DMatrixViewMut, RealField, Scalar};
 use num_traits::{One, Zero};
 
 use std::borrow::Cow;
@@ -16,10 +16,10 @@ use std::borrow::Cow;
 /// Panics if the dimensions of the matrices involved are not compatible with the expression.
 pub fn spmm_csc_dense<'a, T>(
     beta: T,
-    c: impl Into<DMatrixSliceMut<'a, T>>,
+    c: impl Into<DMatrixViewMut<'a, T>>,
     alpha: T,
     a: Op<&CscMatrix<T>>,
-    b: Op<impl Into<DMatrixSlice<'a, T>>>,
+    b: Op<impl Into<DMatrixView<'a, T>>>,
 ) where
     T: Scalar + ClosedAdd + ClosedMul + Zero + One,
 {
@@ -29,10 +29,10 @@ pub fn spmm_csc_dense<'a, T>(
 
 fn spmm_csc_dense_<T>(
     beta: T,
-    c: DMatrixSliceMut<'_, T>,
+    c: DMatrixViewMut<'_, T>,
     alpha: T,
     a: Op<&CscMatrix<T>>,
-    b: Op<DMatrixSlice<'_, T>>,
+    b: Op<DMatrixView<'_, T>>,
 ) where
     T: Scalar + ClosedAdd + ClosedMul + Zero + One,
 {
@@ -173,7 +173,7 @@ where
 /// Panics if `L` is not square, or if `L` and `B` are not dimensionally compatible.
 pub fn spsolve_csc_lower_triangular<'a, T: RealField>(
     l: Op<&CscMatrix<T>>,
-    b: impl Into<DMatrixSliceMut<'a, T>>,
+    b: impl Into<DMatrixViewMut<'a, T>>,
 ) -> Result<(), OperationError> {
     let b = b.into();
     let l_matrix = l.into_inner();
@@ -195,7 +195,7 @@ pub fn spsolve_csc_lower_triangular<'a, T: RealField>(
 
 fn spsolve_csc_lower_triangular_no_transpose<T: RealField>(
     l: &CscMatrix<T>,
-    b: DMatrixSliceMut<'_, T>,
+    b: DMatrixViewMut<'_, T>,
 ) -> Result<(), OperationError> {
     let mut x = b;
 
@@ -253,7 +253,7 @@ fn spsolve_encountered_zero_diagonal() -> Result<(), OperationError> {
 
 fn spsolve_csc_lower_triangular_transpose<T: RealField>(
     l: &CscMatrix<T>,
-    b: DMatrixSliceMut<'_, T>,
+    b: DMatrixViewMut<'_, T>,
 ) -> Result<(), OperationError> {
     let mut x = b;
 
diff --git a/nalgebra-sparse/src/ops/serial/csr.rs b/nalgebra-sparse/src/ops/serial/csr.rs
index 708c81a3..d69bc54c 100644
--- a/nalgebra-sparse/src/ops/serial/csr.rs
+++ b/nalgebra-sparse/src/ops/serial/csr.rs
@@ -4,17 +4,17 @@ use crate::ops::serial::cs::{
 };
 use crate::ops::serial::OperationError;
 use crate::ops::Op;
-use nalgebra::{ClosedAdd, ClosedMul, DMatrixSlice, DMatrixSliceMut, Scalar};
+use nalgebra::{ClosedAdd, ClosedMul, DMatrixView, DMatrixViewMut, Scalar};
 use num_traits::{One, Zero};
 use std::borrow::Cow;
 
 /// Sparse-dense matrix-matrix multiplication `C <- beta * C + alpha * op(A) * op(B)`.
 pub fn spmm_csr_dense<'a, T>(
     beta: T,
-    c: impl Into<DMatrixSliceMut<'a, T>>,
+    c: impl Into<DMatrixViewMut<'a, T>>,
     alpha: T,
     a: Op<&CsrMatrix<T>>,
-    b: Op<impl Into<DMatrixSlice<'a, T>>>,
+    b: Op<impl Into<DMatrixView<'a, T>>>,
 ) where
     T: Scalar + ClosedAdd + ClosedMul + Zero + One,
 {
@@ -24,10 +24,10 @@ pub fn spmm_csr_dense<'a, T>(
 
 fn spmm_csr_dense_<T>(
     beta: T,
-    c: DMatrixSliceMut<'_, T>,
+    c: DMatrixViewMut<'_, T>,
     alpha: T,
     a: Op<&CsrMatrix<T>>,
-    b: Op<DMatrixSlice<'_, T>>,
+    b: Op<DMatrixView<'_, T>>,
 ) where
     T: Scalar + ClosedAdd + ClosedMul + Zero + One,
 {
diff --git a/nalgebra-sparse/tests/unit_tests/coo.rs b/nalgebra-sparse/tests/unit_tests/coo.rs
index 8e46651f..8d7f740b 100644
--- a/nalgebra-sparse/tests/unit_tests/coo.rs
+++ b/nalgebra-sparse/tests/unit_tests/coo.rs
@@ -348,8 +348,8 @@ fn coo_push_matrix_valid_entries() {
     // Works with sliced
     {
         let source = nalgebra::SMatrix::<i32, 2, 2>::new(6, 7, 8, 9);
-        let sliced = source.fixed_slice::<2, 1>(0, 0);
-        coo.push_matrix(1, 0, &sliced);
+        let view = source.fixed_view::<2, 1>(0, 0);
+        coo.push_matrix(1, 0, &view);
 
         assert_eq!(
             coo.triplet_iter().collect::<Vec<_>>(),
diff --git a/nalgebra-sparse/tests/unit_tests/ops.rs b/nalgebra-sparse/tests/unit_tests/ops.rs
index 0a335567..c8d80f32 100644
--- a/nalgebra-sparse/tests/unit_tests/ops.rs
+++ b/nalgebra-sparse/tests/unit_tests/ops.rs
@@ -14,7 +14,7 @@ use nalgebra_sparse::pattern::SparsityPattern;
 use nalgebra_sparse::proptest::{csc, csr, sparsity_pattern};
 
 use nalgebra::proptest::{matrix, vector};
-use nalgebra::{DMatrix, DMatrixSlice, DMatrixSliceMut, Scalar};
+use nalgebra::{DMatrix, DMatrixView, DMatrixViewMut, Scalar};
 
 use proptest::prelude::*;
 
@@ -333,10 +333,10 @@ fn csc_square_with_non_zero_diagonals() -> impl Strategy<Value = CscMatrix<f64>>
 /// Helper function to help us call dense GEMM with our `Op` type
 fn dense_gemm<'a>(
     beta: i32,
-    c: impl Into<DMatrixSliceMut<'a, i32>>,
+    c: impl Into<DMatrixViewMut<'a, i32>>,
     alpha: i32,
-    a: Op<impl Into<DMatrixSlice<'a, i32>>>,
-    b: Op<impl Into<DMatrixSlice<'a, i32>>>,
+    a: Op<impl Into<DMatrixView<'a, i32>>>,
+    b: Op<impl Into<DMatrixView<'a, i32>>>,
 ) {
     let mut c = c.into();
     let a = a.convert();

From 31e687bd76b22430ed3f18e6af761e4a551fa78e Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 16:41:01 +0100
Subject: [PATCH 87/91] Implement Matrix::{as_view, as_view_mut} methods

---
 src/base/conversion.rs  |  3 --
 src/base/matrix_view.rs | 85 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 85 insertions(+), 3 deletions(-)

diff --git a/src/base/conversion.rs b/src/base/conversion.rs
index 79a61461..20553257 100644
--- a/src/base/conversion.rs
+++ b/src/base/conversion.rs
@@ -373,7 +373,6 @@ where
 impl<'a, T, R, C, RView, CView, RStride, CStride, S> From<&'a Matrix<T, R, C, S>>
     for MatrixView<'a, T, RView, CView, RStride, CStride>
 where
-    T: Scalar,
     R: Dim,
     C: Dim,
     RView: Dim,
@@ -410,7 +409,6 @@ where
 impl<'a, T, R, C, RView, CView, RStride, CStride, S> From<&'a mut Matrix<T, R, C, S>>
     for MatrixView<'a, T, RView, CView, RStride, CStride>
 where
-    T: Scalar,
     R: Dim,
     C: Dim,
     RView: Dim,
@@ -447,7 +445,6 @@ where
 impl<'a, T, R, C, RView, CView, RStride, CStride, S> From<&'a mut Matrix<T, R, C, S>>
     for MatrixViewMut<'a, T, RView, CView, RStride, CStride>
 where
-    T: Scalar,
     R: Dim,
     C: Dim,
     RView: Dim,
diff --git a/src/base/matrix_view.rs b/src/base/matrix_view.rs
index ef024f19..210e7a57 100644
--- a/src/base/matrix_view.rs
+++ b/src/base/matrix_view.rs
@@ -8,6 +8,7 @@ use crate::base::dimension::{Const, Dim, DimName, Dynamic, IsNotStaticOne, U1};
 use crate::base::iter::MatrixIter;
 use crate::base::storage::{IsContiguous, Owned, RawStorage, RawStorageMut, Storage};
 use crate::base::{Matrix, Scalar};
+use crate::constraint::{DimEq, ShapeConstraint};
 
 macro_rules! view_storage_impl (
     ($doc: expr; $Storage: ident as $SRef: ty; $legacy_name:ident => $T: ident.$get_addr: ident ($Ptr: ty as $Ref: ty)) => {
@@ -1091,3 +1092,87 @@ where
         unsafe { Matrix::from_data_statically_unchecked(data) }
     }
 }
+
+impl<T, R, C, S> Matrix<T, R, C, S>
+where
+    R: Dim,
+    C: Dim,
+    S: RawStorage<T, R, C>,
+{
+    /// Returns this matrix as a view.
+    ///
+    /// The returned view type is generally ambiguous unless specified.
+    /// This is particularly useful when working with functions or methods that take
+    /// matrix views as input.
+    ///
+    /// # Panics
+    /// Panics if the dimensions of the view and the matrix are not compatible and this cannot
+    /// be proven at compile-time. This might happen, for example, when constructing a static
+    /// view of size 3x3 from a dynamically sized matrix of dimension 5x5.
+    ///
+    /// # Examples
+    /// ```
+    /// use nalgebra::{DMatrixSlice, SMatrixView};
+    ///
+    /// fn consume_view(_: DMatrixSlice<f64>) {}
+    ///
+    /// let matrix = nalgebra::Matrix3::zeros();
+    /// consume_view(matrix.as_view());
+    ///
+    /// let dynamic_view: DMatrixSlice<f64> = matrix.as_view();
+    /// let static_view_from_dyn: SMatrixView<f64, 3, 3> = dynamic_view.as_view();
+    /// ```
+    pub fn as_view<RView, CView, RViewStride, CViewStride>(&self) -> MatrixView<'_, T, RView, CView, RViewStride, CViewStride>
+    where
+        RView: Dim,
+        CView: Dim,
+        RViewStride: Dim,
+        CViewStride: Dim,
+        ShapeConstraint: DimEq<R, RView> + DimEq<C, CView> + DimEq<RViewStride, S::RStride> + DimEq<CViewStride, S::CStride>
+    {
+        // Defer to (&matrix).into()
+        self.into()
+    }
+}
+
+impl<T, R, C, S> Matrix<T, R, C, S>
+where
+    R: Dim,
+    C: Dim,
+    S: RawStorageMut<T, R, C>,
+{
+    /// Returns this matrix as a mutable view.
+    ///
+    /// The returned view type is generally ambiguous unless specified.
+    /// This is particularly useful when working with functions or methods that take
+    /// matrix views as input.
+    ///
+    /// # Panics
+    /// Panics if the dimensions of the view and the matrix are not compatible and this cannot
+    /// be proven at compile-time. This might happen, for example, when constructing a static
+    /// view of size 3x3 from a dynamically sized matrix of dimension 5x5.
+    ///
+    /// # Examples
+    /// ```
+    /// use nalgebra::{DMatrixViewMut, SMatrixViewMut};
+    ///
+    /// fn consume_view(_: DMatrixViewMut<f64>) {}
+    ///
+    /// let mut matrix = nalgebra::Matrix3::zeros();
+    /// consume_view(matrix.as_view_mut());
+    ///
+    /// let mut dynamic_view: DMatrixViewMut<f64> = matrix.as_view_mut();
+    /// let static_view_from_dyn: SMatrixViewMut<f64, 3, 3> = dynamic_view.as_view_mut();
+    /// ```
+    pub fn as_view_mut<RView, CView, RViewStride, CViewStride>(&mut self) -> MatrixViewMut<'_, T, RView, CView, RViewStride, CViewStride>
+        where
+            RView: Dim,
+            CView: Dim,
+            RViewStride: Dim,
+            CViewStride: Dim,
+            ShapeConstraint: DimEq<R, RView> + DimEq<C, CView> + DimEq<RViewStride, S::RStride> + DimEq<CViewStride, S::CStride>
+    {
+        // Defer to (&mut matrix).into()
+        self.into()
+    }
+}

From 55c3a9c76408178411dbd71d3431f57b75cf589f Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 16:43:47 +0100
Subject: [PATCH 88/91] Formatting

---
 src/base/conversion.rs     | 22 ++++++++-------------
 src/base/matrix_view.rs    | 40 ++++++++++++++++++++++++--------------
 src/linalg/schur.rs        | 15 +++++++-------
 tests/core/matrix_slice.rs |  4 ++--
 4 files changed, 42 insertions(+), 39 deletions(-)

diff --git a/src/base/conversion.rs b/src/base/conversion.rs
index 20553257..02f72a43 100644
--- a/src/base/conversion.rs
+++ b/src/base/conversion.rs
@@ -16,8 +16,8 @@ use crate::base::dimension::{
 use crate::base::iter::{MatrixIter, MatrixIterMut};
 use crate::base::storage::{IsContiguous, RawStorage, RawStorageMut};
 use crate::base::{
-    ArrayStorage, DVectorView, DVectorViewMut, DefaultAllocator, Matrix, MatrixView,
-    MatrixViewMut, OMatrix, Scalar,
+    ArrayStorage, DVectorView, DVectorViewMut, DefaultAllocator, Matrix, MatrixView, MatrixViewMut,
+    OMatrix, Scalar,
 };
 #[cfg(any(feature = "std", feature = "alloc"))]
 use crate::base::{DVector, RowDVector, VecStorage};
@@ -380,10 +380,8 @@ where
     RStride: Dim,
     CStride: Dim,
     S: RawStorage<T, R, C>,
-    ShapeConstraint: DimEq<R, RView>
-        + DimEq<C, CView>
-        + DimEq<RStride, S::RStride>
-        + DimEq<CStride, S::CStride>,
+    ShapeConstraint:
+        DimEq<R, RView> + DimEq<C, CView> + DimEq<RStride, S::RStride> + DimEq<CStride, S::CStride>,
 {
     fn from(m: &'a Matrix<T, R, C, S>) -> Self {
         let (row, col) = m.shape_generic();
@@ -416,10 +414,8 @@ where
     RStride: Dim,
     CStride: Dim,
     S: RawStorage<T, R, C>,
-    ShapeConstraint: DimEq<R, RView>
-        + DimEq<C, CView>
-        + DimEq<RStride, S::RStride>
-        + DimEq<CStride, S::CStride>,
+    ShapeConstraint:
+        DimEq<R, RView> + DimEq<C, CView> + DimEq<RStride, S::RStride> + DimEq<CStride, S::CStride>,
 {
     fn from(m: &'a mut Matrix<T, R, C, S>) -> Self {
         let (row, col) = m.shape_generic();
@@ -452,10 +448,8 @@ where
     RStride: Dim,
     CStride: Dim,
     S: RawStorageMut<T, R, C>,
-    ShapeConstraint: DimEq<R, RView>
-        + DimEq<C, CView>
-        + DimEq<RStride, S::RStride>
-        + DimEq<CStride, S::CStride>,
+    ShapeConstraint:
+        DimEq<R, RView> + DimEq<C, CView> + DimEq<RStride, S::RStride> + DimEq<CStride, S::CStride>,
 {
     fn from(m: &'a mut Matrix<T, R, C, S>) -> Self {
         let (row, col) = m.shape_generic();
diff --git a/src/base/matrix_view.rs b/src/base/matrix_view.rs
index 210e7a57..c3dbd215 100644
--- a/src/base/matrix_view.rs
+++ b/src/base/matrix_view.rs
@@ -986,9 +986,9 @@ impl<T, R: Dim, C: Dim, S: RawStorage<T, R, C>> Matrix<T, R, C, S> {
         rows: RowRange,
         cols: ColRange,
     ) -> MatrixView<'_, T, RowRange::Size, ColRange::Size, S::RStride, S::CStride>
-        where
-            RowRange: DimRange<R>,
-            ColRange: DimRange<C>,
+    where
+        RowRange: DimRange<R>,
+        ColRange: DimRange<C>,
     {
         let (nrows, ncols) = self.shape_generic();
         self.generic_view(
@@ -1043,9 +1043,9 @@ impl<T, R: Dim, C: Dim, S: RawStorageMut<T, R, C>> Matrix<T, R, C, S> {
         rows: RowRange,
         cols: ColRange,
     ) -> MatrixViewMut<'_, T, RowRange::Size, ColRange::Size, S::RStride, S::CStride>
-        where
-            RowRange: DimRange<R>,
-            ColRange: DimRange<C>,
+    where
+        RowRange: DimRange<R>,
+        ColRange: DimRange<C>,
     {
         let (nrows, ncols) = self.shape_generic();
         self.generic_view_mut(
@@ -1122,13 +1122,18 @@ where
     /// let dynamic_view: DMatrixSlice<f64> = matrix.as_view();
     /// let static_view_from_dyn: SMatrixView<f64, 3, 3> = dynamic_view.as_view();
     /// ```
-    pub fn as_view<RView, CView, RViewStride, CViewStride>(&self) -> MatrixView<'_, T, RView, CView, RViewStride, CViewStride>
+    pub fn as_view<RView, CView, RViewStride, CViewStride>(
+        &self,
+    ) -> MatrixView<'_, T, RView, CView, RViewStride, CViewStride>
     where
         RView: Dim,
         CView: Dim,
         RViewStride: Dim,
         CViewStride: Dim,
-        ShapeConstraint: DimEq<R, RView> + DimEq<C, CView> + DimEq<RViewStride, S::RStride> + DimEq<CViewStride, S::CStride>
+        ShapeConstraint: DimEq<R, RView>
+            + DimEq<C, CView>
+            + DimEq<RViewStride, S::RStride>
+            + DimEq<CViewStride, S::CStride>,
     {
         // Defer to (&matrix).into()
         self.into()
@@ -1164,13 +1169,18 @@ where
     /// let mut dynamic_view: DMatrixViewMut<f64> = matrix.as_view_mut();
     /// let static_view_from_dyn: SMatrixViewMut<f64, 3, 3> = dynamic_view.as_view_mut();
     /// ```
-    pub fn as_view_mut<RView, CView, RViewStride, CViewStride>(&mut self) -> MatrixViewMut<'_, T, RView, CView, RViewStride, CViewStride>
-        where
-            RView: Dim,
-            CView: Dim,
-            RViewStride: Dim,
-            CViewStride: Dim,
-            ShapeConstraint: DimEq<R, RView> + DimEq<C, CView> + DimEq<RViewStride, S::RStride> + DimEq<CViewStride, S::CStride>
+    pub fn as_view_mut<RView, CView, RViewStride, CViewStride>(
+        &mut self,
+    ) -> MatrixViewMut<'_, T, RView, CView, RViewStride, CViewStride>
+    where
+        RView: Dim,
+        CView: Dim,
+        RViewStride: Dim,
+        CViewStride: Dim,
+        ShapeConstraint: DimEq<R, RView>
+            + DimEq<C, CView>
+            + DimEq<RViewStride, S::RStride>
+            + DimEq<CViewStride, S::CStride>,
     {
         // Defer to (&mut matrix).into()
         self.into()
diff --git a/src/linalg/schur.rs b/src/linalg/schur.rs
index 3388e7cf..06d8426b 100644
--- a/src/linalg/schur.rs
+++ b/src/linalg/schur.rs
@@ -211,10 +211,12 @@ where
 
                     {
                         let mut work = work.rows_mut(0, end + 1);
-                        refl.reflect(&mut t.generic_view_mut(
-                            (m, m),
-                            (Const::<2>, Dynamic::new(dim.value() - m)),
-                        ));
+                        refl.reflect(
+                            &mut t.generic_view_mut(
+                                (m, m),
+                                (Const::<2>, Dynamic::new(dim.value() - m)),
+                            ),
+                        );
                         refl.reflect_rows(
                             &mut t.generic_view_mut((0, m), (Dynamic::new(end + 1), Const::<2>)),
                             &mut work,
@@ -222,10 +224,7 @@ where
                     }
 
                     if let Some(ref mut q) = q {
-                        refl.reflect_rows(
-                            &mut q.generic_view_mut((0, m), (dim, Const::<2>)),
-                            work,
-                        );
+                        refl.reflect_rows(&mut q.generic_view_mut((0, m), (dim, Const::<2>)), work);
                     }
                 }
             } else {
diff --git a/tests/core/matrix_slice.rs b/tests/core/matrix_slice.rs
index ce3a1c37..4ce49d02 100644
--- a/tests/core/matrix_slice.rs
+++ b/tests/core/matrix_slice.rs
@@ -3,8 +3,8 @@
 use na::{
     DMatrix, DMatrixView, DMatrixViewMut, Matrix2, Matrix2x3, Matrix2x4, Matrix2x6, Matrix3,
     Matrix3x2, Matrix3x4, Matrix4x2, Matrix6x2, MatrixView2, MatrixView2x3, MatrixView2xX,
-    MatrixView3, MatrixView3x2, MatrixViewMut2, MatrixViewMut2x3, MatrixViewMut2xX,
-    MatrixViewMut3, MatrixViewMut3x2, MatrixViewMutXx3, MatrixViewXx3, RowVector4, Vector3,
+    MatrixView3, MatrixView3x2, MatrixViewMut2, MatrixViewMut2x3, MatrixViewMut2xX, MatrixViewMut3,
+    MatrixViewMut3x2, MatrixViewMutXx3, MatrixViewXx3, RowVector4, Vector3,
 };
 
 #[test]

From acfd37c7283e0d46e67f601daddbe70559b230c3 Mon Sep 17 00:00:00 2001
From: Andreas Longva <andreas.b.longva@gmail.com>
Date: Mon, 14 Nov 2022 16:59:54 +0100
Subject: [PATCH 89/91] Rename tests/core/matrix_slice.rs to
 tests/core/matrix_view.rs

---
 tests/core/{matrix_slice.rs => matrix_view.rs} | 0
 tests/core/mod.rs                              | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename tests/core/{matrix_slice.rs => matrix_view.rs} (100%)

diff --git a/tests/core/matrix_slice.rs b/tests/core/matrix_view.rs
similarity index 100%
rename from tests/core/matrix_slice.rs
rename to tests/core/matrix_view.rs
diff --git a/tests/core/mod.rs b/tests/core/mod.rs
index acdcd236..667f10a7 100644
--- a/tests/core/mod.rs
+++ b/tests/core/mod.rs
@@ -4,7 +4,7 @@ mod conversion;
 mod edition;
 mod empty;
 mod matrix;
-mod matrix_slice;
+mod matrix_view;
 #[cfg(feature = "mint")]
 mod mint;
 #[cfg(feature = "rkyv-serialize-no-std")]

From a4fdea927d7ddc5f84d8ce8f00aad91020730c16 Mon Sep 17 00:00:00 2001
From: "Ryan B. Harvey" <ryan.b.harvey@gmail.com>
Date: Mon, 12 Dec 2022 04:21:23 +0000
Subject: [PATCH 90/91] Add simple cargo doc step to CI

---
 .github/workflows/nalgebra-ci-build.yml | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/nalgebra-ci-build.yml b/.github/workflows/nalgebra-ci-build.yml
index d1a6c923..8b96d264 100644
--- a/.github/workflows/nalgebra-ci-build.yml
+++ b/.github/workflows/nalgebra-ci-build.yml
@@ -136,4 +136,10 @@ jobs:
       - run: cargo build --no-default-features --features cuda
       - run: cargo build --no-default-features --features cuda --target=nvptx64-nvidia-cuda
         env: 
-          CUDA_ARCH: "350"
\ No newline at end of file
+          CUDA_ARCH: "350"
+  docs:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v2
+    - name: Generate documentation
+      run: cargo doc

From b2da4609cf58d8ae8dcab10562ea8a0e1821a88f Mon Sep 17 00:00:00 2001
From: Liam <6039896+Spodeian@users.noreply.github.com>
Date: Wed, 21 Dec 2022 18:51:02 +1100
Subject: [PATCH 91/91] Update isometry.rs

Fix formatting of documentation so that "A 3D isometry is composed of:" is on its own line.
---
 src/geometry/isometry.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/geometry/isometry.rs b/src/geometry/isometry.rs
index 67660800..ff7c7502 100755
--- a/src/geometry/isometry.rs
+++ b/src/geometry/isometry.rs
@@ -21,6 +21,7 @@ use crate::geometry::{AbstractRotation, Point, Translation};
 /// A 2D isometry is composed of:
 /// - A translation part of type [`Translation2`](crate::Translation2)
 /// - A rotation part which can either be a [`UnitComplex`](crate::UnitComplex) or a [`Rotation2`](crate::Rotation2).
+/// 
 /// A 3D isometry is composed of:
 /// - A translation part of type [`Translation3`](crate::Translation3)
 /// - A rotation part which can either be a [`UnitQuaternion`](crate::UnitQuaternion) or a [`Rotation3`](crate::Rotation3).