srenblad/nalgebra
1
0
Fork 0
forked from M-Labs/nalgebra
Code Pull Requests Activity

Remove unnecessary normalization in Rotation3::face_towards

Browse Source 
`zaxis` and `xaxis` are already normalized which means `zaxis.cross(&xaxis)` should already be normalized.
This commit is contained in:
Alexander Ekdahl 2023-06-19 15:20:01 +02:00 committed by GitHub
parent 5baf86b311
commit 860899cd6d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/geometry/rotation_specialization.rs
View File

@ -478,9 +478,10 @@ where
SB: Storage<T, U3>, SB: Storage<T, U3>,
SC: Storage<T, U3>, SC: Storage<T, U3>,
{ {
// Gram–Schmidt process
let zaxis = dir.normalize(); let zaxis = dir.normalize();
let xaxis = up.cross(&zaxis).normalize(); let xaxis = up.cross(&zaxis).normalize();
let yaxis = zaxis.cross(&xaxis).normalize(); let yaxis = zaxis.cross(&xaxis);
Self::from_matrix_unchecked(SMatrix::<T, 3, 3>::new( Self::from_matrix_unchecked(SMatrix::<T, 3, 3>::new(
xaxis.x.clone(), xaxis.x.clone(),