clippy: fix #redundant_field_names

src/base/dimension.rs

@@ -23,7 +23,7 @@ impl Dynamic {
     /// A dynamic size equal to `value`.
     #[inline]
     pub fn new(value: usize) -> Self {
-        Self { value: value }
+        Self { value }
     }
 }
 

src/base/matrix.rs

@@ -191,7 +191,7 @@ impl<N: Scalar, R: Dim, C: Dim, S> Matrix<N, R, C, S> {
     #[inline]
     pub unsafe fn from_data_statically_unchecked(data: S) -> Matrix<N, R, C, S> {
         Matrix {
-            data: data,
+            data,
             _phantoms: PhantomData,
         }
     }

src/base/vec_storage.rs

@@ -41,11 +41,7 @@ impl<N, R: Dim, C: Dim> VecStorage<N, R, C> {
             nrows.value() * ncols.value() == data.len(),
             "Data storage buffer dimension mismatch."
         );
-        Self {
+        Self { data, nrows, ncols }
-            data: data,
-            nrows: nrows,
-            ncols: ncols,
-        }
     }
 
     /// The underlying data storage.

src/geometry/orthographic.rs

@@ -139,7 +139,7 @@ impl<N: RealField> Orthographic3<N> {
     /// ```
     #[inline]
     pub fn from_matrix_unchecked(matrix: Matrix4<N>) -> Self {
-        Self { matrix: matrix }
+        Self { matrix }
     }
 
     /// Creates a new orthographic projection matrix from an aspect ratio and the vertical field of view.

src/geometry/perspective.rs

@@ -97,7 +97,7 @@ impl<N: RealField> Perspective3<N> {
     /// projection.
     #[inline]
     pub fn from_matrix_unchecked(matrix: Matrix4<N>) -> Self {
-        Self { matrix: matrix }
+        Self { matrix }
     }
 
     /// Retrieves the inverse of the underlying homogeneous matrix.

src/geometry/point.rs

@@ -135,7 +135,7 @@ where
     #[deprecated(note = "Use Point::from(vector) instead.")]
     #[inline]
     pub fn from_coordinates(coords: VectorN<N, D>) -> Self {
-        Self { coords: coords }
+        Self { coords }
     }
 
     /// The dimension of this point.

src/geometry/rotation.rs

@@ -255,7 +255,7 @@ where
             "Unable to create a rotation from a non-square matrix."
         );
 
-        Self { matrix: matrix }
+        Self { matrix }
     }
 
     /// Transposes `self`.

src/geometry/transform.rs

@@ -245,7 +245,7 @@ where
     #[inline]
     pub fn from_matrix_unchecked(matrix: MatrixN<N, DimNameSum<D, U1>>) -> Self {
         Transform {
-            matrix: matrix,
+            matrix,
             _phantom: PhantomData,
         }
     }

src/geometry/translation.rs

@@ -119,7 +119,7 @@ where
     #[inline]
     #[deprecated(note = "Use `::from` instead.")]
     pub fn from_vector(vector: VectorN<N, D>) -> Translation<N, D> {
-        Translation { vector: vector }
+        Translation { vector }
     }
 
     /// Inverts `self`.

src/linalg/full_piv_lu.rs

@@ -60,11 +60,7 @@ where
         let mut q = PermutationSequence::identity_generic(min_nrows_ncols);
 
         if min_nrows_ncols.value() == 0 {
-            return Self {
+            return Self { lu: matrix, p, q };
-                lu: matrix,
-                p: p,
-                q: q,
-            };
         }
 
         for i in 0..min_nrows_ncols.value() {
@@ -90,11 +86,7 @@ where
             }
         }
 
-        Self {
+        Self { lu: matrix, p, q }
-            lu: matrix,
-            p: p,
-            q: q,
-        }
     }
 
     #[doc(hidden)]

src/linalg/lu.rs

@@ -96,7 +96,7 @@ where
         let mut p = PermutationSequence::identity_generic(min_nrows_ncols);
 
         if min_nrows_ncols.value() == 0 {
-            return LU { lu: matrix, p: p };
+            return LU { lu: matrix, p };
         }
 
         for i in 0..min_nrows_ncols.value() {
@@ -117,7 +117,7 @@ where
             }
         }
 
-        LU { lu: matrix, p: p }
+        LU { lu: matrix, p }
     }
 
     #[doc(hidden)]

src/linalg/qr.rs

@@ -57,20 +57,14 @@ where
         let mut diag = unsafe { MatrixMN::new_uninitialized_generic(min_nrows_ncols, U1) };
 
         if min_nrows_ncols.value() == 0 {
-            return QR {
+            return QR { qr: matrix, diag };
-                qr: matrix,
-                diag: diag,
-            };
         }
 
         for ite in 0..min_nrows_ncols.value() {
             householder::clear_column_unchecked(&mut matrix, &mut diag[ite], ite, 0, None);
         }
 
-        QR {
+        QR { qr: matrix, diag }
-            qr: matrix,
-            diag: diag,
-        }
     }
 
     /// Retrieves the upper trapezoidal submatrix `R` of this decomposition.

src/linalg/schur.rs

@@ -73,10 +73,8 @@ where
     pub fn try_new(m: MatrixN<N, D>, eps: N::RealField, max_niter: usize) -> Option<Self> {
         let mut work = unsafe { VectorN::new_uninitialized_generic(m.data.shape().0, U1) };
 
-        Self::do_decompose(m, &mut work, eps, max_niter, true).map(|(q, t)| Schur {
+        Self::do_decompose(m, &mut work, eps, max_niter, true)
-            q: q.unwrap(),
+            .map(|(q, t)| Schur { q: q.unwrap(), t })
-            t: t,
-        })
     }
 
     fn do_decompose(