srenblad/nalgebra
1
0
Fork 0
forked from M-Labs/nalgebra
Code Pull Requests Activity

Add unit tests for issue 1313

Browse Source
This commit is contained in:
Rasmus Brönnegård 2023-11-09 00:53:42 +01:00
parent b6e094c82f
commit 03c24fb369
2 changed files with 48 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
tests/linalg/bidiagonal.rs
View File

@ -1,6 +1,6 @@
#![cfg(feature = "proptest-support")] #[cfg(feature = "proptest-support")]
mod proptest_tests {
macro_rules! gen_tests( macro_rules! gen_tests(
($module: ident, $scalar: expr) => { ($module: ident, $scalar: expr) => {
mod $module { mod $module {
#[allow(unused_imports)] #[allow(unused_imports)]
@ -54,8 +54,9 @@ macro_rules! gen_tests(
} }
); );
gen_tests!(complex, complex_f64()); gen_tests!(complex, complex_f64());
gen_tests!(f64, PROPTEST_F64); gen_tests!(f64, PROPTEST_F64);
}
#[test] #[test]
fn bidiagonal_identity() { fn bidiagonal_identity() {
@ -74,3 +75,31 @@ fn bidiagonal_identity() {
let (u, d, v_t) = bidiagonal.unpack(); let (u, d, v_t) = bidiagonal.unpack();
assert_eq!(m, &u * d * &v_t); assert_eq!(m, &u * d * &v_t);
} }
#[test]
fn bidiagonal_regression_issue_1313() {
let s = 6.123234e-16_f32;
let mut m = nalgebra::dmatrix![
10.0, 0.0, 0.0, 0.0, -10.0, 0.0, 0.0, 0.0;
s, 10.0, 0.0, 10.0, s, 0.0, 0.0, 0.0;
20.0, -20.0, 0.0, 20.0, 20.0, 0.0, 0.0, 0.0;
];
m.unscale_mut(m.camax());
let bidiagonal = m.clone().bidiagonalize();
let (u, d, v_t) = bidiagonal.unpack();
let m2 = &u * d * &v_t;
assert_relative_eq!(m, m2, epsilon = 1e-6);
}
#[test]
fn bidiagonal_regression_issue_1313_minimal() {
let s = 6.123234e-17_f32;
let m = nalgebra::dmatrix![
1.0, 0.0, -1.0;
s, 1.0, s;
];
let bidiagonal = m.clone().bidiagonalize();
let (u, d, v_t) = bidiagonal.unpack();
let m2 = &u * &d * &v_t;
assert_relative_eq!(m, m2, epsilon = 1e-6);
}

14
tests/linalg/svd.rs
View File

@ -499,3 +499,17 @@ fn svd_regression_issue_1072() {
epsilon = 1e-9 epsilon = 1e-9
); );
} }
#[test]
// Exercises bug reported in issue #1313 of nalgebra (https://github.com/dimforge/nalgebra/issues/1313)
fn svd_regression_issue_1313() {
let s = 6.123234e-16_f32;
let m = nalgebra::dmatrix![
10.0, 0.0, 0.0, 0.0, -10.0, 0.0, 0.0, 0.0;
s, 10.0, 0.0, 10.0, s, 0.0, 0.0, 0.0;
20.0, -20.0, 0.0, 20.0, 20.0, 0.0, 0.0, 0.0;
];
let svd = m.clone().svd(true, true);
let m2 = svd.recompose().unwrap();
assert_relative_eq!(&m, &m2, epsilon = 1e-5);
}