srenblad
/
artiq
forked from M-Labs/artiq
1
0
Fork 0
Code Pull Requests Activity

compiler: Implement numpy.rint() using llvm.round()

This commit is contained in:
David Nadlinger 2020-08-09 19:27:54 +01:00
parent ae47d4c0ec
commit a39bd69ca4
2 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
artiq/compiler/math_fns.py
View File

@ -15,8 +15,20 @@ unary_fp_intrinsics = [(name, "llvm." + name + ".f64") for name in [
"floor", "floor",
"ceil", "ceil",
"trunc", "trunc",
"rint", ]] + [
]] # numpy.rint() seems to (NumPy 1.19.0, Python 3.8.5, Linux x86_64)
# implement round-to-even, but unfortunately, rust-lang/libm only
# provides round(), which always rounds away from zero.
#
# As there is no equivalent of the latter in NumPy (nor any other
# basic rounding function), expose round() as numpy.rint anyway,
# even if the rounding modes don't match up, so there is some way
# to do rounding on the core device. (numpy.round() has entirely
# different semantics; it rounds to a configurable number of
# decimals.)
("rint", "llvm.round.f64"),
]
#: float -> float numpy.* math functions lowered to runtime calls. #: float -> float numpy.* math functions lowered to runtime calls.
unary_fp_runtime_calls = [ unary_fp_runtime_calls = [

6
artiq/test/coredevice/test_numpy.py
View File

@ -90,6 +90,6 @@ class CompareHostDeviceTest(ExperimentCase):
] ]
for name in names: for name in names:
op = "numpy.{}(a)".format(name) op = "numpy.{}(a)".format(name)
print(op) # Avoid 0.5, as numpy.rint's rounding mode currently doesn't match.
self._test_unaryop(op, 0.5) self._test_unaryop(op, 0.51)
self._test_unaryop(op, numpy.array([[0.3, 0.4], [0.5, 0.6]])) self._test_unaryop(op, numpy.array([[0.3, 0.4], [0.51, 0.6]]))