From 7f8e53aa5cfa868d524f416b6a9f8e1ddd657bea Mon Sep 17 00:00:00 2001
From: Sebastien Bourdeauducq <sb@m-labs.hk>
Date: Wed, 26 Oct 2016 11:48:47 +0800
Subject: [PATCH] drtio: more fixes and tests

---
 artiq/gateware/drtio/rt_controller.py        | 12 +++---
 artiq/test/gateware/drtio/test_full_stack.py | 39 +++++++++++++++++---
 2 files changed, 40 insertions(+), 11 deletions(-)

diff --git a/artiq/gateware/drtio/rt_controller.py b/artiq/gateware/drtio/rt_controller.py
index bc9dbb2f3..e0efafcd7 100644
--- a/artiq/gateware/drtio/rt_controller.py
+++ b/artiq/gateware/drtio/rt_controller.py
@@ -37,7 +37,7 @@ class RTController(Module):
     def __init__(self, rt_packets, channel_count, fine_ts_width):
         self.kcsrs = _KernelCSRs()
 
-        self.submodules.counter = RTIOCounter(64)
+        self.submodules.counter = RTIOCounter(64-fine_ts_width)
         self.sync += If(self.kcsrs.counter_update.re, 
                         self.kcsrs.counter.status.eq(self.counter.value_sys))
         tsc_correction = Signal(64)
@@ -93,10 +93,10 @@ class RTController(Module):
 
         # TODO: collision, replace, busy
         cond_sequence_error = self.kcsrs.o_timestamp.storage < last_timestamps.dat_r
-        cond_underflow = ((self.kcsrs.o_timestamp.storage - self.kcsrs.underflow_margin.storage
-                           >> fine_ts_width) < self.counter.value_sys)
-        cond_fifo_emptied = ((last_timestamps.dat_r
-                              < self.counter.value_sys - self.kcsrs.underflow_margin.storage)
+        cond_underflow = ((self.kcsrs.o_timestamp.storage[fine_ts_width:]
+                           - self.kcsrs.underflow_margin.storage[fine_ts_width:]) < self.counter.value_sys)
+        cond_fifo_emptied = ((last_timestamps.dat_r[fine_ts_width:]
+                              < self.counter.value_sys - self.kcsrs.underflow_margin.storage[fine_ts_width:])
                              & (last_timestamps.dat_r != 0))
 
         fsm.act("IDLE",
@@ -124,7 +124,7 @@ class RTController(Module):
                     fifo_spaces.dat_w.eq(fifo_spaces.dat_r - 1)
                 ),
                 last_timestamps.we.eq(1),
-                If(fifo_spaces.dat_r <= 1,
+                If(~cond_fifo_emptied & (fifo_spaces.dat_r <= 1),
                     NextState("GET_FIFO_SPACE")
                 ).Else(
                     NextState("IDLE")
diff --git a/artiq/test/gateware/drtio/test_full_stack.py b/artiq/test/gateware/drtio/test_full_stack.py
index ab6fd68e4..002b9bbc0 100644
--- a/artiq/test/gateware/drtio/test_full_stack.py
+++ b/artiq/test/gateware/drtio/test_full_stack.py
@@ -47,8 +47,8 @@ class DUT(Module):
         self.submodules.phy0 = ttl_simple.Output(self.ttl0)
         self.submodules.phy1 = ttl_simple.Output(self.ttl1)
         rtio_channels = [
-            rtio.Channel.from_phy(self.phy0),
-            rtio.Channel.from_phy(self.phy1)
+            rtio.Channel.from_phy(self.phy0, ofifo_depth=4),
+            rtio.Channel.from_phy(self.phy1, ofifo_depth=4)
         ]
         self.submodules.satellite = DRTIOSatellite(
             self.transceivers.bob, rx_synchronizer, rtio_channels)
@@ -79,6 +79,7 @@ class TestFullStack(unittest.TestCase):
             yield from kcsrs.o_we.write(1)
             yield
             status = 1
+            wlen = 0
             while status:
                 status = yield from kcsrs.o_status.read()
                 if status & 2:
@@ -88,6 +89,8 @@ class TestFullStack(unittest.TestCase):
                     yield from kcsrs.o_sequence_error_reset.write(1)
                     raise RTIOSequenceError
                 yield
+                wlen += 1
+            return wlen
 
         def test():
             yield from get_fifo_space(0)
@@ -109,9 +112,28 @@ class TestFullStack(unittest.TestCase):
                 yield from write(0, 1)
             delay(200*8)
 
-            for _ in range(50):
+            delay(200*8)
+            max_wlen = 0
+            for _ in range(3):
+                wlen = yield from write(0, 1)
+                max_wlen = max(max_wlen, wlen)
+                delay(40*8)
+                wlen = yield from write(0, 0)
+                max_wlen = max(max_wlen, wlen)
+                delay(40*8)
+            # check that some writes caused FIFO space requests
+            self.assertGreater(max_wlen, 5)
+
+            # wait for all TTL events to execute
+            for _ in range(40):
                 yield
 
+            # check "last timestamp passed" FIFO empty condition
+            delay(1000*8)
+            wlen = yield from write(0, 1)
+            self.assertEqual(wlen, 2)
+
+
         ttl_changes = []
         @passive
         def check_ttls():
@@ -128,10 +150,17 @@ class TestFullStack(unittest.TestCase):
 
         run_simulation(dut, 
             {"sys": test(), "rtio": check_ttls()},
-            {"sys": 8, "rtio": 5, "rtio_rx": 5, "rio": 5, "rio_phy": 5}, vcd_name="foo.vcd")
+            {"sys": 8, "rtio": 5, "rtio_rx": 5, "rio": 5, "rio_phy": 5})
         self.assertEqual(ttl_changes, [
             (203, 0),
             (208, 0),
             (208, 1),
-            (214, 1)
+            (214, 1),
+
+            (414, 0),
+            (454, 0),
+            (494, 0),
+            (534, 0),
+            (574, 0),
+            (614, 0)
         ])