srenblad
/
artiq
forked from M-Labs/artiq
1
0
Fork 0
Code Pull Requests Activity

Revert "Ensure bindings are created in correct order for e.g. "x, y = y, x"." 

This reverts commit bcd1832203.

The bindings are actually created in lexical order, as evident
in e.g. "x = lambda: x". The safety provided by this check should
be instead provided by a local access analysis.
This commit is contained in:
whitequark 2015-07-18 09:41:53 +03:00
parent 8e1cc8d985
commit 47cbadb564
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
artiq/compiler/transforms/asttyped_rewriter.py
View File

@ -108,25 +108,12 @@ class LocalExtractor(algorithm.Visitor):
def visit_Name(self, node): def visit_Name(self, node):
if self.in_assign: if self.in_assign:
# Code like: # code like:
# x = 1 # x = 1
# def f(): # def f():
# x = 1 # x = 1
# creates a new binding for x in f's scope # creates a new binding for x in f's scope
self._assignable(node.id) self._assignable(node.id)
else:
# This is duplicated here as well as below so that
# code like:
# x, y = y, x
# where y and x were not defined earlier would be invalid.
if node.id in self.typing_env:
return
for outer_env in reversed(self.env_stack):
if node.id in outer_env:
return
diag = diagnostic.Diagnostic("fatal",
"name '{name}' is not bound to anything", {"name":node.id}, node.loc)
self.engine.process(diag)
def visit_Attribute(self, node): def visit_Attribute(self, node):
self.visit_in_assign(node.value, in_assign=False) self.visit_in_assign(node.value, in_assign=False)