From 2a7a72b27a093ae5287d5abcb2124eccdb5c1155 Mon Sep 17 00:00:00 2001
From: Deepskyhunter <48083317+Deepskyhunter@users.noreply.github.com>
Date: Tue, 26 Jul 2022 10:42:03 +0800
Subject: [PATCH] language.environment: error out if unknown arguments are
 passed (#1927)

Closes #1641
---
 artiq/language/environment.py | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/artiq/language/environment.py b/artiq/language/environment.py
index e61bf228b..204bf823f 100644
--- a/artiq/language/environment.py
+++ b/artiq/language/environment.py
@@ -209,18 +209,28 @@ class TraceArgumentManager:
         self.requested_args[key] = processor, group, tooltip
         return None
 
+    def check_unprocessed_arguments(self):
+        pass
 
 class ProcessArgumentManager:
     def __init__(self, unprocessed_arguments):
         self.unprocessed_arguments = unprocessed_arguments
+        self._processed_arguments = set()
 
     def get(self, key, processor, group, tooltip):
         if key in self.unprocessed_arguments:
             r = processor.process(self.unprocessed_arguments[key])
+            self._processed_arguments.add(key)
         else:
             r = processor.default()
         return r
 
+    def check_unprocessed_arguments(self):
+        unprocessed = set(self.unprocessed_arguments.keys()) -\
+                      self._processed_arguments
+        if unprocessed:
+            raise AttributeError("Invalid argument(s): " +
+                                 ", ".join(unprocessed))
 
 class HasEnvironment:
     """Provides methods to manage the environment of an experiment (arguments,
@@ -242,6 +252,7 @@ class HasEnvironment:
         self.__in_build = True
         self.build(*args, **kwargs)
         self.__in_build = False
+        self.__argument_mgr.check_unprocessed_arguments()
 
     def register_child(self, child):
         self.children.append(child)