runtime: allow #[cfg(not(has_rtio))] builds.

artiq/firmware/ksupport/lib.rs

@@ -372,6 +372,7 @@ extern fn dma_retrieve(name: CSlice<u8>) -> DmaTrace {
     })
 }
 
+#[cfg(has_rtio)]
 extern fn dma_playback(timestamp: i64, ptr: i32) {
     assert!(ptr % 64 == 0);
 
@@ -404,6 +405,11 @@ extern fn dma_playback(timestamp: i64, ptr: i32) {
     }
 }
 
+#[cfg(not(has_rtio))]
+extern fn dma_playback(timestamp: i64, ptr: i32) {
+    unimplemented!("not(has_rtio)")
+}
+
 unsafe fn attribute_writeback(typeinfo: *const ()) {
     struct Attr {
         offset: usize,

artiq/firmware/ksupport/rtio.rs

@@ -1,42 +1,46 @@
-use core::ptr::{read_volatile, write_volatile};
-use cslice::CSlice;
-use board::csr;
-use ::send;
-use kernel_proto::*;
 
-pub const RTIO_O_STATUS_WAIT:           u8 = 1;
-pub const RTIO_O_STATUS_UNDERFLOW:      u8 = 2;
-pub const RTIO_O_STATUS_SEQUENCE_ERROR: u8 = 4;
-pub const RTIO_I_STATUS_WAIT_EVENT:     u8 = 1;
-pub const RTIO_I_STATUS_OVERFLOW:       u8 = 2;
-pub const RTIO_I_STATUS_WAIT_STATUS:    u8 = 4;
+#[cfg(has_rtio)]
+mod imp {
+    use core::ptr::{read_volatile, write_volatile};
+    use cslice::CSlice;
 
-pub extern fn init() {
+    use board::csr;
+    use ::send;
+    use kernel_proto::*;
+
+    pub const RTIO_O_STATUS_WAIT:           u8 = 1;
+    pub const RTIO_O_STATUS_UNDERFLOW:      u8 = 2;
+    pub const RTIO_O_STATUS_SEQUENCE_ERROR: u8 = 4;
+    pub const RTIO_I_STATUS_WAIT_EVENT:     u8 = 1;
+    pub const RTIO_I_STATUS_OVERFLOW:       u8 = 2;
+    pub const RTIO_I_STATUS_WAIT_STATUS:    u8 = 4;
+
+    pub extern fn init() {
         send(&RtioInitRequest);
-}
+    }
 
-pub extern fn get_counter() -> i64 {
+    pub extern fn get_counter() -> i64 {
         unsafe {
             csr::rtio::counter_update_write(1);
             csr::rtio::counter_read() as i64
         }
-}
+    }
 
-#[inline(always)]
-pub unsafe fn rtio_o_data_write(offset: usize, data: u32) {
+    #[inline(always)]
+    pub unsafe fn rtio_o_data_write(offset: usize, data: u32) {
         write_volatile(
             csr::rtio::O_DATA_ADDR.offset((csr::rtio::O_DATA_SIZE - 1 - offset) as isize),
             data);
-}
+    }
 
-#[inline(always)]
-pub unsafe fn rtio_i_data_read(offset: usize) -> u32 {
+    #[inline(always)]
+    pub unsafe fn rtio_i_data_read(offset: usize) -> u32 {
         read_volatile(
             csr::rtio::I_DATA_ADDR.offset((csr::rtio::I_DATA_SIZE - 1 - offset) as isize))
-}
+    }
 
-#[inline(never)]
-unsafe fn process_exceptional_status(timestamp: i64, channel: i32, status: u8) {
+    #[inline(never)]
+    unsafe fn process_exceptional_status(timestamp: i64, channel: i32, status: u8) {
         if status & RTIO_O_STATUS_WAIT != 0 {
             while csr::rtio::o_status_read() & RTIO_O_STATUS_WAIT != 0 {}
         }
@@ -50,9 +54,9 @@ unsafe fn process_exceptional_status(timestamp: i64, channel: i32, status: u8) {
                 "RTIO sequence error at {0} mu, channel {1}",
                 timestamp, channel as i64, 0)
         }
-}
+    }
 
-pub extern fn output(timestamp: i64, channel: i32, addr: i32, data: i32) {
+    pub extern fn output(timestamp: i64, channel: i32, addr: i32, data: i32) {
         unsafe {
             csr::rtio::chan_sel_write(channel as _);
             // writing timestamp clears o_data
@@ -65,9 +69,9 @@ pub extern fn output(timestamp: i64, channel: i32, addr: i32, data: i32) {
                 process_exceptional_status(timestamp, channel, status);
             }
         }
-}
+    }
 
-pub extern fn output_wide(timestamp: i64, channel: i32, addr: i32, data: CSlice<i32>) {
+    pub extern fn output_wide(timestamp: i64, channel: i32, addr: i32, data: CSlice<i32>) {
         unsafe {
             csr::rtio::chan_sel_write(channel as _);
             // writing timestamp clears o_data
@@ -82,9 +86,9 @@ pub extern fn output_wide(timestamp: i64, channel: i32, addr: i32, data: CSlice<
                 process_exceptional_status(timestamp, channel, status);
             }
         }
-}
+    }
 
-pub extern fn input_timestamp(timeout: i64, channel: i32) -> u64 {
+    pub extern fn input_timestamp(timeout: i64, channel: i32) -> u64 {
         unsafe {
             csr::rtio::chan_sel_write(channel as _);
             csr::rtio::timestamp_write(timeout as u64);
@@ -106,9 +110,9 @@ pub extern fn input_timestamp(timeout: i64, channel: i32) -> u64 {
 
             csr::rtio::i_timestamp_read()
         }
-}
+    }
 
-pub extern fn input_data(channel: i32) -> i32 {
+    pub extern fn input_data(channel: i32) -> i32 {
         unsafe {
             csr::rtio::chan_sel_write(channel as _);
             csr::rtio::timestamp_write(0xffffffff_ffffffff);
@@ -128,10 +132,10 @@ pub extern fn input_data(channel: i32) -> i32 {
 
             rtio_i_data_read(0) as i32
         }
-}
+    }
 
-#[cfg(has_rtio_log)]
-pub fn log(timestamp: i64, data: &[u8]) {
+    #[cfg(has_rtio_log)]
+    pub fn log(timestamp: i64, data: &[u8]) {
         unsafe {
             csr::rtio::chan_sel_write(csr::CONFIG_RTIO_LOG_CHANNEL);
             csr::rtio::timestamp_write(timestamp as u64);
@@ -152,17 +156,54 @@ pub fn log(timestamp: i64, data: &[u8]) {
                 csr::rtio::o_we_write(1);
             }
         }
+    }
+
+    #[cfg(not(has_rtio_log))]
+    pub fn log(_timestamp: i64, _data: &[u8]) {
+        unimplemented!("not(has_rtio_log)")
+    }
 }
 
-#[cfg(not(has_rtio_log))]
-pub fn log(_timestamp: i64, _data: &[u8]) {}
+#[cfg(not(has_rtio))]
+mod imp {
+    use cslice::CSlice;
+
+    pub extern fn init() {
+        unimplemented!("not(has_rtio)")
+    }
+
+    pub extern fn get_counter() -> i64 {
+        unimplemented!("not(has_rtio)")
+    }
+
+    pub extern fn output(_timestamp: i64, _channel: i32, _addr: i32, _data: i32) {
+        unimplemented!("not(has_rtio)")
+    }
+
+    pub extern fn output_wide(_timestamp: i64, _channel: i32, _addr: i32, _data: CSlice<i32>) {
+        unimplemented!("not(has_rtio)")
+    }
+
+    pub extern fn input_timestamp(_timeout: i64, _channel: i32) -> u64 {
+        unimplemented!("not(has_rtio)")
+    }
+
+    pub extern fn input_data(_channel: i32) -> i32 {
+        unimplemented!("not(has_rtio)")
+    }
+
+    pub fn log(_timestamp: i64, _data: &[u8]) {
+        unimplemented!("not(has_rtio)")
+    }
+}
+
+pub use self::imp::*;
 
 pub mod drtio_dbg {
     use ::send;
     use ::recv;
     use kernel_proto::*;
 
-
     #[repr(C)]
     pub struct ChannelState(i32, i64);
 

artiq/firmware/runtime/kern_hwreq.rs

@@ -1,8 +1,9 @@
-use session::{kern_acknowledge, kern_send};
-use rtio_mgt;
-use kernel_proto as kern;
 use std::io;
+use kernel_proto as kern;
 use sched::Io;
+use session::{kern_acknowledge, kern_send};
+#[cfg(has_rtio)]
+use rtio_mgt;
 
 #[cfg(has_drtio)]
 mod drtio_i2c {
@@ -317,29 +318,35 @@ mod spi {
 
 pub fn process_kern_hwreq(io: &Io, request: &kern::Message) -> io::Result<bool> {
     match request {
+        #[cfg(has_rtio)]
         &kern::RtioInitRequest => {
             info!("resetting RTIO");
             rtio_mgt::init_core();
             kern_acknowledge()
         }
 
+        #[cfg(has_rtio)]
         &kern::DrtioChannelStateRequest { channel } => {
             let (fifo_space, last_timestamp) = rtio_mgt::drtio_dbg::get_channel_state(channel);
             kern_send(io, &kern::DrtioChannelStateReply { fifo_space: fifo_space,
                                                           last_timestamp: last_timestamp })
         }
+        #[cfg(has_rtio)]
         &kern::DrtioResetChannelStateRequest { channel } => {
             rtio_mgt::drtio_dbg::reset_channel_state(channel);
             kern_acknowledge()
         }
+        #[cfg(has_rtio)]
         &kern::DrtioGetFifoSpaceRequest { channel } => {
             rtio_mgt::drtio_dbg::get_fifo_space(channel);
             kern_acknowledge()
         }
+        #[cfg(has_rtio)]
         &kern::DrtioPacketCountRequest { linkno } => {
             let (tx_cnt, rx_cnt) = rtio_mgt::drtio_dbg::get_packet_counts(linkno);
             kern_send(io, &kern::DrtioPacketCountReply { tx_cnt: tx_cnt, rx_cnt: rx_cnt })
         }
+        #[cfg(has_rtio)]
         &kern::DrtioFifoSpaceReqCountRequest { linkno } => {
             let cnt = rtio_mgt::drtio_dbg::get_fifo_space_req_count(linkno);
             kern_send(io, &kern::DrtioFifoSpaceReqCountReply { cnt: cnt })

artiq/firmware/runtime/lib.rs

@@ -37,6 +37,7 @@ macro_rules! borrow_mut {
 
 mod config;
 mod ethmac;
+#[cfg(has_rtio)]
 mod rtio_mgt;
 
 mod urc;
@@ -123,6 +124,7 @@ fn startup() {
 
     let mut scheduler = sched::Scheduler::new();
     let io = scheduler.io();
+    #[cfg(has_rtio)]
     rtio_mgt::startup(&io);
     io.spawn(4096, mgmt::thread);
     io.spawn(16384, session::thread);

artiq/firmware/runtime/rtio_mgt.rs

@@ -303,16 +303,3 @@ pub mod drtio_dbg {
         }
     }
 }
-
-#[cfg(not(has_drtio))]
-pub mod drtio_dbg {
-    pub fn get_channel_state(_channel: u32) -> (u16, u64) { (0, 0) }
-
-    pub fn reset_channel_state(_channel: u32) {}
-
-    pub fn get_fifo_space(_channel: u32) {}
-
-    pub fn get_packet_counts(_linkno: u8) -> (u32, u32) { (0, 0) }
-
-    pub fn get_fifo_space_req_count(_linkno: u8) -> u32 { 0 }
-}

artiq/firmware/runtime/session.rs

@@ -3,19 +3,23 @@ use std::{mem, str};
 use std::cell::{Cell, RefCell};
 use std::io::{self, Read, Write};
 use std::error::Error;
-use {config, rtio_mgt, mailbox, rpc_queue, kernel};
-use cache::Cache;
-use rtio_dma::Manager as DmaManager;
+use byteorder::{ByteOrder, NetworkEndian};
+
 use urc::Urc;
 use sched::{ThreadHandle, Io};
 use sched::{TcpListener, TcpStream};
-use byteorder::{ByteOrder, NetworkEndian};
 use board;
+use {config, mailbox, rpc_queue, kernel};
+#[cfg(has_rtio)]
+use rtio_mgt;
+use rtio_dma::Manager as DmaManager;
+use cache::Cache;
+#[cfg(has_rtio)]
+use kern_hwreq;
 
 use rpc_proto as rpc;
 use session_proto as host;
 use kernel_proto as kern;
-use kern_hwreq;
 
 macro_rules! unexpected {
     ($($arg:tt)*) => {
@@ -268,6 +272,8 @@ fn process_host_message(io: &Io,
                 unexpected!("attempted to switch RTIO clock while a kernel was running")
             }
 
+            #[cfg(has_rtio)]
+            {
                 if rtio_mgt::crg::switch_clock(clk) {
                     host_write(stream, host::Reply::ClockSwitchCompleted)
                 } else {
@@ -275,6 +281,10 @@ fn process_host_message(io: &Io,
                 }
             }
 
+            #[cfg(not(has_rtio))]
+            host_write(stream, host::Reply::ClockSwitchFailed)
+        }
+
         host::Request::LoadKernel(kernel) =>
             match unsafe { kern_load(io, session, &kernel) } {
                 Ok(()) => host_write(stream, host::Reply::LoadCompleted),
@@ -365,9 +375,14 @@ fn process_kern_message(io: &Io, mut stream: Option<&mut TcpStream>,
         }
 
         kern_recv_dotrace(request);
+
+        #[cfg(has_rtio)]
+        {
             if kern_hwreq::process_kern_hwreq(io, request)? {
                 return Ok(false)
             }
+        }
+
         match request {
             &kern::Log(args) => {
                 use std::fmt::Write;
@@ -541,11 +556,14 @@ fn host_kernel_worker(io: &Io,
                 return Err(io_error("watchdog expired"))
             }
 
+            #[cfg(has_rtio)]
+            {
                 if !rtio_mgt::crg::check() {
                     host_write(stream, host::Reply::ClockFailure)?;
                     return Err(io_error("RTIO clock failure"))
                 }
             }
+        }
 
         io.relinquish()?
     }
@@ -583,9 +601,12 @@ fn flash_kernel_worker(io: &Io,
             return Err(io_error("watchdog expired"))
         }
 
+        #[cfg(has_rtio)]
+        {
             if !rtio_mgt::crg::check() {
                 return Err(io_error("RTIO clock failure"))
             }
+        }
 
         io.relinquish()?
     }