From 1fb3995ffc69fa33bc311fdaa6ab849f435d748d Mon Sep 17 00:00:00 2001 From: Robert Jordens Date: Mon, 12 Jun 2017 20:07:25 +0200 Subject: [PATCH] Revert "fir/ParallelHBFUpsampler: add headroom (gain=2)" This reverts commit 6ac9d0c41efba9d9a6f85754b8ec131a9e74f0cc. Overshooting behavior must to be handled outside the FIR. --- artiq/gateware/dsp/fir.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/artiq/gateware/dsp/fir.py b/artiq/gateware/dsp/fir.py index e73499a5e..4fa2e9c5f 100644 --- a/artiq/gateware/dsp/fir.py +++ b/artiq/gateware/dsp/fir.py @@ -163,7 +163,7 @@ class ParallelHBFUpsampler(Module): i = [self.i] for coeff in coefficients: self.parallelism *= 2 - hbf = ParallelFIR(coeff, self.parallelism, width + 1, **kwargs) + hbf = ParallelFIR(coeff, self.parallelism, width, **kwargs) self.submodules += hbf self.comb += [a.eq(b) for a, b in zip(hbf.i[::2], i)] i = hbf.o