This lint is in stable Rust now: https://github.com/rust-lang/rust/issues/43302.
These changes are noted according to code comment from @whitequark.
Some test cases and functions are altered due to changes of #[must_use].
560: IEEE802154: getters for security fields r=Dirbaio a=thibautvdv
This adds getters for the security fields of the IEEE802154 frame. Also added a test for it.
`src/wire/ieee802154.rs` also contained a function for calculating the CRC. However, this is not needed and thus I also remove it in this PR.
Co-authored-by: Thibaut Vandervelden <thvdveld@vub.be>
469: Add IEEE 802.15.4/6LoWPAN support r=Dirbaio a=thibautvdv
This adds the IEEE 802.15.4 frame representation.
Still a work in progress and interested to know what you think about this.
I really would like to add 6LowPAN as well, however I'm not sure where to put this in smoltcp, since 6LowPAN is kind of weird.
Co-authored-by: Thibaut Vandervelden <thvdveld@vub.be>
Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>
Also check for the correct destination PAN id when receiving a frame (as
discussed). Linux does this as well.
However, hardware implementations also can drop those packets.
Using a raw socket on `monitor0` causes weird results: packets we receive
include FCS, packets we send are parsed as if they didn't have FCS, except
by wireshark which always expects a FCS??
Turns out the sane way is to use raw sockets on normal `wpanX` interfaces,
in which case all packets we send/receive are without FCS.
We assume the FCS is checked by lower layers or by hardware.
- Makes it consistent with Ethernet mediums, where we don't handle the FCS either.
- Linux ieee802154 raw sockets send/receive packets without the FCS.
552: tcp: Reply with RST to ACKs with invalid ackno in SYN_SENT. r=Dirbaio a=Dirbaio
Should fixaramperes/onetun#17.
`@aramperes` could you check if this fixes the issue? Thank you!
Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>
549: wire: add From<Address> for ::std::net::IpAddr r=Dirbaio a=Dirbaio
Originally from #296
Co-authored-by: Marc-André Lureau <marcandre.lureau@redhat.com>
548: DHCP fixes r=Dirbaio a=Dirbaio
Several fixes, including one that fixes DHCP not working with some routers.
See individual commit messages for details.
Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>
Reasons:
1. We were already accidentally not setting the BROADCAST flag due to it being the wrong bit (see previous commit).
2. Major OSes don't set it.
3. rfc1542 section 3.1.1 states it's discouraged, and the issue it's supposed to workaround doesn't apply to smoltcp.
Unfortunately, some client implementations are
unable to receive such unicast IP datagrams until they know their own
IP address
(..)
This addition to the protocol is a workaround for old host
implementations. Such implementations SHOULD be modified so
that they may receive unicast BOOTREPLY messages, thus making
use of this workaround unnecessary. In general, the use of
this mechanism is discouraged.
luojia65
bors[bot]
Thibaut Vandervelden
Dario Nieuwenhuis
mkb2091
Marc-André Lureau
