renet/renet
renet
/
renet
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add a test for TCP sockets returning ACKs even with zero window.

This commit is contained in:
whitequark 2017-08-28 06:01:13 +00:00
parent 695c61fd05
commit f84b234a38
1 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/socket/tcp.rs
View File

@ -720,8 +720,7 @@ impl<'a> TcpSocket<'a> {
reply_repr.control = TcpControl::Rst;
reply_repr.seq_number = repr.ack_number.unwrap_or_default();
if repr.control == TcpControl::Syn {
reply_repr.ack_number = Some(repr.seq_number +
repr.segment_len());
reply_repr.ack_number = Some(repr.seq_number + repr.segment_len());
}
(ip_reply_repr, reply_repr)
@ -2895,4 +2894,32 @@ mod test {
..RECV_TEMPL
})));
}
#[test]
fn test_zero_window_ack() {
let mut s = socket_established();
s.rx_buffer = SocketBuffer::new(vec![0; 6]);
send!(s, TcpRepr {
seq_number: REMOTE_SEQ + 1,
ack_number: Some(LOCAL_SEQ + 1),
payload: &b"abcdef"[..],
..SEND_TEMPL
}, Ok(Some(TcpRepr {
seq_number: LOCAL_SEQ + 1,
ack_number: Some(REMOTE_SEQ + 1 + 6),
window_len: 0,
..RECV_TEMPL
})));
send!(s, TcpRepr {
seq_number: REMOTE_SEQ + 1 + 6,
ack_number: Some(LOCAL_SEQ + 1),
payload: &b"123456"[..],
..SEND_TEMPL
}, Ok(Some(TcpRepr {
seq_number: LOCAL_SEQ + 1,
ack_number: Some(REMOTE_SEQ + 1 + 6),
window_len: 0,
..RECV_TEMPL
})));
}
}