Add write mac address #3

occheung · 2021-01-25T13:24:24+08:00

occheung commented

2021-01-25 13:24:24 +08:00

This PR adds write_mac_address(), which reconfigures the MAC address of enc424j600.

This PR adds `write_mac_address()`, which reconfigures the MAC address of enc424j600.

occheung added 1 commit 2021-01-25 13:24:25 +08:00

f9a126d513 lib: add write mac

harry commented

2021-01-25 13:58:42 +08:00

LGTM! Just wanna add a reminder for ourselves for to-dos in QUARTIQ's Booster repo:

Replace the read_from_mac() with write_to_mac()
Import settings.mac() to the configuration Rust source (IMO the "split" from main.rs should be a separate PR on Booster on its own)
Remove the feature-gating when init-ing SerialTerminal

LGTM! Just wanna add a reminder for ourselves for to-dos in QUARTIQ's Booster repo: * [Replace the `read_from_mac()` with `write_to_mac()`](https://github.com/quartiq/booster/blob/feature/enc424j600/src/enc424j600_config.rs#L48-L49) * Import `settings.mac()` to the [configuration Rust source](https://github.com/quartiq/booster/blob/feature/enc424j600/src/enc424j600_config.rs) (IMO the "split" from `main.rs` should be a separate PR on Booster on its own) * [Remove the feature-gating when init-ing `SerialTerminal`](https://github.com/quartiq/booster/blob/feature/enc424j600/src/main.rs#L515-L518)

sb10q merged commit 6021623813 into master

2021-01-25 18:32:21 +08:00

occheung deleted branch write_mac

2021-01-26 15:47:11 +08:00

jordens referenced this issue from a commit

2023-07-03 21:49:40 +08:00

Merge pull request #3 from quartiq/release/0.3.0

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: renet/ENC424J600#3