forked from M-Labs/artiq
88bf7d2233
Before this commit, proto::io::{read,write}_* functions were taking
a &mut {Read,Write}. This means a lot of virtual dispatch.
After this commit, all these functions are specialized for
the specific IO trait.
This could be achieved with just changing the signature from
fn read_x(reader: &mut Read)
to
fn read_x<R: Read>(reader: &mut R)
but the functions were also grouped into ReadExt and WriteExt
traits as a refactoring.
Initially, it was expected that the generic traits from
the byteorder crate could be used, but they require endianness
to be specified on every call and thus aren't very ergonomic.
They also lack the equivalent to our read_string and read_bytes.
Thus, it seems fine to just define a slightly different extension
trait.
This also optimized the test_rpc_timing test: 1.7ms→1.2ms.
23 lines
577 B
Rust
23 lines
577 B
Rust
use std::io::{self, Write};
|
|
use WriteExt;
|
|
|
|
#[derive(Debug)]
|
|
pub struct Header {
|
|
pub sent_bytes: u32,
|
|
pub total_byte_count: u64,
|
|
pub overflow_occurred: bool,
|
|
pub log_channel: u8,
|
|
pub dds_onehot_sel: bool
|
|
}
|
|
|
|
impl Header {
|
|
pub fn write_to(&self, writer: &mut Write) -> io::Result<()> {
|
|
writer.write_u32(self.sent_bytes)?;
|
|
writer.write_u64(self.total_byte_count)?;
|
|
writer.write_u8(self.overflow_occurred as u8)?;
|
|
writer.write_u8(self.log_channel)?;
|
|
writer.write_u8(self.dds_onehot_sel as u8)?;
|
|
Ok(())
|
|
}
|
|
}
|