occheung
/
artiq
forked from M-Labs/artiq
1
0
Fork 0
Code Pull Requests Activity

rtio: more DMA fixes, better stopping mechanism

This commit is contained in:
Sebastien Bourdeauducq 2016-12-05 15:55:05 +08:00
parent 30bce5ad35
commit a5834765d0
1 changed files with 79 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

108
artiq/gateware/rtio/dma.py
View File

@ -52,8 +52,6 @@ class DMAReader(Module, AutoCSR):
# All numbers in bytes # All numbers in bytes
self.base_address = CSRStorage(aw + data_alignment, self.base_address = CSRStorage(aw + data_alignment,
alignment_bits=data_alignment) alignment_bits=data_alignment)
self.last_address = CSRStorage(aw + data_alignment,
alignment_bits=data_alignment)
# # # # # #
@ -65,18 +63,13 @@ class DMAReader(Module, AutoCSR):
address.address.eq(self.base_address.storage), address.address.eq(self.base_address.storage),
address.eop.eq(0), address.eop.eq(0),
address.stb.eq(1), address.stb.eq(1),
If(self.base_address.storage == self.last_address.storage,
address.eop.eq(1)
)
), ),
If(address.stb & address.ack, If(address.stb & address.ack,
If(address.eop, If(address.eop,
address.stb.eq(0) address.stb.eq(0)
).Else( ).Else(
address.address.eq(address.address + 1), address.address.eq(address.address + 1),
If(~enable | (address.address == self.last_address.storage), If(~enable, address.eop.eq(1))
address.eop.eq(1)
)
) )
) )
] ]
@ -90,12 +83,14 @@ class RawSlicer(Module):
self.source = Signal(out_size*g) self.source = Signal(out_size*g)
self.source_stb = Signal() self.source_stb = Signal()
self.source_consume = Signal(max=out_size+1) self.source_consume = Signal(max=out_size+1)
self.flush = Signal()
self.flush_done = Signal()
# # # # # #
# worst-case buffer space required (when loading): # worst-case buffer space required (when loading):
# <data being shifted out> <new incoming word> <EOP marker> # <data being shifted out> <new incoming word>
buf_size = out_size - 1 + in_size + 1 buf_size = out_size - 1 + in_size
buf = Signal(buf_size*g) buf = Signal(buf_size*g)
self.comb += self.source.eq(buf[:out_size*8]) self.comb += self.source.eq(buf[:out_size*8])
@ -109,9 +104,7 @@ class RawSlicer(Module):
self.sync += [ self.sync += [
If(load_buf, Case(level, If(load_buf, Case(level,
# note how the MSBs of the buffer are set to 0 {i: buf[i*g:(i+in_size)*g].eq(self.sink.data)
# (including the EOP marker position)
{i: buf[i*g:].eq(self.sink.data)
for i in range(out_size)})), for i in range(out_size)})),
If(shift_buf, buf.eq(buf >> self.source_consume*g)) If(shift_buf, buf.eq(buf >> self.source_consume*g))
] ]
@ -123,12 +116,7 @@ class RawSlicer(Module):
self.sink.ack.eq(1), self.sink.ack.eq(1),
load_buf.eq(1), load_buf.eq(1),
If(self.sink.stb, If(self.sink.stb,
If(self.sink.eop,
# insert <granularity> bits of 0 to mark EOP
next_level.eq(level + in_size + 1)
).Else(
next_level.eq(level + in_size) next_level.eq(level + in_size)
)
), ),
If(next_level >= out_size, NextState("OUTPUT")) If(next_level >= out_size, NextState("OUTPUT"))
) )
@ -136,10 +124,20 @@ class RawSlicer(Module):
self.source_stb.eq(1), self.source_stb.eq(1),
shift_buf.eq(1), shift_buf.eq(1),
next_level.eq(level - self.source_consume), next_level.eq(level - self.source_consume),
If(next_level < out_size, NextState("FETCH")) If(next_level < out_size, NextState("FETCH")),
If(self.flush, NextState("FLUSH"))
)
fsm.act("FLUSH",
next_level.eq(0),
self.sink.ack.eq(1),
If(self.sink.stb & self.sink.eop,
self.flush_done.eq(1),
NextState("FETCH")
)
) )
# end marker is a record with length=0
record_layout = [ record_layout = [
("length", 8), # of whole record (header+data) ("length", 8), # of whole record (header+data)
("channel", 24), ("channel", 24),
@ -152,34 +150,61 @@ record_layout = [
class RecordConverter(Module): class RecordConverter(Module):
def __init__(self, stream_slicer): def __init__(self, stream_slicer):
self.source = stream.Endpoint(record_layout) self.source = stream.Endpoint(record_layout)
self.end_marker_found = Signal()
self.flush = Signal()
hdrlen = layout_len(record_layout) - 512
record_raw = Record(record_layout) record_raw = Record(record_layout)
self.comb += [ self.comb += [
record_raw.raw_bits().eq(stream_slicer.source), record_raw.raw_bits().eq(stream_slicer.source),
self.source.channel.eq(record_raw.channel), self.source.channel.eq(record_raw.channel),
self.source.timestamp.eq(record_raw.timestamp), self.source.timestamp.eq(record_raw.timestamp),
self.source.address.eq(record_raw.address), self.source.address.eq(record_raw.address),
self.source.data.eq(record_raw.data), self.source.data.eq(record_raw.data)
]
self.source.stb.eq(stream_slicer.source_stb), fsm = FSM(reset_state="FLOWING")
self.source.eop.eq(record_raw.length == 0), self.submodules += fsm
If(self.source.ack,
fsm.act("FLOWING",
If(stream_slicer.source_stb,
If(record_raw.length == 0, If(record_raw.length == 0,
stream_slicer.source_consume.eq(1) NextState("END_MARKER_FOUND")
).Else( ).Else(
self.source.stb.eq(1)
)
),
If(self.source.ack,
stream_slicer.source_consume.eq(record_raw.length) stream_slicer.source_consume.eq(record_raw.length)
) )
) )
] fsm.act("END_MARKER_FOUND",
self.end_marker_found.eq(1),
If(self.flush,
stream_slicer.flush.eq(1),
NextState("WAIT_FLUSH")
)
)
fsm.act("WAIT_FLUSH",
If(stream_slicer.flush_done,
NextState("SEND_EOP")
)
)
fsm.act("SEND_EOP",
self.source.eop.eq(1),
self.source.stb.eq(1),
If(self.source.ack, NextState("FLOWING"))
)
class RecordSlicer(Module): class RecordSlicer(Module):
def __init__(self, in_size): def __init__(self, in_size):
self.submodules.raw_slicer = RawSlicer( self.submodules.raw_slicer = ResetInserter()(RawSlicer(
in_size//8, layout_len(record_layout)//8, 8) in_size//8, layout_len(record_layout)//8, 8))
self.submodules.record_converter = RecordConverter(self.raw_slicer) self.submodules.record_converter = RecordConverter(self.raw_slicer)
self.end_marker_found = self.record_converter.end_marker_found
self.flush = self.record_converter.flush
self.sink = self.raw_slicer.sink self.sink = self.raw_slicer.sink
self.source = self.record_converter.source self.source = self.record_converter.source
@ -199,6 +224,7 @@ class TimeOffset(Module, AutoCSR):
leave_out={"timestamp"}), leave_out={"timestamp"}),
self.source.payload.timestamp.eq(self.sink.payload.timestamp self.source.payload.timestamp.eq(self.sink.payload.timestamp
+ self.time_offset.storage), + self.time_offset.storage),
self.source.eop.eq(self.sink.eop),
self.source.stb.eq(self.sink.stb) self.source.stb.eq(self.sink.stb)
) )
self.comb += [ self.comb += [
@ -260,7 +286,14 @@ class CRIMaster(Module, AutoCSR):
fsm.act("IDLE", fsm.act("IDLE",
If(self.error_status.status == 0, If(self.error_status.status == 0,
If(self.sink.stb, NextState("WRITE")) If(self.sink.stb,
If(self.sink.eop,
# last packet contains dummy data, discard it
self.sink.ack.eq(1)
).Else(
NextState("WRITE")
)
)
).Else( ).Else(
# discard all data until errors are acked # discard all data until errors are acked
self.sink.ack.eq(1) self.sink.ack.eq(1)
@ -295,9 +328,7 @@ class CRIMaster(Module, AutoCSR):
class DMA(Module): class DMA(Module):
def __init__(self, membus): def __init__(self, membus):
# shutdown procedure: set enable to 0, wait until busy=0 self.enable = CSRStorage(write_from_dev=True)
self.enable = CSRStorage()
self.busy = CSRStatus()
self.submodules.dma = DMAReader(membus, self.enable.storage) self.submodules.dma = DMAReader(membus, self.enable.storage)
self.submodules.slicer = RecordSlicer(len(membus.dat_w)) self.submodules.slicer = RecordSlicer(len(membus.dat_w))
@ -314,17 +345,24 @@ class DMA(Module):
fsm = FSM(reset_state="IDLE") fsm = FSM(reset_state="IDLE")
self.submodules += fsm self.submodules += fsm
self.comb += self.enable.dat_w.eq(0)
fsm.act("IDLE", fsm.act("IDLE",
If(self.enable.storage, NextState("FLOWING")) If(self.enable.storage, NextState("FLOWING"))
) )
fsm.act("FLOWING", fsm.act("FLOWING",
self.busy.status.eq(1), If(self.slicer.end_marker_found, self.enable.we.eq(1)),
If(~self.enable.storage,
self.slicer.flush.eq(1),
NextState("WAIT_EOP")
)
)
fsm.act("WAIT_EOP",
If(self.cri_master.sink.stb & self.cri_master.sink.ack & self.cri_master.sink.eop, If(self.cri_master.sink.stb & self.cri_master.sink.ack & self.cri_master.sink.eop,
NextState("WAIT_CRI_MASTER") NextState("WAIT_CRI_MASTER")
) )
) )
fsm.act("WAIT_CRI_MASTER", fsm.act("WAIT_CRI_MASTER",
self.busy.status.eq(1),
If(~self.cri_master.busy, NextState("IDLE")) If(~self.cri_master.busy, NextState("IDLE"))
) )