From 9e15ff7e6a71a95806b7722112150ba8ef7b44b6 Mon Sep 17 00:00:00 2001
From: Sebastien Bourdeauducq <sb@m-labs.hk>
Date: Mon, 30 Dec 2019 16:56:06 +0800
Subject: [PATCH] wrpll: improve DDMTD deglitcher

---
 artiq/gateware/drtio/wrpll/ddmtd.py | 34 ++++++++++++++++-------------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/artiq/gateware/drtio/wrpll/ddmtd.py b/artiq/gateware/drtio/wrpll/ddmtd.py
index 6068b4dec..f46df4463 100644
--- a/artiq/gateware/drtio/wrpll/ddmtd.py
+++ b/artiq/gateware/drtio/wrpll/ddmtd.py
@@ -44,19 +44,23 @@ class DDMTDSamplerGTP(Module):
         ]
 
 
-class DDMTDEdgeDetector(Module):
-    def __init__(self, input_signal):
-        self.rising = Signal()
+class DDMTDDeglitcherFirstEdge(Module):
+    def __init__(self, input_signal, blind_period=128):
+        self.detect = Signal()
+        self.tag_correction = 0
 
-        history = Signal(4)
-        deglitched = Signal()
-        self.sync.helper += history.eq(Cat(history[1:], input_signal))
-        self.comb += deglitched.eq(input_signal | history[0] | history[1] | history[2] | history[3])
-
-        deglitched_r = Signal()
+        rising = Signal()
+        input_signal_r = Signal()
         self.sync.helper += [
-            deglitched_r.eq(deglitched),
-            self.rising.eq(deglitched & ~deglitched_r)
+            input_signal_r.eq(input_signal),
+            rising.eq(input_signal & ~input_signal_r)
+        ]
+
+        blind_counter = Signal(max=blind_period)
+        self.sync.helper += [
+            If(blind_counter != 0, blind_counter.eq(blind_counter - 1)),
+            If(rising, blind_counter.eq(blind_period - 1)),
+            self.detect.eq(rising & (blind_counter == 0))
         ]
 
 
@@ -71,14 +75,14 @@ class DDMTD(Module, AutoCSR):
 
         # # #
 
-        ed = DDMTDEdgeDetector(input_signal)
-        self.submodules += ed
+        deglitcher = DDMTDDeglitcherFirstEdge(input_signal)
+        self.submodules += deglitcher
 
         self.sync.helper += [
             self.h_tag_update.eq(0),
-            If(ed.rising,
+            If(deglitcher.detect,
                 self.h_tag_update.eq(1),
-                self.h_tag.eq(counter)
+                self.h_tag.eq(counter + deglitcher.tag_correction)
             )
         ]