From 7098854b0f0bf8fb0120aa9c67ee8398efa8fa4a Mon Sep 17 00:00:00 2001
From: Sebastien Bourdeauducq <sb@m-labs.hk>
Date: Wed, 4 Dec 2019 19:05:56 +0800
Subject: [PATCH] wrpll: share DDMTD counter

---
 artiq/gateware/drtio/wrpll/core.py  |  6 ++++--
 artiq/gateware/drtio/wrpll/ddmtd.py | 18 ++++++++----------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/artiq/gateware/drtio/wrpll/core.py b/artiq/gateware/drtio/wrpll/core.py
index ee2099648..81527ae58 100644
--- a/artiq/gateware/drtio/wrpll/core.py
+++ b/artiq/gateware/drtio/wrpll/core.py
@@ -21,5 +21,7 @@ class WRPLL(Module, AutoCSR):
         self.submodules.main_dcxo = Si549(main_dcxo_i2c)
         self.submodules.helper_dcxo = Si549(helper_dxco_i2c)
 
-        self.submodules.ddmtd_helper = DDMTD(N, ddmtd_inputs.rec_clk)
-        self.submodules.ddmtd_main = DDMTD(N, ddmtd_inputs.main_xo)
+        ddmtd_counter = Signal(N)
+        self.sync.helper += ddmtd_counter.eq(ddmtd_counter + 1)
+        self.submodules.ddmtd_helper = DDMTD(ddmtd_counter, ddmtd_inputs.rec_clk)
+        self.submodules.ddmtd_main = DDMTD(ddmtd_counter, ddmtd_inputs.main_xo)
diff --git a/artiq/gateware/drtio/wrpll/ddmtd.py b/artiq/gateware/drtio/wrpll/ddmtd.py
index 3708371b5..d05d0445b 100644
--- a/artiq/gateware/drtio/wrpll/ddmtd.py
+++ b/artiq/gateware/drtio/wrpll/ddmtd.py
@@ -4,13 +4,13 @@ from misoc.interconnect.csr import *
 
 
 class DDMTDEdgeDetector(Module):
-    def __init__(self, i):
+    def __init__(self, input_signal):
         self.rising = Signal()
 
         history = Signal(4)
         deglitched = Signal()
-        self.sync.helper += history.eq(Cat(history[1:], i))
-        self.comb += deglitched.eq(i | history[0] | history[1] | history[2] | history[3])
+        self.sync.helper += history.eq(Cat(history[1:], input_signal))
+        self.comb += deglitched.eq(input_signal | history[0] | history[1] | history[2] | history[3])
 
         deglitched_r = Signal()
         self.sync.helper += [
@@ -20,22 +20,20 @@ class DDMTDEdgeDetector(Module):
 
 
 class DDMTD(Module, AutoCSR):
-    def __init__(self, N, i):
+    def __init__(self, counter, input_signal):
         self.arm = CSR()
-        self.tag = CSRStatus(N)
+        self.tag = CSRStatus(len(counter))
 
         # in helper clock domain
-        self.h_tag = Signal(N)
+        self.h_tag = Signal(len(counter))
         self.h_tag_update = Signal()
 
         # # #
 
-        ed = DDMTDEdgeDetector(i)
+        ed = DDMTDEdgeDetector(input_signal)
         self.submodules += ed
 
-        counter = Signal(N)
         self.sync.helper += [
-            counter.eq(counter + 1),
             self.h_tag_update.eq(0),
             If(ed.rising,
                 self.h_tag_update.eq(1),
@@ -49,7 +47,7 @@ class DDMTD(Module, AutoCSR):
         tag_update = Signal()
         self.sync += tag_update.eq(tag_update_ps.o)
 
-        tag = Signal(N)
+        tag = Signal(len(counter))
         self.h_tag.attr.add("no_retiming")
         self.specials += MultiReg(self.h_tag, tag)