[meta] Update cargo dependencies

Some more rules:

- For module-level imports, prefer no prefix > super > crate.
- Use crate instead of super if super refers to the crate-level module

Cargo.lock

@@ -126,9 +126,9 @@ checksum = "1fd0f2584146f6f2ef48085050886acf353beff7305ebd1ae69500e27c67f64b"
 
 [[package]]
 name = "cc"
-version = "1.1.24"
+version = "1.1.30"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "812acba72f0a070b003d3697490d2b55b837230ae7c6c6497f05cc2ddbb8d938"
+checksum = "b16803a61b81d9eabb7eae2588776c4c1e584b738ede45fdbb4c972cec1e9945"
 dependencies = [
  "shlex",
 ]
@@ -141,9 +141,9 @@ checksum = "baf1de4339761588bc0619e3cbc0120ee582ebb74b53b4efbf79117bd2da40fd"
 
 [[package]]
 name = "clap"
-version = "4.5.19"
+version = "4.5.20"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7be5744db7978a28d9df86a214130d106a89ce49644cbc4e3f0c22c3fba30615"
+checksum = "b97f376d85a664d5837dbae44bf546e6477a679ff6610010f17276f686d867e8"
 dependencies = [
  "clap_builder",
  "clap_derive",
@@ -151,9 +151,9 @@ dependencies = [
 
 [[package]]
 name = "clap_builder"
-version = "4.5.19"
+version = "4.5.20"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "a5fbc17d3ef8278f55b282b2a2e75ae6f6c7d4bb70ed3d0382375104bfafdb4b"
+checksum = "19bc80abd44e4bed93ca373a0704ccbd1b710dc5749406201bb018272808dc54"
 dependencies = [
  "anstream",
  "anstyle",
@@ -547,9 +547,9 @@ checksum = "bbd2bcb4c963f2ddae06a2efc7e9f3591312473c50c6685e1f298068316e66fe"
 
 [[package]]
 name = "libc"
-version = "0.2.159"
+version = "0.2.161"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "561d97a539a36e26a9a5fad1ea11a3039a67714694aaa379433e580854bc3dc5"
+checksum = "8e9489c2807c139ffd9c1794f4af0ebe86a828db53ecdc7fea2111d0fed085d1"
 
 [[package]]
 name = "libloading"
@@ -698,12 +698,9 @@ checksum = "650eef8c711430f1a879fdd01d4745a7deea475becfb90269c06775983bbf086"
 
 [[package]]
 name = "once_cell"
-version = "1.20.1"
+version = "1.20.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "82881c4be219ab5faaf2ad5e5e5ecdff8c66bd7402ca3160975c93b24961afd1"
-dependencies = [
- "portable-atomic",
-]
+checksum = "1261fe7e33c73b354eab43b1273a57c8f967d0391e80353e51f764ac02cf6775"
 
 [[package]]
 name = "parking_lot"
@@ -828,9 +825,9 @@ checksum = "925383efa346730478fb4838dbe9137d2a47675ad789c546d150a6e1dd4ab31c"
 
 [[package]]
 name = "proc-macro2"
-version = "1.0.86"
+version = "1.0.88"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5e719e8df665df0d1c8fbfd238015744736151d4445ec0836b8e628aae103b77"
+checksum = "7c3a7fc5db1e57d5a779a352c8cdb57b29aa4c40cc69c3a68a7fedc815fbf2f9"
 dependencies = [
  "unicode-ident",
 ]
@@ -1017,9 +1014,9 @@ dependencies = [
 
 [[package]]
 name = "rustversion"
-version = "1.0.17"
+version = "1.0.18"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "955d28af4278de8121b7ebeb796b6a45735dc01436d898801014aced2773a3d6"
+checksum = "0e819f2bc632f285be6d7cd36e25940d45b2391dd6d9b939e79de557f7014248"
 
 [[package]]
 name = "ryu"
@@ -1070,9 +1067,9 @@ dependencies = [
 
 [[package]]
 name = "serde_json"
-version = "1.0.128"
+version = "1.0.129"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6ff5456707a1de34e7e37f2a6fd3d3f808c318259cbd01ab6377795054b483d8"
+checksum = "6dbcf9b78a125ee667ae19388837dd12294b858d101fdd393cb9d5501ef09eb2"
 dependencies = [
  "itoa",
  "memchr",

nac3artiq/src/codegen.rs

@@ -37,7 +37,7 @@ use nac3core::{
     typecheck::typedef::{iter_type_vars, FunSignature, FuncArg, Type, TypeEnum, VarMap},
 };
 
-use crate::{symbol_resolver::InnerResolver, timeline::TimeFns};
+use super::{symbol_resolver::InnerResolver, timeline::TimeFns};
 
 /// The parallelism mode within a block.
 #[derive(Copy, Clone, Eq, PartialEq)]

nac3artiq/src/lib.rs

@@ -65,13 +65,11 @@ use nac3core::{
 };
 use nac3ld::Linker;
 
-use crate::{
-    codegen::{
-        attributes_writeback, gen_core_log, gen_rtio_log, rpc_codegen_callback, ArtiqCodeGenerator,
-    },
-    symbol_resolver::{DeferredEvaluationStore, InnerResolver, PythonHelper, Resolver},
-    timeline::TimeFns,
+use codegen::{
+    attributes_writeback, gen_core_log, gen_rtio_log, rpc_codegen_callback, ArtiqCodeGenerator,
 };
+use symbol_resolver::{DeferredEvaluationStore, InnerResolver, PythonHelper, Resolver};
+use timeline::TimeFns;
 
 mod codegen;
 mod symbol_resolver;

nac3artiq/src/symbol_resolver.rs

@@ -37,7 +37,7 @@ use nac3core::{
     },
 };
 
-use crate::PrimitivePythonId;
+use super::PrimitivePythonId;
 
 pub enum PrimitiveValue {
     I32(i32),

nac3core/src/codegen/builtin_fns.rs

@@ -5,24 +5,23 @@ use inkwell::{
 };
 use itertools::Itertools;
 
-use crate::{
-    codegen::{
-        classes::{
-            ArrayLikeValue, NDArrayValue, ProxyValue, RangeValue, TypedArrayLikeAccessor,
-            UntypedArrayLikeAccessor, UntypedArrayLikeMutator,
-        },
-        expr::destructure_range,
-        extern_fns, irrt,
-        irrt::calculate_len_for_slice_range,
-        llvm_intrinsics,
-        macros::codegen_unreachable,
-        numpy,
-        numpy::ndarray_elementwise_unaryop_impl,
-        stmt::gen_for_callback_incrementing,
-        CodeGenContext, CodeGenerator,
+use super::{
+    classes::{
+        ArrayLikeValue, NDArrayValue, ProxyValue, RangeValue, TypedArrayLikeAccessor,
+        UntypedArrayLikeAccessor, UntypedArrayLikeMutator,
     },
-    toplevel::helper::PrimDef,
-    toplevel::numpy::unpack_ndarray_var_tys,
+    expr::destructure_range,
+    extern_fns, irrt,
+    irrt::calculate_len_for_slice_range,
+    llvm_intrinsics,
+    macros::codegen_unreachable,
+    numpy,
+    numpy::ndarray_elementwise_unaryop_impl,
+    stmt::gen_for_callback_incrementing,
+    CodeGenContext, CodeGenerator,
+};
+use crate::{
+    toplevel::{helper::PrimDef, numpy::unpack_ndarray_var_tys},
     typecheck::typedef::{Type, TypeEnum},
 };
 

nac3core/src/codegen/classes.rs

@@ -5,7 +5,7 @@ use inkwell::{
     AddressSpace, IntPredicate,
 };
 
-use crate::codegen::{
+use super::{
     irrt::{call_ndarray_calc_size, call_ndarray_flatten_index},
     llvm_intrinsics::call_int_umin,
     stmt::gen_for_callback_incrementing,

nac3core/src/codegen/expr.rs

@@ -18,27 +18,27 @@ use nac3parser::ast::{
     Unaryop,
 };
 
-use crate::{
-    codegen::{
-        classes::{
-            ArrayLikeIndexer, ArrayLikeValue, ListType, ListValue, NDArrayValue, ProxyType,
-            ProxyValue, RangeValue, TypedArrayLikeAccessor, UntypedArrayLikeAccessor,
-        },
-        concrete_type::{ConcreteFuncArg, ConcreteTypeEnum, ConcreteTypeStore},
-        gen_in_range_check, get_llvm_abi_type, get_llvm_type, get_va_count_arg_name,
-        irrt::*,
-        llvm_intrinsics::{
-            call_expect, call_float_floor, call_float_pow, call_float_powi, call_int_smax,
-            call_int_umin, call_memcpy_generic,
-        },
-        macros::codegen_unreachable,
-        need_sret, numpy,
-        stmt::{
-            gen_for_callback_incrementing, gen_if_callback, gen_if_else_expr_callback, gen_raise,
-            gen_var,
-        },
-        CodeGenContext, CodeGenTask, CodeGenerator,
+use super::{
+    classes::{
+        ArrayLikeIndexer, ArrayLikeValue, ListType, ListValue, NDArrayValue, ProxyType, ProxyValue,
+        RangeValue, TypedArrayLikeAccessor, UntypedArrayLikeAccessor,
     },
+    concrete_type::{ConcreteFuncArg, ConcreteTypeEnum, ConcreteTypeStore},
+    gen_in_range_check, get_llvm_abi_type, get_llvm_type, get_va_count_arg_name,
+    irrt::*,
+    llvm_intrinsics::{
+        call_expect, call_float_floor, call_float_pow, call_float_powi, call_int_smax,
+        call_int_umin, call_memcpy_generic,
+    },
+    macros::codegen_unreachable,
+    need_sret, numpy,
+    stmt::{
+        gen_for_callback_incrementing, gen_if_callback, gen_if_else_expr_callback, gen_raise,
+        gen_var,
+    },
+    CodeGenContext, CodeGenTask, CodeGenerator,
+};
+use crate::{
     symbol_resolver::{SymbolValue, ValueEnum},
     toplevel::{
         helper::PrimDef,
@@ -2886,7 +2886,31 @@ pub fn gen_expr<'ctx, G: CodeGenerator>(
             Some((_, Some(static_value), _)) => ValueEnum::Static(static_value.clone()),
             None => {
                 let resolver = ctx.resolver.clone();
-                resolver.get_symbol_value(*id, ctx, generator).unwrap()
+                let value = resolver.get_symbol_value(*id, ctx, generator).unwrap();
+
+                let globals = ctx
+                    .top_level
+                    .definitions
+                    .read()
+                    .iter()
+                    .filter_map(|def| {
+                        if let TopLevelDef::Variable { simple_name, ty, .. } = &*def.read() {
+                            Some((*simple_name, *ty))
+                        } else {
+                            None
+                        }
+                    })
+                    .collect_vec();
+
+                if let Some((_, ty)) = globals.iter().find(|(name, _)| name == id) {
+                    let ptr = value
+                        .to_basic_value_enum(ctx, generator, *ty)
+                        .map(BasicValueEnum::into_pointer_value)?;
+
+                    ctx.builder.build_load(ptr, id.to_string().as_str()).map(Into::into).unwrap()
+                } else {
+                    value
+                }
             }
         },
         ExprKind::List { elts, .. } => {

nac3core/src/codegen/extern_fns.rs

@@ -4,7 +4,7 @@ use inkwell::{
 };
 use itertools::Either;
 
-use crate::codegen::CodeGenContext;
+use super::CodeGenContext;
 
 /// Macro to generate extern function
 /// Both function return type and function parameter type are `FloatValue`

nac3core/src/codegen/generator.rs

@@ -6,8 +6,8 @@ use inkwell::{
 
 use nac3parser::ast::{Expr, Stmt, StrRef};
 
+use super::{bool_to_i1, bool_to_i8, classes::ArraySliceValue, expr::*, stmt::*, CodeGenContext};
 use crate::{
-    codegen::{bool_to_i1, bool_to_i8, classes::ArraySliceValue, expr::*, stmt::*, CodeGenContext},
     symbol_resolver::ValueEnum,
     toplevel::{DefinitionId, TopLevelDef},
     typecheck::typedef::{FunSignature, Type},

nac3core/src/codegen/llvm_intrinsics.rs

@@ -7,7 +7,7 @@ use inkwell::{
 };
 use itertools::Either;
 
-use crate::codegen::CodeGenContext;
+use super::CodeGenContext;
 
 /// Returns the string representation for the floating-point type `ft` when used in intrinsic
 /// functions.

nac3core/src/codegen/mod.rs

@@ -29,7 +29,6 @@ use parking_lot::{Condvar, Mutex};
 use nac3parser::ast::{Location, Stmt, StrRef};
 
 use crate::{
-    codegen::classes::{ListType, NDArrayType, ProxyType, RangeType},
     symbol_resolver::{StaticValue, SymbolResolver},
     toplevel::{helper::PrimDef, numpy::unpack_ndarray_var_tys, TopLevelContext, TopLevelDef},
     typecheck::{
@@ -37,6 +36,9 @@ use crate::{
         typedef::{CallId, FuncArg, Type, TypeEnum, Unifier},
     },
 };
+use classes::{ListType, NDArrayType, ProxyType, RangeType};
+use concrete_type::{ConcreteType, ConcreteTypeEnum, ConcreteTypeStore};
+pub use generator::{CodeGenerator, DefaultCodeGenerator};
 
 pub mod builtin_fns;
 pub mod classes;
@@ -52,9 +54,6 @@ pub mod stmt;
 #[cfg(test)]
 mod test;
 
-use concrete_type::{ConcreteType, ConcreteTypeEnum, ConcreteTypeStore};
-pub use generator::{CodeGenerator, DefaultCodeGenerator};
-
 mod macros {
     /// Codegen-variant of [`std::unreachable`] which accepts an instance of [`CodeGenContext`] as
     /// its first argument to provide Python source information to indicate the codegen location

nac3core/src/codegen/numpy.rs

@@ -6,24 +6,23 @@ use inkwell::{
 
 use nac3parser::ast::{Operator, StrRef};
 
-use crate::{
-    codegen::{
-        classes::{
-            ArrayLikeIndexer, ArrayLikeValue, ListType, ListValue, NDArrayType, NDArrayValue,
-            ProxyType, ProxyValue, TypedArrayLikeAccessor, TypedArrayLikeAdapter,
-            TypedArrayLikeMutator, UntypedArrayLikeAccessor, UntypedArrayLikeMutator,
-        },
-        expr::gen_binop_expr_with_values,
-        irrt::{
-            calculate_len_for_slice_range, call_ndarray_calc_broadcast,
-            call_ndarray_calc_broadcast_index, call_ndarray_calc_nd_indices,
-            call_ndarray_calc_size,
-        },
-        llvm_intrinsics::{self, call_memcpy_generic},
-        macros::codegen_unreachable,
-        stmt::{gen_for_callback_incrementing, gen_for_range_callback, gen_if_else_expr_callback},
-        CodeGenContext, CodeGenerator,
+use super::{
+    classes::{
+        ArrayLikeIndexer, ArrayLikeValue, ListType, ListValue, NDArrayType, NDArrayValue,
+        ProxyType, ProxyValue, TypedArrayLikeAccessor, TypedArrayLikeAdapter,
+        TypedArrayLikeMutator, UntypedArrayLikeAccessor, UntypedArrayLikeMutator,
     },
+    expr::gen_binop_expr_with_values,
+    irrt::{
+        calculate_len_for_slice_range, call_ndarray_calc_broadcast,
+        call_ndarray_calc_broadcast_index, call_ndarray_calc_nd_indices, call_ndarray_calc_size,
+    },
+    llvm_intrinsics::{self, call_memcpy_generic},
+    macros::codegen_unreachable,
+    stmt::{gen_for_callback_incrementing, gen_for_range_callback, gen_if_else_expr_callback},
+    CodeGenContext, CodeGenerator,
+};
+use crate::{
     symbol_resolver::ValueEnum,
     toplevel::{
         helper::PrimDef,

nac3core/src/codegen/test.rs

@@ -15,13 +15,13 @@ use nac3parser::{
 };
 use parking_lot::RwLock;
 
+use super::{
+    classes::{ListType, NDArrayType, ProxyType, RangeType},
+    concrete_type::ConcreteTypeStore,
+    CodeGenContext, CodeGenLLVMOptions, CodeGenTargetMachineOptions, CodeGenTask, CodeGenerator,
+    DefaultCodeGenerator, WithCall, WorkerRegistry,
+};
 use crate::{
-    codegen::{
-        classes::{ListType, NDArrayType, ProxyType, RangeType},
-        concrete_type::ConcreteTypeStore,
-        CodeGenContext, CodeGenLLVMOptions, CodeGenTargetMachineOptions, CodeGenTask,
-        CodeGenerator, DefaultCodeGenerator, WithCall, WorkerRegistry,
-    },
     symbol_resolver::{SymbolResolver, ValueEnum},
     toplevel::{
         composer::{ComposerConfig, TopLevelComposer},

nac3core/src/toplevel/builtins.rs

@@ -11,7 +11,8 @@ use itertools::Either;
 use strum::IntoEnumIterator;
 
 use super::{
-    helper::{debug_assert_prim_is_allowed, make_exception_fields, PrimDefDetails},
+    helper::{debug_assert_prim_is_allowed, make_exception_fields, PrimDef, PrimDefDetails},
+    numpy::make_ndarray_ty,
     *,
 };
 use crate::{
@@ -22,7 +23,6 @@ use crate::{
         stmt::exn_constructor,
     },
     symbol_resolver::SymbolValue,
-    toplevel::{helper::PrimDef, numpy::make_ndarray_ty},
     typecheck::typedef::{into_var_map, iter_type_vars, TypeVar, VarMap},
 };
 

nac3core/src/toplevel/composer.rs

@@ -1,6 +1,6 @@
 use std::rc::Rc;
 
-use nac3parser::ast::{fold::Fold, ExprKind};
+use nac3parser::ast::{fold::Fold, ExprKind, Ident};
 
 use super::*;
 use crate::{
@@ -382,54 +382,34 @@ impl TopLevelComposer {
                 ))
             }
 
+            ast::StmtKind::Assign { .. } => {
+                // Assignment statements can assign to (and therefore create) more than one 
+                // variable, but this function only allows returning one set of symbol information.
+                // We want to avoid changing this to return a `Vec` of symbol info, as this would 
+                // require `iter().next().unwrap()` on every variable created from a non-Assign 
+                // statement.
+                //
+                // Make callers use `register_top_level_var` instead, as it provides more
+                // fine-grained control over which symbols to register, while also simplifying the
+                // usage of this function.
+                panic!("Registration of top-level Assign statements must use TopLevelComposer::register_top_level_var (at {})", ast.location);
+            }
+
             ast::StmtKind::AnnAssign { target, annotation, .. } => {
                 let ExprKind::Name { id: name, .. } = target.node else {
                     return Err(format!(
                         "global variable declaration must be an identifier (at {})",
-                        ast.location
+                        target.location
                     ));
                 };
 
-                if self.keyword_list.contains(&name) {
-                    return Err(format!(
-                        "cannot use keyword `{}` as a class name (at {})",
-                        name,
-                        ast.location
-                    ));
-                }
-
-                let global_var_name = if mod_path.is_empty() {
-                    name.to_string()
-                } else {
-                    format!("{mod_path}.{name}")
-                };
-                if !defined_names.insert(global_var_name.clone()) {
-                    return Err(format!(
-                        "global variable `{}` defined twice (at {})",
-                        global_var_name,
-                        ast.location
-                    ));
-                }
-
-                let ty_to_be_unified = self.unifier.get_dummy_var().ty;
-                self.definition_ast_list.push((
-                    RwLock::new(Self::make_top_level_variable_def(
-                        global_var_name,
-                        name,
-                        // dummy here, unify with correct type later,
-                        ty_to_be_unified,
-                        *(annotation.clone()),
-                        resolver,
-                        Some(ast.location),
-                    )).into(),
-                    None,
-                ));
-
-                Ok((
+                self.register_top_level_var(
                     name,
-                    DefinitionId(self.definition_ast_list.len() - 1),
-                    Some(ty_to_be_unified),
-                ))
+                    Some(annotation.as_ref().clone()),
+                    resolver,
+                    mod_path,
+                    target.location,
+                )
             }
 
             _ => Err(format!(
@@ -439,6 +419,50 @@ impl TopLevelComposer {
         }
     }
 
+    /// Registers a top-level variable with the given `name` into the composer.
+    ///
+    /// `annotation` - The type annotation of the top-level variable, or [`None`] if no type
+    /// annotation is provided.
+    /// `location` - The location of the top-level variable.
+    pub fn register_top_level_var(
+        &mut self,
+        name: Ident,
+        annotation: Option<Expr>,
+        resolver: Option<Arc<dyn SymbolResolver + Send + Sync>>,
+        mod_path: &str,
+        location: Location,
+    ) -> Result<(StrRef, DefinitionId, Option<Type>), String> {
+        if self.keyword_list.contains(&name) {
+            return Err(format!("cannot use keyword `{name}` as a class name (at {location})"));
+        }
+
+        let global_var_name =
+            if mod_path.is_empty() { name.to_string() } else { format!("{mod_path}.{name}") };
+
+        if !self.defined_names.insert(global_var_name.clone()) {
+            return Err(format!(
+                "global variable `{global_var_name}` defined twice (at {location})"
+            ));
+        }
+
+        let ty_to_be_unified = self.unifier.get_dummy_var().ty;
+        self.definition_ast_list.push((
+            RwLock::new(Self::make_top_level_variable_def(
+                global_var_name,
+                name,
+                // dummy here, unify with correct type later,
+                ty_to_be_unified,
+                annotation,
+                resolver,
+                Some(location),
+            ))
+            .into(),
+            None,
+        ));
+
+        Ok((name, DefinitionId(self.definition_ast_list.len() - 1), Some(ty_to_be_unified)))
+    }
+
     pub fn start_analysis(&mut self, inference: bool) -> Result<(), HashSet<String>> {
         self.analyze_top_level_class_type_var()?;
         self.analyze_top_level_class_bases()?;
@@ -485,7 +509,7 @@ impl TopLevelComposer {
                     // things like `class A(Generic[T, V, ImportedModule.T])` is not supported
                     // i.e. only simple names are allowed in the subscript
                     // should update the TopLevelDef::Class.typevars and the TypeEnum::TObj.params
-                    ast::ExprKind::Subscript { value, slice, .. }
+                    ExprKind::Subscript { value, slice, .. }
                         if {
                             matches!(
                                 &value.node,
@@ -501,9 +525,9 @@ impl TopLevelComposer {
                         }
                         is_generic = true;
 
-                        let type_var_list: Vec<&ast::Expr<()>>;
+                        let type_var_list: Vec<&Expr<()>>;
                         // if `class A(Generic[T, V, G])`
-                        if let ast::ExprKind::Tuple { elts, .. } = &slice.node {
+                        if let ExprKind::Tuple { elts, .. } = &slice.node {
                             type_var_list = elts.iter().collect_vec();
                         // `class A(Generic[T])`
                         } else {
@@ -1014,18 +1038,18 @@ impl TopLevelComposer {
                     }
                 }
 
-                let arg_with_default: Vec<(&ast::Located<ast::ArgData<()>>, Option<&ast::Expr>)> =
-                    args.args
-                        .iter()
-                        .rev()
-                        .zip(
-                            args.defaults
-                                .iter()
-                                .rev()
-                                .map(|x| -> Option<&ast::Expr> { Some(x) })
-                                .chain(std::iter::repeat(None)),
-                        )
-                        .collect_vec();
+                let arg_with_default: Vec<(&ast::Located<ast::ArgData<()>>, Option<&Expr>)> = args
+                    .args
+                    .iter()
+                    .rev()
+                    .zip(
+                        args.defaults
+                            .iter()
+                            .rev()
+                            .map(|x| -> Option<&Expr> { Some(x) })
+                            .chain(std::iter::repeat(None)),
+                    )
+                    .collect_vec();
 
                 arg_with_default
                     .iter()
@@ -1283,7 +1307,7 @@ impl TopLevelComposer {
 
                         let arg_with_default: Vec<(
                             &ast::Located<ast::ArgData<()>>,
-                            Option<&ast::Expr>,
+                            Option<&Expr>,
                         )> = args
                             .args
                             .iter()
@@ -1292,7 +1316,7 @@ impl TopLevelComposer {
                                 args.defaults
                                     .iter()
                                     .rev()
-                                    .map(|x| -> Option<&ast::Expr> { Some(x) })
+                                    .map(|x| -> Option<&Expr> { Some(x) })
                                     .chain(std::iter::repeat(None)),
                             )
                             .collect_vec();
@@ -1449,7 +1473,7 @@ impl TopLevelComposer {
                         .map_err(|e| HashSet::from([e.to_display(unifier).to_string()]))?;
                 }
                 ast::StmtKind::AnnAssign { target, annotation, value, .. } => {
-                    if let ast::ExprKind::Name { id: attr, .. } = &target.node {
+                    if let ExprKind::Name { id: attr, .. } = &target.node {
                         if defined_fields.insert(attr.to_string()) {
                             let dummy_field_type = unifier.get_dummy_var().ty;
 
@@ -1457,7 +1481,7 @@ impl TopLevelComposer {
                                 None => {
                                     // handle Kernel[T], KernelInvariant[T]
                                     let (annotation, mutable) = match &annotation.node {
-                                        ast::ExprKind::Subscript { value, slice, .. }
+                                        ExprKind::Subscript { value, slice, .. }
                                             if matches!(
                                                 &value.node,
                                                 ast::ExprKind::Name { id, .. } if id == &core_config.kernel_invariant_ann.into()
@@ -1465,7 +1489,7 @@ impl TopLevelComposer {
                                         {
                                             (slice, false)
                                         }
-                                        ast::ExprKind::Subscript { value, slice, .. }
+                                        ExprKind::Subscript { value, slice, .. }
                                             if matches!(
                                                 &value.node,
                                                 ast::ExprKind::Name { id, .. } if core_config.kernel_ann.map_or(false, |c| id == &c.into())
@@ -1483,13 +1507,13 @@ impl TopLevelComposer {
                                 Some(boxed_expr) => {
                                     // Class attributes are set as immutable regardless
                                     let (annotation, _) = match &annotation.node {
-                                        ast::ExprKind::Subscript { slice, .. } => (slice, false),
+                                        ExprKind::Subscript { slice, .. } => (slice, false),
                                         _ if core_config.kernel_ann.is_none() => (annotation, false),
                                         _ => continue,
                                     };
 
                                     match &**boxed_expr {
-                                        ast::Located {location: _, custom: (), node: ast::ExprKind::Constant { value: v, kind: _ }} => {
+                                        ast::Located {location: _, custom: (), node: ExprKind::Constant { value: v, kind: _ }} => {
                                             // Restricting the types allowed to be defined as class attributes
                                             match v {
                                                 ast::Constant::Bool(_) | ast::Constant::Str(_) | ast::Constant::Int(_) | ast::Constant::Float(_) => {}
@@ -1937,284 +1961,296 @@ impl TopLevelComposer {
             if ast.is_none() {
                 return Ok(());
             }
-            let mut function_def = def.write();
-            if let TopLevelDef::Function {
-                instance_to_stmt,
-                instance_to_symbol,
-                name,
-                simple_name,
-                signature,
-                resolver,
-                ..
-            } = &mut *function_def
-            {
-                let signature_ty_enum = unifier.get_ty(*signature);
-                let TypeEnum::TFunc(FunSignature { args, ret, vars, .. }) =
-                    signature_ty_enum.as_ref()
+
+            let (name, simple_name, signature, resolver) = {
+                let function_def = def.read();
+                let TopLevelDef::Function { name, simple_name, signature, resolver, .. } =
+                    &*function_def
                 else {
-                    unreachable!("must be typeenum::tfunc")
+                    return Ok(());
                 };
 
-                let mut vars = vars.clone();
-                // None if is not class method
-                let uninst_self_type = {
-                    if let Some(class_id) = method_class.get(&DefinitionId(id)) {
-                        let class_def = definition_ast_list.get(class_id.0).unwrap();
-                        let class_def = class_def.0.read();
-                        let TopLevelDef::Class { type_vars, .. } = &*class_def else {
-                            unreachable!("must be class def")
+                (name.clone(), *simple_name, *signature, resolver.clone())
+            };
+
+            let signature_ty_enum = unifier.get_ty(signature);
+            let TypeEnum::TFunc(FunSignature { args, ret, vars, .. }) = signature_ty_enum.as_ref()
+            else {
+                unreachable!("must be typeenum::tfunc")
+            };
+
+            let mut vars = vars.clone();
+            // None if is not class method
+            let uninst_self_type = {
+                if let Some(class_id) = method_class.get(&DefinitionId(id)) {
+                    let class_def = definition_ast_list.get(class_id.0).unwrap();
+                    let class_def = class_def.0.read();
+                    let TopLevelDef::Class { type_vars, .. } = &*class_def else {
+                        unreachable!("must be class def")
+                    };
+
+                    let ty_ann = make_self_type_annotation(type_vars, *class_id);
+                    let self_ty = get_type_from_type_annotation_kinds(
+                        &def_list,
+                        unifier,
+                        primitives_ty,
+                        &ty_ann,
+                        &mut None,
+                    )?;
+                    vars.extend(type_vars.iter().map(|ty| {
+                        let TypeEnum::TVar { id, .. } = &*unifier.get_ty(*ty) else {
+                            unreachable!()
                         };
 
-                        let ty_ann = make_self_type_annotation(type_vars, *class_id);
-                        let self_ty = get_type_from_type_annotation_kinds(
-                            &def_list,
-                            unifier,
-                            primitives_ty,
-                            &ty_ann,
-                            &mut None,
-                        )?;
-                        vars.extend(type_vars.iter().map(|ty| {
-                            let TypeEnum::TVar { id, .. } = &*unifier.get_ty(*ty) else {
+                        (*id, *ty)
+                    }));
+                    Some((self_ty, type_vars.clone()))
+                } else {
+                    None
+                }
+            };
+            // carefully handle those with bounds, without bounds and no typevars
+            // if class methods, `vars` also contains all class typevars here
+            let (type_var_subst_comb, no_range_vars) = {
+                let mut no_ranges: Vec<Type> = Vec::new();
+                let var_combs = vars
+                    .values()
+                    .map(|ty| {
+                        unifier.get_instantiations(*ty).unwrap_or_else(|| {
+                            let TypeEnum::TVar { name, loc, is_const_generic: false, .. } =
+                                &*unifier.get_ty(*ty)
+                            else {
                                 unreachable!()
                             };
 
-                            (*id, *ty)
-                        }));
-                        Some((self_ty, type_vars.clone()))
-                    } else {
-                        None
-                    }
-                };
-                // carefully handle those with bounds, without bounds and no typevars
-                // if class methods, `vars` also contains all class typevars here
-                let (type_var_subst_comb, no_range_vars) = {
-                    let mut no_ranges: Vec<Type> = Vec::new();
-                    let var_combs = vars
-                        .values()
-                        .map(|ty| {
-                            unifier.get_instantiations(*ty).unwrap_or_else(|| {
-                                let TypeEnum::TVar { name, loc, is_const_generic: false, .. } =
-                                    &*unifier.get_ty(*ty)
-                                else {
-                                    unreachable!()
-                                };
-
-                                let rigid = unifier.get_fresh_rigid_var(*name, *loc).ty;
-                                no_ranges.push(rigid);
-                                vec![rigid]
-                            })
+                            let rigid = unifier.get_fresh_rigid_var(*name, *loc).ty;
+                            no_ranges.push(rigid);
+                            vec![rigid]
                         })
-                        .multi_cartesian_product()
-                        .collect_vec();
-                    let mut result: Vec<VarMap> = Vec::default();
-                    for comb in var_combs {
-                        result.push(vars.keys().copied().zip(comb).collect());
+                    })
+                    .multi_cartesian_product()
+                    .collect_vec();
+                let mut result: Vec<VarMap> = Vec::default();
+                for comb in var_combs {
+                    result.push(vars.keys().copied().zip(comb).collect());
+                }
+                // NOTE: if is empty, means no type var, append a empty subst, ok to do this?
+                if result.is_empty() {
+                    result.push(VarMap::new());
+                }
+                (result, no_ranges)
+            };
+
+            for subst in type_var_subst_comb {
+                // for each instance
+                let inst_ret = unifier.subst(*ret, &subst).unwrap_or(*ret);
+                let inst_args = {
+                    args.iter()
+                        .map(|a| FuncArg {
+                            name: a.name,
+                            ty: unifier.subst(a.ty, &subst).unwrap_or(a.ty),
+                            default_value: a.default_value.clone(),
+                            is_vararg: false,
+                        })
+                        .collect_vec()
+                };
+                let self_type = {
+                    uninst_self_type.clone().map(|(self_type, type_vars)| {
+                        let subst_for_self = {
+                            let class_ty_var_ids = type_vars
+                                .iter()
+                                .map(|x| {
+                                    if let TypeEnum::TVar { id, .. } = &*unifier.get_ty(*x) {
+                                        *id
+                                    } else {
+                                        unreachable!("must be type var here");
+                                    }
+                                })
+                                .collect::<HashSet<_>>();
+                            subst
+                                .iter()
+                                .filter_map(|(ty_var_id, ty_var_target)| {
+                                    if class_ty_var_ids.contains(ty_var_id) {
+                                        Some((*ty_var_id, *ty_var_target))
+                                    } else {
+                                        None
+                                    }
+                                })
+                                .collect::<VarMap>()
+                        };
+                        unifier.subst(self_type, &subst_for_self).unwrap_or(self_type)
+                    })
+                };
+                let mut identifiers = {
+                    let mut result = HashMap::new();
+                    if self_type.is_some() {
+                        result.insert("self".into(), IdentifierInfo::default());
                     }
-                    // NOTE: if is empty, means no type var, append a empty subst, ok to do this?
-                    if result.is_empty() {
-                        result.push(VarMap::new());
-                    }
-                    (result, no_ranges)
+                    result.extend(inst_args.iter().map(|x| (x.name, IdentifierInfo::default())));
+                    result
+                };
+                let mut calls: HashMap<CodeLocation, CallId> = HashMap::new();
+                let mut inferencer = Inferencer {
+                    top_level: ctx.as_ref(),
+                    defined_identifiers: identifiers.clone(),
+                    function_data: &mut FunctionData {
+                        resolver: resolver.as_ref().unwrap().clone(),
+                        return_type: if unifier.unioned(inst_ret, primitives_ty.none) {
+                            None
+                        } else {
+                            Some(inst_ret)
+                        },
+                        // NOTE: allowed type vars
+                        bound_variables: no_range_vars.clone(),
+                    },
+                    unifier,
+                    variable_mapping: {
+                        let mut result: HashMap<StrRef, Type> = HashMap::new();
+                        if let Some(self_ty) = self_type {
+                            result.insert("self".into(), self_ty);
+                        }
+                        result.extend(inst_args.iter().map(|x| (x.name, x.ty)));
+                        result
+                    },
+                    primitives: primitives_ty,
+                    virtual_checks: &mut Vec::new(),
+                    calls: &mut calls,
+                    in_handler: false,
                 };
 
-                for subst in type_var_subst_comb {
-                    // for each instance
-                    let inst_ret = unifier.subst(*ret, &subst).unwrap_or(*ret);
-                    let inst_args = {
-                        args.iter()
-                            .map(|a| FuncArg {
-                                name: a.name,
-                                ty: unifier.subst(a.ty, &subst).unwrap_or(a.ty),
-                                default_value: a.default_value.clone(),
-                                is_vararg: false,
-                            })
-                            .collect_vec()
-                    };
-                    let self_type = {
-                        uninst_self_type.clone().map(|(self_type, type_vars)| {
-                            let subst_for_self = {
-                                let class_ty_var_ids = type_vars
-                                    .iter()
-                                    .map(|x| {
-                                        if let TypeEnum::TVar { id, .. } = &*unifier.get_ty(*x) {
-                                            *id
-                                        } else {
-                                            unreachable!("must be type var here");
-                                        }
-                                    })
-                                    .collect::<HashSet<_>>();
-                                subst
-                                    .iter()
-                                    .filter_map(|(ty_var_id, ty_var_target)| {
-                                        if class_ty_var_ids.contains(ty_var_id) {
-                                            Some((*ty_var_id, *ty_var_target))
-                                        } else {
-                                            None
-                                        }
-                                    })
-                                    .collect::<VarMap>()
+                let ast::StmtKind::FunctionDef { body, decorator_list, .. } =
+                    ast.clone().unwrap().node
+                else {
+                    unreachable!("must be function def ast")
+                };
+
+                if !decorator_list.is_empty() {
+                    if matches!(&decorator_list[0].node, ExprKind::Name { id, .. } if id == &"extern".into())
+                    {
+                        let TopLevelDef::Function { instance_to_symbol, .. } = &mut *def.write()
+                        else {
+                            unreachable!()
+                        };
+                        instance_to_symbol.insert(String::new(), simple_name.to_string());
+                        continue;
+                    }
+
+                    if matches!(&decorator_list[0].node, ExprKind::Name { id, .. } if id == &"rpc".into())
+                    {
+                        let TopLevelDef::Function { instance_to_symbol, .. } = &mut *def.write()
+                        else {
+                            unreachable!()
+                        };
+                        instance_to_symbol.insert(String::new(), simple_name.to_string());
+                        continue;
+                    }
+
+                    if let ExprKind::Call { func, .. } = &decorator_list[0].node {
+                        if matches!(&func.node, ExprKind::Name { id, .. } if id == &"rpc".into()) {
+                            let TopLevelDef::Function { instance_to_symbol, .. } =
+                                &mut *def.write()
+                            else {
+                                unreachable!()
                             };
-                            unifier.subst(self_type, &subst_for_self).unwrap_or(self_type)
-                        })
-                    };
-                    let mut identifiers = {
-                        let mut result = HashMap::new();
-                        if self_type.is_some() {
-                            result.insert("self".into(), IdentifierInfo::default());
-                        }
-                        result
-                            .extend(inst_args.iter().map(|x| (x.name, IdentifierInfo::default())));
-                        result
-                    };
-                    let mut calls: HashMap<CodeLocation, CallId> = HashMap::new();
-                    let mut inferencer = Inferencer {
-                        top_level: ctx.as_ref(),
-                        defined_identifiers: identifiers.clone(),
-                        function_data: &mut FunctionData {
-                            resolver: resolver.as_ref().unwrap().clone(),
-                            return_type: if unifier.unioned(inst_ret, primitives_ty.none) {
-                                None
-                            } else {
-                                Some(inst_ret)
-                            },
-                            // NOTE: allowed type vars
-                            bound_variables: no_range_vars.clone(),
-                        },
-                        unifier,
-                        variable_mapping: {
-                            let mut result: HashMap<StrRef, Type> = HashMap::new();
-                            if let Some(self_ty) = self_type {
-                                result.insert("self".into(), self_ty);
-                            }
-                            result.extend(inst_args.iter().map(|x| (x.name, x.ty)));
-                            result
-                        },
-                        primitives: primitives_ty,
-                        virtual_checks: &mut Vec::new(),
-                        calls: &mut calls,
-                        in_handler: false,
-                    };
-
-                    let ast::StmtKind::FunctionDef { body, decorator_list, .. } =
-                        ast.clone().unwrap().node
-                    else {
-                        unreachable!("must be function def ast")
-                    };
-                    if !decorator_list.is_empty()
-                        && matches!(&decorator_list[0].node,
-                            ast::ExprKind::Name{ id, .. } if id == &"extern".into())
-                    {
-                        instance_to_symbol.insert(String::new(), simple_name.to_string());
-                        continue;
-                    }
-                    if !decorator_list.is_empty()
-                        && matches!(&decorator_list[0].node,
-                            ast::ExprKind::Name{ id, .. } if id == &"rpc".into())
-                    {
-                        instance_to_symbol.insert(String::new(), simple_name.to_string());
-                        continue;
-                    }
-                    if !decorator_list.is_empty() {
-                        if let ast::ExprKind::Call { func, .. } = &decorator_list[0].node {
-                            if matches!(&func.node,
-                                ast::ExprKind::Name{ id, .. } if id == &"rpc".into())
-                            {
-                                instance_to_symbol.insert(String::new(), simple_name.to_string());
-                                continue;
-                            }
+                            instance_to_symbol.insert(String::new(), simple_name.to_string());
+                            continue;
                         }
                     }
+                }
 
-                    let fun_body = body
-                        .into_iter()
+                let fun_body =
+                    body.into_iter()
                         .map(|b| inferencer.fold_stmt(b))
                         .collect::<Result<Vec<_>, _>>()?;
 
-                    let returned = inferencer.check_block(fun_body.as_slice(), &mut identifiers)?;
-                    {
-                        // check virtuals
-                        let defs = ctx.definitions.read();
-                        for (subtype, base, loc) in &*inferencer.virtual_checks {
-                            let base_id = {
-                                let base = inferencer.unifier.get_ty(*base);
-                                if let TypeEnum::TObj { obj_id, .. } = &*base {
-                                    *obj_id
-                                } else {
-                                    return Err(HashSet::from([format!(
-                                        "Base type should be a class (at {loc})"
-                                    )]));
-                                }
-                            };
-                            let subtype_id = {
-                                let ty = inferencer.unifier.get_ty(*subtype);
-                                if let TypeEnum::TObj { obj_id, .. } = &*ty {
-                                    *obj_id
-                                } else {
-                                    let base_repr = inferencer.unifier.stringify(*base);
-                                    let subtype_repr = inferencer.unifier.stringify(*subtype);
-                                    return Err(HashSet::from([format!(
-                                        "Expected a subtype of {base_repr}, but got {subtype_repr} (at {loc})"),
-                                    ]));
-                                }
-                            };
-                            let subtype_entry = defs[subtype_id.0].read();
-                            let TopLevelDef::Class { ancestors, .. } = &*subtype_entry else {
-                                unreachable!()
-                            };
-
-                            let m = ancestors.iter()
-                                .find(|kind| matches!(kind, TypeAnnotation::CustomClass { id, .. } if *id == base_id));
-                            if m.is_none() {
+                let returned = inferencer.check_block(fun_body.as_slice(), &mut identifiers)?;
+                {
+                    // check virtuals
+                    let defs = ctx.definitions.read();
+                    for (subtype, base, loc) in &*inferencer.virtual_checks {
+                        let base_id = {
+                            let base = inferencer.unifier.get_ty(*base);
+                            if let TypeEnum::TObj { obj_id, .. } = &*base {
+                                *obj_id
+                            } else {
+                                return Err(HashSet::from([format!(
+                                    "Base type should be a class (at {loc})"
+                                )]));
+                            }
+                        };
+                        let subtype_id = {
+                            let ty = inferencer.unifier.get_ty(*subtype);
+                            if let TypeEnum::TObj { obj_id, .. } = &*ty {
+                                *obj_id
+                            } else {
                                 let base_repr = inferencer.unifier.stringify(*base);
                                 let subtype_repr = inferencer.unifier.stringify(*subtype);
                                 return Err(HashSet::from([format!(
                                     "Expected a subtype of {base_repr}, but got {subtype_repr} (at {loc})"),
                                 ]));
                             }
+                        };
+                        let subtype_entry = defs[subtype_id.0].read();
+                        let TopLevelDef::Class { ancestors, .. } = &*subtype_entry else {
+                            unreachable!()
+                        };
+
+                        let m = ancestors.iter()
+                            .find(|kind| matches!(kind, TypeAnnotation::CustomClass { id, .. } if *id == base_id));
+                        if m.is_none() {
+                            let base_repr = inferencer.unifier.stringify(*base);
+                            let subtype_repr = inferencer.unifier.stringify(*subtype);
+                            return Err(HashSet::from([format!(
+                                "Expected a subtype of {base_repr}, but got {subtype_repr} (at {loc})"),
+                            ]));
                         }
                     }
-                    if !unifier.unioned(inst_ret, primitives_ty.none) && !returned {
-                        let def_ast_list = &definition_ast_list;
-                        let ret_str = unifier.internal_stringify(
-                            inst_ret,
-                            &mut |id| {
-                                let TopLevelDef::Class { name, .. } = &*def_ast_list[id].0.read()
-                                else {
-                                    unreachable!("must be class id here")
-                                };
-
-                                name.to_string()
-                            },
-                            &mut |id| format!("typevar{id}"),
-                            &mut None,
-                        );
-                        return Err(HashSet::from([format!(
-                            "expected return type of `{}` in function `{}` (at {})",
-                            ret_str,
-                            name,
-                            ast.as_ref().unwrap().location
-                        )]));
-                    }
-
-                    instance_to_stmt.insert(
-                        get_subst_key(
-                            unifier,
-                            self_type,
-                            &subst,
-                            Some(&vars.keys().copied().collect()),
-                        ),
-                        FunInstance {
-                            body: Arc::new(fun_body),
-                            unifier_id: 0,
-                            calls: Arc::new(calls),
-                            subst,
-                        },
-                    );
                 }
+                if !unifier.unioned(inst_ret, primitives_ty.none) && !returned {
+                    let def_ast_list = &definition_ast_list;
+                    let ret_str = unifier.internal_stringify(
+                        inst_ret,
+                        &mut |id| {
+                            let TopLevelDef::Class { name, .. } = &*def_ast_list[id].0.read()
+                            else {
+                                unreachable!("must be class id here")
+                            };
+
+                            name.to_string()
+                        },
+                        &mut |id| format!("typevar{id}"),
+                        &mut None,
+                    );
+                    return Err(HashSet::from([format!(
+                        "expected return type of `{}` in function `{}` (at {})",
+                        ret_str,
+                        name,
+                        ast.as_ref().unwrap().location
+                    )]));
+                }
+
+                let TopLevelDef::Function { instance_to_stmt, .. } = &mut *def.write() else {
+                    unreachable!()
+                };
+                instance_to_stmt.insert(
+                    get_subst_key(
+                        unifier,
+                        self_type,
+                        &subst,
+                        Some(&vars.keys().copied().collect()),
+                    ),
+                    FunInstance {
+                        body: Arc::new(fun_body),
+                        unifier_id: 0,
+                        calls: Arc::new(calls),
+                        subst,
+                    },
+                );
             }
 
             Ok(())
         };
+
         for (id, (def, ast)) in self.definition_ast_list.iter().enumerate().skip(self.builtin_num) {
             if ast.is_none() {
                 continue;
@@ -2237,9 +2273,8 @@ impl TopLevelComposer {
         let primitives_store = &self.primitives_ty;
 
         let mut analyze = |variable_def: &Arc<RwLock<TopLevelDef>>| -> Result<_, HashSet<String>> {
-            let variable_def = &mut *variable_def.write();
-
-            let TopLevelDef::Variable { ty: dummy_ty, ty_decl, resolver, loc, .. } = variable_def
+            let TopLevelDef::Variable { ty: dummy_ty, ty_decl, resolver, loc, .. } =
+                &*variable_def.read()
             else {
                 // not top level variable def, skip
                 return Ok(());
@@ -2247,25 +2282,28 @@ impl TopLevelComposer {
 
             let resolver = &**resolver.as_ref().unwrap();
 
-            let ty_annotation = parse_ast_to_type_annotation_kinds(
-                resolver,
-                &temp_def_list,
-                unifier,
-                primitives_store,
-                ty_decl,
-                HashMap::new(),
-            )?;
-            let ty_from_ty_annotation = get_type_from_type_annotation_kinds(
-                &temp_def_list,
-                unifier,
-                primitives_store,
-                &ty_annotation,
-                &mut None,
-            )?;
+            if let Some(ty_decl) = ty_decl {
+                let ty_annotation = parse_ast_to_type_annotation_kinds(
+                    resolver,
+                    &temp_def_list,
+                    unifier,
+                    primitives_store,
+                    ty_decl,
+                    HashMap::new(),
+                )?;
+                let ty_from_ty_annotation = get_type_from_type_annotation_kinds(
+                    &temp_def_list,
+                    unifier,
+                    primitives_store,
+                    &ty_annotation,
+                    &mut None,
+                )?;
+
+                unifier.unify(*dummy_ty, ty_from_ty_annotation).map_err(|e| {
+                    HashSet::from([e.at(Some(loc.unwrap())).to_display(unifier).to_string()])
+                })?;
+            }
 
-            unifier.unify(*dummy_ty, ty_from_ty_annotation).map_err(|e| {
-                HashSet::from([e.at(Some(loc.unwrap())).to_display(unifier).to_string()])
-            })?;
             Ok(())
         };
 

nac3core/src/toplevel/helper.rs

@@ -3,13 +3,11 @@ use std::convert::TryInto;
 use strum::IntoEnumIterator;
 use strum_macros::EnumIter;
 
-use ast::ExprKind;
-use nac3parser::ast::{Constant, Location};
+use nac3parser::ast::{Constant, ExprKind, Location};
 
-use super::*;
+use super::{numpy::unpack_ndarray_var_tys, *};
 use crate::{
     symbol_resolver::SymbolValue,
-    toplevel::numpy::unpack_ndarray_var_tys,
     typecheck::typedef::{into_var_map, iter_type_vars, Mapping, TypeVarId, VarMap},
 };
 
@@ -600,7 +598,7 @@ impl TopLevelComposer {
         name: String,
         simple_name: StrRef,
         ty: Type,
-        ty_decl: Expr,
+        ty_decl: Option<Expr>,
         resolver: Option<Arc<dyn SymbolResolver + Send + Sync>>,
         loc: Option<Location>,
     ) -> TopLevelDef {

nac3core/src/toplevel/mod.rs

@@ -23,19 +23,19 @@ use crate::{
         },
     },
 };
-
-#[derive(PartialEq, Eq, PartialOrd, Ord, Clone, Copy, Hash, Debug)]
-pub struct DefinitionId(pub usize);
+use composer::*;
+use type_annotation::*;
 
 pub mod builtins;
 pub mod composer;
 pub mod helper;
 pub mod numpy;
-pub mod type_annotation;
-use composer::*;
-use type_annotation::*;
 #[cfg(test)]
 mod test;
+pub mod type_annotation;
+
+#[derive(PartialEq, Eq, PartialOrd, Ord, Clone, Copy, Hash, Debug)]
+pub struct DefinitionId(pub usize);
 
 type GenCallCallback = dyn for<'ctx, 'a> Fn(
         &mut CodeGenContext<'ctx, 'a>,
@@ -158,8 +158,8 @@ pub enum TopLevelDef {
         /// Type of the global variable.
         ty: Type,
 
-        /// The declared type of the global variable.
-        ty_decl: Expr,
+        /// The declared type of the global variable, or [`None`] if no type annotation is provided.
+        ty_decl: Option<Expr>,
 
         /// Symbol resolver of the module defined the class.
         resolver: Option<Arc<dyn SymbolResolver + Send + Sync>>,

nac3core/src/toplevel/numpy.rs

@@ -1,11 +1,9 @@
 use itertools::Itertools;
 
-use crate::{
-    toplevel::helper::PrimDef,
-    typecheck::{
-        type_inferencer::PrimitiveStore,
-        typedef::{Type, TypeEnum, TypeVarId, Unifier, VarMap},
-    },
+use super::helper::PrimDef;
+use crate::typecheck::{
+    type_inferencer::PrimitiveStore,
+    typedef::{Type, TypeEnum, TypeVarId, Unifier, VarMap},
 };
 
 /// Creates a `ndarray` [`Type`] with the given type arguments.

nac3core/src/toplevel/test.rs

@@ -9,11 +9,10 @@ use nac3parser::{
     parser::parse_program,
 };
 
-use super::*;
+use super::{helper::PrimDef, DefinitionId, *};
 use crate::{
     codegen::CodeGenContext,
     symbol_resolver::{SymbolResolver, ValueEnum},
-    toplevel::{helper::PrimDef, DefinitionId},
     typecheck::{
         type_inferencer::PrimitiveStore,
         typedef::{into_var_map, Type, Unifier},

nac3core/src/toplevel/type_annotation.rs

@@ -2,12 +2,11 @@ use strum::IntoEnumIterator;
 
 use nac3parser::ast::Constant;
 
-use super::*;
-use crate::{
-    symbol_resolver::SymbolValue,
-    toplevel::helper::{PrimDef, PrimDefDetails},
-    typecheck::typedef::VarMap,
+use super::{
+    helper::{PrimDef, PrimDefDetails},
+    *,
 };
+use crate::{symbol_resolver::SymbolValue, typecheck::typedef::VarMap};
 
 #[derive(Clone, Debug)]
 pub enum TypeAnnotation {

nac3core/src/typecheck/function_check.rs

@@ -10,7 +10,7 @@ use nac3parser::ast::{
 };
 
 use super::{
-    type_inferencer::{IdentifierInfo, Inferencer},
+    type_inferencer::{DeclarationSource, IdentifierInfo, Inferencer},
     typedef::{Type, TypeEnum},
 };
 use crate::toplevel::helper::PrimDef;
@@ -34,6 +34,20 @@ impl<'a> Inferencer<'a> {
                 Err(HashSet::from([format!("cannot assign to a `none` (at {})", pattern.location)]))
             }
             ExprKind::Name { id, .. } => {
+                // If `id` refers to a declared symbol, reject this assignment if it is used in the
+                // context of an (implicit) global variable
+                if let Some(id_info) = defined_identifiers.get(id) {
+                    if matches!(
+                        id_info.source,
+                        DeclarationSource::Global { is_explicit: Some(false) }
+                    ) {
+                        return Err(HashSet::from([format!(
+                            "cannot access local variable '{id}' before it is declared (at {})",
+                            pattern.location
+                        )]));
+                    }
+                }
+
                 if !defined_identifiers.contains_key(id) {
                     defined_identifiers.insert(*id, IdentifierInfo::default());
                 }
@@ -104,7 +118,22 @@ impl<'a> Inferencer<'a> {
                         *id,
                     ) {
                         Ok(_) => {
-                            self.defined_identifiers.insert(*id, IdentifierInfo::default());
+                            let is_global = self.is_id_global(*id);
+
+                            defined_identifiers.insert(
+                                *id,
+                                IdentifierInfo {
+                                    source: match is_global {
+                                        Some(true) => {
+                                            DeclarationSource::Global { is_explicit: Some(false) }
+                                        }
+                                        Some(false) => {
+                                            DeclarationSource::Global { is_explicit: None }
+                                        }
+                                        None => DeclarationSource::Local,
+                                    },
+                                },
+                            );
                         }
                         Err(e) => {
                             return Err(HashSet::from([format!(
@@ -368,9 +397,9 @@ impl<'a> Inferencer<'a> {
             StmtKind::Global { names, .. } => {
                 for id in names {
                     if let Some(id_info) = defined_identifiers.get(id) {
-                        if !id_info.is_global {
+                        if id_info.source == DeclarationSource::Local {
                             return Err(HashSet::from([format!(
-                                "name '{id}' is assigned to before global declaration at {}",
+                                "name '{id}' is referenced prior to global declaration at {}",
                                 stmt.location,
                             )]));
                         }
@@ -385,8 +414,12 @@ impl<'a> Inferencer<'a> {
                         *id,
                     ) {
                         Ok(_) => {
-                            self.defined_identifiers
-                                .insert(*id, IdentifierInfo { is_global: true });
+                            defined_identifiers.insert(
+                                *id,
+                                IdentifierInfo {
+                                    source: DeclarationSource::Global { is_explicit: Some(true) },
+                                },
+                            );
                         }
                         Err(e) => {
                             return Err(HashSet::from([format!(

nac3core/src/typecheck/magic_methods.rs

@@ -5,16 +5,16 @@ use strum::IntoEnumIterator;
 
 use nac3parser::ast::{Cmpop, Operator, StrRef, Unaryop};
 
+use super::{
+    type_inferencer::*,
+    typedef::{FunSignature, FuncArg, Type, TypeEnum, Unifier, VarMap},
+};
 use crate::{
     symbol_resolver::SymbolValue,
     toplevel::{
         helper::PrimDef,
         numpy::{make_ndarray_ty, unpack_ndarray_var_tys},
     },
-    typecheck::{
-        type_inferencer::*,
-        typedef::{FunSignature, FuncArg, Type, TypeEnum, Unifier, VarMap},
-    },
 };
 
 /// The variant of a binary operator.

nac3core/src/typecheck/type_error.rs

@@ -5,10 +5,9 @@ use itertools::Itertools;
 use nac3parser::ast::{Cmpop, Location, StrRef};
 
 use super::{
-    magic_methods::Binop,
-    typedef::{RecordKey, Type, Unifier},
+    magic_methods::{Binop, HasOpInfo},
+    typedef::{RecordKey, Type, TypeEnum, Unifier},
 };
-use crate::typecheck::{magic_methods::HasOpInfo, typedef::TypeEnum};
 
 #[derive(Debug, Clone)]
 pub enum TypeErrorKind {

nac3core/src/typecheck/type_inferencer/mod.rs

@@ -12,7 +12,7 @@ use itertools::{izip, Itertools};
 use nac3parser::ast::{
     self,
     fold::{self, Fold},
-    Arguments, Comprehension, ExprContext, ExprKind, Located, Location, StrRef,
+    Arguments, Comprehension, ExprContext, ExprKind, Ident, Located, Location, StrRef,
 };
 
 use super::{
@@ -88,11 +88,31 @@ impl PrimitiveStore {
     }
 }
 
+/// The location where an identifier declaration refers to.
+#[derive(Clone, Copy, Debug, Eq, PartialEq)]
+pub enum DeclarationSource {
+    /// Local scope.
+    Local,
+
+    /// Global scope.
+    Global {
+        /// Whether the identifier is declared by the use of `global` statement. This field is
+        /// [`None`] if the identifier does not refer to a variable.
+        is_explicit: Option<bool>,
+    },
+}
+
 /// Information regarding a defined identifier.
-#[derive(Clone, Copy, Debug, Default)]
+#[derive(Clone, Copy, Debug)]
 pub struct IdentifierInfo {
     /// Whether this identifier refers to a global variable.
-    pub is_global: bool,
+    pub source: DeclarationSource,
+}
+
+impl Default for IdentifierInfo {
+    fn default() -> Self {
+        IdentifierInfo { source: DeclarationSource::Local }
+    }
 }
 
 impl IdentifierInfo {
@@ -574,7 +594,22 @@ impl<'a> Fold<()> for Inferencer<'a> {
                             *id,
                         ) {
                             Ok(_) => {
-                                self.defined_identifiers.insert(*id, IdentifierInfo::default());
+                                let is_global = self.is_id_global(*id);
+
+                                self.defined_identifiers.insert(
+                                    *id,
+                                    IdentifierInfo {
+                                        source: match is_global {
+                                            Some(true) => DeclarationSource::Global {
+                                                is_explicit: Some(false),
+                                            },
+                                            Some(false) => {
+                                                DeclarationSource::Global { is_explicit: None }
+                                            }
+                                            None => DeclarationSource::Local,
+                                        },
+                                    },
+                                );
                             }
                             Err(e) => {
                                 return report_error(
@@ -2650,4 +2685,22 @@ impl<'a> Inferencer<'a> {
         self.constrain(body.custom.unwrap(), orelse.custom.unwrap(), &body.location)?;
         Ok(body.custom.unwrap())
     }
+
+    /// Determines whether the given `id` refers to a global symbol.
+    ///
+    /// Returns `Some(true)` if `id` refers to a global variable, `Some(false)` if `id` refers to a
+    /// class/function, and `None` if `id` refers to a local symbol.
+    pub(super) fn is_id_global(&self, id: Ident) -> Option<bool> {
+        self.top_level
+            .definitions
+            .read()
+            .iter()
+            .map(|def| match *def.read() {
+                TopLevelDef::Class { name, .. } => (name, false),
+                TopLevelDef::Function { simple_name, .. } => (simple_name, false),
+                TopLevelDef::Variable { simple_name, .. } => (simple_name, true),
+            })
+            .find(|(global, _)| global == &id)
+            .map(|(_, has_explicit_prop)| has_explicit_prop)
+    }
 }

nac3core/src/typecheck/typedef/mod.rs

@@ -14,14 +14,14 @@ use itertools::{repeat_n, Itertools};
 use nac3parser::ast::{Cmpop, Location, StrRef, Unaryop};
 
 use super::{
-    magic_methods::{Binop, HasOpInfo},
+    magic_methods::{Binop, HasOpInfo, OpInfo},
     type_error::{TypeError, TypeErrorKind},
+    type_inferencer::PrimitiveStore,
     unification_table::{UnificationKey, UnificationTable},
 };
 use crate::{
     symbol_resolver::SymbolValue,
     toplevel::{helper::PrimDef, DefinitionId, TopLevelContext, TopLevelDef},
-    typecheck::{magic_methods::OpInfo, type_inferencer::PrimitiveStore},
 };
 
 #[cfg(test)]

nac3standalone/demo/src/globals.py

@@ -7,7 +7,7 @@ def output_int64(x: int64):
     ...
 
 X: int32 = 0
-Y: int64 = int64(1)
+Y = int64(1)
 
 def f():
     global X, Y

nac3standalone/src/main.rs

@@ -45,9 +45,10 @@ use nac3core::{
     },
 };
 
-mod basic_symbol_resolver;
 use basic_symbol_resolver::*;
 
+mod basic_symbol_resolver;
+
 /// Command-line argument parser definition.
 #[derive(Parser)]
 #[command(author, version, about, long_about = None)]
@@ -174,46 +175,49 @@ fn handle_typevar_definition(
 fn handle_assignment_pattern(
     targets: &[Expr],
     value: &Expr,
-    resolver: &(dyn SymbolResolver + Send + Sync),
+    resolver: Arc<dyn SymbolResolver + Send + Sync>,
     internal_resolver: &ResolverInternal,
-    def_list: &[Arc<RwLock<TopLevelDef>>],
-    unifier: &mut Unifier,
-    primitives: &PrimitiveStore,
+    composer: &mut TopLevelComposer,
 ) -> Result<(), String> {
     if targets.len() == 1 {
-        match &targets[0].node {
+        let target = &targets[0];
+
+        match &target.node {
             ExprKind::Name { id, .. } => {
+                let def_list = composer.extract_def_list();
+                let unifier = &mut composer.unifier;
+                let primitives = &composer.primitives_ty;
+
                 if let Ok(var) =
-                    handle_typevar_definition(value, resolver, def_list, unifier, primitives)
+                    handle_typevar_definition(value, &*resolver, &def_list, unifier, primitives)
                 {
                     internal_resolver.add_id_type(*id, var);
                     Ok(())
-                } else if let Ok(val) = parse_parameter_default_value(value, resolver) {
+                } else if let Ok(val) = parse_parameter_default_value(value, &*resolver) {
                     internal_resolver.add_module_global(*id, val);
+                    let (name, def_id, _) = composer
+                        .register_top_level_var(
+                            *id,
+                            None,
+                            Some(resolver.clone()),
+                            "__main__",
+                            target.location,
+                        )
+                        .unwrap();
+                    internal_resolver.add_id_def(name, def_id);
                     Ok(())
                 } else {
                     Err(format!("fails to evaluate this expression `{:?}` as a constant or generic parameter at {}",
-                        targets[0].node,
-                        targets[0].location,
+                        target.node,
+                        target.location,
                     ))
                 }
             }
             ExprKind::List { elts, .. } | ExprKind::Tuple { elts, .. } => {
-                handle_assignment_pattern(
-                    elts,
-                    value,
-                    resolver,
-                    internal_resolver,
-                    def_list,
-                    unifier,
-                    primitives,
-                )?;
+                handle_assignment_pattern(elts, value, resolver, internal_resolver, composer)?;
                 Ok(())
             }
-            _ => Err(format!(
-                "assignment to {:?} is not supported at {}",
-                targets[0], targets[0].location
-            )),
+            _ => Err(format!("assignment to {target:?} is not supported at {}", target.location)),
         }
     } else {
         match &value.node {
@@ -223,11 +227,9 @@ fn handle_assignment_pattern(
                         handle_assignment_pattern(
                             std::slice::from_ref(tar),
                             val,
-                            resolver,
+                            resolver.clone(),
                             internal_resolver,
-                            def_list,
-                            unifier,
-                            primitives,
+                            composer,
                         )?;
                     }
                     Ok(())
@@ -248,8 +250,9 @@ fn handle_assignment_pattern(
 fn handle_global_var(
     target: &Expr,
     value: Option<&Expr>,
-    resolver: &(dyn SymbolResolver + Send + Sync),
+    resolver: &Arc<dyn SymbolResolver + Send + Sync>,
     internal_resolver: &ResolverInternal,
+    composer: &mut TopLevelComposer,
 ) -> Result<(), String> {
     let ExprKind::Name { id, .. } = target.node else {
         return Err(format!(
@@ -262,8 +265,12 @@ fn handle_global_var(
         return Err(format!("global variable `{id}` must be initialized in its definition"));
     };
 
-    if let Ok(val) = parse_parameter_default_value(value, resolver) {
+    if let Ok(val) = parse_parameter_default_value(value, &**resolver) {
         internal_resolver.add_module_global(id, val);
+        let (name, def_id, _) = composer
+            .register_top_level_var(id, None, Some(resolver.clone()), "__main__", target.location)
+            .unwrap();
+        internal_resolver.add_id_def(name, def_id);
         Ok(())
     } else {
         Err(format!(
@@ -355,17 +362,12 @@ fn main() {
     for stmt in parser_result {
         match &stmt.node {
             StmtKind::Assign { targets, value, .. } => {
-                let def_list = composer.extract_def_list();
-                let unifier = &mut composer.unifier;
-                let primitives = &composer.primitives_ty;
                 if let Err(err) = handle_assignment_pattern(
                     targets,
                     value,
-                    resolver.as_ref(),
+                    resolver.clone(),
                     internal_resolver.as_ref(),
-                    &def_list,
-                    unifier,
-                    primitives,
+                    &mut composer,
                 ) {
                     panic!("{err}");
                 }
@@ -375,16 +377,12 @@ fn main() {
                 if let Err(err) = handle_global_var(
                     target,
                     value.as_ref().map(Box::as_ref),
-                    resolver.as_ref(),
+                    &resolver,
                     internal_resolver.as_ref(),
+                    &mut composer,
                 ) {
                     panic!("{err}");
                 }
-
-                let (name, def_id, _) = composer
-                    .register_top_level(stmt, Some(resolver.clone()), "__main__", true)
-                    .unwrap();
-                internal_resolver.add_id_def(name, def_id);
             }
 
             // allow (and ignore) "from __future__ import annotations"