• Joined on 2024-06-03
lyken pushed to ndstrides-enhance-irrt at M-Labs/nac3 2024-08-26 19:20:51 +08:00
ff1088b429 tmp: reformat nac3standalone/demo/demo.c
6a35203101 tmp: reformat nac3core/irrt
ff6fed6d45 tmp: use .clang-format
Compare 3 commits »
lyken pushed to ndstrides-enhance-irrt at M-Labs/nac3 2024-08-26 19:02:03 +08:00
6354e99320 standalone: use C++ casting in demo.c
lyken commented on pull request M-Labs/nac3#508 2024-08-26 19:02:02 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

...unless you are talking about nacstandalone/

lyken commented on pull request M-Labs/nac3#508 2024-08-26 18:51:02 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

Also I can't find any C-style casts in nac3core/irrt, or at least with rg '\*\)' nac3core/irrt and vim.

lyken commented on pull request M-Labs/nac3#508 2024-08-26 18:46:23 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

I am fully relying on .clang-format to reformat, and it really does not like T*. Many of the formatting issues come from me just doing

$ find nac3core/irrt -name '*.hpp' -o -name…
lyken pushed to ndstrides-enhance-irrt at M-Labs/nac3 2024-08-26 16:44:59 +08:00
99da1974ef standalone: reformat demo.c
lyken commented on pull request M-Labs/nac3#508 2024-08-26 16:34:24 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

Revised. Squash commits when everything is ok.

lyken pushed to ndstrides-enhance-irrt at M-Labs/nac3 2024-08-26 16:32:06 +08:00
6f483aed6c core/irrt: split original.hpp
4248716327 core/irrt: reformat with new style
69ec22eab7 core/irrt: update .clang-format to use LLVM style
0d78be4639 core/irrt: merge load_irrt() and setup_irrt_exceptions()
a156af8501 core/irrt: use constexpr for NO_PARAM
Compare 10 commits »
lyken commented on pull request M-Labs/nac3#508 2024-08-26 16:11:36 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

Update: I think implementing it would make the process a bit too complicated, at least with the solution I came up with.

  • Write a Makefile
  • Write the multi-file compilation process in that…
lyken commented on pull request M-Labs/nac3#508 2024-08-26 15:21:32 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

Sure I can reformat everything to LLVM, should be little work. Later commits too.

lyken commented on pull request M-Labs/nac3#508 2024-08-26 15:13:34 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

Ah okay

lyken commented on pull request M-Labs/nac3#508 2024-08-26 15:12:35 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

IRRT_DEBUG_ASSERT_BOOL itself will be used to write stuff like:

if (IRRT_DEBUG_ASSERT_BOOL) {
  // Code that only runs in debug mode.
}

I could place a bunch of `#ifdef IRRT_DEBUG_AS…

lyken commented on pull request M-Labs/nac3#508 2024-08-26 15:10:05 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

I would like to understand why.

I am not too familiar with constexpr and why people put them everywhere.

lyken commented on pull request M-Labs/nac3#508 2024-08-26 15:07:26 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

Microsoft.

lyken commented on pull request M-Labs/nac3#508 2024-08-26 15:07:00 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

Microsoft again.

I am not using reinterpret_cast because it is convenient. Do they make a difference?

lyken commented on pull request M-Labs/nac3#508 2024-08-26 15:05:15 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

Forced by Microsoft

lyken commented on pull request M-Labs/nac3#508 2024-08-26 15:04:55 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

Sure, but I didn't want to deal with having to managing temporary files. I can implement that now.

lyken commented on pull request M-Labs/nac3#508 2024-08-26 14:59:00 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

I picked Microsoft arbitrarily. Could we reformat demo.c to be Microsoft style too?

lyken closed pull request M-Labs/nac3#506 2024-08-26 14:37:11 +08:00
NDArray with strides + NDArrayObject + Models + Exceptions in IRRT.
lyken commented on pull request M-Labs/nac3#506 2024-08-26 14:37:11 +08:00
NDArray with strides + NDArrayObject + Models + Exceptions in IRRT.

Closing, to be broken down into smaller PRs.