• Joined on 2024-06-03
lyken closed issue M-Labs/nac3#280 2024-06-21 09:44:03 +08:00
ndarray: Elementwise negation for bool arrays
lyken commented on issue M-Labs/nac3#280 2024-06-21 09:44:02 +08:00
ndarray: Elementwise negation for bool arrays

Has already been implemented. Closing.

lyken commented on pull request M-Labs/nac3#424 2024-06-20 16:23:17 +08:00
core: implement np.any() & np.all()

An isolated commit has now been created to extend gen_for_callback.

lyken commented on pull request M-Labs/nac3#424 2024-06-20 16:21:03 +08:00
core: implement np.any() & np.all()

After some thoughts, I will not use folds to implement any/all. The short-circuiting logic was slightly awkward to implement. But more importantly it could not provide the necessary control to…

lyken commented on pull request M-Labs/nac3#424 2024-06-20 16:15:16 +08:00
core: implement np.any() & np.all()

The function requires codegen::builtin_fns::unsupported_type, which is private. Should I move it too?

lyken pushed to numpy-anyall at M-Labs/nac3 2024-06-20 16:11:23 +08:00
c4971fad82 core: implement np.any() & np.all()
lyken pushed to numpy-anyall at M-Labs/nac3 2024-06-20 16:09:28 +08:00
ac5acf7156 core: implement np.any() & np.all()
e52c1c4423 core: add gen_ndarray_iter_scalar_callback
18b4b150d8 core: add BreakContinueHooks for gen_for_callback
d89146aa02 core: use no_run on builtin_fns docs
5bade81ddb standalone: Add test for multidim array index with one index
Compare 15 commits »
lyken pushed to master at M-Labs/nac3 2024-06-20 13:53:57 +08:00
d89146aa02 core: use no_run on builtin_fns docs
lyken commented on pull request M-Labs/nac3#422 2024-06-20 12:37:24 +08:00
core: reduce code duplication in codegen/builtin_fns

Could we instead make a squash commit? Because I think the history of this branch does not matter too much and might pollute the master branch. The branch also contains commits that revert parts…

lyken commented on pull request M-Labs/nac3#422 2024-06-20 11:47:45 +08:00
core: reduce code duplication in codegen/builtin_fns

Revised.

lyken pushed to refactor-builtin-fns at M-Labs/nac3 2024-06-20 11:47:22 +08:00
eceeee1c50 core: add newline in comments
7987dca464 core: restore call_abs() parameter name
Compare 2 commits »
lyken commented on pull request M-Labs/nac3#424 2024-06-20 10:42:03 +08:00
core: implement np.any() & np.all()

I would also like to take time to extend this to a general fold - to also refactor np.max() and np.min().

lyken commented on pull request M-Labs/nac3#422 2024-06-20 10:33:36 +08:00
core: reduce code duplication in codegen/builtin_fns

Revised.

About the macro comments, I have taken the liberty to make changes to the suggested update.

lyken pushed to refactor-builtin-fns at M-Labs/nac3 2024-06-20 10:30:59 +08:00
777077a723 core: revise nac3core/codegen/builtin_fns.rs numpy macros
lyken opened issue M-Labs/nac3#427 2024-06-20 09:41:28 +08:00
Allow numpy factories to take in shape parameter as tuple
lyken created pull request M-Labs/nac3#424 2024-06-19 17:30:06 +08:00
core: implement np.any() & np.all()
lyken pushed to numpy-anyall at M-Labs/nac3 2024-06-19 17:29:22 +08:00
554c9234b8 core: implement np.any() & np.all()
lyken created branch numpy-anyall in M-Labs/nac3 2024-06-19 17:29:21 +08:00
lyken pushed to refactor-builtin-fns at M-Labs/nac3 2024-06-19 16:08:17 +08:00
ef2502e7b4 core: more minor doc refine for helper_call_numpy()
lyken pushed to refactor-builtin-fns at M-Labs/nac3 2024-06-19 09:48:09 +08:00
c20c9a2c5a core: minor doc refine for helper_call_numpy()