• Joined on 2024-06-03
lyken deleted branch fixed-ndarray-rpc from M-Labs/nac3 2024-08-29 16:30:51 +08:00
lyken commented on pull request M-Labs/nac3#527 2024-08-29 15:58:27 +08:00
Fix RPC of ndarrays from host to device

Wait actually, why do we allocate alloc_size x i8* here? I thought alloc_size is the number of bytes to allocate on the kernel's end.

lyken commented on pull request M-Labs/nac3#527 2024-08-29 15:55:07 +08:00
Fix RPC of ndarrays from host to device

Oh

lyken approved M-Labs/nac3#527 2024-08-29 15:48:37 +08:00
Fix RPC of ndarrays from host to device
lyken commented on pull request M-Labs/nac3#527 2024-08-29 15:48:37 +08:00
Fix RPC of ndarrays from host to device

Probably some super insignificant details: I used ndarray_nbytes / itemsize to derive the num_elements for ndarray.create_data because it is computationally less expensive. Doing like this is a little bit less efficient but I am not sure if this is concerning.

lyken commented on pull request M-Labs/nac3#527 2024-08-29 15:48:37 +08:00
Fix RPC of ndarrays from host to device

Unrelated: I think there are inconsistencies with how we insert assertion tests in NAC3.

lyken commented on pull request M-Labs/nac3#527 2024-08-29 15:48:36 +08:00
Fix RPC of ndarrays from host to device

We should delete/change my comment here. I think it is not [i32; ndims]. Also I messed up the sentence after NOTE:.

lyken commented on pull request M-Labs/nac3#527 2024-08-29 15:48:36 +08:00
Fix RPC of ndarrays from host to device

Redundant pointer cast I think.

lyken created branch fixed-ndarray-rpc in M-Labs/nac3 2024-08-29 13:32:03 +08:00
lyken pushed to fixed-ndarray-rpc at M-Labs/nac3 2024-08-29 13:32:03 +08:00
712c4df6da working?
953c80fda1 fix 1
2bdf3be6a7 [artiq] WIP
ff4e6fc9db [artiq] WIP
ae041e2917 [artiq] WIP
Compare 8 commits »
lyken pushed to master at M-Labs/nac3 2024-08-29 10:37:53 +08:00
59cad5bfe1 standalone: clang-format demo.c
lyken pushed to master at M-Labs/nac3 2024-08-29 10:35:41 +08:00
4318f8de84 standalone: improve src/assignment.py
lyken commented on issue M-Labs/nac3#135 2024-08-29 10:16:16 +08:00
implement enumerate()

Also see M-Labs/nac3#137 - a more general version of this feature.

lyken commented on issue M-Labs/nac3#278 2024-08-29 09:57:22 +08:00
ndarray: Implement reshaping

np_reshape() is currently in master after PR M-Labs/nac3#478 in commit 00236f48bc. -1 is…

lyken commented on pull request M-Labs/nac3#525 2024-08-29 09:40:58 +08:00
Fix several missing i1/i8 casts

On i1 vs i8, is this relevant commit? 31dcd2dde9

lyken pushed to ndstrides-3-indexing at M-Labs/nac3 2024-08-28 16:44:12 +08:00
40cf1c747f core/ndstrides: remove duplicated gen_slice()
lyken created pull request M-Labs/nac3#524 2024-08-28 14:27:16 +08:00
ndstrides: [14] Final cleanups
lyken created branch ndstrides-14-end in M-Labs/nac3 2024-08-28 14:26:22 +08:00
lyken pushed to ndstrides-14-end at M-Labs/nac3 2024-08-28 14:26:22 +08:00
lyken created pull request M-Labs/nac3#523 2024-08-28 14:25:16 +08:00
ndstrides: [13] Enhance ndarray.py tests