From fc9d47fb546f0dd0d8a5b6ffa46d5ac4d43a2649 Mon Sep 17 00:00:00 2001
From: lyken <lyken@m-labs.hk>
Date: Fri, 26 Jul 2024 16:21:25 +0800
Subject: [PATCH] core/irrt: fix error context check logic error

---
 nac3core/irrt/irrt/error_context.hpp       | 4 ++--
 nac3core/src/codegen/irrt/error_context.rs | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/nac3core/irrt/irrt/error_context.hpp b/nac3core/irrt/irrt/error_context.hpp
index 568f680b..c8ab8e09 100644
--- a/nac3core/irrt/irrt/error_context.hpp
+++ b/nac3core/irrt/irrt/error_context.hpp
@@ -72,8 +72,8 @@ void __nac3_error_context_initialize(ErrorContext *errctx,
     errctx->initialize(error_ids);
 }
 
-bool __nac3_error_context_has_no_error(ErrorContext *errctx) {
-    return !errctx->has_error();
+bool __nac3_error_context_has_error(ErrorContext *errctx) {
+    return errctx->has_error();
 }
 
 void __nac3_error_context_get_error_str(ErrorContext *errctx,
diff --git a/nac3core/src/codegen/irrt/error_context.rs b/nac3core/src/codegen/irrt/error_context.rs
index dad74246..2ed71194 100644
--- a/nac3core/src/codegen/irrt/error_context.rs
+++ b/nac3core/src/codegen/irrt/error_context.rs
@@ -100,11 +100,11 @@ pub fn call_nac3_error_context_initialize<'ctx>(
         .returning_void();
 }
 
-pub fn call_nac3_error_context_has_no_error<'ctx>(
+pub fn call_nac3_error_context_has_error<'ctx>(
     ctx: &CodeGenContext<'ctx, '_>,
     errctx: Pointer<'ctx, StructModel<ErrorContext>>,
 ) -> NInt<'ctx, Bool> {
-    FunctionBuilder::begin(ctx, "__nac3_error_context_has_no_error")
+    FunctionBuilder::begin(ctx, "__nac3_error_context_has_error")
         .arg("errctx", errctx)
         .returning("has_error", NIntModel(Bool))
 }
@@ -157,7 +157,7 @@ pub fn check_error_context<'ctx, G: CodeGenerator + ?Sized>(
     let end_bb = ctx.ctx.insert_basic_block_after(irrt_has_error_bb, "end");
 
     // Inserting into `current_bb`
-    let has_error = call_nac3_error_context_has_no_error(ctx, errctx_ptr);
+    let has_error = call_nac3_error_context_has_error(ctx, errctx_ptr);
     ctx.builder.build_conditional_branch(has_error.value, irrt_has_error_bb, end_bb).unwrap();
 
     // Inserting into `irrt_has_error_bb`