From fb54d5d11250e40733d7a77cf65168723e93b779 Mon Sep 17 00:00:00 2001 From: lyken Date: Tue, 30 Jul 2024 15:40:41 +0800 Subject: [PATCH] core/ndstrides: add TODO in np_reshape --- nac3core/src/toplevel/builtins.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/nac3core/src/toplevel/builtins.rs b/nac3core/src/toplevel/builtins.rs index a53aa15b..a0cd33c7 100644 --- a/nac3core/src/toplevel/builtins.rs +++ b/nac3core/src/toplevel/builtins.rs @@ -1341,6 +1341,8 @@ impl<'a> BuiltinBuilder<'a> { match prim { PrimDef::FunNpReshape => { + // TODO: Support scalar inputs, e.g., `np.reshape(99, (1, 1, 1, 1))` + let new_ndim_ty = self.unifier.get_fresh_var(Some("NewNDim".into()), None); let returned_ndarray_ty = make_ndarray_ty( self.unifier,