linuswck
  • Joined on 2023-07-05
linuswck commented on pull request M-Labs/thermostat#127 2024-08-15 18:13:25 +08:00
Show and save the set values of PWM limits into flash store instead of machine value

I don't think it is meaningful to read back the configured settings in machine unit. Just return the user configured value?

linuswck commented on pull request linuswck/thermostat#2 2024-08-09 18:11:59 +08:00
GUI: Control Panel changes

The parameter SpinBoxes previously would only update if the interpreted

linuswck pushed to master at M-Labs/kirdy 2024-08-07 17:37:48 +08:00
3ba8b99084 Use degree celsius as temperature base unit
linuswck pushed to master at M-Labs/kirdy 2024-08-07 12:49:42 +08:00
af73ac8127 gui: Add text for LD & Thermostat status
linuswck pushed to master at M-Labs/kirdy 2024-08-07 12:17:25 +08:00
c214e4182d temp_mon: fix limits not effective at stable temp
fb69ae3306 main: Don't change temp ctrl mode at otp
Compare 2 commits »
linuswck commented on pull request M-Labs/thermostat#119 2024-08-07 11:14:16 +08:00
Calculate current_abs_max_tec_i from all channels

It doesn't matter here. The bottleneck will be self.get_tec_i(channel) which blocks until the single conversion Adc readings return.

linuswck commented on pull request M-Labs/thermostat#117 2024-08-06 17:55:33 +08:00
steinhart_hart: Beta Parameter uom dimensions

if you add kelvin unit to b, don't use self.b.get::<kelvin>(). The unit is correct now.

linuswck pushed to master at M-Labs/kirdy 2024-08-06 13:11:48 +08:00
8c8ed12522 gui: Disable param tree compact height
572e2dbc5d gui: update for the new driver code
82c46e04d0 Update PID Autotune Code for Driver Code
28f8c3c497 Update Example Code for Driver Code
47bf166ecb driver: kirdy driver rewrite
Compare 6 commits »
linuswck commented on issue M-Labs/thermostat#111 2024-08-02 15:28:50 +08:00
TCP sockets aren't reset on ethernet cable reconnect

Stabilizer Firmware does reset all the sockets when Ethernet link is dropped. Just the part that reset all sockets is written inside the smoltcp-nal crate.

https://github.com/quartiq/stabilizer/

linuswck commented on pull request linuswck/thermostat#2 2024-08-02 11:24:33 +08:00
GUI: Control Panel changes

You should fix all the siPrefix. Especially when we do not allow unit to be modified now. It will be confusing if the siPrefix of the unit suddenly changes.

linuswck commented on pull request linuswck/thermostat#2 2024-08-02 11:22:32 +08:00
GUI: Control Panel changes

Replacing the incorrectly defined FLOAT_REGEX on pyqtgraph.functions is more preferable.

linuswck pushed to master at M-Labs/kirdy 2024-07-26 14:30:44 +08:00
3f9a4bf140 ld: Block pwr on request if alarm is asserted
201148fb21 main: allow loading flash without device settings
a90031dd6c ld_pwr_exc_protector: clear irq bit at pwr up
7b52072617 ld: cfg hardware when pd_mon params changes
c241d34434 gui: fix default units and mv to params' titles
Compare 5 commits »
linuswck pushed to master at M-Labs/kirdy 2024-07-25 18:38:43 +08:00
98d577bed5 main: allow loading flash without device settings
b84cf77805 ld_pwr_exc_protector: clear irq bit at pwr up
49cff8e2a3 ld: cfg hardware when pd_mon params changes
73796a4728 gui: move unit to ctrl panel params' titles
20c3d42dd7 rm ld soft current limit
Compare 7 commits »
linuswck pushed to master at M-Labs/kirdy 2024-07-22 17:53:04 +08:00
a76b8de994 thermostat: Save the user config-ed value directly
3410a271fd thermostat: rst pid_state at pwr_up
8f38acd0f2 thermostat: do not rst tec_i_out to 0 at pwr down
Compare 3 commits »
linuswck commented on pull request linuswck/thermostat#2 2024-07-22 13:06:23 +08:00
GUI: Control Panel changes

Can can bold the "Control Method" in ctrl panel?

linuswck commented on pull request linuswck/thermostat#2 2024-07-22 13:05:31 +08:00
GUI: Control Panel changes

Readability: ADC Filter sampling rate is unrelated to Thermistor. Move it up a layer. image

linuswck commented on pull request linuswck/thermostat#2 2024-07-22 12:56:31 +08:00
GUI: Control Panel changes

Usability:

linuswck commented on pull request linuswck/thermostat#2 2024-07-22 12:28:21 +08:00
GUI: Control Panel changes

Looks like a hack. The unit conversion should not be affected by the title.

linuswck commented on pull request linuswck/thermostat#2 2024-07-22 11:52:57 +08:00
GUI: Control Panel changes

Readability: Better to Add a Readings group to "Temperature" and "Current Through TEC". More intuitive for first time user. image

linuswck commented on pull request linuswck/thermostat#2 2024-07-22 11:50:25 +08:00
GUI: Control Panel changes

Usability: Then, what does Off do? What is the sampling rate? image