linuswck/thermostat
1
0
Fork 0
forked from M-Labs/thermostat
Code Pull Requests 1 Activity

GUI: Control Panel changes #2

Open
atse wants to merge 21 commits from gui_dev-ctrl_panel into gui_dev
pull from: gui_dev-ctrl_panel
merge into: linuswck:gui_dev
Conversation 13 Commits 21 Files Changed 6 +3 -5
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3fe343435d - Show all commits

8
pytec/pytec/gui/view/param_tree.json
View File

@ -205,7 +205,7 @@
"title": "R₀", "title": "R₀",
"type": "float", "type": "float",
"value": 10000, "value": 10000,
"step": 1, "step": 100,
"min": 0, "min": 0,
"siPrefix": true, "siPrefix": true,
"pinSiPrefix": "k", "pinSiPrefix": "k",
@ -224,7 +224,7 @@
"title": "B", "title": "B",
linuswck commented 2024-08-02 11:24:33 +08:00
Outdated
Review
Copy Link

You should fix all the siPrefix. Especially when we do not allow unit to be modified now. It will be confusing if the siPrefix of the unit suddenly changes.

You should fix **all** the siPrefix. Especially when we do not allow unit to be modified now. It will be confusing if the siPrefix of the unit suddenly changes.
👍 1
"type": "float", "type": "float",
"value": 3950, "value": 3950,
"step": 1, "step": 10,
"suffix": "K", "suffix": "K",
"noUnitEditing": true, "noUnitEditing": true,
"decimals": 4, "decimals": 4,
@ -269,7 +269,6 @@
"title": "Kp", "title": "Kp",
"type": "float", "type": "float",
"step": 0.1, "step": 0.1,
"suffix": "",
"compactHeight": false, "compactHeight": false,
"thermostat:set_param": { "thermostat:set_param": {
"topic": "pid", "topic": "pid",
@ -406,9 +405,8 @@
"type": "float", "type": "float",
"value": 1.5, "value": 1.5,
"step": 0.1, "step": 0.1,
"prefix": "±",
"format": "{value:.4f} {suffix}", "format": "{value:.4f} {suffix}",
"suffix": "°C", "suffix": "K",
"noUnitEditing": true, "noUnitEditing": true,
"compactHeight": false, "compactHeight": false,
"pid_autotune": "temp_swing", "pid_autotune": "temp_swing",