Compare commits

..

13 Commits

Author SHA1 Message Date
21eb13ed6f ctrl_panel: Keep i_set visible when PID engaged
Since i_set is also plotted, we would also want to see its precise value
too.
2024-07-19 15:14:19 +08:00
646452f559 ctrl_panel: Remove MutexParameter
Use the standard ListParamenter instead, and hook up UI changes
elsewhere.
2024-07-19 15:14:19 +08:00
46a22a9c32 ctrl_panel: Limits fixes
* PID Autotune test current should be positive

* Maximum absolute voltage should be 4 V not 5 V
2024-07-19 15:14:19 +08:00
8ec7bb833a ctrl_panel: Code cleanup
* Remove unnecessary duplication of `THERMOSTAT_PARAMETERS`

* i -> ch

* Separate ParameterTree and Parameter initiation

* Remove extra "channel" option to root parameters, as the "value"
option is already the channel number
2024-07-19 15:14:19 +08:00
02d04dbae5 ctrl_panel: PID Auto Tune -> PID Autotune 2024-07-19 15:14:19 +08:00
85ff340b6f ctrl_panel: Stop crushing spinboxes
It might not be the case on some themes, but on the default Qt theme the
spinbox are a bit too short for the containing numbers. See
https://github.com/pyqtgraph/pyqtgraph/issues/701.
2024-07-19 15:14:19 +08:00
d844c02a3a ctrl_panel: Approriate units for measured current
Allow the readonly display of current to vary its SI prefix in the unit,
since as a display entry it won't have the unit adjustment problem.
2024-07-19 15:13:49 +08:00
8a4d861672 ctrl_panel: Pin down units for editable fields
Avoids awkward value editing
2024-07-19 11:12:38 +08:00
b668c699fb ctrl_panel: Improve postfilter description 2024-07-19 11:11:59 +08:00
eb3719044f ctrl_panel: Add tooltips
For users' better understanding of what the parameters do
2024-07-19 11:11:55 +08:00
8ac4a32106 ctrl_panel: Refer to Parameters by concise names
For displayed string representations, use the `title` key, or for
`ListParameter`s, use the dictionary mapping method instead.
2024-07-16 15:08:42 +08:00
493088f4a5 ctrl_panel: Config -> Settings 2024-07-16 15:08:05 +08:00
2ae58b9abb Format JSON 2024-07-16 15:00:10 +08:00
2 changed files with 2 additions and 2 deletions

View File

@ -117,7 +117,7 @@ class Thermostat(QObject, metaclass=PropertyMeta):
async def save_cfg(self, ch):
await self._client.save_config(ch)
self.info_box_trigger.emit(
"Settings saved", f"Channel {ch} Settings has been saved to flash."
"Settings loaded", f"Channel {ch} Settings has been loaded to flash."
)
@asyncSlot()

View File

@ -332,7 +332,7 @@ class MainWindow(QtWidgets.QMainWindow):
case PIDAutotuneState.STATE_FAILED:
self.info_box.display_info_box(
"PID Autotune Failed", f"Channel {ch} PID Autotune has failed."
"PID Autotune Failed", f"Channel {ch} PID Autotune is failed."
)
self.info_box.show()