kai/pounder_test
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

attenuators: use robust latching sequence

Browse Source 
To ensure that eatch call to latch() generates a rising edge, first
assert low, then high, not the other way round.
This commit is contained in:
Robert Jördens 2021-05-25 20:59:48 +00:00
parent a9f5943296
commit fc78b087ee
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/hardware/pounder/mod.rs
View File

@ -313,12 +313,7 @@ impl PounderDevices {
.map_err(|_| Error::I2c)?; .map_err(|_| Error::I2c)?;
devices devices
.mcp23017 .mcp23017
.write_gpio(mcp23017::Port::GPIOB, 1 << 5) .write_gpio(mcp23017::Port::GPIOB, 0x2F)
.map_err(|_| Error::I2c)?;
devices
.mcp23017
.digital_write(EXT_CLK_SEL_PIN, false)
.map_err(|_| Error::I2c)?; .map_err(|_| Error::I2c)?;
Ok(devices) Ok(devices)
@ -351,23 +346,25 @@ impl AttenuatorInterface for PounderDevices {
Channel::Out0 => ATT_LE1_PIN, Channel::Out0 => ATT_LE1_PIN,
Channel::Out1 => ATT_LE3_PIN, Channel::Out1 => ATT_LE3_PIN,
}; };
self.mcp23017 self.mcp23017
.digital_write(pin, true) .digital_write(pin, false)
.map_err(|_| Error::I2c)?;
self.mcp23017
.digital_write(pin, false)
.map_err(|_| Error::I2c)?; .map_err(|_| Error::I2c)?;
// TODO: Measure the I2C transaction speed to the RST pin to ensure that the delay is // TODO: Measure the I2C transaction speed to the RST pin to ensure that the delay is
// sufficient. Document the delay here. // sufficient. Document the delay here.
self.mcp23017 self.mcp23017
.digital_write(pin, false) .digital_write(pin, true)
.map_err(|_| Error::I2c)?; .map_err(|_| Error::I2c)?;
Ok(()) Ok(())
} }
/// Read the raw attenuation codes stored in the attenuator shift registers. /// Read the raw attenuation codes stored in the attenuator shift registers.
/// ///
/// Args: /// Args:
/// * `channels` - A slice to store the channel readings into. /// * `channels` - A 4 byte slice to be shifted into the
/// attenuators and to contain the data shifted out.
fn transfer_attenuators( fn transfer_attenuators(
&mut self, &mut self,
channels: &mut [u8; 4], channels: &mut [u8; 4],