I also wonder whether it's really a good idea for WRPLLSim to have a separate run method outside of the constructor. Are there any cases where one doesn't immediately want to call run after…
When you have code like this
self.period_err, self.phase_err, self.helper_adpll, self.main_adpll, self.gtx_beating, self.main_beating, self.gtx, self.helper, self.main, self.helperfre…Might also be worth adding jupytext to avoid committing binary data.
Thanks for that nice write up @jordens
There are varying levels of sophistication we can go for here. Right now even a few really simple tweaks (multiply before sum, rethink the limiting) would…
It's also not clear to me what happens when the I gain is changed. Imagine Kp and Kd are both zero and we step Ki. That can easily result in the output shooting up to max because of the multiply…
I also don't think I understand the electric current error condition on the integrator.
Imagine the following situation: the unit starts off cold, so the current rails positive. Now, before it has…
it may take a while.
No hurry from my end. We now know enough to get things working so this isn't urgent. The interface exposed by Thermostat is currently overly complex and a bit ugly but we…
(I probably will file a PR at some point but first I need to turn my debugging hacks into something useful. Even without a PR right now it's useufl to have the issues open so there is a record of…
I disagree with that conclusion, there are several users who have it in the lab without complaining like you do - they might just have to send us a question or two (that's what we have helpdesk@…
Conclusion for anyone looking over these issues: to my view this is not in state where I would expect a skilled scientist (e.g. has used commercial temperature controllers before) to be able to…
Also, when I tried to run the tests locally I got a bunch or errors like
error[E0531]: cannot find tuple struct or tuple variant `Err` in this scope
--> src/main.rs:86:13
Right, got it!
So, issues I see here:
- Command parser errors should be sent to ethernet not the USB
- The error message here is pretty unfriendly (why only send the first unexpected character…
This should be covered by a test. f6802635a4/src/command_parser.rs (L650) Where are the test logs?
Maybe there is a more useful error message hiding in there somewhere but it's only on the USB UART?…
The instruction in README is actually "see the mcu folder of nix-scripts" i.e. follow what Hydra does. I suppose your issue is with shell.nix?
I wasn't using nix at all.
Maybe the…