• Joined on 2019-09-03
hartytp commented on issue M-Labs/thermostat#61 2022-01-05 03:32:34 +08:00
build fails

The objcopy step also failed for me arm-none-eabi-objcopy -O binary thermostat.elf thermostat.bin. The build outputs didn't have a thermostat.elf just thermostat and it wasn't in the file place…

hartytp opened issue M-Labs/thermostat#61 2022-01-05 03:20:23 +08:00
build fails
hartytp commented on issue M-Labs/nac3#74 2021-11-06 23:20:58 +08:00
define parallel/sequential in nac3artiq Rust side

Cool! It's not a huge deal, but would make some things cleaner. The situation with the old compiler is a bit annoying because the error message is so bad.

hartytp commented on issue M-Labs/nac3#74 2021-11-06 17:04:19 +08:00
define parallel/sequential in nac3artiq Rust side

What's your view on supporting things like import artiq as aq, with aq.parallel aq.delay_mu. This is the style we're moving towards here. In the current compiler, aq.delay gives an obscure…

hartytp commented on issue M-Labs/thermostat#24 2021-01-25 20:05:37 +08:00
review (firmware-hardware) vs (Thermostat design goals)

I'm definitely happy with the recent progress. I'm afraid I haven't looked at the code/tested it on hw recently so can't comment on the actual state of things. FWIW, overall it wasn't in bad shape…

hartytp commented on issue M-Labs/thermostat#21 2020-12-15 01:43:50 +08:00
document postfilter

I'm happy either way. It's a nice feature to play with as it gives users the option of making the loop tighter (wider bw) at the expense of slightly more noise. IIRC 10Hz is slower than optimal in…

hartytp commented on issue M-Labs/thermostat#11 2020-12-09 01:14:01 +08:00
loop servo time step / PID autotune

Agreed. Asking questions helps clarify design intent and spot difference between intent and implementation. :)

Well, that's about my point.

However, shifting to a clock-determined (vs loop…

hartytp commented on issue M-Labs/thermostat#24 2020-12-09 01:09:29 +08:00
review (firmware-hardware) vs (Thermostat design goals)

No idea. I assume no one (and none of us are using it yet for the reasons discussed), but I might be wrong.

It may well be useable to some degree right now, but it's not really tested and seems to…

hartytp commented on issue M-Labs/thermostat#24 2020-12-09 00:57:50 +08:00
review (firmware-hardware) vs (Thermostat design goals)

It really shouldn't have to be me who does the review. The thermostat EEM project is live and I'm hoping we can unify the firmware from the two projects to create a single repo that works nicely...

hartytp commented on issue M-Labs/thermostat#23 2020-12-09 00:57:02 +08:00
README.md not-ready-for-lab-use warning

Best if project status is reflected in README.md as this is where we put authoritative info on Sinara modules.

We haven't done that in the past. Generally this stuff is all in flux and I'd…

hartytp commented on issue M-Labs/thermostat#23 2020-12-09 00:42:36 +08:00
README.md not-ready-for-lab-use warning

I can see that being annoying. But, you've been on enough of this journey with us that I would have expected you to have asked before assuming the hardware is production ready. Even the M-Labs…

hartytp commented on issue M-Labs/thermostat#11 2020-12-09 00:39:51 +08:00
loop servo time step / PID autotune

@jbqubit as explained above the period is already defined by the ADC’s internal clock.

No reasonable amount of computation is ever going to take a timescale that's relevant on thermal…

hartytp commented on issue M-Labs/thermostat#11 2020-12-08 18:52:42 +08:00
loop servo time step / PID autotune

BTW I would definitely not consider this firmware production ready yet. Last time I looked over it the firmware did not do what I expect in various places (e.g. the zero-current calibration looked…

hartytp commented on issue M-Labs/thermostat#11 2020-12-08 18:47:55 +08:00
loop servo time step / PID autotune

Does the firmware include a mechanism for strictly controlling this period?

You need to be more careful with language here since you're talking across domains of expertise so it’s easy for…

hartytp pushed to master at hartytp/ionpak-thermostat 2019-09-13 18:15:10 +08:00
fa2089b8a3 Revert "command_parser: fix typo"
hartytp pushed to master at hartytp/ionpak-thermostat 2019-09-13 18:12:57 +08:00
34f09030e5 command_parser: fix typo
hartytp created pull request M-Labs/ionpak-thermostat#1 2019-09-13 18:12:10 +08:00
AD7172: fix typo in comment [NFC]
hartytp pushed to master at hartytp/ionpak-thermostat 2019-09-13 18:11:57 +08:00
b118ad0cec AD7172: fix typo in comment [NFC]
hartytp created repository hartytp/ionpak-thermostat 2019-09-13 18:11:29 +08:00