Egor Savkin esavkin
  • Joined on 2022-09-30
esavkin pushed to 69-fan_pwm at esavkin/thermostat 2023-01-05 14:54:06 +08:00
73ecffcf1e Remove all tacho/status related logic
esavkin commented on issue M-Labs/thermostat#72 2023-01-05 14:48:58 +08:00
warn when current/voltage limits are at 0

Proposed features

Emit warning messages to the log and all TCP sessions once, on the case: any of the max_v, max_i_pos, max_i_neg of any channel is set to zero+-EPSILON by pwm…

esavkin pushed to 69-fan_pwm at esavkin/thermostat 2023-01-05 13:05:39 +08:00
6551a86f8a Remove all tacho/status related logic
33070abd81 Make commands more consistent
21fc244eac Fan status via quadratic regression
Compare 3 commits »
esavkin commented on pull request M-Labs/thermostat#74 2023-01-05 10:29:36 +08:00
WIP: Update python to 3.11 and use StrEnum

Without matplotlib it works

esavkin commented on pull request M-Labs/thermostat#73 2023-01-05 09:58:05 +08:00
Support fan PWM settings

What does the graph represent? The axes aren't even labeled and don't have units...

As mentioned in the code comments, it's a comparison of qudratic and log regressions against real 80% tacho…

esavkin pushed to 1697-rtiomap at esavkin/artiq-zynq 2023-01-04 17:35:47 +08:00
439653b02a Do not acquire channel name on the core1
esavkin commented on pull request M-Labs/thermostat#73 2023-01-04 17:15:10 +08:00
Support fan PWM settings

Well, they are subject of change, but they come from the power formula P=I^2 * R

esavkin pushed to 63-fix-pid-error at esavkin/thermostat 2023-01-04 16:23:36 +08:00
34a38b5ae9 Accept ending whitespace in commands
esavkin commented on pull request M-Labs/thermostat#73 2023-01-04 16:12:08 +08:00
Support fan PWM settings

As I said before the device should enter a failsafe mode with output currents at zero when a fan failure is detected.

Next time

esavkin commented on pull request M-Labs/thermostat#73 2023-01-04 16:09:23 +08:00
Support fan PWM settings

Mentioned regression comparison:

esavkin pushed to 69-fan_pwm at esavkin/thermostat 2023-01-04 16:07:04 +08:00
bd18b5fa3a Fan status via quadratic regression
esavkin commented on pull request M-Labs/thermostat#75 2023-01-03 11:28:23 +08:00
Fix failure on commands ending on whitespace

parse_with_trailing_whitespaces_and_check_equality? I think 7 words is too much, and still it is a bit confusing

esavkin commented on pull request M-Labs/thermostat#75 2023-01-03 11:23:20 +08:00
Fix failure on commands ending on whitespace

I think it is better now

esavkin pushed to 63-fix-pid-error at esavkin/thermostat 2023-01-03 11:22:31 +08:00
d566cca7e0 Accept ending whitespace in commands
esavkin commented on issue M-Labs/artiq-zynq#204 2023-01-03 11:00:09 +08:00
ZC706+Evaluation Board Not Running Idle Kernels

Well, that's pretty silly behavior. Maybe modify it to require reboot to align with Zynq, and then document.

https://github.com/m-labs/artiq/issues/2041

esavkin pushed to 63-fix-pid-error at esavkin/thermostat 2023-01-03 10:38:12 +08:00
7d2be841c2 Accept ending whitespace in commands
esavkin commented on pull request M-Labs/thermostat#75 2023-01-03 10:35:26 +08:00
Fix failure on commands ending on whitespace

Yes, as shown in test cases, it accepts multiple spaces and tabs

esavkin commented on pull request M-Labs/thermostat#75 2023-01-03 10:29:41 +08:00
Fix failure on commands ending on whitespace

No, before this change different commands had different reaction on ending whitespace(s)

esavkin commented on pull request M-Labs/thermostat#73 2023-01-03 10:24:44 +08:00
Support fan PWM settings

Yes, with current version of library, TIM8 can be used with the PWM pins only, and tieing tacho pin would move it to the Timer, and therefore couldn't be used without unsafe hacks. I am not sure…

esavkin commented on pull request M-Labs/thermostat#73 2023-01-03 10:18:10 +08:00
Support fan PWM settings

That there are some signals being registered, but in general it so low so that it can be zero on some small timeline. It tipically happens on very low fan speed (from 1 to 3 included), and that…