core: refactor to use
TypeVarId
and TypeVar
I don't think it's necessary to pub
the value of the TypeVarId
. Maybe add a From<TypeVarId> for u32
if we want to be able to convert back to a u32
value.
core: refactor to use
TypeVarId
and TypeVar
The rest of the PR looks good. Do remove the *.bc
and *.o
file, or otherwise add those to the Gitignore.
2cfa6091f3
core: WIP - Add tracer runtime
be55e2ac80
meta: Update README to include info regarding pre-commit hooks
79c8b759ad
meta: Add pre-commit configuration
4798c53a21
flake: Add pre-commit to dev environment
23974feae7
meta: Restrict number of allowed lints
be55e2ac80
meta: Update README to include info regarding pre-commit hooks
79c8b759ad
meta: Add pre-commit configuration
4798c53a21
flake: Add pre-commit to dev environment
23974feae7
meta: Restrict number of allowed lints
40a3bded36
meta: Set clippy lints in {main,lib}.rs
Add cargo clippy and cargo fmt to pre-commit hooks
v2: Rebased onto master, added Rustrover configuration files
2c9b1f5330
meta: Update README to include info regarding pre-commit hooks
bd13630f9a
meta: Add pre-commit configuration
467ce051ec
flake: Add pre-commit to dev environment
f78a0ca8ee
meta: Restrict number of allowed lints
d151ed48a7
meta: Set clippy lints in {main,lib}.rs
Add cargo clippy and cargo fmt to pre-commit hooks
01ea93706d
meta: Update README to include info regarding pre-commit hooks
f24de6cbc6
meta: Add pre-commit configuration
e738264cf7
flake: Add pre-commit to dev environment
b55892e8cf
meta: Reformat codebase using `cargo fmt`
4bdd8128da
meta: Restrict number of allowed lints
core: Refactor PrimitiveDefinitionIds into an enum + refactor
get_builtins()
All suggested changes are now implemented.
I think the following changes are not yet implemented:
- Please split the formatting changes into a separate commit.
- Split refactoring…
271dd875bd
meta: Update README to include info regarding pre-commit hooks
5001988e09
meta: Add pre-commit configuration
495b26bf70
flake: Add pre-commit to dev environment
627cc2bc42
meta: Reformat codebase using `cargo fmt`
52cc822a53
meta: Set clippy lints in {main,lib}.rs
core: Refactor PrimitiveDefinitionIds into an enum + refactor
get_builtins()
The lifetime 'a
can be elided; Same for the functions below.
core: Refactor PrimitiveDefinitionIds into an enum + refactor
get_builtins()
allowlist
can just be a &[PrimDef]
.
core: Refactor PrimitiveDefinitionIds into an enum + refactor
get_builtins()
Could we just have one constructor with simple_name
being an Option<&'static str>
?
core: Refactor PrimitiveDefinitionIds into an enum + refactor
get_builtins()
The design looks good to me, just several nitpicks here and there.
e053872b10
core: WIP - Add tracer runtime
53d44b9595
standalone: Add np_array tests
6153f94b05
core/numpy: Implement codegen for np_array
4730b595f3
core/builtins: Add np_array function
c2fdb12397
core/type_inferencer: Add special rule for np_array