core: refactor to use
TypeVarId
and TypeVar
I don't think it's necessary to pub
the value of the TypeVarId
. Maybe add a From<TypeVarId> for u32
if we want to be able to convert back to a u32
value.
core: refactor to use
TypeVarId
and TypeVar
The rest of the PR looks good. Do remove the *.bc
and *.o
file, or otherwise add those to the Gitignore.
Add cargo clippy and cargo fmt to pre-commit hooks
v2: Rebased onto master, added Rustrover configuration files
Add cargo clippy and cargo fmt to pre-commit hooks
core: Refactor PrimitiveDefinitionIds into an enum + refactor
get_builtins()
All suggested changes are now implemented.
I think the following changes are not yet implemented:
- Please split the formatting changes into a separate commit.
- Split refactoring…
core: Refactor PrimitiveDefinitionIds into an enum + refactor
get_builtins()
The lifetime 'a
can be elided; Same for the functions below.
core: Refactor PrimitiveDefinitionIds into an enum + refactor
get_builtins()
allowlist
can just be a &[PrimDef]
.
core: Refactor PrimitiveDefinitionIds into an enum + refactor
get_builtins()
Could we just have one constructor with simple_name
being an Option<&'static str>
?
core: Refactor PrimitiveDefinitionIds into an enum + refactor
get_builtins()
The design looks good to me, just several nitpicks here and there.