David Mak derppening
  • Joined on 2023-08-31
derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

Same as Array, bound N to FloatKind here as well.

derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

I would suggest following Inkwell conventions - size_of.

derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

MapStructFields? Since the only operations its implementing classes do is to add fields based on some criteria, matching what map does to an iterator. Or FieldMapper.

derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

This name is non-descriptive. Output or OutType would be better.

derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

u32.

derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

Same as with Float and Array.

derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

I would suggest naming it llvm_type. Use of get_ is discouraged in Rust AFAIK.

derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

iter_fields

derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

Move this into the documentation for their respective functions. It is very difficult to refer to these examples when you are trying to look for how to use the APIs.

derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

I think FunctionCall or FuncCall might be a better name.

derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

I would name this builder instead.

derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

nit: ///

derppening commented on pull request M-Labs/nac3#509 2024-08-27 15:52:31 +08:00
ndstrides: [1] Introduce models

Are there any types in Model that distinguishes between an array alloca and alloca? I think it would be preferable to have something like an ArrayPtr to replace the type of an ArraySliceValue.

derppening commented on pull request M-Labs/nac3#508 2024-08-27 10:25:29 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

Thanks. You could squash the final few commits and then we can merge it.

derppening commented on pull request M-Labs/nac3#508 2024-08-27 10:18:09 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

This still needs fixing AFAICT.

derppening commented on pull request M-Labs/nac3#508 2024-08-27 10:17:46 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

Switched to your .clang-format and reformatted everything. How see?

Much better.

derppening commented on pull request M-Labs/nac3#508 2024-08-26 17:37:06 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

Do you want me to help you do a quick rebase pass to fix all the formatting issues instead?

derppening commented on pull request M-Labs/nac3#497 2024-08-26 17:36:26 +08:00
core: allow calling parent methods

No further comments.

derppening suggested changes for M-Labs/nac3#508 2024-08-26 17:34:56 +08:00
ndstrides: Allow multi-file IRRT + Exceptions in IRRT

The positions of pointers * and references & are still incorrect, and I still see many uses of C-style casts. Please change those before submitting for re-review.