Fix several missing i1/i8 casts
All boolean operations (e.g. icmp) return i1, and LLVM's ABI uses i1 for boolean parameters in functions. I would prefer to follow these conventions as we need these casts either way.
Fix several missing i1/i8 casts
ndstrides: [1] Introduce models
I did some testing and this might work:
pub struct CallFunction<'ctx, 'a, 'b, G: CodeGenerator + ?Sized> {
generator: &'b mut G,
ctx: &'b CodeGenContext<'ctx, 'a>,
name: &'b…
ndstrides: [1] Introduce models
I guess you mean there could have been a single visitor that collects the fields into a
Vec<dyn Model>and do stuff with thatVec(like checking field types and more).The short…
ndstrides: [1] Introduce models
I wouldn't be too concerned with using PhantomData here. I'd rather the type bounds of the struct be explicit so that users of this class do not misuse the fields.
In fact, we should also…
ndstrides: [1] Introduce models
What about two functions, one that creates a void func and another that creates a value-returning func?