David Mak derppening
0 Followers · 0 Following
  • Joined on 2023-08-31
Repositories Projects Packages Code Public Activity Starred Repositories
derppening created branch enhance/issue-149-ndarray/rpc in M-Labs/nac3 2024-06-14 14:48:37 +08:00
derppening pushed to enhance/issue-149-ndarray/rpc at M-Labs/nac3 2024-06-14 14:48:37 +08:00
4cffd3aa07 artiq: WIP - Implement Python-to-LLVM conversion of ndarray
derppening commented on pull request M-Labs/nac3#414 2024-06-13 15:32:50 +08:00
core: refactor to use TypeVarId and TypeVar

I don't think it's necessary to pub the value of the TypeVarId. Maybe add a From<TypeVarId> for u32 if we want to be able to convert back to a u32 value.

derppening commented on pull request M-Labs/nac3#414 2024-06-13 15:32:50 +08:00
core: refactor to use TypeVarId and TypeVar

Typo: fo -> of

derppening commented on pull request M-Labs/nac3#414 2024-06-13 15:32:50 +08:00
core: refactor to use TypeVarId and TypeVar

This might be better named as into_var_map.

derppening suggested changes for M-Labs/nac3#414 2024-06-13 15:32:50 +08:00
core: refactor to use TypeVarId and TypeVar

The rest of the PR looks good. Do remove the *.bc and *.o file, or otherwise add those to the Gitignore.

derppening pushed to misc/impl-tracert at M-Labs/nac3 2024-06-12 16:31:29 +08:00
2cfa6091f3 core: WIP - Add tracer runtime
be55e2ac80 meta: Update README to include info regarding pre-commit hooks
79c8b759ad meta: Add pre-commit configuration
4798c53a21 flake: Add pre-commit to dev environment
23974feae7 meta: Restrict number of allowed lints
Compare 9 commits »
derppening commented on pull request M-Labs/nac3#413 2024-06-12 16:11:55 +08:00
Add cargo clippy and cargo fmt to pre-commit hooks

v3: Removed Rustrover configurations

derppening pushed to misc/workflow-updates at M-Labs/nac3 2024-06-12 16:11:42 +08:00
be55e2ac80 meta: Update README to include info regarding pre-commit hooks
79c8b759ad meta: Add pre-commit configuration
4798c53a21 flake: Add pre-commit to dev environment
23974feae7 meta: Restrict number of allowed lints
40a3bded36 meta: Set clippy lints in {main,lib}.rs
Compare 5 commits »
derppening commented on pull request M-Labs/nac3#413 2024-06-12 16:07:01 +08:00
Add cargo clippy and cargo fmt to pre-commit hooks

v2: Rebased onto master, added Rustrover configuration files

derppening pushed to misc/workflow-updates at M-Labs/nac3 2024-06-12 16:06:47 +08:00
2c9b1f5330 meta: Update README to include info regarding pre-commit hooks
bd13630f9a meta: Add pre-commit configuration
467ce051ec flake: Add pre-commit to dev environment
f78a0ca8ee meta: Restrict number of allowed lints
d151ed48a7 meta: Set clippy lints in {main,lib}.rs
Compare 9 commits »
derppening commented on pull request M-Labs/nac3#408 2024-06-12 15:44:00 +08:00
core: Refactor PrimitiveDefinitionIds into an enum + refactor get_builtins()

LGTM, thanks!

derppening created pull request M-Labs/nac3#413 2024-06-12 15:39:27 +08:00
Add cargo clippy and cargo fmt to pre-commit hooks
derppening pushed to misc/workflow-updates at M-Labs/nac3 2024-06-12 15:37:44 +08:00
01ea93706d meta: Update README to include info regarding pre-commit hooks
f24de6cbc6 meta: Add pre-commit configuration
e738264cf7 flake: Add pre-commit to dev environment
b55892e8cf meta: Reformat codebase using `cargo fmt`
4bdd8128da meta: Restrict number of allowed lints
Compare 5 commits »
derppening commented on pull request M-Labs/nac3#408 2024-06-12 13:18:52 +08:00
core: Refactor PrimitiveDefinitionIds into an enum + refactor get_builtins()

All suggested changes are now implemented.

I think the following changes are not yet implemented:

  • Please split the formatting changes into a separate commit.
  • Split refactoring…
derppening created branch misc/workflow-updates in M-Labs/nac3 2024-06-12 13:14:43 +08:00
derppening pushed to misc/workflow-updates at M-Labs/nac3 2024-06-12 13:14:43 +08:00
271dd875bd meta: Update README to include info regarding pre-commit hooks
5001988e09 meta: Add pre-commit configuration
495b26bf70 flake: Add pre-commit to dev environment
627cc2bc42 meta: Reformat codebase using `cargo fmt`
52cc822a53 meta: Set clippy lints in {main,lib}.rs
Compare 5 commits »
derppening commented on pull request M-Labs/nac3#408 2024-06-12 11:24:10 +08:00
core: Refactor PrimitiveDefinitionIds into an enum + refactor get_builtins()

The lifetime 'a can be elided; Same for the functions below.

derppening commented on pull request M-Labs/nac3#408 2024-06-12 11:24:10 +08:00
core: Refactor PrimitiveDefinitionIds into an enum + refactor get_builtins()

allowlist can just be a &[PrimDef].

derppening commented on pull request M-Labs/nac3#408 2024-06-12 11:24:10 +08:00
core: Refactor PrimitiveDefinitionIds into an enum + refactor get_builtins()

Could we just have one constructor with simple_name being an Option<&'static str>?