atse
0 Followers · 0 Following
  • Joined on 2023-07-05
Repositories
1
 Projects Packages Code Public Activity Starred Repositories
atse deleted branch remove-vref-reporting from atse/thermostat 2023-08-23 15:44:26 +08:00
atse pushed to remove-vref-reporting at atse/thermostat 2023-08-22 17:16:43 +08:00
bb4f43fe1c Remove stale reference to channel_state vref
atse commented on pull request M-Labs/thermostat#84 2023-08-22 17:12:46 +08:00
Fix i_set, a user-provided value, to stop varying on VREF measurements

Is that what you would expect from reading the datasheets?

Yes, as the MAX1968 datasheet specifies a threshold of ±15mV from 1.5V. When used in the current setpoint calculation it yields…

atse created pull request M-Labs/thermostat#86 2023-08-22 17:10:06 +08:00
Remove stale reference to channel_state vref
atse pushed to remove-vref-reporting at atse/thermostat 2023-08-22 17:05:49 +08:00
fa0f3d4992 Remove stale reference to channel_state vref
atse commented on pull request M-Labs/thermostat#84 2023-08-22 17:05:17 +08:00
Fix i_set, a user-provided value, to stop varying on VREF measurements

Shouldn't VREF be stable? I don't understand this PR.

Well, theoretically it should be at a constant 1.5V, but the actual value, as returned by read_vref, fluctuates a bit around it, being…

atse commented on pull request M-Labs/thermostat#84 2023-08-22 11:47:37 +08:00
Fix i_set, a user-provided value, to stop varying on VREF measurements

Ok, I've dropped that commit. I've opened a separate pull request for removing VREF reporting #85 as it is a protocol change.

atse created pull request M-Labs/thermostat#85 2023-08-22 11:46:12 +08:00
Remove VREF in reports
atse pushed to fix-i_set at atse/thermostat 2023-08-22 11:45:46 +08:00
atse created branch remove-vref-reporting in atse/thermostat 2023-08-22 11:45:13 +08:00
atse pushed to remove-vref-reporting at atse/thermostat 2023-08-22 11:45:13 +08:00
9df0fe406f Remove VREF in reports
atse pushed to master at atse/thermostat 2023-08-22 11:34:35 +08:00
5ba74c6d9b README: Correct expected TEC polarity
atse commented on pull request M-Labs/thermostat#84 2023-08-22 10:56:42 +08:00
Fix i_set, a user-provided value, to stop varying on VREF measurements

The reports would not have an updated VREF value then. Should we remove VREF reporting? It's an implementation detail anyway.

atse created pull request M-Labs/thermostat#84 2023-08-21 13:48:04 +08:00
Refactor center point and VREF measurement for a more stable i_set
atse pushed to fix-i_set at atse/thermostat 2023-08-21 13:37:25 +08:00
bdffcd4423 Update channel_state VREF on every measurement
7043974bb5 Make set_i use get_center again
d68e6f16a0 Fix get_center to use calibrated VREF
Compare 3 commits »
atse created branch fix-i_set in atse/thermostat 2023-08-21 13:37:25 +08:00
atse pushed to fix-docs-polarity at atse/thermostat 2023-08-15 16:40:13 +08:00
5ba74c6d9b README: Correct expected TEC polarity
atse pushed to fix-docs-polarity at atse/thermostat 2023-08-15 16:24:33 +08:00
e6839bad77 README: Correct expected TEC polarity
atse created pull request M-Labs/thermostat#83 2023-08-15 15:13:05 +08:00
README: Correct expected TEC polarity
atse pushed to fix-docs-polarity at atse/thermostat 2023-08-15 15:10:34 +08:00
d7bc2a2268 README: Correct expected TEC polarity