Keep i_set visible even when PID is engaged

Since i_set is also plotted, we would also want to see its precise value too.
Remove MutexParameter
2024-07-18 18:08:39 +08:00 · 2024-07-18 18:08:39 +08:00 · 2024-07-18 18:08:38 +08:00 · 2024-07-18 18:08:38 +08:00 · 2024-07-18 18:08:36 +08:00 · 2024-07-18 18:08:10 +08:00
1 changed files with 15 additions and 13 deletions
--- a/pytec/pytec/gui/view/param_tree.json
+++ b/pytec/pytec/gui/view/param_tree.json
@ -61,7 +61,7 @@
                  },
                  {
                     "name": "target",
-                     "title": "Setpoint (°C)",
+                     "title": "Set Temperature (°C)",
                     "type": "float",
                     "visible": false,
                     "value": 25,
@ -76,7 +76,7 @@
                        "topic": "pid",
                        "field": "target"
                     },
-                     "tip": "The temperature setpoint of the TEC",
+                     "tip": "The target temperature of the TEC",
                     "lock": false
                  }
               ]
@ -134,7 +134,7 @@
                     "step": 0.1,
                     "limits": [
                        0,
-                        4
+                        5
                     ],
                     "siPrefix": true,
                     "compactHeight": false,
@ -142,7 +142,7 @@
                        "topic": "pwm",
                        "field": "max_v"
                     },
-                     "tip": "The maximum voltage (in both directions) across the output pins",
+                     "tip": "The maximum voltage across the output pins",
                     "lock": false
                  }
               ]
@ -154,7 +154,7 @@
         "title": "Thermistor Settings",
         "expanded": true,
         "type": "group",
-         "tip": "Settings of the connected thermistor\n- Parameters for the resistance to temperature conversion (with the B-Parameter equation)\n- Settings for the 50/60 Hz filter with the thermistor",
+         "tip": "Settings of the connected Thermistor, including for the B-Parameter conversion",
         "children": [
            {
               "name": "t0",
@ -172,7 +172,7 @@
                  "topic": "s-h",
                  "field": "t0"
               },
-               "tip": "The base temperature",
+               "tip": "The origin temperature",
               "lock": false
            },
            {
@ -187,7 +187,7 @@
                  "topic": "s-h",
                  "field": "r0"
               },
-               "tip": "The resistance of the thermistor at base temperature T₀",
+               "tip": "The resistance of the thermistor at origin temperature T₀",
               "lock": false
            },
            {
@ -202,12 +202,12 @@
                  "topic": "s-h",
                  "field": "b"
               },
-               "tip": "The Beta Parameter",
+               "tip": "The B (or Beta) Parameter",
               "lock": false
            },
            {
               "name": "rate",
-               "title": "50/60 Hz filter rejection",
+               "title": "Postfilter Rejection",
               "type": "list",
               "value": 16.67,
               "thermostat:set_param": {
@ -249,9 +249,10 @@
            },
            {
               "name": "ki",
-               "title": "Ki (Hz)",
+               "title": "Ki",
               "type": "float",
               "step": 0.1,
+               "suffix": "Hz",
               "compactHeight": false,
               "thermostat:set_param": {
                  "topic": "pid",
@ -262,9 +263,10 @@
            },
            {
               "name": "kd",
-               "title": "Kd (s)",
+               "title": "Kd",
               "type": "float",
               "step": 0.1,
+               "suffix": "s",
               "compactHeight": false,
               "thermostat:set_param": {
                  "topic": "pid",
@ -380,7 +382,7 @@
                     "pid_autotune": {
                        "params_name": "lookback"
                     },
-                     "tip": "Amount of time referenced for tuning"
+                     "tip": "Amount of time to lookback"
                  },
                  {
                     "name": "run_pid",
@ -402,7 +404,7 @@
         "name": "load",
         "title": "Load from flash",
         "type": "action",
-         "tip": "Load settings from thermostat"
+         "tip": "Load settings from flash"
      }
   ]
 }
Author	SHA1	Message	Date
atse	6dcd1b6275	Keep i_set visible even when PID is engaged Since i_set is also plotted, we would also want to see its precise value too.	2024-07-18 18:08:39 +08:00
atse	c75c8f2da0	Remove MutexParameter Use the standard ListParamenter instead, and hook up UI changes elsewhere.	2024-07-18 18:08:39 +08:00
atse	c754dcfb18	Remove "activater" option Interpret commands directly in send_command	2024-07-18 18:08:38 +08:00
atse	0b0bf26244	PID Autotune test current should only be positive	2024-07-18 18:08:38 +08:00
atse	487bf24ffe	More straightforward mapping to thermostat command New tag "thermostat:set_param" used in JSON.	2024-07-18 18:08:36 +08:00
atse	6372e03dff	Separate tree and param changes	2024-07-18 18:08:10 +08:00
atse	dbee457c09	i -> ch and others	2024-07-18 18:08:10 +08:00
atse	97c5f2a201	Remove unnessarily duplicated parameter tree Huge source of confusion and easy bugs!	2024-07-18 18:08:10 +08:00
atse	fad9008707	Remove unneccessary redirection The child at inner_param's childpath to the root parameter... is just inner_param.	2024-07-18 18:08:10 +08:00
atse	bbd6774c75	Make send_command more readable	2024-07-18 18:08:10 +08:00
atse	405d40c543	Remove extra "channel" option to root parameters Their corresponding channel numbers are already represented with their "value" options.	2024-07-18 18:08:10 +08:00
atse	56655854cf	Fix grammar in info box on PID Autotune failure	2024-07-18 18:08:10 +08:00
atse	37e888846b	Don't say settings loaded on settings save	2024-07-18 18:08:09 +08:00
atse	301db2e003	ctrl_panel: PID Auto Tune -> PID Autotune	2024-07-18 18:08:09 +08:00
atse	f2ca607b8b	ctrl_panel: Stop crushing spinboxes It might not be the case on some themes, but on the default Qt theme the spinbox are a bit too short for the containing numbers. See https://github.com/pyqtgraph/pyqtgraph/issues/701.	2024-07-18 18:08:09 +08:00
atse	a18d6fb4d0	ctrl_panel: Approriate units for measured current Allow the readonly display of current to vary its SI prefix in the unit, since as a display entry it won't have the unit adjustment problem.	2024-07-18 18:08:09 +08:00
atse	0e39b29c5d	ctrl_panel: Pin down units for editable fields Avoids awkward value editing	2024-07-18 18:08:09 +08:00
atse	ce93004368	ctrl_panel: Improve postfilter description	2024-07-18 18:08:07 +08:00
atse	a57c365b8d	ctrl_panel: Add tooltips For users' better understanding of what the parameters do	2024-07-18 18:07:43 +08:00