atse/thermostat
1
0
Fork 0
forked from M-Labs/thermostat
Code Issues Pull Requests Activity

Correct exception catching

Browse Source 
asyncio.Task.result() is simply going to throw the exception in
asyncio.Task.exception(), there is no need to manually throw it.
This commit is contained in:
atse 2024-07-09 12:27:35 +08:00
parent 446d5c4d22
commit f230a51a52
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pytec/pytec/gui/model/thermostat.py
View File

@ -41,15 +41,13 @@ class Thermostat(QObject, metaclass=PropertyMeta):
self._update_params_task = asyncio.create_task(self.update_params()) self._update_params_task = asyncio.create_task(self.update_params())
while True: while True:
if self._update_params_task.done(): if self._update_params_task.done():
if self.task.exception() is not None:
try: try:
raise self._update_params_task.exception() _ = self._update_params_task.result()
except asyncio.TimeoutError: except asyncio.TimeoutError:
logging.error( logging.error(
"Encountered an error while polling for information from Thermostat.", "Encountered an error while polling for information from Thermostat.",
exc_info=True, exc_info=True,
) )
_ = self.task.result()
self._update_params_task = asyncio.create_task(self.update_params()) self._update_params_task = asyncio.create_task(self.update_params())
await asyncio.sleep(self._update_s) await asyncio.sleep(self._update_s)