atse/thermostat
1
0
Fork 0
forked from M-Labs/thermostat
Code Issues Pull Requests Activity

Correct exception catching

Browse Source 
asyncio.Task.result() is simply going to throw the exception in
asyncio.Task.exception(), there is no need to manually throw it.
This commit is contained in:
atse 2024-07-09 12:27:35 +08:00
parent fae0c4141d
commit 1b64a88c75
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pytec/pytec/gui/model/thermostat.py
View File

@ -40,15 +40,13 @@ class Thermostat(QObject, metaclass=PropertyMeta):
self.task = asyncio.create_task(self.update_params()) self.task = asyncio.create_task(self.update_params())
while True: while True:
if self.task.done(): if self.task.done():
if self.task.exception() is not None:
try: try:
raise self.task.exception() _ = self.task.result()
except asyncio.TimeoutError: except asyncio.TimeoutError:
logging.error( logging.error(
"Encountered an error while updating parameter tree.", "Encountered an error while updating parameter tree.",
exc_info=True, exc_info=True,
) )
_ = self.task.result()
self.task = asyncio.create_task(self.update_params()) self.task = asyncio.create_task(self.update_params())
await asyncio.sleep(self._update_s) await asyncio.sleep(self._update_s)