Would this way of getting the fully qualified name of the to-be-initialized class work for inner (nested) classes?
Hmm I tried testing on inner classes, but they are not currently supported in…
Do you mean it returns
Some(DefinitionID(self.f1))
? Aren'tDefinitionID
s global?
Since each class function is assigned a unique DefintionID, this returns replaces the attribute with the…
Initiated ?
Should have been initialized. This part checks if there are any function calls in the __init__
block where user might have initialized some variables (as all variables must be…
I don't understand this comment, can you elaborate?
Class names in TopLevelDef are stored by first prepending module name to the class name. So,
class A:
pass
would be named…
core_log
and rtio_log
to ARTIQ
So the present change should be reverted i.e. there is no need to add
--target-features +sse2
?
Yes, since the feature is already implied by i686 target, --target-feature +sse2
is…
core_log
and rtio_log
to ARTIQ
Okay, but that comment is about Rust, not LLVM. nac3 is only using the latter here.
LLVM does interpret "i686" as implying sse2 for most part (Debian LLVM requires patch though). This commit…
core_log
and rtio_log
to ARTIQ
@abdul124 I thought you said this sse2 option was no longer required when using i686 instead of i386?
sse2 should be enforced by default on rustc i686 target https://github.com/rust-lang/rust/is…