Using llvm.roundeven was breaking since musl libc did not provide an implementation of the roundeven function. Instead of adding a roundeven function patch for platforms with musl libc, I…
I'm not sure if doing another manual implementation of this function is the right thing to do in the first place.
As an alternative, I can replace the llvm.roundeven with llvm.rint or…
Floating point stuff can be deceptive. Please look at a reference roundeven implementation e.g. from glibc.
I compared the implementation with the implementation of floor and roundeven in…
Well OK but will it return the same/correct results?
It passed the testcases in nac3standalone/demo/ndarray.py file. The functionality was relatively simple (round to nearest integer using…
I was using the example given in #102, but I see your point. I will update the file and while I am at it, refactor nac3core/composer to avoid code duplications
Hmm, are there any other codebases doing this?
I did not find a similar issue in other codebases online. However, by using simpler llvm.floor calls instead of llvm.roundeven, the new…
Please run the pre-commit hooks (i.e.
cargo clippyandcargo fmt) on each commit so that theapply cargo fmtcommit can be dropped.
Force pushed to update commit history. Also replaced…