The as_slice
function on nalgebra Matrix returns a column-major slice. The transpose is done to get it the output in a form compatible (row-by-row) with NDValue.
Try setting the environment variable
RUSTFLAGS="-Z const_fn -Z extended_key_value_attributes -Z array_methods"
While adding -Zextended_key_value_attributes
and -Zarray_methods
to…
Does not belong in this PR.
Noted. I will remove it from this PR.
Isn't no_mangle implied by extern C anyway?
I don't think no_mangle
is implied by extern C
as discussed here: https://git…
Also this is function is poorly named. Add a
linalg_
prefix or something, otherwise you have no idea what it can possibly do just looking at the name.
Updated function name and removed…
Sounds fishy to me. The other one would be a variable inside a call, so there shouldn't be that much difference.
The other already has the function signature (the constructor of the exception)…
No need to quote issue number.
Ok.
Why is the code so complicated?
The shorthand exception notation is treated as a variable in the AST. Here I am performing a lookup using the variable…
Removed helper entirely and merged the macros into generate_extern_fn
macro
Renamed macros to:
generate_llvm_intrinsic_fn_body
: Generates the llvm intrinsic build call (body of thecall_llvm_intrinsic
functions).generate_llvm_intrinsic_fn
: Generates the…