Kasli-SoC: Enable Ethernet LEDs #91

Merged
sb10q merged 4 commits from mwojcik/zynq-rs:ethernet_leds into master 2022-03-10 16:46:05 +08:00

Closes #84.

LED control only for Kasli-SoC (as requested in the PR). Disabled for others. A bit tricky since we're supporting different transceivers, and (of course) they have different registers setup.

Currently set so the yellow LED lights up when there's a link (any kind - by default... it kinda depended), and the orange one blinks during activity.

Closes #84. LED control only for Kasli-SoC (as requested in the PR). Disabled for others. A bit tricky since we're supporting different transceivers, and (of course) they have different registers setup. Currently set so the yellow LED lights up when there's a link (any kind - by default... it kinda depended), and the orange one blinks during activity.
sb10q reviewed 2022-03-10 16:33:16 +08:00
@ -0,0 +24,4 @@
0b1101 => Led0Control::Mode2,
0b1110 => Led0Control::Mode3,
0b1111 => Led0Control::Mode4,
_ => Led0Control::OnLinkOffNoLink, //impossible, but Rust compiler requires it

Use unreachable!() which is made for cases like this.

Use ``unreachable!()`` which is made for cases like this.

A bit tricky since we're supporting different transceivers, and (of course) they have different registers setup.

IIRC the default PHY setup works for the other boards and there is nothing to do.

Can you rebase and remove the merge commit?

> A bit tricky since we're supporting different transceivers, and (of course) they have different registers setup. IIRC the default PHY setup works for the other boards and there is nothing to do. Can you rebase and remove the merge commit?
mwojcik force-pushed ethernet_leds from 272f60ea9f to 072fd5f015 2022-03-10 16:42:36 +08:00 Compare
mwojcik added 1 commit 2022-03-10 16:45:35 +08:00
sb10q merged commit c4c52c33b4 into master 2022-03-10 16:46:05 +08:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/zynq-rs#91
There is no content yet.