M-Labs
/
zynq-rs
10
0
Fork 12
Code Issues 6 Pull Requests 1 Releases Wiki Activity

Add config writing capability #68

Closed
cw wants to merge 7 commits from cw/zynq-rs:master into master
pull from: cw/zynq-rs:master
merge into: M-Labs:master
Conversation 1 Commits 7 Files Changed 1
cw commented 2020-09-11 16:32:47 +08:00

Tested with short (less than 100 characters) and long data strings

Tested with short (less than 100 characters) and long data strings
sb10q reviewed 2020-09-11 16:33:42 +08:00
libconfig/src/lib.rs
@ -69,0 +82,4 @@
}
Ok(())
}
fn rename_file<'a>(dir: &fatfs::Dir<sd_reader::SdReader>, old_file_name: &str, new_file_name: &str) -> Result<'a, ()>{
sb10q commented 2020-09-11 16:33:42 +08:00
Owner

Add blank line between functions

Add blank line between functions
sb10q reviewed 2020-09-11 16:34:05 +08:00
libconfig/src/lib.rs Outdated
@ -115,0 +206,4 @@
}
}
};
if need_to_rename { // docs: ensure no ref to files
sb10q commented 2020-09-11 16:34:05 +08:00
Owner

docs?

docs?
sb10q commented 2020-09-11 16:34:42 +08:00
Owner

This needs to be exposed to the artiq_coremgmt interface.

This needs to be exposed to the artiq_coremgmt interface.
sb10q reviewed 2020-09-11 17:24:06 +08:00
libconfig/src/lib.rs
@ -70,0 +84,4 @@
Ok(())
}
fn rename_file<'a>(dir: &fatfs::Dir<sd_reader::SdReader>, old_file_name: &str, new_file_name: &str) -> Result<'a, ()>{
sb10q commented 2020-09-11 17:24:06 +08:00
Owner

https://docs.rs/fatfs/0.3.2/fatfs/struct.Dir.html#method.rename ???

https://docs.rs/fatfs/0.3.2/fatfs/struct.Dir.html#method.rename ???
cw commented 2020-09-18 18:20:32 +08:00
Poster

I cannot get it to work with rename. rename_file is the workaround

I cannot get it to work with rename. rename_file is the workaround
sb10q commented 2020-09-18 18:29:21 +08:00
Owner

Why not?

Why not?
sb10q reviewed 2020-09-11 17:24:43 +08:00
libconfig/src/lib.rs Outdated
@ -115,0 +166,4 @@
}
};
rename_file(&root_dir, config_txt_tmp, "/CONFIG.TXT")?;
sb10q commented 2020-09-11 17:24:43 +08:00
Owner

Why?

Why?
sb10q closed this pull request 2020-10-30 16:49:51 +08:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/zynq-rs#68
There is no content yet.
Delete Branch "cw/zynq-rs:master"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?