M-Labs/zynq-rs
11
0
Fork 15
Code Issues 6 Pull Requests Releases Wiki Activity

i2c: Disabled on Cora Z7-10 #62

Merged
sb10q merged 1 commits from harry/zynq-rs:i2c into master 2020-08-10 18:46:32 +08:00
Conversation 0 Commits 1 Files Changed 2 +31 -27
harry commented 2020-08-10 12:13:00 +08:00
Contributor
Copy Link

This is to disable the I2C code when the firmware is to be compiled on Cora Z7-10.

This is to disable the I2C code when the firmware is to be compiled on Cora Z7-10.
sb10q reviewed 2020-08-10 12:14:37 +08:00
libboard_zynq/src/i2c/eeprom.rs Outdated
@ -22,6 +22,11 @@ impl<'a> EEPROM<'a> {
}
}
#[cfg(feature = "target_cora_z7_10")]
sb10q commented 2020-08-10 12:14:37 +08:00
Owner
Copy Link

not needed if you are removing the entire module unless it's ZC706

not needed if you are removing the entire module unless it's ZC706
harry commented 2020-08-10 12:29:18 +08:00
Author
Contributor
Copy Link

Fixed in 960eb92f9967eb56c6a351431f87f1c53babb1c7. I thought about a possibility that someone in the future would implement I2C on the Cora board themselves, so I included these lines acting as "clues" about what functions would need to be implemented.

Fixed in `960eb92f9967eb56c6a351431f87f1c53babb1c7`. I thought about a possibility that someone in the future would implement I2C on the Cora board themselves, so I included these lines acting as "clues" about what functions would need to be implemented.
sb10q reviewed 2020-08-10 12:14:42 +08:00
libboard_zynq/src/i2c/mod.rs Outdated
@ -43,6 +43,11 @@ impl I2C {
Self::ctor_common(0xFFFF - 0x000C)
}
#[cfg(feature = "target_cora_z7_10")]
sb10q commented 2020-08-10 12:14:42 +08:00
Owner
Copy Link

same as above

same as above
sb10q closed this pull request 2020-08-10 18:46:32 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/zynq-rs#62
No description provided.
Delete Branch "harry/zynq-rs:i2c"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?