M-Labs
/
zynq-rs
10
0
Fork 12
Code Issues 6 Pull Requests 1 Releases Wiki Activity

sync_channel rework #52 #53

Merged
sb10q merged 1 commits from pca006132/zynq-rs:sync into master 2020-07-28 12:38:20 +08:00
Conversation 3 Commits 1 Files Changed 1
pca006132 commented 2020-07-27 16:44:34 +08:00

The channels are now basically static.
Now uses macro to construct the sync_channel, cannot think of a better way.

The channels are now basically static. Now uses macro to construct the sync_channel, cannot think of a better way.
pca006132 changed title from WIP: sync_channel rework #52 to sync_channel rework #52 2020-07-28 11:54:05 +08:00
pca006132 commented 2020-07-28 11:54:26 +08:00
Poster

Tested in experiments, seems working.

Tested in experiments, seems working.
sb10q reviewed 2020-07-28 12:28:21 +08:00
libcortex_a9/src/lib.rs Outdated
@ -9,6 +10,7 @@ pub mod regs;
pub mod cache;
pub mod mmu;
pub mod mutex;
#[macro_use]
sb10q commented 2020-07-28 12:28:21 +08:00
Owner

IMO the regular use statements are better than macro_use.

IMO the regular ``use`` statements are better than ``macro_use``.
sb10q reviewed 2020-07-28 12:30:14 +08:00
experiments/src/main.rs Outdated
@ -215,3 +217,3 @@
// match stream.send((0..=255).cycle().take(CHUNK_SIZE)).await {
match stream.send_slice(&tx_data[..]).await {
Ok(len) => stats_tx.borrow_mut().1 += tx_data.len(), //CHUNK_SIZE,
Ok(_) => stats_tx.borrow_mut().1 += tx_data.len(), //CHUNK_SIZE,
sb10q commented 2020-07-28 12:30:14 +08:00
Owner

unrelated change

unrelated change
sb10q reviewed 2020-07-28 12:32:02 +08:00
libcortex_a9/src/sync_channel.rs Outdated
@ -226,2 +154,4 @@
}
}
#[macro_export]
sb10q commented 2020-07-28 12:32:02 +08:00
Owner

https://doc.rust-lang.org/edition-guide/rust-2018/macros/macro-changes.html

https://doc.rust-lang.org/edition-guide/rust-2018/macros/macro-changes.html
sb10q commented 2020-07-28 12:34:59 +08:00
Owner

Apart from those nitpicks LGTM.

Apart from those nitpicks LGTM.
pca006132 commented 2020-07-28 12:37:34 +08:00
Poster

Apart from those nitpicks LGTM.

Fixed.

> Apart from those nitpicks LGTM. Fixed.
sb10q closed this pull request 2020-07-28 12:38:20 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/zynq-rs#53
There is no content yet.
Delete Branch "pca006132/zynq-rs:sync"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?