M-Labs
/
zynq-rs
10
0
Fork 12
Code Issues 6 Pull Requests 1 Releases Wiki Activity

SD card write slice mutability #35

Merged
sb10q merged 1 commits from pca006132/zynq-rs:sdio-fix into master 2020-06-10 14:54:44 +08:00
Conversation 0 Commits 1 Files Changed 2
pca006132 commented 2020-06-10 13:01:32 +08:00

Changed mutability for slice in SD card write_block function and cache, and removed some unused read functions for ADMA2 descriptor table.

This change is for implementing the Write trait for SD card, as the write function only accepts immutable slice which does not fit into the current SdCard::write_block signature, and the mutability is not really needed.
(dcci takes &T while dcci_slice takes &mut [T] originally)

Tested on ZC706, it should be working.

@astro

Changed mutability for slice in SD card `write_block` function and cache, and removed some unused read functions for ADMA2 descriptor table. This change is for implementing the `Write` trait for SD card, as the `write` function only accepts immutable slice which does not fit into the current `SdCard::write_block` signature, and the mutability is not really needed. (`dcci` takes `&T` while `dcci_slice` takes `&mut [T]` originally) Tested on ZC706, it should be working. @astro
sb10q closed this pull request 2020-06-10 14:54:44 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/zynq-rs#35
There is no content yet.
Delete Branch "pca006132/zynq-rs:sdio-fix"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?